arin 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5b10ee0ba80cabed89245ed72f491f0bbbc73196
-  data.tar.gz: 11962da1cfa1b6c7cf488268d72878955eb3a08d
+  metadata.gz: 2fd1981d6157a72fe95604cb03d0600fc451760d
+  data.tar.gz: 2671fca3c0624c6f2a24f65d21d482a117045d10
 SHA512:
-  metadata.gz: 0a2f393223c258d6d5b6c670f5fd17ccad39324c721a5c8eab9d083e0d91d99f135f13c71fc5d3d0b920444fb62598bce5a018c6ac5a22f7e380c506a5a37e3c
-  data.tar.gz: 4850e75ea2a42fea3a6ff67f51d2cce4cfe1581126ea53f57b5b6486a5be5a9420dac1791e226f5b7ac2cbc69241043911e4f0794418f70fb12394bd6378a74f
+  metadata.gz: 82070bd541eee0ecfe9b353cbea7e7d73db7f6b0cf0645f66ba5fcab83ae15feddd54b496a60820df5147d8a46ed39df42d6b793df68f58adde8979767581d62
+  data.tar.gz: f313027570cc47695e7bac51e9dc20ee45a5322a5c268eab12ac001e33ace7edc32a8b74ec80445276ee97bf0dad04fb493a6b9fd954c975837c256688228173

data/README.md

@@ -7,7 +7,7 @@ Arin - ActiveRecord integrity checking tool
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'arin', github: 'fmnoise/arin'
+gem 'arin'
 ```
 
 And then execute:
@@ -22,21 +22,21 @@ Or install it yourself as:
 
 Consider the example: Order belongs to User which doesn't exist anymore.
 
-In order to find models of certain class which points to non-existant entities we need to pass class contant to constructor
+In order to find models of certain class which points to non-existant entities we need to pass class constant to constructor:
 ```ruby
 Arin::Check.new(Order).issues
 
 # callable object style
 Arin::Check.(Order)
 ```
-Multiple classes should be passed as array
+Multiple classes should be passed as array:
 ```ruby
 Arin::Check.new([Payment, Order]).issues
 
 # callable object style
 Arin::Check.([Payment, Order])
 ```
-Omit parameters to check all loaded models
+Omit parameters to check all loaded models:
 ```ruby
 Rails.application.eager_load!
 Arin::Check.new.issues
@@ -45,9 +45,16 @@ Arin::Check.new.issues
 Arin::Check.()
 ```
 
-Working with found issues collection which is simple array of `Arin::Issue` instances
+Working with found issues collection which is simple array of `Arin::Issue` instances:
 ```ruby
-issue = Arin::Check.().first
+issues = Arin::Check.()
+
+# getting stats
+issues.group_by(&:class_name).map{ |k,v| Hash[k, v.size] }
+=> [{"Order"=>3}, {"Payment"=>2}]
+
+# getting issue info
+issue = issues.first
 => #<Arin::Issue:0x007f9fe2823af0
  @class_name="Order",
  @id=6789,
@@ -66,6 +73,7 @@ issue.relation_class
 issue.relation_id
 => 4567
 
+# getting reported object
 issue.object
 => #<Order:0x007f9fdfbd9af8
   id: 6789,
@@ -74,6 +82,10 @@ issue.object
   updated_at: Sun, 20 Jun 2017 20:06:36 UTC +00:00>
 ```
 
+## TODO
+
+Add tests
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
@@ -82,7 +94,8 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-*The main idea behind Arin development is to stay as small and unopinionated as possible*
+**The main idea behind Arin development is to stay as small and unopinionated as possible**
+
 Bug reports and pull requests are welcome on GitHub at https://github.com/fmnoise/arin.
 
 ## License

data/lib/arin/check.rb

@@ -33,18 +33,36 @@ module Arin
       end
 
       def query
-        subqueries = []
-        classes.each do |klass|
-          klass.reflect_on_all_associations(:belongs_to).each do |relation|
-            q = relation_query(klass, relation) rescue nil
-            subqueries << q if q && processable?(klass, relation)
-          end
-        end
-        subqueries.join <<-SQL
+        queries.join <<-SQL
           UNION ALL
         SQL
       end
 
+      def queries
+        [].tap do |qs|
+          classes.each do |klass|
+            klass.reflect_on_all_associations(:belongs_to).each do |relation|
+              begin
+                if is_polymorphic?(relation)
+                  polymorphics(klass, relation).each do |poly|
+                    poly_class = poly.safe_constantize
+                    if poly_class
+                      qs << polymorphic_relation_query(klass, relation, poly_class)
+                    else
+                      qs << broken_polymorchic_class_query(klass, relation, poly)
+                    end
+                  end
+                else
+                  qs << relation_query(klass, relation) if processable?(klass, relation)
+                end
+              rescue StandardError => e
+                handle_query_failure(klass, relation, e)
+              end
+            end
+          end
+        end
+      end
+
       def processable?(klass, relation)
         klass.table_exists? &&
         klass.primary_key &&
@@ -64,5 +82,43 @@ module Arin
             AND t.#{relation.foreign_key} IS NOT NULL
         SQL
       end
+
+      def polymorphic_relation_query(klass, relation, relation_class)
+        <<-SQL
+          SELECT "#{klass.name}" AS class_name,
+            t.#{klass.primary_key} AS id,
+            "#{relation_class}" AS relation_class,
+            t.#{relation.foreign_key} AS relation_id
+          FROM #{klass.table_name} AS t
+          LEFT JOIN #{relation_class.table_name} AS r
+            ON t.#{relation.foreign_key} = r.#{relation_class.primary_key}
+            AND t.#{relation.foreign_type} = "#{relation_class}"
+          WHERE r.#{relation_class.primary_key} IS NULL
+            AND t.#{relation.foreign_key} IS NOT NULL
+        SQL
+      end
+
+      def broken_polymorphic_class_query(klass, relation, relation_class)
+        <<-SQL
+          SELECT "#{klass.name}" AS class_name,
+            t.#{klass.primary_key} AS id,
+            "#{relation_class}" AS relation_class,
+            t.#{relation.foreign_key} AS relation_id
+          FROM #{klass.table_name} AS t
+          WHERE t.#{relation.foreign_type} = "#{relation_class}"
+        SQL
+      end
+
+      def polymorphics(klass, relation)
+        klass.pluck(relation.foreign_type).uniq.compact
+      end
+
+      def is_polymorphic?(relation)
+        relation.options[:polymorphic]
+      end
+
+      def handle_query_failure(klass, relation, e)
+        warn("Cannot process #{relation.name} relation for #{klass}: #{e.message}")
+      end
   end
 end

data/lib/arin/version.rb

@@ -1,3 +1,3 @@
 module Arin
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: arin
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - fmnoise@gmail.com