argon2id 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c9cccf037023d8c6788dd8121b537ba8bcb2b4d1cb490fc335ea0f196246c351
-  data.tar.gz: 63080bd2c9934a105f6b43eae9b48ac0a913eecf00fd6bc3a6d9432708e6567a
+  metadata.gz: cf19fbe439098391805284f0cce1dfb96265e38f9aaa4fc50966f73d866246e0
+  data.tar.gz: 4edab8ef1ea285bd4e8a98e9b340857fbbb9637a1f31797510b16e56fdc93c09
 SHA512:
-  metadata.gz: a1dabc66e583524d094986af8e485e27c56176c87a1f66e995b7f1114a0d9289cb5389f9de88202299f05f66f992f9198d6e4bf31f2e153ac6f6b39cba32356e
-  data.tar.gz: abfa2425264961ca1eff57a07e674d9cad976377a649f9ea577ac0edeadc3b475a7061d4818e44405a938c1e251f4ab6e97d222cafe16c748bbb1eb3fc468ed9
+  metadata.gz: 3393526bbbc5411b75b1b77579e8626195022a2448fc89a3333151e69bcaf56527ef9497c264f9b557ba239ea020d3f25d8cd618925a7d01ab0110d1f1334f8c
+  data.tar.gz: 7613d11e0c43b7538e6248122c8351a69c36884e76b339659d0fe27ebfb101df2ce26619349d30083b477a480dfc063e97ba28e2027941fa28a429080dd3c6a8

data/CHANGELOG.md

@@ -5,12 +5,21 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.1] - 2024-11-02
+
+### Changed
+
+- Refactor verification on JRuby to avoid parsing encoded hashes unnecessarily
+- No longer describe the gem in terms of bindings to the reference C
+  implementation given the Bouncy Castle-based JRuby implementation
+- Only wrap `IllegalStateException` with `Argon2id::Error` on JRuby
+
 ## [0.4.0] - 2024-11-02
 
 ### Added
 
 - Added support for JRuby 9.4 by adding an implementation of Argon2id hashing
-  and verification using JRuby-OpenSSL's Bouncy Castle internals.
+  and verification using JRuby-OpenSSL's Bouncy Castle internals
 - Added `output` to `Argon2id::Password` instances so the actual "output" part
   of a password hash can be retrieved (and compared)
 
@@ -77,6 +86,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   reference C implementation of Argon2, the password-hashing function that won
   the Password Hashing Competition.
 
+[0.4.1]: https://github.com/mudge/argon2id/releases/tag/v0.4.1
 [0.4.0]: https://github.com/mudge/argon2id/releases/tag/v0.4.0
 [0.3.0]: https://github.com/mudge/argon2id/releases/tag/v0.3.0
 [0.2.1]: https://github.com/mudge/argon2id/releases/tag/v0.2.1

data/README.md

@@ -1,11 +1,11 @@
 # Argon2id - Ruby bindings to the OWASP recommended password-hashing function
 
-Ruby bindings to the reference C implementation of [Argon2][], the password-hashing
-function that won the 2015 [Password Hashing Competition][].
+Ruby bindings to [Argon2][], the password-hashing function that won the 2015
+[Password Hashing Competition][].
 
 [![Build Status](https://github.com/mudge/argon2id/actions/workflows/tests.yml/badge.svg?branch=main)](https://github.com/mudge/argon2id/actions)
 
-**Current version:** 0.4.0  
+**Current version:** 0.4.1  
 **Bundled Argon2 version:** libargon2.1 (20190702)
 
 ```ruby
@@ -127,7 +127,7 @@ password == "opensesame"    #=> true
 password == "notopensesame" #=> false
 ```
 
-Or, if you only have the hash (e.g. retrieved from storage):
+Or, if you only have the encoded hash (e.g. retrieved from storage):
 
 ```ruby
 password = Argon2id::Password.new("$argon2id$v=19$m=19456,t=2,p=1$ZS2nBFWBpnt28HjtzNOW4w$SQ+p+dIcWbpzWpZQ/ZZFj8IQkyhYZf127U4QdkRmKFU")
@@ -143,7 +143,7 @@ password.is_password?("opensesame")    #=> true
 password.is_password?("notopensesame") #=> false
 ```
 
-The various parts of the encoded password can be retrieved:
+The various parts of the encoded hash can be retrieved:
 
 ```ruby
 password = Argon2id::Password.new("$argon2id$v=19$m=256,t=2,p=1$c29tZXNhbHQ$nf65EOgLrQMR/uIPnA4rEsF5h7TKyQwu9U1bMCHGi/4")
@@ -177,7 +177,7 @@ This gem requires any of the following to run:
 > [!NOTE]
 > The JRuby version of the gem uses
 > [JRuby-OpenSSL](https://github.com/jruby/jruby-openssl)'s implementation of
-> Argon2 instead of the reference C implementation.
+> Argon2 while the others use the reference C implementation.
 
 ### Native gems
 
@@ -198,11 +198,11 @@ notes](https://github.com/mudge/argon2id/releases) for each version and can be
 checked with `sha256sum`, e.g.
 
 ```console
-$ gem fetch argon2id -v 0.3.0
-Fetching argon2id-0.3.0-arm64-darwin.gem
-Downloaded argon2id-0.3.0-arm64-darwin
-$ sha256sum argon2id-0.3.0-arm64-darwin.gem
-9d49de6840942b48d020dddd422a1577fde7289ccb08a637bdb29f4a09b4e181  argon2id-0.3.0-arm64-darwin.gem
+$ gem fetch argon2id -v 0.4.0
+Fetching argon2id-0.4.0-arm64-darwin.gem
+Downloaded argon2id-0.4.0-arm64-darwin
+$ sha256sum argon2id-0.4.0-arm64-darwin.gem
+2cecd6d5a1ecaf0a025e95714c0dee22dfc3d4585b649c57c06f432031b55a77  argon2id-0.4.0-arm64-darwin.gem
 ```
 
 [GPG](https://www.gnupg.org/) signatures are attached to each release (the
@@ -212,8 +212,8 @@ from a public keyserver, e.g. `gpg --keyserver keyserver.ubuntu.com --recv-key
 0x39AC3530070E0F75`):
 
 ```console
-$ gpg --verify argon2id-0.3.0-arm64-darwin.gem.sig argon2id-0.3.0-arm64-darwin.gem
-gpg: Signature made Fri  1 Nov 18:15:47 2024 GMT
+$ gpg --verify argon2id-0.4.0-arm64-darwin.gem.sig argon2id-0.4.0-arm64-darwin.gem
+gpg: Signature made Sat  2 Nov 15:25:15 2024 GMT
 gpg:                using RSA key 702609D9C790F45B577D7BEC39AC3530070E0F75
 gpg: Good signature from "Paul Mucur <mudge@mudge.name>" [unknown]
 gpg:                 aka "Paul Mucur <paul@ghostcassette.com>" [unknown]

data/argon2id.gemspec

@@ -6,7 +6,7 @@ Gem::Specification.new do |s|
   s.name = "argon2id"
   s.version = Argon2id::VERSION
   s.summary = "Ruby bindings to Argon2"
-  s.description = "Ruby bindings to the reference C implementation of Argon2, the password-hashing function that won the 2015 Password Hashing Competition."
+  s.description = "Ruby bindings to Argon2, the password-hashing function that won the 2015 Password Hashing Competition."
   s.license = "BSD-3-Clause"
   s.authors = ["Paul Mucur"]
   s.homepage = "https://github.com/mudge/argon2id"

data/lib/argon2id/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Argon2id
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

data/lib/argon2id.rb

@@ -57,7 +57,35 @@ module Argon2id
     Error = Class.new(StandardError)
 
     def self.hash_encoded(t_cost, m_cost, parallelism, pwd, salt, hashlen)
-      raise Error, "Salt is too short" unless String(salt).bytesize.positive?
+      output = hash_raw(t_cost, m_cost, parallelism, pwd, salt, hashlen)
+
+      encoder = Java::JavaUtil::Base64.get_encoder.without_padding
+      encoded_salt = encoder.encode_to_string(salt.to_java_bytes)
+      encoded_output = encoder.encode_to_string(output)
+
+      "$argon2id$v=19$m=#{Integer(m_cost)},t=#{Integer(t_cost)}," \
+        "p=#{Integer(parallelism)}$#{encoded_salt}$#{encoded_output}"
+    end
+
+    def self.verify(encoded, pwd)
+      password = Password.new(encoded)
+      other_raw = hash_raw(
+        password.t_cost,
+        password.m_cost,
+        password.parallelism,
+        String(pwd),
+        password.salt,
+        password.output.bytesize
+      )
+
+      Java::OrgBouncycastleUtil::Arrays.constant_time_are_equal(
+        password.output.to_java_bytes,
+        other_raw
+      )
+    end
+
+    def self.hash_raw(t_cost, m_cost, parallelism, pwd, salt, hashlen)
+      raise Error, "Salt is too short" if String(salt).empty?
 
       hash = Java::byte[Integer(hashlen)].new
       params = Java::OrgBouncycastleCryptoParams::Argon2Parameters::Builder
@@ -68,38 +96,13 @@ module Argon2id
         .with_iterations(Integer(t_cost))
         .build
       generator = Java::OrgBouncycastleCryptoGenerators::Argon2BytesGenerator.new
-      encoder = Java::JavaUtil::Base64.get_encoder.without_padding
 
       generator.init(params)
       generator.generate_bytes(String(pwd).to_java_bytes, hash)
 
-      encoded_salt = encoder.encode_to_string(params.get_salt)
-      encoded_output = encoder.encode_to_string(hash)
-
-      "$argon2id$v=#{params.get_version}$m=#{params.get_memory}," \
-        "t=#{params.get_iterations},p=#{params.get_lanes}" \
-        "$#{encoded_salt}$#{encoded_output}"
-    rescue => e
+      hash
+    rescue Java::JavaLang::IllegalStateException => e
       raise Error, e.message
     end
-
-    def self.verify(encoded, pwd)
-      password = Password.new(encoded)
-      other_password = Password.new(
-        hash_encoded(
-          password.t_cost,
-          password.m_cost,
-          password.parallelism,
-          String(pwd),
-          password.salt,
-          password.output.bytesize
-        )
-      )
-
-      Java::OrgBouncycastleUtil::Arrays.constant_time_are_equal(
-        password.output.to_java_bytes,
-        other_password.output.to_java_bytes
-      )
-    end
   end
 end

data/test/test_hash_encoded.rb

@@ -10,6 +10,12 @@ class TestHashEncoded < Minitest::Test
     assert_equal "$argon2id$v=19$m=256,t=2,p=1$c29tZXNhbHQ$nf65EOgLrQMR/uIPnA4rEsF5h7TKyQwu9U1bMCHGi/4", encoded
   end
 
+  def test_password_with_parallelism_of_two
+    encoded = Argon2id.hash_encoded(2, 256, 2, "password", "somesalt", 32)
+
+    assert_equal "$argon2id$v=19$m=256,t=2,p=2$c29tZXNhbHQ$bQk8UB/VmZZF4Oo79iDXuL5/0ttZwg2f/5U52iv1cDc", encoded
+  end
+
   def test_valid_password_does_not_include_trailing_null_byte
     encoded = Argon2id.hash_encoded(2, 256, 1, "password", "somesalt", 32)
 

data/test/test_password.rb

@@ -169,4 +169,10 @@ class TestPassword < Minitest::Test
 
     assert_equal 1, password.parallelism
   end
+
+  def test_extracting_output_from_hash
+    password = Argon2id::Password.new("$argon2id$v=19$m=256,t=2,p=1$c29tZXNhbHQ$nf65EOgLrQMR/uIPnA4rEsF5h7TKyQwu9U1bMCHGi/4")
+
+    assert_equal "\x9D\xFE\xB9\x10\xE8\v\xAD\x03\x11\xFE\xE2\x0F\x9C\x0E+\x12\xC1y\x87\xB4\xCA\xC9\f.\xF5M[0!\xC6\x8B\xFE".b, password.output
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: argon2id
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Paul Mucur
@@ -52,8 +52,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.25'
-description: Ruby bindings to the reference C implementation of Argon2, the password-hashing
-  function that won the 2015 Password Hashing Competition.
+description: Ruby bindings to Argon2, the password-hashing function that won the 2015
+  Password Hashing Competition.
 email: 
 executables: []
 extensions: