arena 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f3371aa0176ae4b8281424c96411818c2148a94577064b82028d74d2c0b3a25b
-  data.tar.gz: 95896b4182c13238e273aea03e07d4268672d62b2769886f16d03bf989d2bc72
+  metadata.gz: eb1d546f2e81fba83aacb5950d9fe25fe4fc9907d7cf1224ee3ce82bbab0d33b
+  data.tar.gz: 4202eac01621ce84c36a681e0d266dce58cf9bb209e519f24f2b18399cf0fe84
 SHA512:
-  metadata.gz: 51ada54286c9ecc23b53cb0d585c287785373770a37eefce33708d8593ee953985c8e9e4721389cb94442499bee56f4fcfa494f5335a342ccd19e892bd9f4989
-  data.tar.gz: 1bec6fc4a24221ab8a9e4a7fda5e20db5ebafb2e49f226f136e682620f65964548612dc6a0a10ea26a6a79546fbcc704af277754bd0fbf71a2406b6747bcf5a4
+  metadata.gz: 0f80bcf522f69df14235daa04aafb0d04f9f71387ba9e1791ae61c5970742fa33e23575a1e181c0144482f2c64cf3006bc4dac493d54e92d5c6692d987670ee8
+  data.tar.gz: 00c436b76d931c6e5f01b47aa55206660afa94ccc47279371e6e10b61a48add35d6de6b9ed9eec450cf1c22111c5055dc26d3bcf340c4722e1c3fa9261b41653

data/.rubocop_todo.yml

@@ -1,11 +1,17 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-10-12 15:57:16 UTC using RuboCop version 1.81.1.
+# on 2025-10-13 18:03:06 UTC using RuboCop version 1.81.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 1
+# Configuration parameters: AllowComments, AllowNil.
+Lint/SuppressedException:
+  Exclude:
+    - 'lib/arena/client.rb'
+
 # Offense count: 2
 # Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods, WaywardPredicates.
 # AllowedMethods: call
@@ -47,3 +53,11 @@ Style/MissingRespondToMissing:
     - 'lib/arena/cache/adaptor/null.rb'
     - 'lib/arena/cache/adaptor/padrino.rb'
     - 'lib/arena/cache/adaptor/rails.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
+# AllowedMethods: present?, blank?, presence, try, try!
+Style/SafeNavigation:
+  Exclude:
+    - 'lib/arena/client.rb'

data/lib/arena/client.rb

@@ -44,10 +44,14 @@ module Arena
       response.code != 200
     end
 
-    def error_message(response)
+    def error_message_from_json(response)
       "#{response['code']}: #{response['message']} - #{response['description']}"
     end
 
+    def error_message(response)
+      "#{response.code}: #{response.body && response.body.length.positive? ? response.body : 'Unexpected Error'}"
+    end
+
     def request(method, path, options)
       response = self.class.send(method, "https://#{@base_domain}/#{@api_version}#{path}", options)
 
@@ -55,13 +59,10 @@ module Arena
                  begin
                    JSON.parse(response.body)
                  rescue JSON::ParserError, TypeError
-                   nil
                  end
-               else
-                 response.body
                end
 
-      raise Arena::Error, error_message(parsed) if error?(response)
+      raise Arena::Error, parsed ? error_message_from_json(parsed) : error_message(response) if error?(response)
 
       parsed
     end

data/lib/arena/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Arena
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 
   def self.version
     VERSION

data/test/cassettes/Arena/channel/handles_a_400_error_that_returns_nil.yml

@@ -0,0 +1,36 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://api.are.na/v2/channels/delightfully-absurd
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 403
+      message: OK
+    headers:
+      Date:
+      - Sat, 11 Oct 2025 20:29:37 GMT
+      Content-Type:
+      - text/plain; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Cache-Control:
+      - max-age=604800, private
+      Server:
+      - cloudflare
+      Vary:
+      - Origin
+      Via:
+      - 2.0 heroku-router
+  recorded_at: Sat, 11 Oct 2025 20:29:37 GMT
+recorded_with: VCR 6.3.1

data/test/lib/arena/api_test.rb

@@ -9,16 +9,24 @@ describe Arena do
     end
 
     it 'handles a 403 error' do
-      assert_raises StandardError do
+      error = assert_raises Arena::Error do
         Arena.channel('delightfully-absurd')
       end
+      assert_equal '403: Forbidden', error.message
     end
 
     it 'handles a 400 error that returns JSON' do
-      error = assert_raises StandardError do
+      error = assert_raises Arena::Error do
         Arena.channel('delightfully-absurd')
       end
       assert_equal '400: Internal Server Error - Something went wrong.', error.message
     end
+
+    it 'handles a 400 error that returns nil' do
+      error = assert_raises Arena::Error do
+        Arena.channel('delightfully-absurd')
+      end
+      assert_equal '403: Unexpected Error', error.message
+    end
   end
 end

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arena
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - dzuc
+autorequire:
 bindir: bin
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2025-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -94,6 +95,7 @@ files:
 - lib/arena/user_feed.rb
 - lib/arena/version.rb
 - test/cassettes/Arena/channel/handles_a_400_error_that_returns_JSON.yml
+- test/cassettes/Arena/channel/handles_a_400_error_that_returns_nil.yml
 - test/cassettes/Arena/channel/handles_a_403_error.yml
 - test/cassettes/Arena/channel/returns_a_channel.yml
 - test/lib/arena/api_test.rb
@@ -103,6 +105,7 @@ homepage: https://www.are.na/
 licenses: []
 metadata:
   rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -117,7 +120,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 3.5.16
+signing_key:
 specification_version: 4
 summary: Wrapper for Arena's API
 test_files: []