arel_toolkit 0.4.0 → 0.4.5

data/Guardfile

@@ -47,3 +47,7 @@ group :red_green_refactor, halt_on_fail: true do
     watch(%r{(?:.+/)?\.rubocop(?:_todo)?\.yml$}) { |m| File.dirname(m[0]) }
   end
 end
+
+guard 'rake', task: 'compile' do
+  watch(/^ext/)
+end

data/README.md

@@ -2,7 +2,7 @@
 
 ## Overview
 
-- [![Build Status](https://travis-ci.com/mvgijssel/arel_toolkit.svg?branch=master)](https://travis-ci.com/mvgijssel/arel_toolkit)
+- [![](https://github.com/mvgijssel/arel_toolkit/workflows/CI%20-%20master/badge.svg)](https://github.com/mvgijssel/arel_toolkit/actions)
 - [![Maintainability](https://api.codeclimate.com/v1/badges/3ef13d1649a00a98562d/maintainability)](https://codeclimate.com/github/mvgijssel/arel_toolkit/maintainability)
 - [![Test Coverage](https://api.codeclimate.com/v1/badges/3ef13d1649a00a98562d/test_coverage)](https://codeclimate.com/github/mvgijssel/arel_toolkit/test_coverage)
 - [![Gem Version](https://badge.fury.io/rb/arel_toolkit.svg)](https://badge.fury.io/rb/arel_toolkit)
@@ -65,7 +65,7 @@ enhanced_arel.child_at_path(['ast', 'cores', 0, 'projections', 1]).object
 ```
 
 ##### Replace or remove nodes without modifying the original arel
-`remove` and `replace` allow for modifications to the Arel AST. The changes are aplied to a new copy of the AST, making sure the original AST is not touched.
+`remove` and `replace` allow for modifications to the Arel AST. The changes are aplied to a new copy of the AST, making sure the original AST is not touched. The `replace` method accepts any Arel node or a precomputed enhanced node for improved performance.
 
 ```ruby
 enhanced_arel.child_at_path(['ast', 'cores', 0, 'projections', 1]).replace(Post.arel_table[:content])
@@ -84,33 +84,36 @@ Middleware sits between ActiveRecord and the database, it allows you to alter th
 The middleware works out of the box in combination with Rails. If using ActiveRecord standalone you need to run the following **after** setting up the database connection:
 
 ```ruby
-Arel::Middleware::Railtie.insert_postgresql
+Arel::Middleware::Railtie.insert
 ```
 
 ### Example
 
-Create some middleware (this can be any Ruby object as long as it responds to `call`). In this example, we're creating a middleware that will reorder any query. Next to reordering, we're adding an additional middleware that prints out the result of the reorder middleware.
+Create middleware which can be any Ruby object as long as it responds to `call`. Middleware accepts 2 or 3 arguments, context is optional. Calling `.call` on `next_middleware` invokes the next middleware in the chain, returning the response from the database.
+
+In this example, we're creating a middleware that will reorder any query. Next to reordering, we're adding an additional middleware that prints out the result of the reorder middleware.
 
 ```ruby
 class ReorderMiddleware
-  def self.call(arel, _context)
+  def self.call(arel, next_middleware)
     enhanced_arel = Arel.enhance(arel)
     enhanced_arel.query(class: Arel::Nodes::SelectStatement).each do |node|
       arel_table = node.child_at_path(['cores', 0, 'source', 'left']).object
       node['orders'].replace([arel_table[:id].asc])
     end
 
-    arel.order(Post.arel_table[:id].asc)
+    new_arel = arel.order(Post.arel_table[:id].asc)
+    next_middleware.call(new_arel)
   end
 end
 
 class LoggingMiddleware
-  def self.call(arel, context)
+  def self.call(arel, next_middleware, context)
     puts "User executing query: `#{context[:current_user_id]}`"
     puts "Original SQL: `#{context[:original_sql]}`"
     puts "Modified SQL: `#{arel.to_sql}`"
-    
-    arel
+
+    next_middleware.call(arel)
   end
 end
 ```
@@ -140,9 +143,20 @@ This gem aims to have full support for PostgreSQL's SQL. In order to do so, it n
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment. To install this gem onto your local machine, run `bundle exec rake install`.
+
+## Releasing
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+1. Update version in `version.rb`
+1. Create a new branch `v<<VERSION_HERE>>`
+1. Run `bundle install`
+1. Run `bundle exec appraisal install`
+1. Run `bundle exec rake changelog`
+1. Commit the changes
+1. Open a PR with name `Version <<VERSION_HERE>>` ([example](https://github.com/mvgijssel/arel_toolkit/pull/172))
+1. Merge the PR
+1. Checkout the master branch and pull latest changes
+1. Run `bundle exec rake release`
 
 ## Contributing
 

data/Rakefile

@@ -10,5 +10,15 @@ GitHubChangelogGenerator::RakeTask.new :changelog do |config|
   config.user = 'mvgijssel'
   config.project = 'arel_toolkit'
   config.future_release = "v#{ArelToolkit::VERSION}"
-  config.pulls = false
+  config.add_pr_wo_labels = false
+  config.enhancement_labels = %w[enhancement dependencies]
+  config.exclude_tags = ['v0.1.0']
+end
+
+require 'rake/extensiontask'
+
+task build: :compile
+
+Rake::ExtensionTask.new('pg_result_init') do |ext|
+  ext.lib_dir = 'lib/arel_toolkit'
 end

data/arel_toolkit.gemspec

@@ -23,16 +23,17 @@ Gem::Specification.new do |spec|
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
+  spec.extensions    = ['ext/pg_result_init/extconf.rb']
 
-  spec.add_dependency 'arel', '~> 9.0.0'
-  spec.add_dependency 'activerecord', '~> 5.2.0'
+  spec.add_dependency 'activerecord'
   spec.add_dependency 'pg', '~> 1.1.4'
-  spec.add_dependency 'pg_query', '~> 1.1.0'
+  spec.add_dependency 'pg_query', '~> 1.3'
 
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'dpl', '~> 1.10.11'
-  spec.add_development_dependency 'github_changelog_generator', '~> 1.14.3'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'github_changelog_generator', '~> 1.15'
+  spec.add_development_dependency 'rake', '~> 13.0'
+  spec.add_development_dependency 'rake-compiler', '~> 1.0'
   spec.add_development_dependency 'rspec', '~> 3.8'
   spec.add_development_dependency 'approvals', '~> 0.0.24'
   spec.add_development_dependency 'appraisal', '~> 2.2.0'
@@ -45,6 +46,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'guard', '~> 2.15'
   spec.add_development_dependency 'guard-rspec', '~> 4.7'
   spec.add_development_dependency 'guard-rubocop', '~> 1.3.0'
+  spec.add_development_dependency 'guard-rake', '~> 1.0.0'
+
+  spec.add_development_dependency 'stackprof', '~> 0.2'
+  spec.add_development_dependency 'memory_profiler', '~> 0.9'
 
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'pry-nav'

data/benchmark.rb

@@ -0,0 +1,54 @@
+GC.disable
+
+require 'arel'
+require 'active_record'
+require 'memory_profiler'
+require 'json'
+require 'stackprof'
+
+require './lib/arel/enhance'
+require './lib/arel/extensions'
+require './lib/arel/sql_to_arel'
+
+ActiveRecord::Base.establish_connection(
+  adapter: 'postgresql',
+  host: 'localhost',
+  databse: 'arel_toolkit_test',
+  username: 'postgres',
+)
+
+# rubocop:disable Metrics/LineLength
+SQL = %{
+SELECT COUNT("hacktivity_items"."id") FROM (SELECT "hacktivity_items".* FROM (SELECT "hacktivity_items".* FROM (SELECT "hacktivity_items".*, (NULLIF(current_setting('secure.requester_id'), ''))::integer AS "_requester_id" FROM (SELECT "outer_hacktivity_items".*, EXISTS (SELECT 1 FROM "public"."reports" INNER JOIN "public"."teams" ON "teams"."id" = "reports"."team_id" WHERE "teams"."state" = 5 AND "reports"."disclosed_at" IS NOT NULL AND "reports"."public_view" = 'full' AND "reports"."id" = "outer_hacktivity_items"."report_id") AS "is_someone_visiting_a_public_report", EXISTS (SELECT 1 FROM "public"."reports" INNER JOIN "public"."teams" ON "teams"."id" = "reports"."team_id" INNER JOIN "public"."whitelisted_reporters" ON "whitelisted_reporters"."team_id" = "teams"."id" WHERE "teams" ."state" = 4 AND "teams"."allows_private_disclosure" = 't'::bool AND (("whitelisted_reporters"."user_id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "whitelisted_reporters"."user_id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "reports"."disclosed_at" IS NOT NULL AND "reports"."public_view" = 'full' AND "reports"."id" = "outer_hacktivity_items"."report_id") AS "is_someone_visiting_a_report_privately_disclosed_to_them", EXISTS (SELECT 1 FROM "public"."reports" WHERE "reports"."hacker_published" = 't'::bool AND "reports"."disclosed_at" IS NOT NULL AND "reports"."id" = "outer_hacktivity_items"."report_id") AS "is_hacker_published", EXISTS (SELECT 1 FROM "public"."teams" INNER JOIN "public"."team_members" ON "team_members"."team_id" = "teams"."id" WHERE (("team_members"."user_id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "team_members"."user_id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "team_members"."user_id" IS NOT NULL AND "teams"."id" = "outer_hacktivity_items"."team_id") AS "is_team_team_member", EXISTS (SELECT 1 FROM "public"."teams" WHERE "teams"."state" = 5 AND "teams"."id" = "outer_hacktivity_items"."team_id") AS "is_team_public", EXISTS (SELECT 1 FROM "public"."teams" INNER JOIN "public"."whitelisted_reporters" ON "whitelisted_reporters"."team_id" = "teams"."id" INNER JOIN "public"."users" ON "users"."id" = "whitelisted_reporters"."user_id" WHERE (("users"."id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "users"."id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "users"."id" IS NOT NULL AND "teams"."id" = "outer_hacktivity_items"."team_id") AS "is_team_whitelisted_reporter", EXISTS (SELECT 1 FROM "public"."teams" WHERE "teams"."state" = 4 AND "teams"."id" = "outer_hacktivity_items"."team_id") AS "is_team_private", EXISTS (SELECT 1 FROM "public"."teams" WHERE "teams"."offers_bounties" = 't'::bool AND "teams"."hide_bounty_amounts" = 'f'::bool AND "teams"."id" = "outer_hacktivity_items"."team_id") AS "is_team_shows_bounty_amounts" FROM "public"."hacktivity_items" "outer_hacktivity_items") AS "hacktivity_items" WHERE "hacktivity_items"."is_team_public" = 't'::bool OR ("hacktivity_items"."is_team_private" = 't'::bool AND ("hacktivity_items"."is_team_team_member" = 't'::bool OR "hacktivity_items"."is_team_whitelisted_reporter" = 't'::bool)) OR "hacktivity_items"."is_hacker_published" = 't'::bool) hacktivity_items) AS "hacktivity_items" LEFT OUTER JOIN (SELECT "reports".*, "new_j0"."disclosed_at" AS "__new_filterable_disclosed_at" FROM (SELECT "reports".*, (NULLIF(current_setting('secure.requester_id'), ''))::integer AS "_requester_id" FROM (SELECT "outer_reports".*, EXISTS (SELECT 1 FROM "public"."teams" INNER JOIN "public"."team_members" ON "team_members"."team_id" = "teams"."id" INNER JOIN "public"."users" ON "users"."id" = "team_members"."user_id" WHERE (("users"."id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "users"."id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "users"."id" IS NOT NULL AND "teams"."id" = "outer_reports"."team_id") AS "is_team_member", (("outer_reports"."reporter_id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "outer_reports"."reporter_id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "outer_reports"."reporter_id" IS NOT NULL AS "is_reporter", EXISTS (SELECT 1 FROM "public"."reports_users" INNER JOIN "public"."users" ON "users"."id" = "reports_users"."user_id" WHERE (("reports_users"."user_id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "reports_users"."user_id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "reports_users"."user_id" IS NOT NULL AND "reports_users"."report_id" = "outer_reports"."id") AS "is_external_user", EXISTS (SELECT 1 FROM "public"."report_retests" INNER JOIN "public"."report_retest_users" ON "report_retest_users"."report_retest_id" = "report_retests"."id" WHERE (EXISTS (SELECT "invitations".* FROM "public"."invitations" WHERE ("accepted_at" IS NOT NULL OR "expires_at" >= now() OR "expires_at" IS NULL) AND "invitations"."cancelled_at" IS NULL AND "invitations"."rejected_at" IS NULL AND "invitations"."id" = "report_retest_users"."invitation_id") OR (NOT (EXISTS (SELECT "invitations".* FROM "public"."invitations" WHERE "invitations"."id" = "report_retest_users"."invitation_id")))) AND (("report_retest_users"."user_id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "report_retest_users"."user_id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "report_retest_users"."user_id" IS NOT NULL AND "report_retests"."report_id" = "outer_reports"."id") AS "is_retester", EXISTS (SELECT 1 FROM "public"."teams" LEFT OUTER JOIN "public"."users" ON "users"."anc_triager" WHERE "outer_reports"."pre_submission_review_state" IS NOT NULL AND "teams"."state" IN (4, 5) AND "teams"."anc_enabled" = 't'::bool AND (("users"."id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "users"."id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "users"."id" IS NOT NULL AND "teams"."id" = "outer_reports"."team_id") AS "is_anc_triager", EXISTS (SELECT 1 FROM "public"."teams" INNER JOIN "public"."team_members" ON "team_members"."team_id" = "teams"."id" INNER JOIN "public"."users" ON "users"."id" = "team_members"."user_id" WHERE (("users"."id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "users"."id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "users"."hackerone_triager" = 't'::bool AND "users"."id" IS NOT NULL AND "teams"."id" = "outer_reports"."team_id") AS "is_hackerone_triager", EXISTS (SELECT 1 FROM "public"."report_collaborators" WHERE (("report_collaborators"."user_id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "report_collaborators"."user_id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "report_collaborators"."user_id" IS NOT NULL AND "report_collaborators"."report_id" = "outer_reports"."id") AS "is_report_collaborator", EXISTS (SELECT 1 FROM "public"."teams" WHERE "teams"."state" = 5 AND "outer_reports"."disclosed_at" IS NOT NULL AND "outer_reports"."public_view" = 'full' AND "teams"."id" = "outer_reports"."team_id") AS "is_someone_visiting_a_public_report", EXISTS (SELECT 1 FROM "public"."teams" WHERE "teams"."state" = 5 AND "outer_reports"."disclosed_at" IS NOT NULL AND "outer_reports"."public_view" = 'no-content' AND "teams"."id" = "outer_reports"."team_id") AS "is_someone_visiting_a_public_limited_report", EXISTS (SELECT 1 FROM "public"."teams" INNER JOIN "public"."whitelisted_reporters" ON "whitelisted_reporters"."team_id" = "teams"."id" WHERE "teams"."state" = 4 AND "teams"."allows_private_disclosure" = 't'::bool AND (("whitelisted_reporters"."user_id" IS NULL AND NULLIF(current_setting('secure.requester_id'), '') IS NULL) OR "whitelisted_reporters"."user_id" = (NULLIF(current_setting('secure.requester_id'), ''))::integer) AND "outer_reports"."disclosed_at" IS NOT NULL AND "outer_reports"."public_view" = 'full' AND "teams"."id" = "outer_reports"."team_id") AS "is_someone_visiting_a_report_privately_disclosed_to_them", "outer_reports"."hacker_published" = 't'::bool AND "outer_reports"."disclosed_at" IS NOT NULL AS "is_hacker_published" FROM "public"."reports" "outer_reports") AS "reports" WHERE "reports"."is_reporter" = 't'::bool OR "reports"."is_team_member" = 't'::bool OR "reports"."is_external_user" = 't'::bool OR "reports"."is_anc_triager" = 't'::bool OR "reports"."is_report_collaborator" = 't'::bool OR "reports"."is_someone_visiting_a_public_report" = 't'::bool OR "reports"."is_someone_visiting_a_public_limited_report" = 't'::bool OR "reports"."is_someone_visiting_a_report_privately_disclosed_to_them" = 't'::bool OR "reports"."is_hacker_published" = 't'::bool OR "reports"."is_retester" = 't'::bool) reports LEFT OUTER JOIN "public"."reports" "new_j0" ON "reports"."id" = "new_j0"."id" AND ("reports"."is_reporter" = 't'::bool OR "reports"."is_team_member" = 't'::bool OR "reports"."is_external_user" = 't'::bool OR "reports"."is_anc_triager" = 't'::bool OR "reports"."is_report_collaborator" = 't'::bool OR "reports"."is_someone_visiting_a_public_report" = 't'::bool OR "reports"."is_someone_visiting_a_public_limited_report" = 't'::bool OR "reports"."is_someone_visiting_a_report_privately_disclosed_to_them" = 't'::bool OR "reports"."is_hacker_published" = 't'::bool)) AS "reports" ON "reports"."id" = "hacktivity_items"."report_id" WHERE "reports"."__new_filterable_disclosed_at" IS NOT NULL) AS "hacktivity_items" LEFT OUTER JOIN "hacktivity_scores" ON "hacktivity_scores"."hacktivity_item_id" = "hacktivity_items"."id"
+}.freeze
+# rubocop:enable Metrics/LineLength
+
+def do_it
+  arel = Arel.sql_to_arel SQL
+  enhanced_arel = Arel.enhance(arel)
+
+  enhanced_arel.query(class: Arel::Attributes::Attribute).each do |node|
+    node.replace node
+  end
+
+  enhanced_arel
+end
+
+# Warm up
+do_it
+
+profile = StackProf.run(mode: :wall, raw: true) { do_it }
+File.write('stackprof.json', JSON.generate(profile))
+
+report = MemoryProfiler.report { do_it }
+puts report.pretty_print
+
+n = 100
+
+Benchmark.bm do |benchmark|
+  benchmark.report do
+    n.times do
+      do_it
+    end
+  end
+end

data/ext/pg_result_init/extconf.rb

@@ -0,0 +1,52 @@
+require 'mkmf'
+require 'pg'
+
+CONFIG['debugflags'] = '-ggdb3'
+CONFIG['optflags'] = '-O0'
+
+# https://github.com/jeremyevans/sequel_pg/blob/master/ext/sequel_pg/extconf.rb
+
+pg_include_dir = ENV['POSTGRES_INCLUDE'] ||
+                 (begin
+                    IO.popen('pg_config --includedir').readline.chomp
+                  rescue StandardError
+                    nil
+                  end)
+pg_lib_dir = ENV['POSTGRES_LIB'] ||
+             (begin
+                IO.popen('pg_config --libdir').readline.chomp
+              rescue StandardError
+                nil
+              end)
+
+dir_config(
+  'pg',
+  pg_include_dir,
+  pg_lib_dir,
+)
+
+pg_ext = Gem.loaded_specs.fetch('pg')
+pg_ext_inlude_dir = File.join(pg_ext.full_gem_path, 'ext')
+pg_ext_lib_dir = pg_ext.extension_dir
+
+dir_config(
+  'pg_ext',
+  pg_ext_inlude_dir,
+  pg_ext_lib_dir,
+)
+
+if (
+    have_library('pq') ||
+    have_library('libpq') ||
+    have_library('ms/libpq')
+  ) &&
+   have_header('libpq-fe.h') &&
+   have_header('pg.h') &&
+   have_func('PQcopyResult') &&
+   have_func('PQsetResultAttrs') &&
+   have_func('PQsetvalue')
+
+  create_makefile('arel_toolkit/pg_result_init')
+else
+  abort 'Could not find PostgreSQL build environment (libraries & headers): Makefile not created'
+end

data/ext/pg_result_init/pg_result_init.c

@@ -0,0 +1,138 @@
+#include <libpq-fe.h>
+#include <pg.h>
+#include "pg_result_init.h"
+
+VALUE rb_mPgResultInit;
+
+static VALUE
+pg_result_init_create(VALUE self, VALUE rb_pgconn, VALUE rb_result, VALUE rb_columns, VALUE rb_rows) {
+  Check_Type(rb_columns, T_ARRAY);
+  Check_Type(rb_rows, T_ARRAY);
+
+	if (!rb_obj_is_kind_of(rb_result, rb_cPGresult)) {
+	  rb_raise(
+      rb_eTypeError,
+      "wrong argument type %s (expected kind of PG::Result)",
+      rb_obj_classname(rb_result)
+    );
+  }
+
+  if (!rb_obj_is_kind_of(rb_pgconn, rb_cPGconn)) {
+    rb_raise(
+      rb_eTypeError,
+      "wrong argument type %s (expected kind of PG::Connection)",
+      rb_obj_classname(rb_pgconn)
+    );
+  }
+
+  PGresult *result = pgresult_get(rb_result);
+  PGresult *result_copy = PQcopyResult(result, PG_COPYRES_EVENTS | PG_COPYRES_NOTICEHOOKS);
+
+  int num_columns = RARRAY_LEN(rb_columns);
+  PGresAttDesc *attDescs = malloc(num_columns * sizeof(PGresAttDesc));
+
+  if (attDescs == NULL)
+    rb_raise(rb_eRuntimeError, "Cannot allocate memory");
+
+  int index;
+  VALUE rb_column;
+  VALUE rb_column_name;
+  VALUE rb_table_id;
+  VALUE rb_column_id;
+  VALUE rb_format;
+  VALUE rb_typ_id;
+  VALUE rb_typ_len;
+  VALUE rb_att_typemod;
+
+  char *column_name;
+
+  for(index = 0; index < num_columns; index++) {
+    rb_column = rb_ary_entry(rb_columns, index);
+    Check_Type(rb_column, T_HASH);
+
+    rb_column_name = rb_funcall(rb_column, rb_intern("fetch"), 1, ID2SYM(rb_intern("name")));
+
+    // 0 means unknown tableid
+    rb_table_id = rb_funcall(rb_column, rb_intern("fetch"), 2, ID2SYM(rb_intern("tableid")), INT2NUM(0));
+
+    // 0 means unknown columnid
+    rb_column_id = rb_funcall(rb_column, rb_intern("fetch"), 2, ID2SYM(rb_intern("columnid")), INT2NUM(0));
+
+    // 0 is text, 1 is binary https://www.postgresql.org/docs/10/libpq-exec.html
+    rb_format = rb_funcall(rb_column, rb_intern("fetch"), 2, ID2SYM(rb_intern("format")), INT2NUM(0));
+
+    rb_typ_id = rb_funcall(rb_column, rb_intern("fetch"), 1, ID2SYM(rb_intern("typid")));
+    rb_typ_len = rb_funcall(rb_column, rb_intern("fetch"), 1, ID2SYM(rb_intern("typlen")));
+
+    // -1 means that there is no type modifier
+    rb_att_typemod = rb_funcall(rb_column, rb_intern("fetch"), 2, ID2SYM(rb_intern("atttypmod")), INT2NUM(-1));
+
+    // Using StringValueCStr, if column contains null bytes it should raise Argument error
+    // postgres does not handle null bytes.
+    column_name = StringValueCStr(rb_column_name);
+
+    // postgres/src/interfaces/libpq/libpq-fe.h:235
+    attDescs[index].name = column_name;
+    attDescs[index].tableid = NUM2INT(rb_table_id);
+    attDescs[index].columnid = NUM2INT(rb_column_id);
+    attDescs[index].format = NUM2INT(rb_format);
+    attDescs[index].typid = NUM2INT(rb_typ_id);
+    attDescs[index].typlen = NUM2INT(rb_typ_len);
+    attDescs[index].atttypmod = NUM2INT(rb_att_typemod);
+  }
+
+  int success;
+
+  success = PQsetResultAttrs(result_copy, num_columns, attDescs);
+
+  if (success == 0)
+    rb_raise(rb_eRuntimeError, "PQsetResultAttrs failed: %d", success);
+
+  free(attDescs);
+
+  int num_rows = RARRAY_LEN(rb_rows);
+  int row_index;
+  int column_index;
+  VALUE rb_row;
+  VALUE rb_value;
+  char *value;
+  int value_len;
+
+  for(row_index = 0; row_index < num_rows; row_index++) {
+    for(column_index = 0; column_index < num_columns; column_index++) {
+      rb_row = rb_ary_entry(rb_rows, row_index);
+      rb_value = rb_ary_entry(rb_row, column_index);
+
+      if (NIL_P(rb_value)) {
+        success = PQsetvalue(result_copy, row_index, column_index, NULL, -1);
+
+        if (success == 0)
+          rb_raise(rb_eRuntimeError, "PQsetvalue failed: %d", success);
+      }
+      else {
+        rb_value = rb_funcall(rb_value, rb_intern("to_s"), 0);
+
+        // Using StringValueCStr, if column contains null bytes it should raise Argument error
+        // postgres does not handle null bytes.
+        value = StringValueCStr(rb_value);
+        value_len = RSTRING_LEN(rb_value);
+
+        success = PQsetvalue(result_copy, row_index, column_index, value, value_len);
+
+        if (success == 0)
+          rb_raise(rb_eRuntimeError, "PQsetvalue failed: %d", success);
+      }
+    }
+  }
+
+  VALUE rb_pgresult = pg_new_result(result_copy, rb_pgconn);
+  return rb_pgresult;
+}
+
+void
+Init_pg_result_init(void)
+{
+  rb_mPgResultInit = rb_define_module("PgResultInit");
+
+  rb_define_module_function(rb_mPgResultInit, "create", pg_result_init_create, 4);
+}

data/ext/pg_result_init/pg_result_init.h

@@ -0,0 +1,6 @@
+#ifndef PG_RESULT_INIT_H
+#define PG_RESULT_INIT_H 1
+
+#include "ruby.h"
+
+#endif /* PG_RESULT_INIT_H */

data/gemfiles/active_record_6.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source 'https://rubygems.org'
+
+gem 'activerecord', '~> 6.0.0'
+
+gemspec path: '../'

data/gemfiles/active_record_6.gemfile.lock

@@ -0,0 +1,210 @@
+PATH
+  remote: ..
+  specs:
+    arel_toolkit (0.4.5)
+      activerecord
+      pg (~> 1.1.4)
+      pg_query (~> 1.3)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (6.0.0)
+      activesupport (= 6.0.0)
+    activerecord (6.0.0)
+      activemodel (= 6.0.0)
+      activesupport (= 6.0.0)
+    activesupport (6.0.0)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.1, >= 2.1.8)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
+    ansi (1.5.0)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    approvals (0.0.24)
+      nokogiri (~> 1.6)
+      thor (~> 0.18)
+    ast (2.4.1)
+    binding_of_caller (0.8.0)
+      debug_inspector (>= 0.0.1)
+    coderay (1.1.3)
+    concurrent-ruby (1.1.7)
+    database_cleaner (1.7.0)
+    debug_inspector (0.0.3)
+    diff-lcs (1.4.4)
+    docile (1.3.2)
+    dpl (1.10.15)
+    faraday (1.1.0)
+      multipart-post (>= 1.2, < 3)
+      ruby2_keywords
+    faraday-http-cache (2.2.0)
+      faraday (>= 0.8)
+    ffi (1.13.1)
+    formatador (0.2.5)
+    github_changelog_generator (1.15.2)
+      activesupport
+      faraday-http-cache
+      multi_json
+      octokit (~> 4.6)
+      rainbow (>= 2.2.1)
+      rake (>= 10.0)
+      retriable (~> 3.0)
+    guard (2.16.2)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, < 4.0)
+      lumberjack (>= 1.0.12, < 2.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.9.12)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rake (1.0.0)
+      guard
+      rake
+    guard-rspec (4.7.3)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
+    guard-rubocop (1.3.0)
+      guard (~> 2.0)
+      rubocop (~> 0.20)
+    hirb (0.7.3)
+    i18n (1.8.5)
+      concurrent-ruby (~> 1.0)
+    interception (0.5)
+    jaro_winkler (1.5.4)
+    json (2.3.1)
+    listen (3.2.1)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.2.8)
+    memory_profiler (0.9.14)
+    method_source (0.9.2)
+    mini_portile2 (2.4.0)
+    minitest (5.14.2)
+    multi_json (1.15.0)
+    multipart-post (2.1.1)
+    nenv (0.3.0)
+    nokogiri (1.10.10)
+      mini_portile2 (~> 2.4.0)
+    notiffany (0.1.3)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    octokit (4.19.0)
+      faraday (>= 0.9)
+      sawyer (~> 0.8.0, >= 0.5.3)
+    parallel (1.19.2)
+    parser (2.7.2.0)
+      ast (~> 2.4.1)
+    pg (1.1.4)
+    pg_query (1.3.0)
+    pry (0.12.2)
+      coderay (~> 1.1.0)
+      method_source (~> 0.9.0)
+    pry-alias (0.0.1)
+      binding_of_caller
+      pry
+    pry-doc (1.1.0)
+      pry (~> 0.11)
+      yard (~> 0.9.11)
+    pry-nav (0.3.0)
+      pry (>= 0.9.10, < 0.13.0)
+    pry-rescue (1.5.2)
+      interception (>= 0.5)
+      pry (>= 0.12.0)
+    pry-stack_explorer (0.4.9.3)
+      binding_of_caller (>= 0.7)
+      pry (>= 0.9.11)
+    public_suffix (4.0.6)
+    rainbow (3.0.0)
+    rake (13.0.1)
+    rake-compiler (1.1.1)
+      rake
+    rb-fsevent (0.10.4)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    retriable (3.1.2)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.3)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.3)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.4)
+    rubocop (0.71.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.6)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    ruby-progressbar (1.10.1)
+    ruby2_keywords (0.0.2)
+    sawyer (0.8.2)
+      addressable (>= 2.3.5)
+      faraday (> 0.8, < 2.0)
+    shellany (0.0.1)
+    simplecov (0.16.1)
+      docile (~> 1.1)
+      json (>= 1.8, < 3)
+      simplecov-html (~> 0.10.0)
+    simplecov-console (0.4.2)
+      ansi
+      hirb
+      simplecov
+    simplecov-html (0.10.2)
+    stackprof (0.2.16)
+    thor (0.20.3)
+    thread_safe (0.3.6)
+    tzinfo (1.2.7)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.6.1)
+    yard (0.9.25)
+    zeitwerk (2.4.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (~> 6.0.0)
+  appraisal (~> 2.2.0)
+  approvals (~> 0.0.24)
+  arel_toolkit!
+  bundler (~> 2.0)
+  database_cleaner (~> 1.7.0)
+  dpl (~> 1.10.11)
+  github_changelog_generator (~> 1.15)
+  guard (~> 2.15)
+  guard-rake (~> 1.0.0)
+  guard-rspec (~> 4.7)
+  guard-rubocop (~> 1.3.0)
+  memory_profiler (~> 0.9)
+  pry
+  pry-alias
+  pry-doc
+  pry-nav
+  pry-rescue
+  pry-stack_explorer
+  rake (~> 13.0)
+  rake-compiler (~> 1.0)
+  rspec (~> 3.8)
+  rubocop (= 0.71.0)
+  simplecov (~> 0.16.1)
+  simplecov-console (~> 0.4.2)
+  stackprof (~> 0.2)
+
+BUNDLED WITH
+   2.2.19