arel_extensions 2.3.0 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bec346d9bbce78a1d91d023e0291903cb1c61b115237681cb4d9b4174e5f370a
-  data.tar.gz: b2e307f12bdb154129d29179093a04e1c7cd632feb2ed4d5e706a97acbfd0526
+  metadata.gz: 897fdf4d5248e3a7d67d5c99bdea4341e0f3d29f756d712bb982577adc438671
+  data.tar.gz: 5066e14f35d9f820e413ed8cbb994fd8870966b9b086536c57e71a0718a60033
 SHA512:
-  metadata.gz: 90fc4233e4699e6a7da8d7141351f21d1d33d72d9f3220a2b47f5f9e425bca147be2db7a1f062696b17b593cb5191bf5fe75be2f68022139c4e7fce6021a43a9
-  data.tar.gz: 5c49180d1bb19d6ad2338a509811010c0749bcb6beda93c9d1d8e68c46f4316bd9bf3cc22768695bf790c2d4f6ddd68d7378819dbf10ad38823cf55030c3aff9
+  metadata.gz: 7cc535755cbe7274d118a8b4ab68321082664be5c8714e44f546c71f16ebe083a54acd816c720b5d3e8dde4272c649565b544e94072e5d9de50be1625f26888f
+  data.tar.gz: d8d578ed26702eb285fe2e36cd4b9166187ed3486eccd09901b9f599750d0e45a6100e09394fdb1181e2c64c3446ef00dae89b2ef18d1dba17321b17a0b0b39b

data/.github/workflows/ruby.yml

@@ -2,6 +2,10 @@ name: Build and Test
 
 # Ruby + Rails Compatibility Matrix from here:
 # https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html
+#
+# Images are fixed to ubuntu 22.04 because jruby-9.2 is unavailable in
+# ubuntu-24.04 (ubuntu-latest when I tested). Also, for rails < 6, sqlite3
+# will not build because libsqlite3-dev is missing.
 
 on:
   push:
@@ -14,7 +18,7 @@ on:
 jobs:
   job_test_to_sql:
     name: test to_sql
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
@@ -78,7 +82,7 @@ jobs:
 
   job_test_sqlite:
     name: test sqlite
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
@@ -143,7 +147,7 @@ jobs:
 
   job_test_postgres:
     name: test postgres
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
@@ -232,7 +236,7 @@ jobs:
 
   job_test_mysql:
     name: test mysql
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
@@ -316,7 +320,7 @@ jobs:
 
   job_test_mssql:
     name: test mssql on linux
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:

data/NEWS.md

@@ -2,6 +2,16 @@
 
 ## [unreleased]
 
+## Release v2.3.2/v1.5.2 (02-01-2025)
+
+- Fix a subtle bug on table access as in `table[:col]` in certain situations.
+- `==` and `!=` deprecation warnings can stem from `arel` itself, so now we don't emit them because they're plain wrong.
+
+## Release v2.3.1/v1.5.1 (20-12-2024)
+
+- Fallback to Ruby's Warning module if ActiveSupport doesn't exist. Relevant for old Rails versions.
+- Added documentation on how to _"properly"_ configure the deprecator in a Rails application.
+
 ## Release v2.3.0/v1.5.0 (19-12-2024)
 
 - Use ActiveSupport's deprecation machinery instead of Ruby's Warning module.

data/lib/arel_extensions/string_functions.rb

@@ -47,14 +47,27 @@ module ArelExtensions
       ArelExtensions::Nodes::Substring.new [self, start, len]
     end
 
-    def [](start, ind = nil)
-      start += 1 if start.is_a?(Integer)
-      if start.is_a?(Range)
+    # Return a [ArelExtensions::Nodes::Substring] if `start` is a [Range] or an
+    # [Integer].
+    #
+    # Return the result to `self.send(start)` if it's a [String|Symbol]. The
+    # assumption is that you're trying to reach an [Arel::Table]'s
+    # [Arel::Attribute].
+    #
+    # @note `ind` should be an [Integer|NilClass] if `start` is an [Integer].
+    #   It's ignored in all other cases.
+    def [](start, end_ = nil)
+      if start.is_a?(String) || start.is_a?(Symbol)
+        self.send(start)
+      elsif start.is_a?(Range)
         ArelExtensions::Nodes::Substring.new [self, start.begin + 1, start.end - start.begin + 1]
-      elsif start.is_a?(Integer) && !ind
-        ArelExtensions::Nodes::Substring.new [self, start, 1]
+      elsif start.is_a?(Integer) && !end_
+        ArelExtensions::Nodes::Substring.new [self, start + 1, 1]
+      elsif start.is_a?(Integer)
+        start += 1
+        ArelExtensions::Nodes::Substring.new [self, start, end_ - start + 1]
       else
-        ArelExtensions::Nodes::Substring.new [self, start, ind - start + 1]
+        raise ArgumentError, 'unrecognized argument types; can accept integers, ranges, or strings.'
       end
     end
 

data/lib/arel_extensions/version.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = '2.3.0'.freeze
+  VERSION = '2.3.2'.freeze
 end

data/lib/arel_extensions/warning.rb

@@ -1,12 +1,39 @@
 module ArelExtensions
+  class RubyDeprecator
+    if RUBY_VERSION.split('.')[0].to_i < 3
+      def warn msg
+        Kernel.warn(msg)
+      end
+    else
+      def warn msg
+        Kernel.warn(msg, category: :deprecated)
+      end
+    end
+  end
+
+  # To configure deprecations in a Rails application, you can do something
+  # like this:
+  #
+  # ```ruby
+  #   ArelExtensions.deprecator.behavior =
+  #     (Rails.application.config.active_support.deprecation || :stderr)
+  # ```
+  #
+  # See ActiveSupport's deprecation documentation for more details.
   def self.deprecator
-    @deprecator ||= ActiveSupport::Deprecation.new(ArelExtensions::VERSION, "arel_extensions")
+    @deprecator ||=
+      if defined?(ActiveSupport::Deprecation)
+        major, minor = Gem::Version.create(ArelExtensions::VERSION).segments
+        ActiveSupport::Deprecation.new("#{major}.#{minor}", 'arel_extensions')
+      else
+        RubyDeprecator::new
+      end
   end
 
   module Warning
     def deprecated msg, what: nil
       kaller = caller(2..2).first
-      return if kaller.include?('lib/arel_extensions') && ENV['AREL_EXTENSIONS_IN_TEST'] != '1'
+      return if /lib\/(:?arel(?:_extensions)?|active_record)\// =~ kaller && ENV['AREL_EXTENSIONS_IN_TEST'] != '1'
 
       what = caller_locations(1, 1).first.label if what.nil?
       ArelExtensions.deprecator.warn "#{kaller}: `#{what}` is now deprecated. #{msg}"

data/version_v1.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = '1.5.0'.freeze
+  VERSION = '1.5.2'.freeze
 end

data/version_v2.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = '2.3.0'.freeze
+  VERSION = '2.3.2'.freeze
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: arel_extensions
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.3.2
 platform: ruby
 authors:
 - Yann Azoury
 - Félix Bellanger
 - Julien Delporte
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-19 00:00:00.000000000 Z
+date: 2025-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -204,7 +204,7 @@ homepage: https://github.com/Faveod/arel-extensions
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--main"
 - README.md
@@ -222,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.4.19
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Extending Arel
 test_files: []