arel_extensions 1.5.3 → 2.0.0.rc3

data/gemfiles/rails6_1.gemfile

@@ -1,42 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'rails', '~> 6.1.0'
-
-group :development, :test do
-  gem 'ruby-lsp', platforms: %i[mri]
-  gem 'debug', platforms: %i[mri]
-  gem 'concurrent-ruby', '1.3.4' # Need to pin b/c of a known issue https://github.com/rails/rails/issues/54260
-
-  gem 'activesupport', '~> 6.1.0'
-  gem 'activemodel', '~> 6.1.0'
-  gem 'activerecord', '~> 6.1.0'
-
-  gem 'sqlite3', '~> 1.4', platforms: [:mri]
-  gem 'mysql2', '~>0.5', platforms: [:mri]
-  gem 'pg', '~> 1.1', platforms: [:mri]
-
-  gem 'tiny_tds', platforms: %i[mri mingw x64_mingw mswin]
-  gem 'activerecord-sqlserver-adapter', '~> 6.1.0', platforms: %i[mri mingw x64_mingw mswin]
-  gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw]
-
-  gem 'ruby-oci8', platforms: %i[mri mswin mingw] if ENV.has_key? 'ORACLE_HOME'
-  gem 'activerecord-oracle_enhanced-adapter', '~> 6.0.0' if ENV.has_key? 'ORACLE_HOME'
-
-  # for JRuby
-  gem 'activerecord-jdbc-alt-adapter', '~> 61.0', platform: :jruby, require: true
-  gem 'activerecord-jdbcmysql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcpostgresql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcsqlite3-adapter', platforms: :jruby
-  gem 'jdbc-mssql', platforms: :jruby, require: true
-  gem 'jdbc-sqlite3', platforms: :jruby
-
-  # Ruby 3.4+ removes the following gems from the standard distribution.
-  # Warnings are emitted from 3.3 .
-  if Gem::Version.create(RUBY_VERSION) >= Gem::Version.create('3.3.0')
-    gem 'base64'
-    gem 'bigdecimal'
-    gem 'mutex_m'
-  end
-end
-
-gemspec path: Dir.pwd

data/gemfiles/rails7.gemfile

@@ -1,42 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'rails', '~> 7.0.1'
-
-group :development, :test do
-  gem 'ruby-lsp', platforms: %i[mri]
-  gem 'debug', platforms: %i[mri]
-  gem 'concurrent-ruby', '1.3.4' # Need to pin b/c of a known issue https://github.com/rails/rails/issues/54260
-
-  gem 'activesupport', '~> 7.0.1'
-  gem 'activemodel', '~> 7.0.1'
-  gem 'activerecord', '~> 7.0.1'
-
-  gem 'sqlite3', '~> 1.4', platforms: [:mri]
-  gem 'mysql2', '~>0.5', platforms: [:mri]
-  gem 'pg', '~> 1.1', platforms: [:mri]
-
-  gem 'tiny_tds', platforms: %i[mri mingw x64_mingw mswin]
-  gem 'activerecord-sqlserver-adapter', '~> 7.0.7', platforms: %i[mri mingw x64_mingw mswin]
-  gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw]
-
-  gem 'ruby-oci8', platforms: %i[mri mswin mingw] if ENV.has_key? 'ORACLE_HOME'
-  gem 'activerecord-oracle_enhanced-adapter', '~> 6.0.0' if ENV.has_key? 'ORACLE_HOME'
-
-  # for JRuby
-  gem 'jdbc-mssql', platforms: :jruby, require: true
-  gem 'jdbc-sqlite3', platform: :jruby
-  gem 'activerecord-jdbc-alt-adapter', '~> 70.0', platform: :jruby, require: true
-  gem 'activerecord-jdbcmysql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcpostgresql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcsqlite3-adapter', platforms: :jruby
-
-  # Ruby 3.4+ removes the following gems from the standard distribution.
-  # Warnings are emitted from 3.3 .
-  if Gem::Version.create(RUBY_VERSION) >= Gem::Version.create('3.3.0')
-    gem 'base64'
-    gem 'bigdecimal'
-    gem 'mutex_m'
-  end
-end
-
-gemspec path: Dir.pwd

data/gemfiles/rails7_1.gemfile

@@ -1,41 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'rails', '~> 7.1'
-
-group :development, :test do
-  gem 'ruby-lsp', platforms: %i[mri]
-  gem 'debug', platforms: %i[mri]
-
-  gem 'activesupport', '~> 7.1'
-  gem 'activemodel', '~> 7.1'
-  gem 'activerecord', '~> 7.1'
-
-  gem 'sqlite3', '~> 1.6', platforms: [:mri]
-  gem 'mysql2', '~>0.5', platforms: [:mri]
-  gem 'pg', '~> 1.5', platforms: [:mri]
-
-  gem 'tiny_tds', platforms: %i[mri mingw x64_mingw mswin]
-  gem 'activerecord-sqlserver-adapter', '~> 7.1.0.beta1', platforms: %i[mri mingw x64_mingw mswin]
-  gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw]
-
-  gem 'ruby-oci8', platforms: %i[mri mswin mingw] if ENV.has_key? 'ORACLE_HOME'
-  gem 'activerecord-oracle_enhanced-adapter', '~> 7.0.0' if ENV.has_key? 'ORACLE_HOME'
-
-  # for JRuby
-  gem 'jdbc-mssql', platforms: :jruby, require: true
-  gem 'jdbc-sqlite3', platform: :jruby
-  gem 'activerecord-jdbc-alt-adapter', '~> 71.0.0.alpha1', platform: :jruby, require: true
-  gem 'activerecord-jdbcmysql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcpostgresql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcsqlite3-adapter', platforms: :jruby
-
-  # Ruby 3.4+ removes the following gems from the standard distribution.
-  # Warnings are emitted from 3.3 .
-  if Gem::Version.create(RUBY_VERSION) >= Gem::Version.create('3.3.0')
-    gem 'base64'
-    gem 'bigdecimal'
-    gem 'mutex_m'
-  end
-end
-
-gemspec path: Dir.pwd

data/gemfiles/rails7_2.gemfile

@@ -1,41 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'rails', '~> 7.2'
-
-group :development, :test do
-  gem 'ruby-lsp', platforms: %i[mri]
-  gem 'debug', platforms: %i[mri]
-
-  gem 'activesupport', '~> 7.2'
-  gem 'activemodel', '~> 7.2'
-  gem 'activerecord', '~> 7.2'
-
-  gem 'sqlite3', '~> 1.6', platforms: [:mri]
-  gem 'mysql2', '~>0.5', platforms: [:mri]
-  gem 'pg', '~> 1.5', platforms: [:mri]
-
-  gem 'tiny_tds', platforms: %i[mri mingw x64_mingw mswin]
-  gem 'activerecord-sqlserver-adapter', '~> 7.2', platforms: %i[mri mingw x64_mingw mswin]
-  gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw]
-
-  gem 'ruby-oci8', platforms: %i[mri mswin mingw] if ENV.has_key? 'ORACLE_HOME'
-  gem 'activerecord-oracle_enhanced-adapter', '~> 7.0.0' if ENV.has_key? 'ORACLE_HOME'
-
-  # for JRuby
-  gem 'jdbc-mssql', platforms: :jruby, require: true
-  gem 'jdbc-sqlite3', platform: :jruby
-  # gem 'activerecord-jdbc-alt-adapter', '~> 71.0.0.alpha1', platform: :jruby, require: true
-  gem 'activerecord-jdbcmysql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcpostgresql-adapter', platforms: :jruby
-  gem 'activerecord-jdbcsqlite3-adapter', platforms: :jruby
-
-  # Ruby 3.4+ removes the following gems from the standard distribution.
-  # Warnings are emitted from 3.3 .
-  if Gem::Version.create(RUBY_VERSION) >= Gem::Version.create('3.3.0')
-    gem 'base64'
-    gem 'bigdecimal'
-    gem 'mutex_m'
-  end
-end
-
-gemspec path: Dir.pwd

data/gemspecs/arel_extensions-v1.gemspec

@@ -1,27 +0,0 @@
-$:.push File.expand_path('../lib', __FILE__)
-require 'arel_extensions/version'
-
-Gem::Specification.new do |s|
-  s.name        = 'arel_extensions'
-  s.version     = ArelExtensions::VERSION
-  s.platform    = Gem::Platform::RUBY
-  s.authors     = ['Yann Azoury', 'Félix Bellanger', 'Julien Delporte']
-  s.email       = ['yann.azoury@faveod.com', 'felix.bellanger@faveod.com', 'julien.delporte@faveod.com']
-  s.homepage    = 'https://github.com/Faveod/arel-extensions'
-  s.description = 'Adds new features to Arel'
-  s.summary     = 'Extending Arel'
-  s.license     = 'MIT'
-
-  s.rdoc_options = ['--main', 'README.md']
-  s.extra_rdoc_files = ['MIT-LICENSE.txt', 'README.md', 'functions.html']
-
-  # Manifest
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.require_paths = ['lib']
-
-  s.add_dependency('arel', '>= 6.0')
-
-  s.add_development_dependency('minitest', '~> 5.9')
-  s.add_development_dependency('rake', '~> 12.3.3')
-end

data/gemspecs/arel_extensions-v2.gemspec

@@ -1,27 +0,0 @@
-$:.push File.expand_path('../lib', __FILE__)
-require 'arel_extensions/version'
-
-Gem::Specification.new do |s|
-  s.name        = 'arel_extensions'
-  s.version     = ArelExtensions::VERSION
-  s.platform    = Gem::Platform::RUBY
-  s.authors     = ['Yann Azoury', 'Félix Bellanger', 'Julien Delporte']
-  s.email       = ['yann.azoury@faveod.com', 'felix.bellanger@faveod.com', 'julien.delporte@faveod.com']
-  s.homepage    = 'https://github.com/Faveod/arel-extensions'
-  s.description = 'Adds new features to Arel'
-  s.summary     = 'Extending Arel'
-  s.license     = 'MIT'
-
-  s.rdoc_options = ['--main', 'README.md']
-  s.extra_rdoc_files = ['MIT-LICENSE.txt', 'README.md', 'functions.html']
-
-  # Manifest
-  s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.require_paths = ['lib']
-
-  s.add_dependency('activerecord', '>= 6.0')
-
-  s.add_development_dependency('minitest', '~> 5.9')
-  s.add_development_dependency('rake', '~> 12.3.3')
-end

data/generate_gems.sh

@@ -1,15 +0,0 @@
-
-#gem uninstall arel_extensions
-
-# VERSION ~> 1
-cp ./version_v1.rb lib/arel_extensions/version.rb
-cp ./gemspecs/arel_extensions-v1.gemspec ./arel_extensions.gemspec
-gem build ./arel_extensions.gemspec
-
-# VERSION ~> 2
-cp ./version_v2.rb lib/arel_extensions/version.rb
-mv ./arel_extensions.gemspec ./arel_extensions.gemspec.bck
-cp ./gemspecs/arel_extensions-v2.gemspec ./arel_extensions.gemspec
-gem build ./arel_extensions.gemspec
-cp ./version_v1.rb lib/arel_extensions/version.rb
-cp ./gemspecs/arel_extensions-v1.gemspec ./arel_extensions.gemspec

data/lib/arel_extensions/aliases.rb

@@ -1,14 +0,0 @@
-module ArelExtensions
-  module Aliases
-
-    # Install an alias, if present.
-    def xas other
-      if other.present?
-        Arel::Nodes::As.new(self, Arel.sql(other))
-      else
-        self
-      end
-    end
-
-  end
-end

data/lib/arel_extensions/helpers.rb

@@ -1,62 +0,0 @@
-module ArelExtensions
-
-  #
-  # column_of
-  #
-  # Before the creation of these methods, getting the column name was done
-  # uniquely through the code found in `column_of_via_arel_table`.
-  #
-  # This turned out to be unreliable, most notably when using adapters that do
-  # not come with activerecord standard batteries. SQL Server is the most
-  # notorious example.
-  #
-  # Currently, we're using a needlessly complicated way to address this issue.
-  # Different versions of activerecord are behaving differently; the public APIs
-  # do not seem to come with any guarantees, so we need to be sure that we're
-  # coveing all these cases.
-
-  def self.column_of_via_arel_table(table_name, column_name)
-    Arel::Table.engine.connection.schema_cache.columns_hash(table_name)[column_name]
-  rescue NoMethodError
-    nil
-  rescue => e
-    warn("Warning: Unexpected exception caught while fetching column name for #{table_name}.#{column_name} in `column_of_via_arel_table`\n#{e.class}")
-    warn(e.backtrace)
-    nil
-  end
-
-  def self.column_of(table_name, column_name)
-    pool = ActiveRecord::Base.connection.pool
-    use_arel_table = !ActiveRecord::Base.connected? || \
-      (pool.respond_to?(:schema_cache) && pool.schema_cache.nil?)
-
-    if use_arel_table
-      column_of_via_arel_table(table_name, column_name)
-    else
-      if pool.respond_to?(:pool_config)
-        if pool.pool_config.respond_to?(:schema_reflection) # activerecord >= 7.1
-          if ActiveRecord.version >= Gem::Version.create('7.2')
-            pool.pool_config.schema_reflection.columns_hash(pool, table_name)[column_name]
-          else
-            pool.pool_config.schema_reflection.columns_hash(ActiveRecord::Base.connection, table_name)[column_name]
-          end
-        else # activerecord < 7.1
-          pool.pool_config.schema_cache.columns_hash(table_name)[column_name]
-        end
-      elsif pool.respond_to?(:schema_cache) # activerecord < 6.1
-        pool.schema_cache.columns_hash(table_name)[column_name]
-      else # activerecord < 5.0
-        column_of_via_arel_table(table_name, column_name)
-      end
-    end
-  rescue ActiveRecord::ConnectionNotEstablished
-    column_of_via_arel_table(table_name, column_name)
-  rescue ActiveRecord::StatementInvalid
-    nil
-  rescue => e
-    warn("Warning: Unexpected exception caught while fetching column name for #{table_name}.#{column_name} in `column_of`")
-    warn(e)
-    warn(e.backtrace)
-    nil
-  end
-end

data/lib/arel_extensions/nodes/aggregate_function.rb

@@ -1,13 +0,0 @@
-module ArelExtensions
-  module Nodes
-    class AggregateFunction < Function
-      attr_accessor :order, :group
-
-      def initialize node, **opts
-        @order = Array.wrap(opts[:order]).map{|e| convert_to_node(e)}
-        @group = Array.wrap(opts[:group]).map{|e| convert_to_node(e)}
-        super [node]
-      end
-    end
-  end
-end

data/lib/arel_extensions/nodes/formatted_date.rb

@@ -1,42 +0,0 @@
-require 'strscan'
-
-module ArelExtensions
-  module Nodes
-    class FormattedDate < Function
-      RETURN_TYPE = :string
-
-      attr_accessor :col_type, :iso_format, :time_zone
-
-      def initialize expr
-        col = expr[0]
-        @iso_format = convert_format(expr[1])
-        @time_zone  = expr[2]
-        @col_type = type_of_attribute(col)
-        super [col, convert_to_string_node(@iso_format)]
-      end
-
-      private
-
-      # Address portability issues with some of the formats.
-      def convert_format(fmt)
-        s = StringScanner.new fmt
-        res = StringIO.new
-        while !s.eos?
-          res <<
-            case
-            when s.scan(/%D/)    then '%m/%d/%y'
-            when s.scan(/%F/)    then '%Y-%m-%d'
-            when s.scan(/%R/)    then '%H:%M'
-            when s.scan(/%r/)    then '%I:%M:%S %p'
-            when s.scan(/%T/)    then '%H:%M:%S'
-            when s.scan(/%v/)    then '%e-%b-%Y'
-
-            when s.scan(/[^%]+/) then s.matched
-            when s.scan(/./)     then s.matched
-            end
-        end
-        res.string
-      end
-    end
-  end
-end

data/lib/arel_extensions/nodes/rollup.rb

@@ -1,36 +0,0 @@
-# The following is a patch to activerecord when it doesn't
-# have RollUp defined, i.e. for rails < 5.2
-
-begin
-  Arel::Nodes.const_get('RollUp')
-rescue NameError => _
-  module Arel
-    module Nodes
-      class RollUp < Arel::Nodes::Unary
-      end
-    end
-  end
-
-  module Arel
-    module Visitors
-      class PostgreSQL
-        # Utilized by GroupingSet, Cube & RollUp visitors to
-        # handle grouping aggregation semantics
-        def grouping_array_or_grouping_element(o, collector)
-          if o.expr.is_a? Array
-            collector << "( "
-            visit o.expr, collector
-            collector << " )"
-          else
-            visit o.expr, collector
-          end
-        end
-
-        def visit_Arel_Nodes_RollUp(o, collector)
-          collector << "ROLLUP"
-          grouping_array_or_grouping_element o, collector
-        end
-      end
-    end
-  end
-end

data/lib/arel_extensions/nodes/select.rb

@@ -1,10 +0,0 @@
-module Arel
-  module Nodes
-    class SelectCore
-      # havings did not exist in rails < 5.2
-      if !method_defined?(:havings)
-        alias :havings :having
-      end
-    end
-  end
-end

data/lib/arel_extensions/nodes/sum.rb

@@ -1,7 +0,0 @@
-module ArelExtensions
-  module Nodes
-    class Sum < AggregateFunction
-      RETURN_TYPE = :number
-    end
-  end
-end

data/lib/arel_extensions/visitors/convert_format.rb

@@ -1,37 +0,0 @@
-module ArelExtensions
-  module Visitors
-    # Convert date format in strftime syntax to whatever the RDBMs
-    # wants, based on the table of conversion +mapping+.
-    def self.strftime_to_format format, mapping
-      @mapping_regexps ||= {}
-      @mapping_regexps[mapping] ||=
-        Regexp.new(
-          mapping
-            .keys
-            .map{|k| Regexp.escape(k)}
-            .join('|')
-        )
-
-      regexp = @mapping_regexps[mapping]
-      s = StringScanner.new format
-      res = StringIO.new
-      while !s.eos?
-        res <<
-          case
-          when s.scan(regexp)
-            if v = mapping[s.matched]
-              v
-            else
-              # Should never happen.
-              s.matched
-            end
-          when s.scan(/[^%]+/)
-            s.matched
-          when s.scan(/./)
-            s.matched
-          end
-      end
-      res.string
-    end
-  end
-end

data/lib/arel_extensions/warning.rb

@@ -1,42 +0,0 @@
-module ArelExtensions
-  class RubyDeprecator
-    if RUBY_VERSION.split('.')[0].to_i < 3
-      def warn msg
-        Kernel.warn(msg)
-      end
-    else
-      def warn msg
-        Kernel.warn(msg, category: :deprecated)
-      end
-    end
-  end
-
-  # To configure deprecations in a Rails application, you can do something
-  # like this:
-  #
-  # ```ruby
-  #   ArelExtensions.deprecator.behavior =
-  #     (Rails.application.config.active_support.deprecation || :stderr)
-  # ```
-  #
-  # See ActiveSupport's deprecation documentation for more details.
-  def self.deprecator
-    @deprecator ||=
-      if defined?(ActiveSupport::Deprecation)
-        major, minor = Gem::Version.create(ArelExtensions::VERSION).segments
-        ActiveSupport::Deprecation.new("#{major}.#{minor}", 'arel_extensions')
-      else
-        RubyDeprecator::new
-      end
-  end
-
-  module Warning
-    def deprecated msg, what: nil
-      kaller = caller(2..2).first
-      return if /lib\/(:?arel(?:_extensions)?|active_record)\// =~ kaller && ENV['AREL_EXTENSIONS_IN_TEST'] != '1'
-
-      what = caller_locations(1, 1).first.label if what.nil?
-      ArelExtensions.deprecator.warn "#{kaller}: `#{what}` is now deprecated. #{msg}"
-    end
-  end
-end

data/test/arelx_test_helper.rb

@@ -1,92 +0,0 @@
-require 'rubygems'
-require 'minitest/autorun'
-require 'fileutils'
-require 'arel'
-require 'active_record'
-
-require 'support/fake_record'
-
-ENV['AREL_EXTENSIONS_IN_TEST'] = '1' # Useful for deprecation warnings.
-
-def colored(color, msg)
-  /^xterm|-256color$/.match?(ENV['TERM']) ? "\x1b[#{color}m#{msg}\x1b[89m\x1b[0m" : "#{msg}"
-end
-
-YELLOW = '33'
-
-# Load gems specific to databases.
-#
-# NOTE:
-#     It's strongly advised to test each database on its own. Loading multiple
-#     backend gems leads to undefined behavior according to tests; the backend
-#     might not recognize the correct DB visitor and will fallback to `ToSQL`
-#     and screw all tests.
-#
-#     The issue also seems to be related to arel version: at some point, arel
-#     dropped its wide support for DBs and kept Postgres, MySQL and SQLite.
-#     Here, we're just trying to load the correct ones.
-#
-# NOTE:
-#     As of jruby 9.4 (and maybe 9.3, but I couldn't test it given the state of
-#     the alt-adapter), we need to load jdbc/mssql manually.
-db_and_gem =
-  if RUBY_PLATFORM == 'java'
-    {
-      'oracle'     => ['activerecord-oracle_enhanced-adapter'],
-      'mssql'      => ['jdbc/mssql', 'activerecord-jdbcsqlserver-adapter'],
-    }
-  else
-    {
-      'oracle'     => ['activerecord-oracle_enhanced-adapter'],
-      'mssql'      => ['activerecord-sqlserver-adapter'],
-    }
-  end
-
-module Warning
-  ARELX_IGNORED = [
-    'PG::Coder.new(hash)',
-    'rb_check_safe_obj',       # ruby 3.0
-    'rb_tainted_str_new',      # ruby 3.0
-    'Using the last argument', # ruby < 3.0
-  ].freeze
-
-  def self.warn(message)
-    return if ARELX_IGNORED.any? { |msg| message.include?(msg) }
-
-    super
-  end
-end
-
-
-def load_lib(gems)
-  if gems && (RUBY_PLATFORM == 'java' || Arel::VERSION.to_i > 9)
-    gems.each do |gem|
-      begin
-        require gem
-      rescue Exception => e
-        warn "Warning: failed to load gem #{gem}. Are you sure it's installed?"
-        warn e.message
-      end
-    end
-  end
-end
-
-load_lib(db_and_gem[ENV['DB']])
-
-require 'arel_extensions'
-
-$arel_silence_type_casting_deprecation = true
-
-module Minitest::Assertions
-  #
-  #  Fails unless +expected and +actual are the same string, modulo extraneous spaces.
-  #
-  def assert_like(expected, actual, msg = nil)
-    msg ||= "Expected #{expected.inspect} and #{actual.inspect} to be alike"
-    assert_equal expected.gsub(/\s+/, ' ').strip, actual.gsub(/\s+/, ' ').strip
-  end
-end
-
-module Minitest::Expectations
-  infect_an_assertion :assert_like, :must_be_like
-end

data/version_v1.rb

@@ -1,3 +0,0 @@
-module ArelExtensions
-  VERSION = '1.5.3'.freeze
-end

data/version_v2.rb

@@ -1,3 +0,0 @@
-module ArelExtensions
-  VERSION = '2.3.3'.freeze
-end