arel_extensions 1.5.1 → 1.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4782dabe4923d8936216aff9889a846f3dc83e5c4404cf0282799d70326b5da0
-  data.tar.gz: fb02053b169f2fd2cac3a15b8bc8bab24d9d9c9f6da085e4a97e3af94696b050
+  metadata.gz: aa4f854a32266aeaef27f214b3bbb6ee7c1af78fe29aab1038a0bab9efd263a2
+  data.tar.gz: 22ae69a84925c2fc30a3036ea5e737aa36e5b3bc80099449ae806d62c5789cd4
 SHA512:
-  metadata.gz: 32a490287b7018a829d226328a2051a681027c6c16152400038c70a58c145531a5400a72f0c505f34607b8c7d93ce8590340948c1e91f5512f67c1c5e3b12f93
-  data.tar.gz: 5d8376ea039e7a6c3b062b8e224a12d225bff6777474fe5d1140ff35ecebcc5b7684727de64ff89ee4b70515e0a1e529c3564f8a161875c411bf7ab85df8023b
+  metadata.gz: 6f4e4c8ff1d568f917d6d731d5498e5c86e26d0f3f2908911a4f564cb0c5b201f3ce29eb9189316c96c5d8982b5ead4a6b456e9a796ffa38c4bb31d56c9481b4
+  data.tar.gz: 6974d4a2fb0648462b4aedcb1dc3639186a3cbbe58e3440cd8cfa80459ab7d073983ae317bec7491ba0b76674765abfa9b2aa900ab03c20911363328f644da0b

data/.github/workflows/ruby.yml

@@ -2,6 +2,10 @@ name: Build and Test
 
 # Ruby + Rails Compatibility Matrix from here:
 # https://www.fastruby.io/blog/ruby/rails/versions/compatibility-table.html
+#
+# Images are fixed to ubuntu 22.04 because jruby-9.2 is unavailable in
+# ubuntu-24.04 (ubuntu-latest when I tested). Also, for rails < 6, sqlite3
+# will not build because libsqlite3-dev is missing.
 
 on:
   push:
@@ -14,7 +18,7 @@ on:
 jobs:
   job_test_to_sql:
     name: test to_sql
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
@@ -78,7 +82,7 @@ jobs:
 
   job_test_sqlite:
     name: test sqlite
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
@@ -143,7 +147,7 @@ jobs:
 
   job_test_postgres:
     name: test postgres
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
@@ -232,7 +236,7 @@ jobs:
 
   job_test_mysql:
     name: test mysql
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
@@ -316,7 +320,7 @@ jobs:
 
   job_test_mssql:
     name: test mssql on linux
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:

data/NEWS.md

@@ -2,6 +2,11 @@
 
 ## [unreleased]
 
+## Release v2.3.2/v1.5.2 (02-01-2025)
+
+- Fix a subtle bug on table access as in `table[:col]` in certain situations.
+- `==` and `!=` deprecation warnings can stem from `arel` itself, so now we don't emit them because they're plain wrong.
+
 ## Release v2.3.1/v1.5.1 (20-12-2024)
 
 - Fallback to Ruby's Warning module if ActiveSupport doesn't exist. Relevant for old Rails versions.

data/lib/arel_extensions/string_functions.rb

@@ -47,14 +47,27 @@ module ArelExtensions
       ArelExtensions::Nodes::Substring.new [self, start, len]
     end
 
-    def [](start, ind = nil)
-      start += 1 if start.is_a?(Integer)
-      if start.is_a?(Range)
+    # Return a [ArelExtensions::Nodes::Substring] if `start` is a [Range] or an
+    # [Integer].
+    #
+    # Return the result to `self.send(start)` if it's a [String|Symbol]. The
+    # assumption is that you're trying to reach an [Arel::Table]'s
+    # [Arel::Attribute].
+    #
+    # @note `ind` should be an [Integer|NilClass] if `start` is an [Integer].
+    #   It's ignored in all other cases.
+    def [](start, end_ = nil)
+      if start.is_a?(String) || start.is_a?(Symbol)
+        self.send(start)
+      elsif start.is_a?(Range)
         ArelExtensions::Nodes::Substring.new [self, start.begin + 1, start.end - start.begin + 1]
-      elsif start.is_a?(Integer) && !ind
-        ArelExtensions::Nodes::Substring.new [self, start, 1]
+      elsif start.is_a?(Integer) && !end_
+        ArelExtensions::Nodes::Substring.new [self, start + 1, 1]
+      elsif start.is_a?(Integer)
+        start += 1
+        ArelExtensions::Nodes::Substring.new [self, start, end_ - start + 1]
       else
-        ArelExtensions::Nodes::Substring.new [self, start, ind - start + 1]
+        raise ArgumentError, 'unrecognized argument types; can accept integers, ranges, or strings.'
       end
     end
 

data/lib/arel_extensions/version.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = '1.5.1'.freeze
+  VERSION = '1.5.2'.freeze
 end

data/lib/arel_extensions/warning.rb

@@ -33,7 +33,7 @@ module ArelExtensions
   module Warning
     def deprecated msg, what: nil
       kaller = caller(2..2).first
-      return if kaller.include?('lib/arel_extensions') && ENV['AREL_EXTENSIONS_IN_TEST'] != '1'
+      return if /lib\/(:?arel(?:_extensions)?|active_record)\// =~ kaller && ENV['AREL_EXTENSIONS_IN_TEST'] != '1'
 
       what = caller_locations(1, 1).first.label if what.nil?
       ArelExtensions.deprecator.warn "#{kaller}: `#{what}` is now deprecated. #{msg}"

data/version_v1.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = '1.5.1'.freeze
+  VERSION = '1.5.2'.freeze
 end

data/version_v2.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = '2.3.1'.freeze
+  VERSION = '2.3.2'.freeze
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: arel_extensions
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.2
 platform: ruby
 authors:
 - Yann Azoury
 - Félix Bellanger
 - Julien Delporte
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-20 00:00:00.000000000 Z
+date: 2025-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: arel
@@ -204,7 +204,7 @@ homepage: https://github.com/Faveod/arel-extensions
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options:
 - "--main"
 - README.md
@@ -222,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.4.19
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Extending Arel
 test_files: []