arel_extensions 1.3.2 → 1.3.5

data/lib/arel_extensions/nodes/repeat.rb

@@ -7,11 +7,11 @@ module ArelExtensions
         tab = expr.map { |arg|
           convert_to_node(arg)
         }
-        return super(tab)
+        super(tab)
       end
 
       def +(other)
-        return ArelExtensions::Nodes::Concat.new(self.expressions + [other])
+        ArelExtensions::Nodes::Concat.new(self.expressions + [other])
       end
     end
   end

data/lib/arel_extensions/nodes/replace.rb

@@ -8,7 +8,7 @@ module ArelExtensions
         @left = convert_to_node(left)
         @pattern = convert_to_node(pattern)
         @substitute = convert_to_node(substitute)
-        super([@left,@pattern,@substitute])
+        super([@left, @pattern, @substitute])
       end
     end
 
@@ -20,7 +20,7 @@ module ArelExtensions
         @left = convert_to_node(left)
         @pattern = (pattern.is_a?(Regexp) ? pattern : %r[#{pattern}])
         @substitute = convert_to_node(substitute)
-        super([@left,@pattern,@substitute])
+        super([@left, @pattern, @substitute])
       end
     end
   end

data/lib/arel_extensions/nodes/soundex.rb

@@ -7,11 +7,11 @@ module ArelExtensions
       RETURN_TYPE = :string
 
       def ==(other)
-        Arel::Nodes::Equality.new self, Arel::Nodes.build_quoted(other, self)
+        Arel::Nodes::Equality.new self, Arel.quoted(other, self)
       end
 
       def !=(other)
-        Arel::Nodes::NotEqual.new self, Arel::Nodes.build_quoted(other, self)
+        Arel::Nodes::NotEqual.new self, Arel.quoted(other, self)
       end
     end
   end

data/lib/arel_extensions/nodes/substring.rb

@@ -8,7 +8,7 @@ module ArelExtensions
         if expr[2]
           tab << convert_to_node(expr[2])
         end
-        return super(tab)
+        super(tab)
       end
     end
   end

data/lib/arel_extensions/nodes/then.rb

@@ -5,7 +5,7 @@ module ArelExtensions
         tab = expr.map { |arg|
           convert_to_node(arg)
         }
-        return super(tab)
+        super(tab)
       end
     end
   end

data/lib/arel_extensions/nodes/trim.rb

@@ -7,11 +7,11 @@ module ArelExtensions
         tab = expr.map { |arg|
           convert_to_node(arg)
         }
-        return super(tab)
+        super(tab)
       end
 
       def +(other)
-        return ArelExtensions::Nodes::Concat.new(self.expressions + [other])
+        ArelExtensions::Nodes::Concat.new(self.expressions + [other])
       end
     end
 

data/lib/arel_extensions/nodes/union.rb

@@ -1,16 +1,16 @@
 module ArelExtensions
   module Nodes
     class Union < Arel::Nodes::Union
-      def initialize left,right
-        return super(left,right)
+      def initialize left, right
+        super(left, right)
       end
 
       def +(other)
-        return ArelExtensions::Nodes::Union.new(self,other)
+        ArelExtensions::Nodes::Union.new(self, other)
       end
 
       def union(other)
-        return ArelExtensions::Nodes::UnionAll.new(self,other)
+        ArelExtensions::Nodes::UnionAll.new(self, other)
       end
 
       def as other

data/lib/arel_extensions/nodes/union_all.rb

@@ -1,12 +1,12 @@
 module ArelExtensions
   module Nodes
     class UnionAll < Arel::Nodes::UnionAll
-      def initialize left,right
-        return super(left,right)
+      def initialize left, right
+        super(left, right)
       end
 
       def union_all(other)
-        return ArelExtensions::Nodes::UnionAll.new(self,other)
+        ArelExtensions::Nodes::UnionAll.new(self, other)
       end
 
       def as other

data/lib/arel_extensions/predications.rb

@@ -1,14 +1,14 @@
 module ArelExtensions
   module Predications
     def when right, expression = nil
-      ArelExtensions::Nodes::Case.new(self).when(right,expression)
+      ArelExtensions::Nodes::Case.new(self).when(right, expression)
     end
 
-    def matches(other, escape = nil,case_sensitive = nil)
+    def matches(other, escape = nil, case_sensitive = nil)
       if Arel::VERSION.to_i < 7
-        Arel::Nodes::Matches.new(self, Arel::Nodes.build_quoted(other), escape)
+        Arel::Nodes::Matches.new(self, Arel.quoted(other), escape)
       else
-        Arel::Nodes::Matches.new(self, Arel::Nodes.build_quoted(other), escape, case_sensitive)
+        Arel::Nodes::Matches.new(self, Arel.quoted(other), escape, case_sensitive)
       end
     end
 
@@ -17,7 +17,7 @@ module ArelExtensions
     end
 
     def cast right
-      ArelExtensions::Nodes::Cast.new([self,right])
+      ArelExtensions::Nodes::Cast.new([self, right])
     end
 
     def in(*other) # In should handle nil element in the Array
@@ -72,7 +72,7 @@ module ArelExtensions
       when Arel::SelectManager
         Arel::Nodes::NotIn.new(self, other.ast)
       else
-        Arel::Nodes::NotIn.new(self,quoted_node(other))
+        Arel::Nodes::NotIn.new(self, quoted_node(other))
       end
     end
 
@@ -81,13 +81,13 @@ module ArelExtensions
       when Arel::Attributes::Attribute, Arel::Nodes::Node, Integer
         object
       when DateTime
-        Arel::Nodes.build_quoted(object, self)
+        Arel.quoted(object, self)
       when Time
-        Arel::Nodes.build_quoted(object.strftime('%H:%M:%S'), self)
+        Arel.quoted(object.strftime('%H:%M:%S'), self)
       when String
-        Arel::Nodes.build_quoted(object)
+        Arel.quoted(object)
       when Date
-        Arel::Nodes.build_quoted(object.to_s, self)
+        Arel.quoted(object.to_s, self)
       when NilClass
         Arel.sql('NULL')
       when ActiveSupport::Duration

data/lib/arel_extensions/railtie.rb

@@ -3,7 +3,7 @@ require 'rails'
 module ArelExtensions
   class Railtie < Rails::Railtie
     rake_tasks do
-        load 'arel_extensions/tasks.rb'
+      load 'arel_extensions/tasks.rb'
     end
   end
 end

data/lib/arel_extensions/set_functions.rb

@@ -4,15 +4,15 @@ require 'arel_extensions/nodes/union_all'
 module ArelExtensions
   module SetFunctions
     def +(other)
-      ArelExtensions::Nodes::Union.new(self,other)
+      ArelExtensions::Nodes::Union.new(self, other)
     end
 
     def union(other)
-      ArelExtensions::Nodes::Union.new(self,other)
+      ArelExtensions::Nodes::Union.new(self, other)
     end
 
     def union_all(other)
-      ArelExtensions::Nodes::UnionAll.new(self,other)
+      ArelExtensions::Nodes::UnionAll.new(self, other)
     end
 
     def uniq

data/lib/arel_extensions/string_functions.rb

@@ -101,27 +101,27 @@ module ArelExtensions
     end
 
     def ai_matches other # accent insensitive & case sensitive
-      ArelExtensions::Nodes::AiMatches.new(self,other)
+      ArelExtensions::Nodes::AiMatches.new(self, other)
     end
 
     def ai_imatches other # accent insensitive & case insensitive
-      ArelExtensions::Nodes::AiIMatches.new(self,other)
+      ArelExtensions::Nodes::AiIMatches.new(self, other)
     end
 
     def smatches other # accent sensitive & case sensitive
-      ArelExtensions::Nodes::SMatches.new(self,other)
+      ArelExtensions::Nodes::SMatches.new(self, other)
     end
 
     def ai_collate
-      ArelExtensions::Nodes::Collate.new(self,nil,true,false)
+      ArelExtensions::Nodes::Collate.new(self, nil, true, false)
     end
 
     def ci_collate
-      ArelExtensions::Nodes::Collate.new(self,nil,false,true)
+      ArelExtensions::Nodes::Collate.new(self, nil, false, true)
     end
 
-    def collate ai = false,ci = false, option = nil
-      ArelExtensions::Nodes::Collate.new(self,option,ai,ci)
+    def collate ai = false, ci = false, option = nil
+      ArelExtensions::Nodes::Collate.new(self, option, ai, ci)
     end
 
     # REPLACE function replaces a sequence of characters in a string with another set of characters, not case-sensitive.
@@ -144,7 +144,7 @@ module ArelExtensions
     # concat elements of a group, separated by sep and ordered by a list of Ascending or Descending
     def group_concat(sep = nil, *orders, group: nil, order: nil)
       if orders.present?
-        warn("Warning : ArelExtensions: group_concat: you should now use the kwarg 'order' to specify an order in the group_concat.")
+        warn("Warning: ArelExtensions: group_concat: you should now use the kwarg 'order' to specify an order in the group_concat.")
       end
       order_tabs = [orders].flatten.map{ |o|
         if o.is_a?(Arel::Nodes::Ascending) || o.is_a?(Arel::Nodes::Descending)

data/lib/arel_extensions/tasks.rb

@@ -1,8 +1,8 @@
 namespace :arel_extensions do
   desc 'Install DB functions into current DB'
   task install_functions: :environment do
-    @env_db = if ENV['DB'] == 'oracle' && ((defined?(RUBY_ENGINE) && RUBY_ENGINE == "rbx") || (RUBY_PLATFORM == 'java')) # not supported
-                (RUBY_PLATFORM == 'java' ? "jdbc-sqlite" : 'sqlite')
+    @env_db = if ENV['DB'] == 'oracle' && ((defined?(RUBY_ENGINE) && RUBY_ENGINE == 'rbx') || (RUBY_PLATFORM == 'java')) # not supported
+                (RUBY_PLATFORM == 'java' ? 'jdbc-sqlite' : 'sqlite')
               else
                 ENV['DB'] || ActiveRecord::Base.connection.adapter_name
               end

data/lib/arel_extensions/version.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = "1.3.2".freeze
+  VERSION = '1.3.5'.freeze
 end

data/lib/arel_extensions/visitors/ibm_db.rb

@@ -2,45 +2,45 @@ module ArelExtensions
   module Visitors
     class Arel::Visitors::IBM_DB
       def visit_ArelExtensions_Nodes_Ceil o, collector
-        collector << "CEILING("
+        collector << 'CEILING('
         collector = visit o.expr, collector
-        collector << ")"
+        collector << ')'
         collector
       end
 
       def visit_ArelExtensions_Nodes_Trim o, collector
-        collector << "LTRIM(RTRIM("
+        collector << 'LTRIM(RTRIM('
         o.expressions.each_with_index { |arg, i|
           collector << COMMA if i != 0
           collector = visit arg, collector
         }
-        collector << "))"
+        collector << '))'
         collector
       end
 
       def visit_ArelExtensions_Nodes_DateDiff o, collector
-        collector << "DAY("
+        collector << 'DAY('
         collector = visit o.left, collector
-        collector << ","
+        collector << ','
         if o.right.is_a?(Arel::Attributes::Attribute)
           collector = visit o.right, collector
         else
           collector << "'#{o.right}'"
         end
-        collector << ")"
+        collector << ')'
         collector
       end
 
       def visit_ArelExtensions_Nodes_Duration o, collector
         # visit left for period
-        if o.left == "d"
-          collector << "DAY("
-        elsif o.left == "m"
-          collector << "MONTH("
-        elsif o.left == "w"
-          collector << "WEEK"
-        elsif o.left == "y"
-          collector << "YEAR("
+        if o.left == 'd'
+          collector << 'DAY('
+        elsif o.left == 'm'
+          collector << 'MONTH('
+        elsif o.left == 'w'
+          collector << 'WEEK'
+        elsif o.left == 'y'
+          collector << 'YEAR('
         end
         # visit right
         if o.right.is_a?(Arel::Attributes::Attribute)
@@ -48,20 +48,20 @@ module ArelExtensions
         else
           collector << "'#{o.right}'"
         end
-        collector << ")"
+        collector << ')'
         collector
       end
 
       def visit_ArelExtensions_Nodes_IsNull o, collector
-        collector << "COALESCE("
+        collector << 'COALESCE('
         collector = visit o.left, collector
-        collector << ","
-        if (o.right.is_a?(Arel::Attributes::Attribute))
+        collector << ','
+        if o.right.is_a?(Arel::Attributes::Attribute)
           collector = visit o.right, collector
         else
           collector << "'#{o.right}'"
         end
-        collector << ")"
+        collector << ')'
         collector
       end
     end