arel_extensions 1.2.3 → 1.2.5

data/lib/arel_extensions/math_functions.rb

@@ -7,6 +7,7 @@ require 'arel_extensions/nodes/formatted_number'
 require 'arel_extensions/nodes/log10'
 require 'arel_extensions/nodes/power'
 require 'arel_extensions/nodes/std'
+require 'arel_extensions/nodes/sum'
 
 module ArelExtensions
   module MathFunctions
@@ -62,12 +63,16 @@ module ArelExtensions
     end
 
     # Aggregate Functions
-    def std unbiased = true
-      ArelExtensions::Nodes::Std.new [self,unbiased]
+    def std opts={unbiased: true}
+      ArelExtensions::Nodes::Std.new self, opts
     end
 
-    def variance unbiased = true
-      ArelExtensions::Nodes::Variance.new [self,unbiased]
+    def variance opts={unbiased: true}
+      ArelExtensions::Nodes::Variance.new self, opts
+    end
+
+    def sum opts={unbiased: true}
+      ArelExtensions::Nodes::Sum.new self, opts
     end
 
     #function that can be invoked to produce random numbers between 0 and 1

data/lib/arel_extensions/nodes.rb

@@ -1,2 +1,2 @@
 require 'arel_extensions/nodes/function'
-
+require 'arel_extensions/nodes/aggregate_function'

data/lib/arel_extensions/nodes/aggregate_function.rb

@@ -0,0 +1,14 @@
+module ArelExtensions
+  module Nodes
+    class AggregateFunction < Function
+      attr_accessor :order, :group
+
+      def initialize node, **opts
+        @order = Array(opts[:order]).map{|e| convert_to_node(e)}
+        @group = Array(opts[:group]).map{|e| convert_to_node(e)}
+        super [node]
+      end
+    end
+
+  end
+end

data/lib/arel_extensions/nodes/coalesce.rb

@@ -2,7 +2,7 @@ module ArelExtensions
   module Nodes
     class Coalesce < Function
       RETURN_TYPE = :string
-      
+
       attr_accessor :left_node_type
 
       def return_type
@@ -20,7 +20,7 @@ module ArelExtensions
           @left_node_type = :number
         when ArelExtensions::Nodes::Coalesce, ArelExtensions::Nodes::Function
           @left_node_type = expr.first.respond_to?(:left_node_type) ? expr.first.left_node_type : nil
-        when Arel::Nodes::Node, Arel::Attributes::Attribute 
+        when Arel::Nodes::Node, Arel::Attributes::Attribute
           @left_node_type = type_of_attribute(expr.first)
         when Date
           @left_node_type = :ruby_date

data/lib/arel_extensions/nodes/concat.rb

@@ -40,21 +40,14 @@ module ArelExtensions::Nodes
 
   end
 
-  class GroupConcat < Function
+  class GroupConcat < AggregateFunction
     RETURN_TYPE = :string
 
-    attr_accessor :orders
-    
-    def initialize expr
-      tab = expr.map { |arg|
-        if arg.is_a?(Array)
-          @orders = arg
-          nil
-        else
-          convert_to_node(arg)
-        end
-      }.compact
-      super(tab)
+    attr_accessor :separator
+
+    def initialize node, separator = ', ', **opts
+      @separator = convert_to_node(separator)
+      super node, opts
     end
 
   end

data/lib/arel_extensions/nodes/date_diff.rb

@@ -12,7 +12,7 @@ module ArelExtensions
         res = []
         col = expr.first
         case col
-        when Arel::Nodes::Node, Arel::Attributes::Attribute 
+        when Arel::Nodes::Node, Arel::Attributes::Attribute
           @left_node_type = type_of_attribute(col)
         when Date
           @left_node_type = :ruby_date
@@ -21,7 +21,7 @@ module ArelExtensions
         end
         res << ([:date, :ruby_date].include?(@left_node_type) ? convert_to_date_node(col) : convert_to_datetime_node(col))
         case expr[1]
-        when Arel::Nodes::Node, Arel::Attributes::Attribute 
+        when Arel::Nodes::Node, Arel::Attributes::Attribute
           @right_node_type = type_of_attribute(expr[1])
         when Date
           @right_node_type = :ruby_date

data/lib/arel_extensions/nodes/format.rb

@@ -1,15 +1,15 @@
 module ArelExtensions
   module Nodes
-    class Format < Function      
+    class Format < Function
       RETURN_TYPE = :string
 
-    	attr_accessor :col_type, :iso_format
-    	def initialize expr
-	        col = expr.first
-            @iso_format = expr[1]
-	        @col_type = type_of_attribute(col)
-        	super [col, convert_to_string_node(@iso_format)]
-    	end
+      attr_accessor :col_type, :iso_format
+      def initialize expr
+        col = expr.first
+        @iso_format = expr[1]
+        @col_type = type_of_attribute(col)
+        super [col, convert_to_string_node(@iso_format)]
+      end
     end
   end
 end

data/lib/arel_extensions/nodes/formatted_number.rb

@@ -1,16 +1,16 @@
 module ArelExtensions
 	module Nodes
-		class FormattedNumber < Function		
+		class FormattedNumber < Function
 			RETURN_TYPE = :string
-			
+
 			attr_accessor :locale, :prefix, :suffix, :flags, :scientific_notation, :width,:precision, :type, :original_string
-			
+
 			def initialize expr
 				# expr[1] = {:locale => 'fr_FR', :type => "e"/"f"/"d", :prefix => "$ ", :suffix => " %", :flags => " +-#0", :width => 5, :precision => 6}
 				col = expr.first
 				@locale = expr[1][:locale]
 				@prefix = expr[1][:prefix]
-				@suffix = expr[1][:suffix] 
+				@suffix = expr[1][:suffix]
 				@width = expr[1][:width]
 				@precision = expr[1][:precision]
 				@type = expr[1][:type]
@@ -19,7 +19,7 @@ module ArelExtensions
 				@original_string = expr[1][:original_string]
 				super [col]
 			end
-			
-		end				
+
+		end
 	end
 end

data/lib/arel_extensions/nodes/function.rb

@@ -71,6 +71,8 @@ module ArelExtensions
           Arel.sql('NULL')
         when ActiveSupport::Duration
           Arel.sql(object.to_i)
+        when Array
+          Arel::Nodes::Grouping.new(object.map{|r| convert_to_node(e)})
         else
           raise(ArgumentError, "#{object.class} can not be converted to CONCAT arg")
         end

data/lib/arel_extensions/nodes/matches.rb

@@ -3,7 +3,7 @@ module ArelExtensions
     class IMatches < Arel::Nodes::Matches
 
       attr_accessor :case_sensitive if Arel::VERSION.to_i < 7
-      
+
       def initialize(left, right, escape = nil)
         r = Arel::Nodes.build_quoted(right)
         if Arel::VERSION.to_i < 7 # managed by default in version 7+ (rails 5), so useful for rails 3 & 4
@@ -17,13 +17,13 @@ module ArelExtensions
 
     class IDoesNotMatch < IMatches
     end
-    
+
     class AiMatches < IMatches
     end
-    
+
     class AiIMatches < IMatches
     end
-    
+
     class SMatches < IMatches
     end
 

data/lib/arel_extensions/nodes/power.rb

@@ -2,9 +2,9 @@ module ArelExtensions
   module Nodes
     class Power < Function
     	RETURN_TYPE = :number
-		
+
 		def initialize expr
-		  super [convert_to_node(expr.first), convert_to_number(expr[1])]		  
+		  super [convert_to_node(expr.first), convert_to_number(expr[1])]
 		end
     end
   end

data/lib/arel_extensions/nodes/repeat.rb

@@ -2,7 +2,7 @@ module ArelExtensions
   module Nodes
     class Repeat < Function
       RETURN_TYPE = :string
-      
+
       def initialize expr
         tab = expr.map { |arg|
           convert_to_node(arg)
@@ -11,7 +11,7 @@ module ArelExtensions
       end
 
       def +(other)
-        return ArelExtensions::Nodes::Concat.new(self.expressions + [other]) 
+        return ArelExtensions::Nodes::Concat.new(self.expressions + [other])
       end
 
     end

data/lib/arel_extensions/nodes/replace.rb

@@ -11,7 +11,7 @@ module ArelExtensions
       end
 
       def +(other)
-        return ArelExtensions::Nodes::Concat.new(self.expressions + [other]) 
+        return ArelExtensions::Nodes::Concat.new(self.expressions + [other])
       end
 
     end

data/lib/arel_extensions/nodes/soundex.rb

@@ -1,11 +1,11 @@
 module ArelExtensions
 	module Nodes
-		class Soundex < Function	
+		class Soundex < Function
 			include Arel::Expressions
-			include ArelExtensions::Comparators			
-							
+			include ArelExtensions::Comparators
+
 			RETURN_TYPE = :string
-				
+
 			def ==(other)
 				Arel::Nodes::Equality.new self, Arel::Nodes.build_quoted(other, self)
 			end

data/lib/arel_extensions/nodes/std.rb

@@ -1,26 +1,24 @@
 module ArelExtensions
   module Nodes
-    class Std < Function
-    	RETURN_TYPE = :number
-    	
-		attr_accessor :unbiased_estimator
-    	def initialize expr
-	        col = expr.first
-            @unbiased_estimator = expr[1]
-        	super [col]
-    	end    	
+    class Std < AggregateFunction
+      RETURN_TYPE = :number
+      attr_accessor :unbiased_estimator
+
+      def initialize node, opts = {}
+        @unbiased_estimator = opts[:unbiased] ? true : false
+        super node, opts
+      end
     end
-    
-    class Variance < Function
-    	RETURN_TYPE = :number
-    	
-		attr_accessor :unbiased_estimator
-    	def initialize expr
-	        col = expr.first
-            @unbiased_estimator = expr[1]
-        	super [col]
-    	end    	
-    end    
-    
+
+    class Variance < AggregateFunction
+      RETURN_TYPE = :number
+      attr_accessor :unbiased_estimator
+
+      def initialize node, opts = {}
+        @unbiased_estimator = opts[:unbiased] ? true : false
+        super node, opts
+      end
+    end
+
   end
 end

data/lib/arel_extensions/nodes/substring.rb

@@ -15,7 +15,7 @@ module ArelExtensions
 
 #		def +(other)
 #			puts "[Substring] : #{other.inspect} (#{self.expressions.inspect})"
-#	        return ArelExtensions::Nodes::Concat.new(self.expressions + [other]) 
+#	        return ArelExtensions::Nodes::Concat.new(self.expressions + [other])
 #		end
 
     end

data/lib/arel_extensions/nodes/sum.rb

@@ -0,0 +1,7 @@
+module ArelExtensions
+  module Nodes
+    class Sum < AggregateFunction
+      RETURN_TYPE = :number
+    end
+  end
+end

data/lib/arel_extensions/nodes/trim.rb

@@ -2,7 +2,7 @@ module ArelExtensions
   module Nodes
     class Trim < Function
       RETURN_TYPE = :string
-      
+
       def initialize expr
         tab = expr.map { |arg|
           convert_to_node(arg)
@@ -11,7 +11,7 @@ module ArelExtensions
       end
 
       def +(other)
-        return ArelExtensions::Nodes::Concat.new(self.expressions + [other]) 
+        return ArelExtensions::Nodes::Concat.new(self.expressions + [other])
       end
 
     end

data/lib/arel_extensions/nodes/union.rb

@@ -7,11 +7,11 @@ module ArelExtensions
       end
 
       def +(other)
-        return ArelExtensions::Nodes::Union.new(self,other) 
+        return ArelExtensions::Nodes::Union.new(self,other)
       end
 
       def union(other)
-        return ArelExtensions::Nodes::UnionAll.new(self,other) 
+        return ArelExtensions::Nodes::UnionAll.new(self,other)
       end
 
       def as other

data/lib/arel_extensions/null_functions.rb

@@ -8,12 +8,12 @@ module ArelExtensions
     def is_null
       ArelExtensions::Nodes::IsNull.new [self]
     end
-    
+
     #ISNOTNULL function lets you return an alternative value when an expression is NOT NULL.
     def is_not_null
       ArelExtensions::Nodes::IsNotNull.new [self]
     end
-    
+
     # returns the first non-null expr in the expression list. You must specify at least two expressions.
     #If all occurrences of expr evaluate to null, then the function returns null.
     def coalesce *args

data/lib/arel_extensions/string_functions.rb

@@ -92,7 +92,7 @@ module ArelExtensions
       ArelExtensions::Nodes::SMatches.new(self,other)
     end
 
-    def ai_collate 
+    def ai_collate
       ArelExtensions::Nodes::Collate.new(self,nil,true,false)
     end
 
@@ -108,13 +108,16 @@ module ArelExtensions
     def replace left, right
       ArelExtensions::Nodes::Replace.new [self, left, right]
     end
-    
+
     def concat other
       ArelExtensions::Nodes::Concat.new [self, other]
     end
 
     #concat elements of a group, separated by sep and ordered by a list of Ascending or Descending
-    def group_concat sep = nil, *orders 
+    def group_concat(sep= nil, *orders, group: nil, order: nil)
+      if orders.present?
+        warn("Warning : ArelExtensions: group_concat: you should now use the kwarg 'order' to specify an order in the group_concat.")
+      end
       order_tabs = [orders].flatten.map{ |o|
         if o.is_a?(Arel::Nodes::Ascending) || o.is_a?(Arel::Nodes::Descending)
           o
@@ -124,7 +127,7 @@ module ArelExtensions
           nil
         end
       }.compact
-      ArelExtensions::Nodes::GroupConcat.new [self, sep, order_tabs]
+      ArelExtensions::Nodes::GroupConcat.new(self, sep, group: group, order: (order || order_tabs))
     end
 
     #Function returns a string after removing left, right or the both prefixes or suffixes int argument
@@ -155,11 +158,11 @@ module ArelExtensions
     def not_blank
       ArelExtensions::Nodes::NotBlank.new [self]
     end
-    
-    def repeat other = 1 
+
+    def repeat other = 1
       ArelExtensions::Nodes::Repeat.new [self, other]
     end
-    
+
     def levenshtein_distance other
       ArelExtensions::Nodes::LevenshteinDistance.new [self, other]
     end

data/lib/arel_extensions/version.rb

@@ -1,3 +1,3 @@
 module ArelExtensions
-  VERSION = "1.2.3".freeze
+  VERSION = "1.2.5".freeze
 end

data/lib/arel_extensions/visitors/mssql.rb

@@ -400,14 +400,14 @@ module ArelExtensions
         collector << "(STRING_AGG("
         collector = visit o.left, collector
         collector << Arel::Visitors::Oracle::COMMA
-        if o.right  && o.right != 'NULL'
-          collector = visit o.right, collector
+        if o.separator  && o.selector != 'NULL'
+          collector = visit o.separator, collector
         else
           collector = visit Arel::Nodes.build_quoted(','), collector
         end
         collector << ") WITHIN GROUP (ORDER BY "
-        if !o.orders.blank?
-          o.orders.each_with_index do |order,i|
+        if !o.order.blank?
+          o.order.each_with_index do |order,i|
             collector << Arel::Visitors::Oracle::COMMA unless i == 0
             collector = visit order, collector
           end