arel_extensions 1.2.15 → 1.2.23

data/test/arelx_test_helper.rb

@@ -22,7 +22,5 @@ module Minitest::Assertions
 end
 
 module Minitest::Expectations
-
   infect_an_assertion :assert_like, :must_be_like
-
 end

data/test/database.yml

@@ -10,6 +10,8 @@ mysql:
   adapter: mysql2
   database: arext_test
   username: travis
+  host: 127.0.0.1
+  port: 3306
   encoding: utf8
 jdbc-mysql:
   adapter: jdbcmysql

data/test/real_db_test.rb

@@ -21,10 +21,10 @@ def setup_db
         db.enable_load_extension(0)
       rescue => e
         $load_extension_disabled = true
-        $stderr << "can not load extensions #{e.inspect}\n"
+        $stderr << "cannot load extensions #{e.inspect}\n"
       end
     end
-    #function find_in_set
+    # function find_in_set
     db.create_function("find_in_set", 1) do |func, value1, value2|
       func.result = value1.index(value2)
     end
@@ -44,15 +44,13 @@ def teardown_db
 end
 
 class User < ActiveRecord::Base
-
 end
 
 class ListTest < Minitest::Test
-
   def setup
     d = Date.new(2016,05,23)
     setup_db
-    User.create :age => 5, :name => "Lucas", :created_at => d , :score => 20.16
+    User.create :age => 5, :name => "Lucas", :created_at => d, :score => 20.16
     User.create :age => 15, :name => "Sophie", :created_at => d, :score => 20.16
     User.create :age => 20, :name => "Camille", :created_at => d, :score => 20.16
     User.create :age => 21, :name => "Arthur", :created_at => d, :score => 65.62
@@ -90,30 +88,28 @@ class ListTest < Minitest::Test
   end
 
   def test_Comparator
-    assert_equal 2,User.where(User.arel_table[:age] < 6 ).count
-    assert_equal 2,User.where(User.arel_table[:age] <=10 ).count
-    assert_equal 3,User.where(User.arel_table[:age] > 20 ).count
-    assert_equal 4,User.where(User.arel_table[:age] >=20 ).count
-    assert_equal 1,User.where(User.arel_table[:age] > 5 ).where(User.arel_table[:age] < 20 ).count
+    assert_equal 2,User.where(User.arel_table[:age] < 6).count
+    assert_equal 2,User.where(User.arel_table[:age] <=10).count
+    assert_equal 3,User.where(User.arel_table[:age] > 20).count
+    assert_equal 4,User.where(User.arel_table[:age] >=20).count
+    assert_equal 1,User.where(User.arel_table[:age] > 5).where(User.arel_table[:age] < 20).count
   end
 
   def test_date_duration
-    #Year
+    # Year
     assert_equal 2016,User.where(User.arel_table[:name].eq("Lucas")).select((User.arel_table[:created_at].year).as("res")).first.res.to_i
     assert_equal 0,User.where(User.arel_table[:created_at].year.eq("2012")).count
-    #Month
+    # Month
     assert_equal 5,User.where(User.arel_table[:name].eq("Camille")).select((User.arel_table[:created_at].month).as("res")).first.res.to_i
     assert_equal 8,User.where(User.arel_table[:created_at].month.eq("05")).count
-    #Week
+    # Week
     assert_equal 21,User.where(User.arel_table[:name].eq("Arthur")).select((User.arel_table[:created_at].week).as("res")).first.res.to_i
     assert_equal 8,User.where(User.arel_table[:created_at].month.eq("05")).count
-    #Day
+    # Day
     assert_equal 23,User.where(User.arel_table[:name].eq("Laure")).select((User.arel_table[:created_at].day).as("res")).first.res.to_i
     assert_equal 0,User.where(User.arel_table[:created_at].day.eq("05")).count
   end
 
-
-
   def test_length
     assert_equal 7,User.where(User.arel_table[:name].eq("Camille")).select((User.arel_table[:name].length).as("res")).first.res
     assert_equal 5,User.where(User.arel_table[:name].eq("Laure")).select((User.arel_table[:name].length).as("res")).first.res
@@ -136,7 +132,6 @@ class ListTest < Minitest::Test
     end
   end
 
-
   def test_floor
     if !$sqlite || !$load_extension_disabled
       assert_equal 0,User.where(User.arel_table[:name].eq("Negatif")).select((User.arel_table[:score].floor).as("res")).first.res
@@ -144,57 +139,51 @@ class ListTest < Minitest::Test
     end
   end
 
-
   def test_findinset
     db = ActiveRecord::Base.connection.raw_connection
-    assert_equal 3,db.get_first_value( "select find_in_set(name,'i') from users where name = 'Camille'" )
-    assert_equal "",db.get_first_value( "select find_in_set(name,'p') from users where name = 'Camille'" ).to_s
-    #number
-    #assert_equal 1,User.select(User.arel_table[:name] & ("l")).count
-    #assert_equal 3,(User.select(User.arel_table[:age] & [5,15,20]))
-    #string
+    assert_equal 3,db.get_first_value("select find_in_set(name,'i') from users where name = 'Camille'")
+    assert_equal "",db.get_first_value("select find_in_set(name,'p') from users where name = 'Camille'").to_s
+    # number
+    # assert_equal 1,User.select(User.arel_table[:name] & ("l")).count
+    # assert_equal 3,(User.select(User.arel_table[:age] & [5,15,20]))
+    # string
   end
 
-
   def test_math_plus
     d = Date.new(1997,06,15)
-    #Concat String
+    # Concat String
     assert_equal "SophiePhan",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + "Phan").as("res")).first.res
-    assert_equal "Sophie2",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + 2 ).as("res")).first.res
+    assert_equal "Sophie2",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + 2).as("res")).first.res
     assert_equal "Sophie1997-06-15",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + d).as("res")).first.res
     assert_equal "Sophie15",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + User.arel_table[:age]).as("res")).first.res
     assert_equal "SophieSophie",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + User.arel_table[:name]).as("res")).first.res
     assert_equal "Sophie2016-05-23",User.where(User.arel_table[:name].eq("Sophie")).select((User.arel_table[:name] + User.arel_table[:created_at]).as("res")).first.res
-    #concat Integer
+    # concat Integer
     assert_equal 1, User.where((User.arel_table[:age] + 10).eq(33)).count
     assert_equal 1, User.where((User.arel_table[:age] + "1").eq(6)).count
     assert_equal 1, User.where((User.arel_table[:age] + User.arel_table[:age]).eq(10)).count
-    #concat Date
-#    puts((User.arel_table[:created_at] + 1).as("res").to_sql.inspect)
+    # concat Date
+    #    puts((User.arel_table[:created_at] + 1).as("res").to_sql.inspect)
     assert_equal "2016-05-24", @myung.select((User.arel_table[:created_at] + 1).as("res")).first.res.to_date.to_s
     assert_equal "2016-05-25", @myung.select((User.arel_table[:created_at] + 2.day).as("res")).first.res.to_date.to_s
   end
 
-
   def test_math_moins
     d = Date.new(2016,05,20)
-    #Datediff
+    # Datediff
     assert_equal 8,User.where((User.arel_table[:created_at] - User.arel_table[:created_at]).eq(0)).count
     assert_equal 3,User.where(User.arel_table[:name].eq("Laure")).select((User.arel_table[:created_at] - d).as("res")).first.res.abs.to_i
-    #Substraction
+    # Substraction
     assert_equal 0, User.where((User.arel_table[:age] - 10).eq(50)).count
     assert_equal 0, User.where((User.arel_table[:age] - "10").eq(50)).count
   end
 
-
-
   def test_rand
     assert_equal 5,User.where(User.arel_table[:score].eq(20.16)).select(User.arel_table[:id]).order(Arel.rand).take(50).count
-    #test_alias  :random  :rand
+    # test_alias  :random  :rand
     assert_equal 8,User.select(User.arel_table[:name]).order(Arel.rand).take(50).count
   end
 
-
   def test_regexp_not_regex
     if !$sqlite || !$load_extension_disabled
       assert_equal 1, User.where(User.arel_table[:name] =~ '^M').count
@@ -207,13 +196,11 @@ class ListTest < Minitest::Test
     assert_equal "replace",User.where(User.arel_table[:name].eq("Lucas")).select(((User.arel_table[:name]).replace(User.arel_table[:name],"replace")).as("res")).first.res
   end
 
-
   def test_round
     assert_equal 1, User.where(((User.arel_table[:age]).round(0)).eq(5.0)).count
     assert_equal 0, User.where(((User.arel_table[:age]).round(-1)).eq(6.0)).count
   end
 
-
   def test_Soundex
     if !$sqlite || !$load_extension_disabled
       assert_equal "C540",User.where(User.arel_table[:name].eq("Camille")).select((User.arel_table[:name].soundex).as("res")).first.res.to_s
@@ -222,14 +209,13 @@ class ListTest < Minitest::Test
   end
 
   def test_Sum
-    #.take(50) because of limit by ORDER BY
+    # .take(50) because of limit by ORDER BY
     assert_equal 110,User.select((User.arel_table[:age].sum + 1).as("res")).take(50).first.res
     assert_equal 218,User.select((User.arel_table[:age].sum + User.arel_table[:age].sum).as("res")).take(50).first.res
     assert_equal 327,User.select(((User.arel_table[:age] * 3).sum).as("res")).take(50).first.res
     assert_equal 2245,User.select(((User.arel_table[:age] * User.arel_table[:age]).sum).as("res")).take(50).first.res
   end
 
-
   def test_trim
     assert_equal "Myun",User.where(User.arel_table[:name].eq("Myung")).select(User.arel_table[:name].rtrim("g").as("res")).first.res
     assert_equal "yung",User.where(User.arel_table[:name].eq("Myung")).select(User.arel_table[:name].ltrim("M").as("res")).first.res
@@ -243,5 +229,4 @@ class ListTest < Minitest::Test
       assert_equal 1,User.where(User.arel_table[:name].eq("Myung")).select((User.arel_table[:created_at].wday).as("res")).first.res.to_i
       assert_equal 0,User.select(d.wday).as("res").first.to_i
   end
-
 end

data/test/support/fake_record.rb

@@ -7,7 +7,7 @@ module FakeRecord
     attr_accessor :visitor
 
     def initialize(visitor = nil)
-      @tables = %w{ users photos developers products}
+      @tables = %w{users photos developers products}
       @columns = {
         'users' => [
           Column.new('id', :integer),

data/test/test_comparators.rb

@@ -2,9 +2,7 @@ require 'arelx_test_helper'
 
 module ArelExtensions
   module Nodes
-
     describe ArelExtensions::Comparators do
-
       before do
         @conn = FakeRecord::Base.new
         Arel::Table.engine = @conn
@@ -39,8 +37,6 @@ module ArelExtensions
         _(compile(@table[:created_at] >= Date.new(2016, 3, 31)))
           .must_be_like %{"users"."created_at" >= '2016-03-31'}
       end
-
     end
-
   end
 end

data/test/visitors/test_bulk_insert_oracle.rb

@@ -29,7 +29,6 @@ module ArelExtensions
           .must_be_like %Q[INSERT INTO "users" ("name", "comments", "created_at")
                         ((SELECT 'nom1', 'sdfdsfdsfsdf', '2016-01-01' FROM DUAL) UNION ALL (SELECT 'nom2', 'sdfdsfdsfsdf', '2016-01-01' FROM DUAL))]
       end
-
     end
   end
 end

data/test/visitors/test_bulk_insert_sqlite.rb

@@ -2,7 +2,6 @@ require 'arelx_test_helper'
 
 module ArelExtensions
   module BulkInsertSQLlite
-
     describe 'the sqlite visitor can bulk insert' do
       before do
         @conn = FakeRecord::Base.new
@@ -31,7 +30,6 @@ module ArelExtensions
           .must_be_like %Q[INSERT INTO "users" ("id", "name", "comments", "created_at")
                          SELECT 23 AS 'id', 'nom1' AS 'name', 'sdfdsfdsfsdf' AS 'comments', '2016-01-01' AS 'created_at' UNION ALL SELECT 25, 'nom2', 'sdfdsfdsfsdf', '2016-01-01']
       end
-
     end
   end
 end

data/test/visitors/test_oracle.rb

@@ -70,7 +70,7 @@ module ArelExtensions
 
       it "should diff date col and datetime col with AS" do
         sql = compile((@table[:updated_at] - @table[:created_at]).as('new_name'))
-#        sql.must_be_like %{(TO_DATE("users"."updated_at") - "users"."created_at") * 86400 AS new_name}
+        #        sql.must_be_like %{(TO_DATE("users"."updated_at") - "users"."created_at") * 86400 AS new_name}
         _(sql).must_be_like %{("users"."updated_at" - "users"."created_at") * (CASE WHEN (TRUNC("users"."updated_at", 'DDD') = "users"."updated_at") THEN 1 ELSE 86400 END) AS new_name}
       end
 
@@ -104,7 +104,6 @@ module ArelExtensions
         _(compile(c =~ /\Atest\Z/)).must_be_like %{REGEXP_LIKE("users"."name", '^test$')}
         _(compile(c !~ /\Ate\Dst\Z/)).must_be_like %{NOT REGEXP_LIKE("users"."name", '^te[^0-9]st$')}
       end
-
     end
   end
 end

data/test/visitors/test_to_sql.rb

@@ -23,7 +23,6 @@ module ArelExtensions
       end
 
       describe "primitive methods" do
-
        it "should be able to recognize equal nodes" do
          c = @table[:id]
          _(c == 1).must_be :eql?, (c == 1)
@@ -32,7 +31,6 @@ module ArelExtensions
 
          _([c == 1, c == 1].uniq).must_equal [c == 1]
        end
-
       end
 
       # Math Functions
@@ -53,7 +51,7 @@ module ArelExtensions
       end
 
       it "should return right calculations on numbers" do
-        #puts (@price.abs + 42).inspect
+        # puts (@price.abs + 42).inspect
         _(compile(@price.abs + 42)).must_be_like %{(ABS("products"."price") + 42)}
         _(compile(@price.ceil + 42)).must_be_like %{(CEIL("products"."price") + 42)}
         _(compile(@price.floor + 42)).must_be_like %{(FLOOR("products"."price") + 42)}
@@ -93,7 +91,7 @@ module ArelExtensions
         c = @table[:name]
         _(compile(c + 'test')).must_be_like %{CONCAT(\"users\".\"name\", 'test')}
         _(compile(c.length)).must_be_like %{LENGTH("users"."name")}
-        #puts (c.length.round + 42).inspect
+        # puts (c.length.round + 42).inspect
         _(compile(c.length.round + 42)).must_be_like %{(ROUND(LENGTH("users"."name")) + 42)}
         _(compile(c.locate('test'))).must_be_like %{LOCATE('test', "users"."name")}
         _(compile(c & 42)).must_be_like %{FIND_IN_SET(42, "users"."name")}
@@ -119,7 +117,7 @@ module ArelExtensions
         _(compile(Arel::Nodes.build_quoted('test') + ' chain')).must_be_like %{'test chain'}
         _(compile(c + '' + c)).must_be_like %{CONCAT(\"users\".\"name\", \"users\".\"name\")}
 
-        _(compile(c.md5)).must_be_like  %{MD5(\"users\".\"name\")}
+        _(compile(c.md5)).must_be_like %{MD5(\"users\".\"name\")}
       end
 
       # Comparators
@@ -135,9 +133,9 @@ module ArelExtensions
         _(compile(@table[:id] <= 42)).must_match %{"users"."id" <= 42}
         _(compile((@table[:id] <= 42).as('new_name'))).must_match %{("users"."id" <= 42) AS new_name}
         _(compile(@table[:id].count.eq 42)).must_match %{COUNT("users"."id") = 42}
-        #_(compile(@table[:id].count == 42)).must_match %{COUNT("users"."id") = 42} # TODO
-        #_(compile(@table[:id].count != 42)).must_match %{COUNT("users"."id") != 42}
-        #_(compile(@table[:id].count >= 42)).must_match %{COUNT("users"."id") >= 42}
+        # _(compile(@table[:id].count == 42)).must_match %{COUNT("users"."id") = 42} # TODO
+        # _(compile(@table[:id].count != 42)).must_match %{COUNT("users"."id") != 42}
+        # _(compile(@table[:id].count >= 42)).must_match %{COUNT("users"."id") >= 42}
       end
 
       it "should accept comparators on dates" do
@@ -201,7 +199,7 @@ module ArelExtensions
 
       it "should accept operators on dates with numbers" do
         c = @table[:created_at]
-        #u = @table[:updated_at]
+        # u = @table[:updated_at]
         _(compile(c - 42)).must_be_like %{DATE_SUB("users"."created_at", 42)}
         _(compile(c - @table[:id])).must_be_like %{DATE_SUB("users"."created_at", "users"."id")}
       end
@@ -300,7 +298,7 @@ module ArelExtensions
         c = @table[:name]
         _(compile(c.soundex == 'test')).must_be_like %{SOUNDEX("users"."name") = 'test'}
         _(compile(c.soundex != 'test')).must_be_like %{SOUNDEX("users"."name") != 'test'}
-        _(compile(c.length >= 0 )).must_be_like %{LENGTH("users"."name") >= 0}
+        _(compile(c.length >= 0)).must_be_like %{LENGTH("users"."name") >= 0}
       end
 
       it "should accept in on select statement" do
@@ -339,7 +337,6 @@ module ArelExtensions
       end
 
       describe "the function in" do
-
         it "should be possible to have nil element in the function IN" do
           _(compile(@table[:id].in(nil)))
             .must_be_like %{ISNULL("users"."id")}
@@ -362,14 +359,14 @@ module ArelExtensions
         it "should be possible to correctly use a Range on an IN" do
           _(compile(@table[:id].in(1..4)))
             .must_be_like %{"users"."id" BETWEEN (1) AND (4)}
-          _(compile(@table[:created_at].in(Date.new(2016, 3, 31) .. Date.new(2017, 3, 31))))
+          _(compile(@table[:created_at].in(Date.new(2016, 3, 31)..Date.new(2017, 3, 31))))
             .must_be_like %{"users"."created_at" BETWEEN ('2016-03-31') AND ('2017-03-31')}
         end
 
         it "should be possible to use a list of values and ranges on an IN" do
           _(compile(@table[:id].in [1..10, 20, 30, 40..50]))
             .must_be_like %{("users"."id" IN (20, 30)) OR ("users"."id" BETWEEN (1) AND (10)) OR ("users"."id" BETWEEN (40) AND (50))}
-          _(compile(@table[:created_at].in(Date.new(2016, 1, 1), Date.new(2016, 2, 1)..Date.new(2016, 2, 28), Date.new(2016, 3, 31) .. Date.new(2017, 3, 31), Date.new(2018, 1, 1))))
+          _(compile(@table[:created_at].in(Date.new(2016, 1, 1), Date.new(2016, 2, 1)..Date.new(2016, 2, 28), Date.new(2016, 3, 31)..Date.new(2017, 3, 31), Date.new(2018, 1, 1))))
             .must_be_like %{   ("users"."created_at" IN ('2016-01-01', '2018-01-01'))
                             OR ("users"."created_at" BETWEEN ('2016-02-01') AND ('2016-02-28'))
                             OR ("users"."created_at" BETWEEN ('2016-03-31') AND ('2017-03-31'))}
@@ -385,12 +382,9 @@ module ArelExtensions
           _(compile(g[@table[:id], @table[:age]].in(g[1, 42], g[2, 51])))
             .must_be_like %{("users"."id", "users"."age") IN ((1, 42), (2, 51))}
         end
-
-
       end
 
       describe "the function not_in" do
-
         it "should be possible to have nil element in the function IN" do
           _(compile(@table[:id].not_in nil))
             .must_be_like %{NOT ISNULL("users"."id")}
@@ -415,7 +409,7 @@ module ArelExtensions
           _(compile(@table[:id].not_in 1..4))
             .must_be_like %{NOT ("users"."id" BETWEEN (1) AND (4))}
           # FIXME: Should use NOT BETWEEN
-          _(compile(@table[:created_at].not_in Date.new(2016, 3, 31) .. Date.new(2017, 3, 31)))
+          _(compile(@table[:created_at].not_in Date.new(2016, 3, 31)..Date.new(2017, 3, 31)))
             .must_be_like %{NOT ("users"."created_at" BETWEEN ('2016-03-31') AND ('2017-03-31'))}
         end
 
@@ -424,12 +418,11 @@ module ArelExtensions
             .must_be_like %{       ("users"."id" NOT IN (20, 30))
                             AND (NOT ("users"."id" BETWEEN (1) AND (10)))
                             AND (NOT ("users"."id" BETWEEN (40) AND (50)))}
-          _(compile(@table[:created_at].not_in Date.new(2016, 1, 1), Date.new(2016, 2, 1)..Date.new(2016, 2, 28), Date.new(2016, 3, 31) .. Date.new(2017, 3, 31), Date.new(2018, 1, 1)))
+          _(compile(@table[:created_at].not_in Date.new(2016, 1, 1), Date.new(2016, 2, 1)..Date.new(2016, 2, 28), Date.new(2016, 3, 31)..Date.new(2017, 3, 31), Date.new(2018, 1, 1)))
             .must_be_like %{   ("users"."created_at" NOT IN ('2016-01-01', '2018-01-01'))
                             AND (NOT ("users"."created_at" BETWEEN ('2016-02-01') AND ('2016-02-28')))
                             AND (NOT ("users"."created_at" BETWEEN ('2016-03-31') AND ('2017-03-31')))}
         end
-
       end
 
       it "should be possible to add and substract as much as we want" do
@@ -471,7 +464,6 @@ module ArelExtensions
       end
 
       describe "logical functions" do
-
         it "should know about truth" do
           _(compile(Arel.false))
             .must_be_like %{1 = 0}
@@ -544,17 +536,16 @@ module ArelExtensions
 
         it "should avoid useless nesting" do
           c = @table[:id]
-          _(compile(((c == 1).and(c == 2)) .and ((c == 3).and(c == 4))))
+          _(compile(((c == 1).and(c == 2)).and ((c == 3).and(c == 4))))
             .must_be_like %{("users"."id" = 1) AND ("users"."id" = 2) AND ("users"."id" = 3) AND ("users"."id" = 4)}
-          _(compile(((c == 1).or(c == 2)) .or ((c == 3).or(c == 4))))
+          _(compile(((c == 1).or(c == 2)).or ((c == 3).or(c == 4))))
             .must_be_like %{("users"."id" = 1) OR ("users"."id" = 2) OR ("users"."id" = 3) OR ("users"."id" = 4)}
 
-          _(compile(((c == 1).or(c == 2)) .and ((c == 3).or(c == 4))))
+          _(compile(((c == 1).or(c == 2)).and ((c == 3).or(c == 4))))
             .must_be_like %{(("users"."id" = 1) OR ("users"."id" = 2)) AND (("users"."id" = 3) OR ("users"."id" = 4))}
-          _(compile(((c == 1).and(c == 2)) .or ((c == 3).and(c == 4))))
+          _(compile(((c == 1).and(c == 2)).or ((c == 3).and(c == 4))))
             .must_be_like %{(("users"."id" = 1) AND ("users"."id" = 2)) OR (("users"."id" = 3) AND ("users"."id" = 4))}
         end
-
       end
 
       puts "AREL VERSION : " + Arel::VERSION.to_s

data/test/with_ar/all_agnostic_test.rb

@@ -3,7 +3,6 @@ require 'date'
 
 module ArelExtensions
   module WthAr
-
     class ListTest < Minitest::Test
       require 'minitest/pride'
       def connect_db
@@ -95,7 +94,7 @@ module ArelExtensions
         scope.select(node.as('res')).to_a.first.res
       end
 
-      #manage the difference between adapters that handle or not json type
+      # manage the difference between adapters that handle or not json type
       def parse_json(h)
         if @env_db != 'postgresql'
           JSON.parse("{\"res\":#{h}}")['res']
@@ -117,7 +116,7 @@ module ArelExtensions
       end
 
       def test_ceil
-#        skip "Sqlite version can't load extension for ceil" if $sqlite && $load_extension_disabled
+        #        skip "Sqlite version can't load extension for ceil" if $sqlite && $load_extension_disabled
         assert_equal 2, t(@test, @score.ceil) # 1.62
         assert_equal(-20, t(@camille, @score.ceil)) # -20.16
         assert_equal(-20, t(@camille, (@score - 0.5).ceil)) # -20.16
@@ -126,7 +125,7 @@ module ArelExtensions
       end
 
       def test_floor
-#        skip "Sqlite version can't load extension for floor" if $sqlite && $load_extension_disabled
+        #        skip "Sqlite version can't load extension for floor" if $sqlite && $load_extension_disabled
         assert_equal 0, t(@neg, @score.floor)
         assert_equal 1, t(@test, @score.floor) # 1.62
         assert_equal(-9, t(@test, (@score - 10).floor)) # 1.62
@@ -163,6 +162,12 @@ module ArelExtensions
         end
       end
 
+      def test_aggregation_with_ar_calculation
+        # Since Arel10 (Rails6.1), some unwanted behaviors on aggregated calculation were present.
+        # This should works no matter which version of rails is used
+        assert User.group(:score).average(:id).values.all?{|e| !e.nil?}
+      end
+
       # String Functions
       def test_concat
         assert_equal 'Camille Camille', t(@camille, @name + ' ' + @name)
@@ -220,7 +225,7 @@ module ArelExtensions
         assert_equal 'Lu', t(@lucas, @name[0,2])
         assert_equal 'Lu', t(@lucas, @name[0..1])
 
-        #substring should accept string function
+        # substring should accept string function
         assert_equal 'Ce', t(@camille, @name.substring(1, 1).concat('e'))
         assert_equal 'Ce', t(@camille, @name.substring(1, 1)+'e')
       end
@@ -233,7 +238,7 @@ module ArelExtensions
       end
 
       def test_string_comparators
-        #skip "Oracle can't use math operators to compare strings" if @env_db == 'oracle' # use GREATEST ?
+        # skip "Oracle can't use math operators to compare strings" if @env_db == 'oracle' # use GREATEST ?
         skip "SQL Server can't use math operators to compare strings" if @env_db == 'mssql' # use GREATEST ?
         if @env_db == 'postgresql' # may return real boolean
           assert t(@neg, @name >= 'Mest') == true || t(@neg, @name >= 'Mest') == 't' # depends of ar version
@@ -254,20 +259,19 @@ module ArelExtensions
       def test_compare_on_date_time_types
         skip "Sqlite can't compare time" if $sqlite
         skip "Oracle can't compare time" if @env_db == 'oracle'
-        #@created_at == 2016-05-23
+        # @created_at == 2016-05-23
         assert_includes [true,'t',1], t(@laure, ArelExtensions::Nodes::Case.new.when(@created_at >= '2014-01-01').then(1).else(0))
         assert_includes [false,'f',0], t(@laure, ArelExtensions::Nodes::Case.new.when(@created_at >= '2018-01-01').then(1).else(0))
-        #@updated_at == 2014-03-03 12:42:00
+        # @updated_at == 2014-03-03 12:42:00
         assert_includes [true,'t',1], t(@laure, ArelExtensions::Nodes::Case.new.when(@updated_at >= '2014-03-03 10:10:10').then(1).else(0))
         assert_includes [false,'f',0], t(@laure, ArelExtensions::Nodes::Case.new.when(@updated_at >= '2014-03-03 13:10:10').then(1).else(0))
-        #@duration == 12:42:21
-        #puts @laure.select(ArelExtensions::Nodes::Case.new.when(@duration >= '10:10:10').then(1).else(0)).to_sql
-        #puts @laure.select(ArelExtensions::Nodes::Case.new.when(@duration >= '14:10:10').then(1).else(0)).to_sql
+        # @duration == 12:42:21
+        # puts @laure.select(ArelExtensions::Nodes::Case.new.when(@duration >= '10:10:10').then(1).else(0)).to_sql
+        # puts @laure.select(ArelExtensions::Nodes::Case.new.when(@duration >= '14:10:10').then(1).else(0)).to_sql
         assert_includes [true,'t',1], t(@laure, ArelExtensions::Nodes::Case.new.when(@duration >= '10:10:10').then(1).else(0))
         assert_includes [false,'f',0], t(@laure, ArelExtensions::Nodes::Case.new.when(@duration >= '14:10:10').then(1).else(0))
       end
 
-
       def test_regexp_not_regexp
         skip "Sqlite version can't load extension for regexp" if $sqlite && $load_extension_disabled
         skip "SQL Server does not know about REGEXP without extensions" if @env_db == 'mssql'
@@ -278,7 +282,7 @@ module ArelExtensions
       end
 
       def test_imatches
-        #puts User.where(@name.imatches('m%')).to_sql
+        # puts User.where(@name.imatches('m%')).to_sql
         assert_equal 1, User.where(@name.imatches('m%')).count
         assert_equal 4, User.where(@name.imatches_any(['L%', '%e'])).count
         assert_equal 7, User.where(@name.idoes_not_match('L%')).count
@@ -298,7 +302,7 @@ module ArelExtensions
 
       def test_replace_once
         skip "TODO"
-        #skip "Sqlite version can't load extension for locate" if $sqlite && $load_extension_disabled
+        # skip "Sqlite version can't load extension for locate" if $sqlite && $load_extension_disabled
         assert_equal "LuCas", t(@lucas, @name.substring(1, @name.locate('c') - 1) + 'C' + @name.substring(@name.locate('c') + 1, @name.length))
       end
 
@@ -307,7 +311,7 @@ module ArelExtensions
         skip "PostgreSql version can't load extension for soundex" if @env_db == 'postgresql'
         assert_equal "C540", t(@camille, @name.soundex)
         assert_equal 9, User.where(@name.soundex.eq(@name.soundex)).count
-        assert_equal 9  , User.where(@name.soundex == @name.soundex).count
+        assert_equal 9, User.where(@name.soundex == @name.soundex).count
       end
 
       def test_change_case
@@ -356,6 +360,7 @@ module ArelExtensions
         assert_equal '2016-05-23', t(@lucas, @created_at.format('%Y-%m-%d'))
         skip "SQL Server does not accept any format" if @env_db == 'mssql'
         assert_equal '2014/03/03 12:42:00', t(@lucas, @updated_at.format('%Y/%m/%d %H:%M:%S'))
+        assert_equal '12:42%', t(@lucas, @updated_at.format('%R%%'))
       end
 
       def test_coalesce
@@ -396,27 +401,27 @@ module ArelExtensions
       end
 
       def test_date_duration
-        #Year
+        # Year
         assert_equal 2016, t(@lucas, @created_at.year).to_i
         assert_equal 0, User.where(@created_at.year.eq("2012")).count
-        #Month
+        # Month
         assert_equal 5, t(@camille, @created_at.month).to_i
         assert_equal 9, User.where(@created_at.month.eq("05")).count
-        #Week
+        # Week
         assert_equal(@env_db == 'mssql' ? 22 : 21, t(@arthur, @created_at.week).to_i)
         assert_equal 9, User.where(@created_at.month.eq("05")).count
-        #Day
+        # Day
         assert_equal 23, t(@laure, @created_at.day).to_i
         assert_equal 0, User.where(@created_at.day.eq("05")).count
 
-        #skip "manage DATE" if @env_db == 'oracle'
-        #Hour
+        # skip "manage DATE" if @env_db == 'oracle'
+        # Hour
         assert_equal 0, t(@laure, @created_at.hour).to_i
         assert_equal 12, t(@lucas, @updated_at.hour).to_i
-        #Minute
+        # Minute
         assert_equal 0, t(@laure, @created_at.minute).to_i
         assert_equal 42, t(@lucas, @updated_at.minute).to_i
-        #Second
+        # Second
         assert_equal 0, t(@laure, @created_at.second).to_i
         assert_equal 0, t(@lucas, @updated_at.second).to_i
       end
@@ -449,13 +454,13 @@ module ArelExtensions
 
         datetime1 = Time.utc(2014, 3, 3, 12, 42, 0)
         # Pull Request #5 tests
-        #puts (@created_at + durPos).cast(:date).to_sql
+        # puts (@created_at + durPos).cast(:date).to_sql
         assert_includes [date2,"2026-05-23"], t(@test,(@created_at + durPos).cast(:date))
         assert_includes [date3,"2006-05-23"], t(@test,(@created_at + durNeg).cast(:date))
 
-        #puts (@created_at + @created_at.day).cast(:date).to_sql
+        # puts (@created_at + @created_at.day).cast(:date).to_sql
         assert_includes [date4,"2016-06-15"], t(@test,(@created_at + @created_at.day).cast(:date))
-        #puts (@created_at - @created_at.day).cast(:date).to_sql
+        # puts (@created_at - @created_at.day).cast(:date).to_sql
         assert_includes [date5,"2016-04-30"], t(@test,(@created_at - @created_at.day).cast(:date))
 
         assert_includes [datetime1 + 42.seconds,"2014-03-03 12:42:42 UTC"], t(@lucas,(@updated_at + @updated_at.minute))
@@ -463,18 +468,18 @@ module ArelExtensions
 
         # (@updated_at + Arel.duration('s',(@updated_at.hour*60 + @updated_at.minute))).to_sql
         assert_includes [datetime1 + (12*60+42).seconds,"2014-03-03 12:54:42 UTC"],
-          t(@lucas,(@updated_at + Arel.duration('s',(@updated_at.hour*60 + @updated_at.minute))))
+                        t(@lucas,(@updated_at + Arel.duration('s',(@updated_at.hour*60 + @updated_at.minute))))
 
         assert_includes [datetime1 + (12*60+42).minutes,"2014-03-04 01:24:00 UTC"],
-          t(@lucas,(@updated_at + Arel.duration('mn',(@updated_at.hour*60 + @updated_at.minute))))
+                        t(@lucas,(@updated_at + Arel.duration('mn',(@updated_at.hour*60 + @updated_at.minute))))
 
         assert_includes ["2024-03-03"], t(@lucas,(@updated_at + durPos).format('%Y-%m-%d'))
-        #puts (@updated_at - durPos).to_sql
+        # puts (@updated_at - durPos).to_sql
         assert_includes ["2004-03-03"], t(@lucas,(@updated_at - durPos).format('%Y-%m-%d'))
 
 
         # we test with the ruby object or the string because some adapters don't return an object Date
-#        end
+        #        end
       end
 
       # TODO; cast types
@@ -495,27 +500,27 @@ module ArelExtensions
           assert_equal Time, t(@lucas,@updated_at.cast(:string).cast(:datetime)).class
           assert_equal Time, t(@lucas,@updated_at.cast(:time)).class
 
-          assert_equal "2014-03-03 12:42:00", t(@lucas,@updated_at.cast(:string)) unless @env_db == 'mssql' #locale dependent
+          assert_equal "2014-03-03 12:42:00", t(@lucas,@updated_at.cast(:string)) unless @env_db == 'mssql' # locale dependent
           assert_equal Date.parse("2014-03-03"), t(@lucas,Arel::Nodes.build_quoted('2014-03-03').cast(:date))
           assert_equal Date.parse("5014-03-03"), t(@lucas,(@age.cast(:string) + '014-03-03').cast(:date))
           assert_equal Time.parse("2014-03-03 12:42:00 UTC"), t(@lucas,@updated_at.cast(:string).cast(:datetime))
           assert_equal Date.parse("2014-03-03"), t(@lucas,@updated_at.cast(:date))
-          assert_equal "12:42:00", t(@lucas,@updated_at.cast(:time).cast(:string)).split('.').first unless @env_db == 'oracle'  #DateTime
+          assert_equal "12:42:00", t(@lucas,@updated_at.cast(:time).cast(:string)).split('.').first unless @env_db == 'oracle'  # DateTime
         end
       end
 
       def test_is_null
-        #puts User.where(@age.is_null).select(@name).to_sql
-        #puts @age.is_null
-        #puts @age.is_null.inspect
-        #puts @age.is_null.to_sql
-        #puts @age=='34'
+        # puts User.where(@age.is_null).select(@name).to_sql
+        # puts @age.is_null
+        # puts @age.is_null.inspect
+        # puts @age.is_null.to_sql
+        # puts @age=='34'
         assert_equal "Test", User.select(@name).where(@age.is_null.to_sql).first.name
       end
 
       def test_math_plus
         d = Date.new(1997, 6, 15)
-        #Concat String
+        # Concat String
         assert_equal "SophiePhan", t(@sophie, @name + "Phan")
         assert_equal "Sophie2", t(@sophie, @name + 2)
         assert_equal "Sophie1997-06-15", t(@sophie, @name + d)
@@ -524,25 +529,24 @@ module ArelExtensions
         assert_equal "SophieSophieSophie", t(@sophie, @name + @name + @name)
         assert_equal "SophieSophieSophie", t(@sophie, @name.concat(@name.concat(@name)))
         assert_equal "SophieSophieSophie", t(@sophie, @name.concat(@name).concat(@name))
-        #FIXME: should work as expected in Oracle
+        # FIXME: should work as expected in Oracle
         assert_equal "Sophie2016-05-23", t(@sophie, @name + @created_at) unless @env_db == 'oracle'
-        #concat Integer
+        # concat Integer
         assert_equal 1, User.where((@age + 10).eq(33)).count
         assert_equal 1, User.where((@age + "1").eq(6)).count
         assert_equal 1, User.where((@age + @age).eq(10)).count
-        #concat Date
-        #puts((User.arel_table[:created_at] + 1).as("res").to_sql.inspect)
+        # concat Date
+        # puts((User.arel_table[:created_at] + 1).as("res").to_sql.inspect)
         assert_equal "2016-05-24", t(@myung, @created_at + 1).to_date.to_s
         assert_equal "2016-05-25", t(@myung, @created_at + 2.day).to_date.to_s
       end
 
-
       def test_math_minus
         d = Date.new(2016, 5, 20)
-        #Datediff
+        # Datediff
         assert_equal 9, User.where((@created_at - @created_at).eq(0)).count
         assert_equal 3, @laure.select((@created_at - d).as("res")).first.res.abs.to_i
-        #Substraction
+        # Substraction
         assert_equal 0, User.where((@age - 10).eq(50)).count
         assert_equal 0, User.where((@age - "10").eq(50)).count
         # assert_equal 0, User.where((@age - 9.5).eq(50.5)).count # should work: TODO
@@ -550,7 +554,7 @@ module ArelExtensions
       end
 
       def test_wday
-        #d = Date.new(2016, 6, 26)
+        # d = Date.new(2016, 6, 26)
         assert_equal(@env_db == 'oracle' || @env_db == 'mssql' ? 2 : 1, t(@myung, @created_at.wday).to_i) # monday
       end
 
@@ -586,41 +590,41 @@ module ArelExtensions
         assert_equal 0, t(@arthur, @score.when(65.62,1).else(0)-1)
         assert_equal "11", t(@arthur, @score.when(65.62).then("1").else("0")+"1")
         assert_equal 66.62, t(@arthur, @score.when(65.62).then(@score).else(@score)+1)
-        assert_equal "65.621", t(@arthur, @score.when(65.62).then(@score.cast(:string)).else(@score.cast(:string))+1).tr('0','') #tr is here because of precision on cast for some DBMS
+        assert_equal "65.621", t(@arthur, @score.when(65.62).then(@score.cast(:string)).else(@score.cast(:string))+1).tr('0','') # tr is here because of precision on cast for some DBMS
       end
 
       def test_format_numbers
-        #score of Arthur = 65.62
+        # score of Arthur = 65.62
         skip " Works with SQLite if the version used knows printf" if $sqlite
 
-        assert_equal "Wrong Format" , t(@arthur, @score.format_number("$ %...234.6F €","fr_FR"))
-        assert_equal "AZERTY65,62" , t(@arthur, @score.format_number("AZERTY%.2f","fr_FR"))
-        assert_equal "65,62AZERTY" , t(@arthur, @score.format_number("%.2fAZERTY","fr_FR"))
-        assert_equal "$ 65.62 €" , t(@arthur, @score.format_number("$ %.2f €","en_US"))
-        assert_equal "$ 66 €" , t(@arthur, @score.format_number("$ %.0f €","en_US"))
-        assert_equal "$ 0065,62 €" , t(@arthur, @score.format_number("$ %07.2f €","fr_FR"))
-        assert_equal "$ 65,62   €" , t(@arthur, @score.format_number("$ %-07.2f €","fr_FR"))
-        assert_equal "$ 65,62   €" , t(@arthur, @score.format_number("$ %-7.2f €","fr_FR"))
-        assert_equal "$   65,62 €" , t(@arthur, @score.format_number("$ % 7.2f €","fr_FR"))
-        assert_equal "$    65,6 €" , t(@arthur, @score.format_number("$ % 7.1f €","fr_FR"))
-        assert_equal "$  +65,62 €" , t(@arthur, @score.format_number("$ % +7.2f €","fr_FR"))
-        assert_equal "$ +065,62 €" , t(@arthur, @score.format_number("$ %0+7.2f €","fr_FR"))
+        assert_equal "Wrong Format", t(@arthur, @score.format_number("$ %...234.6F €","fr_FR"))
+        assert_equal "AZERTY65,62", t(@arthur, @score.format_number("AZERTY%.2f","fr_FR"))
+        assert_equal "65,62AZERTY", t(@arthur, @score.format_number("%.2fAZERTY","fr_FR"))
+        assert_equal "$ 65.62 €", t(@arthur, @score.format_number("$ %.2f €","en_US"))
+        assert_equal "$ 66 €", t(@arthur, @score.format_number("$ %.0f €","en_US"))
+        assert_equal "$ 0065,62 €", t(@arthur, @score.format_number("$ %07.2f €","fr_FR"))
+        assert_equal "$ 65,62   €", t(@arthur, @score.format_number("$ %-07.2f €","fr_FR"))
+        assert_equal "$ 65,62   €", t(@arthur, @score.format_number("$ %-7.2f €","fr_FR"))
+        assert_equal "$   65,62 €", t(@arthur, @score.format_number("$ % 7.2f €","fr_FR"))
+        assert_equal "$    65,6 €", t(@arthur, @score.format_number("$ % 7.1f €","fr_FR"))
+        assert_equal "$  +65,62 €", t(@arthur, @score.format_number("$ % +7.2f €","fr_FR"))
+        assert_equal "$ +065,62 €", t(@arthur, @score.format_number("$ %0+7.2f €","fr_FR"))
         assert_includes ["$ 6,56e1 €","$ 6,56e+01 €"], t(@arthur, @score.format_number("$ %.2e €","fr_FR"))
         assert_includes ["$ 6,56E1 €","$ 6,56E+01 €"], t(@arthur, @score.format_number("$ %.2E €","fr_FR"))
         assert_includes ["$ 6,562E1 €","$ 6,562E+01 €"], t(@arthur, @score.format_number("$ %.3E €","fr_FR"))
-        assert_equal "123 456 765,6" , t(@arthur, (@score+123456700).format_number("%.1f","sv_SE")).gsub("\u00A0"," ") #some DBMS put no-break space here (it makes sense thus)
-        assert_equal "123456765,6" , t(@arthur, (@score+123456700).format_number("%.1f","fr_FR")).gsub("\u00A0","") #because SqlServer does it like no one else
-        assert_equal "123,456,765.6" , t(@arthur, (@score+123456700).format_number("%.1f","en_US"))
-        assert_equal "   123,456,765.6" , t(@arthur, (@score+123456700).format_number("%16.1f","en_US"))
-        assert_equal "$ 0,00 €" , t(@arthur, @score.when(65.62).then(Arel.sql("null")).else(1).format_number("$ %.2f €","fr_FR"))
-        assert_equal "$ 0,00 €" , t(@arthur, (@score-65.62).format_number("$ %.2f €","fr_FR"))
+        assert_equal "123 456 765,6", t(@arthur, (@score+123456700).format_number("%.1f","sv_SE")).gsub("\u00A0"," ") # some DBMS put no-break space here (it makes sense thus)
+        assert_equal "123456765,6", t(@arthur, (@score+123456700).format_number("%.1f","fr_FR")).gsub("\u00A0","") # because SqlServer does it like no one else
+        assert_equal "123,456,765.6", t(@arthur, (@score+123456700).format_number("%.1f","en_US"))
+        assert_equal "   123,456,765.6", t(@arthur, (@score+123456700).format_number("%16.1f","en_US"))
+        assert_equal "$ 0,00 €", t(@arthur, @score.when(65.62).then(Arel.sql("null")).else(1).format_number("$ %.2f €","fr_FR"))
+        assert_equal "$ 0,00 €", t(@arthur, (@score-65.62).format_number("$ %.2f €","fr_FR"))
       end
 
       def test_accent_insensitive
         skip "SQLite is natively Case Insensitive and Accent Sensitive" if $sqlite
         skip "Not finished" if @env_db == 'mysql'
         # actual comments value: "arrêté"
-        #AI & CI
+        # AI & CI
         if !['postgresql'].include?(@env_db) # Extension unaccent required on PG
           assert_equal "1", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.ai_imatches("arrêté")).then("1").else("0"))
           assert_equal "1", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.ai_imatches("arrete")).then("1").else("0"))
@@ -628,7 +632,7 @@ module ArelExtensions
           assert_equal "0", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.ai_imatches("arretez")).then("1").else("0"))
           assert_equal "1", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.ai_imatches("Arrete")).then("1").else("0"))
           assert_equal "1", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.ai_imatches("Arrêté")).then("1").else("0"))
-          #AI & CS
+          # AI & CS
           assert_equal "1", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.ai_matches("arrêté")).then("1").else("0"))
           assert_equal "1", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.ai_matches("arrete")).then("1").else("0"))
           assert_equal "1", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.ai_matches("àrrétè")).then("1").else("0"))
@@ -638,7 +642,7 @@ module ArelExtensions
             assert_equal "0", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.ai_matches("Arrêté")).then("1").else("0"))
           end
         end
-        #AS & CI
+        # AS & CI
         assert_equal "1", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.imatches("arrêté")).then("1").else("0"))
         if !['mysql'].include?(@env_db) # CI => AI in utf8 (AI not possible in latin1)
           assert_equal "0", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.imatches("arrete")).then("1").else("0"))
@@ -649,7 +653,7 @@ module ArelExtensions
           assert_equal "0", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.imatches("Arrete")).then("1").else("0"))
         end
         assert_equal "1", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.imatches("Arrêté")).then("1").else("0"))
-        #AS & CS
+        # AS & CS
         assert_equal "1", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.smatches("arrêté")).then("1").else("0"))
         assert_equal "0", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.smatches("arrete")).then("1").else("0"))
         assert_equal "0", t(@arthur,ArelExtensions::Nodes::Case.new.when(@comments.smatches("àrrétè")).then("1").else("0"))
@@ -663,29 +667,29 @@ module ArelExtensions
         assert_equal 9, User.where(@ut[:name].in(@ut.project(@ut[:name]).order(@ut[:name]))).count
         if !['mysql'].include?(@env_db)  # MySql can't have limit in IN subquery
           assert_equal 2, User.where(:name => User.select(:name).order(:name).limit(2)).count
-          #assert_equal 6, User.where(:name => User.select(:name).order(:name).offset(2)).count
+          # assert_equal 6, User.where(:name => User.select(:name).order(:name).offset(2)).count
         end
       end
 
       def test_in_with_nil
-        assert_equal true  , @myung.where(@age.in(1)).blank?
-        assert_equal false , @myung.where(@age.in(23)).blank?
-        assert_equal true  , @myung.where(@age.in([1])).blank?
-        assert_equal true  , @myung.where(@age.in([1,2])).blank?
-        assert_equal false , @myung.where(@age.in([1,23])).blank?
-        assert_equal true  , @myung.where(@age.in(nil)).blank?
-        assert_equal true  , @myung.where(@age.in([nil])).blank?
-        assert_equal true  , @myung.where(@age.in([nil,1])).blank?
-        assert_equal false , @myung.where(@age.in([nil,23])).blank?
-        assert_equal true  , @myung.where(@age.in([nil,1,2])).blank?
-        assert_equal false , @myung.where(@age.in([nil,1,23])).blank?
-        assert_equal true  , @test.where(@age.in(1)).blank?
-        assert_equal true  , @test.where(@age.in([1])).blank?
-        assert_equal true  , @test.where(@age.in([1,2])).blank?
-        assert_equal false , @test.where(@age.in(nil)).blank?
-        assert_equal false , @test.where(@age.in([nil])).blank?
-        assert_equal false , @test.where(@age.in([nil,1])).blank?
-        assert_equal false , @test.where(@age.in([nil,1,2])).blank?
+        assert_equal true, @myung.where(@age.in(1)).blank?
+        assert_equal false, @myung.where(@age.in(23)).blank?
+        assert_equal true, @myung.where(@age.in([1])).blank?
+        assert_equal true, @myung.where(@age.in([1,2])).blank?
+        assert_equal false, @myung.where(@age.in([1,23])).blank?
+        assert_equal true, @myung.where(@age.in(nil)).blank?
+        assert_equal true, @myung.where(@age.in([nil])).blank?
+        assert_equal true, @myung.where(@age.in([nil,1])).blank?
+        assert_equal false, @myung.where(@age.in([nil,23])).blank?
+        assert_equal true, @myung.where(@age.in([nil,1,2])).blank?
+        assert_equal false, @myung.where(@age.in([nil,1,23])).blank?
+        assert_equal true, @test.where(@age.in(1)).blank?
+        assert_equal true, @test.where(@age.in([1])).blank?
+        assert_equal true, @test.where(@age.in([1,2])).blank?
+        assert_equal false, @test.where(@age.in(nil)).blank?
+        assert_equal false, @test.where(@age.in([nil])).blank?
+        assert_equal false, @test.where(@age.in([nil,1])).blank?
+        assert_equal false, @test.where(@age.in([nil,1,2])).blank?
       end
 
       def test_scope_with_in_plus_new
@@ -699,40 +703,40 @@ module ArelExtensions
       end
 
       def test_is_not_null
-        assert_equal false , @myung.where(@age.is_not_null).blank?
-        assert_equal true  , @test.where(@age.is_not_null).blank?
+        assert_equal false, @myung.where(@age.is_not_null).blank?
+        assert_equal true, @test.where(@age.is_not_null).blank?
       end
 
       def test_not_in_with_nil
-        assert_equal false , @myung.where(@age.not_in(1)).blank?
-        assert_equal true  , @myung.where(@age.not_in(23)).blank?
-        assert_equal false , @myung.where(@age.not_in([1])).blank?
-        assert_equal false , @myung.where(@age.not_in([1,2])).blank?
-        assert_equal true  , @myung.where(@age.not_in([1,23])).blank?
-        assert_equal false , @myung.where(@age.not_in(nil)).blank?
-        assert_equal false , @myung.where(@age.not_in([nil])).blank?
-        assert_equal false , @myung.where(@age.not_in([nil,1])).blank?
-        assert_equal true  , @myung.where(@age.not_in([nil,23])).blank?
-        assert_equal false , @myung.where(@age.not_in([nil,1,2])).blank?
-        assert_equal true  , @myung.where(@age.not_in([nil,1,23])).blank?
-
-        assert_equal false , @myung.where(@age.not_in(1..2)).blank?
-
-        #if the column is null, the entry will never be selected with not in (like every DBMS does)
-        #assert_equal false , @test.where(@age.not_in(1)).blank?
-        #assert_equal false , @test.where(@age.not_in([1])).blank?
-        #assert_equal false , @test.where(@age.not_in([1,2])).blank?
-        #assert_equal true  , @test.where(@age.not_in(nil)).blank?
-        #assert_equal true  , @test.where(@age.not_in([nil])).blank?
-        #assert_equal true  , @test.where(@age.not_in([nil,1])).blank?
-        #assert_equal true  , @test.where(@age.not_in([nil,1,2])).blank?
+        assert_equal false, @myung.where(@age.not_in(1)).blank?
+        assert_equal true, @myung.where(@age.not_in(23)).blank?
+        assert_equal false, @myung.where(@age.not_in([1])).blank?
+        assert_equal false, @myung.where(@age.not_in([1,2])).blank?
+        assert_equal true, @myung.where(@age.not_in([1,23])).blank?
+        assert_equal false, @myung.where(@age.not_in(nil)).blank?
+        assert_equal false, @myung.where(@age.not_in([nil])).blank?
+        assert_equal false, @myung.where(@age.not_in([nil,1])).blank?
+        assert_equal true, @myung.where(@age.not_in([nil,23])).blank?
+        assert_equal false, @myung.where(@age.not_in([nil,1,2])).blank?
+        assert_equal true, @myung.where(@age.not_in([nil,1,23])).blank?
+
+        assert_equal false, @myung.where(@age.not_in(1..2)).blank?
+
+        # if the column is null, the entry will never be selected with not in (like every DBMS does)
+        # assert_equal false , @test.where(@age.not_in(1)).blank?
+        # assert_equal false , @test.where(@age.not_in([1])).blank?
+        # assert_equal false , @test.where(@age.not_in([1,2])).blank?
+        # assert_equal true  , @test.where(@age.not_in(nil)).blank?
+        # assert_equal true  , @test.where(@age.not_in([nil])).blank?
+        # assert_equal true  , @test.where(@age.not_in([nil,1])).blank?
+        # assert_equal true  , @test.where(@age.not_in([nil,1,2])).blank?
       end
 
       def test_in_on_grouping
         skip "We should modify the visitor of IN to make it work" if $sqlite || @env_db == 'mssql'
-        assert_equal 2 , User.where(Arel.tuple(@name,@age).in(Arel.tuple('Myung',23),Arel.tuple('Arthur',21))).count
-        assert_equal 1 , User.where(Arel.tuple(@name,@age).in(Arel.tuple('Myung',23))).count
-        assert_equal 0 , User.where(Arel.tuple(@name,@age).in([])).count
+        assert_equal 2, User.where(Arel.tuple(@name,@age).in(Arel.tuple('Myung',23),Arel.tuple('Arthur',21))).count
+        assert_equal 1, User.where(Arel.tuple(@name,@age).in(Arel.tuple('Myung',23))).count
+        assert_equal 0, User.where(Arel.tuple(@name,@age).in([])).count
       end
 
       def test_alias_shortened
@@ -741,29 +745,29 @@ module ArelExtensions
           at = User.arel_table.alias('azerty' * 15)
           assert_equal "\"user_tests\" \"#{new_alias}\"".downcase, User.arel_table.alias('azerty' * 15).to_sql.downcase
           assert_equal '"user_tests" "u"'.downcase, User.arel_table.alias('u').to_sql.downcase
-          assert_equal  %Q[SELECT "#{new_alias}"."id" FROM "user_tests" "#{new_alias}"].downcase,
-                User.select(at[:id]).from(at).to_sql.downcase
+          assert_equal %Q[SELECT "#{new_alias}"."id" FROM "user_tests" "#{new_alias}"].downcase,
+                       User.select(at[:id]).from(at).to_sql.downcase
         end
       end
 
       def test_stat_functions
         skip "SQLite doesn't work for most on this functions" if $sqlite
-        #puts t(User.where(nil), @score.average)
-        #puts t(User.where(nil), @score.variance(unbiased: true))
-        #puts t(User.where(nil), @score.variance(unbiased: false))
-        #puts t(User.where(nil), @score.std(unbiased: true))
-        #puts t(User.where(nil), @score.std(unbiased: false))
+        # puts t(User.where(nil), @score.average)
+        # puts t(User.where(nil), @score.variance(unbiased: true))
+        # puts t(User.where(nil), @score.variance(unbiased: false))
+        # puts t(User.where(nil), @score.std(unbiased: true))
+        # puts t(User.where(nil), @score.std(unbiased: false))
 
         assert ( 15.43222 - t(User.where(nil), @score.average)).abs < 0.01
         assert (539.79804 - t(User.where(nil), @score.variance)).abs < 0.01
         assert (479.82048 - t(User.where(nil), @score.variance(unbiased: false))).abs < 0.01
         assert ( 23.23355 - t(User.where(nil), @score.std)).abs < 0.01
         assert ( 21.90480 - t(User.where(nil), @score.std(unbiased: false))).abs < 0.01
-        skip "Not Yet Implemented" #if !['postgresql'].include?(@env_db)
+        skip "Not Yet Implemented" # if !['postgresql'].include?(@env_db)
         assert_equal 2, User.select(@score.std(group: Arel.when(@name > "M").then(0).else(1)).as('res')).map{|e| e['res']}.uniq.length
-        assert_equal 2, User.select(@score.variance(group: Arel.when(@name > "M").then(0).else(1)).as('res')).map{|e|e['res']}.uniq.length
-        assert_equal 2, User.select(@score.sum(group: Arel.when(@name > "M").then(0).else(1)).as('res')).map{|e|e['res']}.uniq.length
-        assert_equal 2, User.select(@comments.group_concat(group: Arel.when(@name > "M").then(0).else(1)).as('res')).map{|e|e['res']}.uniq.length
+        assert_equal 2, User.select(@score.variance(group: Arel.when(@name > "M").then(0).else(1)).as('res')).map{|e| e['res']}.uniq.length
+        assert_equal 2, User.select(@score.sum(group: Arel.when(@name > "M").then(0).else(1)).as('res')).map{|e| e['res']}.uniq.length
+        assert_equal 2, User.select(@comments.group_concat(group: Arel.when(@name > "M").then(0).else(1)).as('res')).map{|e| e['res']}.uniq.length
       end
 
       def test_levenshtein_distance
@@ -775,7 +779,7 @@ module ArelExtensions
 
       def test_json
         skip "Can't be tested on travis"
-        #creation
+        # creation
         assert_equal 'Arthur', t(@arthur,Arel.json(@name))
         assert_equal ["Arthur","Arthur"], parse_json(t(@arthur,Arel.json(@name,@name)))
         assert_equal ({"Arthur" => "Arthur", "Arthur2" => "ArthurArthur"}), parse_json(t(@arthur,Arel.json({@name => @name,@name+"2" => @name+@name})))
@@ -784,29 +788,29 @@ module ArelExtensions
 
         # aggregate
         assert_equal ({"5" => "Lucas", "15" => "Sophie", "23" => "Myung", "25" => "Laure"}),
-              parse_json(t(User.group(:score).where(@age.is_not_null).where(@score == 20.16),Arel.json({@age => @name}).group(false)))
+                     parse_json(t(User.group(:score).where(@age.is_not_null).where(@score == 20.16),Arel.json({@age => @name}).group(false)))
         assert_equal ({"5" => "Lucas", "15" => "Sophie", "23" => "Myung", "25" => "Laure", "Laure"=>25, "Lucas"=>5, "Myung"=>23, "Sophie"=>15}),
-              parse_json(t(User.group(:score).where(@age.is_not_null).where(@score == 20.16),Arel.json({@age => @name,@name => @age}).group(false)))
+                     parse_json(t(User.group(:score).where(@age.is_not_null).where(@score == 20.16),Arel.json({@age => @name,@name => @age}).group(false)))
         assert_equal ([{"5" => "Lucas"},{ "15" => "Sophie"},{ "23" => "Myung"},{ "25" => "Laure"}]),
-              parse_json(t(User.group(:score).where(@age.is_not_null).where(@score == 20.16).select(@score),Arel.json({@age => @name}).group(true,[@age])))
+                     parse_json(t(User.group(:score).where(@age.is_not_null).where(@score == 20.16).select(@score),Arel.json({@age => @name}).group(true,[@age])))
 
-        #puts User.group(:score).where(@age.is_not_null).where(@score == 20.16).select(@score,Arel.json({@age => @name}).group(true,[@age])).to_sql
-        #puts User.group(:score).where(@age.is_not_null).where(@score == 20.16).select(@score,Arel.json({@age => @name}).group(true,[@age])).to_a
+        # puts User.group(:score).where(@age.is_not_null).where(@score == 20.16).select(@score,Arel.json({@age => @name}).group(true,[@age])).to_sql
+        # puts User.group(:score).where(@age.is_not_null).where(@score == 20.16).select(@score,Arel.json({@age => @name}).group(true,[@age])).to_a
 
         skip "Not Yet Implemented" if $sqlite || ['oracle','mssql'].include?(@env_db)
-        #get
+        # get
         h1 = Arel.json({@name => @name+@name,@name+"2" => 1})
         assert_equal "ArthurArthur", parse_json(t(@arthur,h1.get(@name)))
         h2 = Arel.json([{age: @age},{name: @name,score: @score}])
         assert_equal ({"age" => 21}), parse_json(t(@arthur,h2.get(0)))
         assert_equal 21, parse_json(t(@arthur,h2.get(0).get('age')))
         assert_nil t(@arthur,h2.get('age'))
-        #set
+        # set
         assert_equal ({"Arthur" => ["toto", "tata"], "Arthur2" => 1}), parse_json(t(@arthur,h1.set(@name, ['toto','tata'])))
         assert_equal ({"Arthur" => "ArthurArthur", "Arthur2" => 1, "Arthur3" => 2}), parse_json(t(@arthur,h1.set(@name+"3",2)))
         assert_equal ({"Arthur" => "ArthurArthur", "Arthur2" => 1, "Arthur3" => nil}), parse_json(t(@arthur,h1.set(@name+"3",nil)))
         assert_equal ({"Arthur" => "ArthurArthur", "Arthur2" => 1, "Arthur3" => {"a" => 2}}), parse_json(t(@arthur,h1.set(@name+"3",{a: 2})))
-        #merge
+        # merge
         assert_equal ({"Arthur" => ["toto", "tata"], "Arthur2" => 1, "Arthur3" => 2}), parse_json(t(@arthur,h1.merge({@name => ['toto','tata']},{@name+"3" => 2})))
         assert_equal ({"Arthur" => ["toto", "tata"], "Arthur2" => 1, "Arthur3" => 2}), parse_json(t(@arthur,h1.merge({@name => ['toto','tata'], @name+"3" => 2})))
         assert_equal ({"Arthur" => "ArthurArthur","Arthur2" => 1}), parse_json(t(@arthur,h1.merge({})))
@@ -814,7 +818,7 @@ module ArelExtensions
 
       def test_as_on_everything
         name = @arthur.select(@name.as('NaMe')).first.attributes
-        assert_equal 'Arthur', name["NaMe"] || name["name"] #because of Oracle
+        assert_equal 'Arthur', name["NaMe"] || name["name"] # because of Oracle
         assert_equal 'Arthur', @arthur.select(@name.as('Na Me')).first.attributes["Na Me"]
         assert_equal 'ArthurArthur', @arthur.select((@name+@name).as('Na-Me')).first.attributes["Na-Me"]
       end
@@ -822,8 +826,6 @@ module ArelExtensions
       def test_exists_in_subquery
         assert User.where(User.where(nil).arel.exists).first
       end
-
-
     end
   end
 end