arel_extensions 0.8.7 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e8d7cc16253e73e976d81b8beb558c2041c2915f
-  data.tar.gz: 7ff4c6640d063ef79b6ada768ae7b57cb9bf4dd4
+  metadata.gz: d3be3f3b4a82f0721265a42e8ae75fe66da12ba3
+  data.tar.gz: a1660c2b64388e6e56bf442de63504da32c2c5ca
 SHA512:
-  metadata.gz: 2b2748e84a31a944bc2a835036ff81be4528d3a85940ea34ee6d65389bf86c5c67230ec7dea7c726375395733da138cfd80920463475a54c4e97abc024f3cd76
-  data.tar.gz: 7779b7ef80ab54c3f08e1bf3016d0e9311393576f18be74d5795d7e86d8fc1390afaf12f6d9271cb47e0a5a6e57e947eafb204d9a06ddae5ae9dae04bf278c9f
+  metadata.gz: 4465b08c98214889ca8be08d437a49deeb59df7de899095bcb4c4a7e7ff5d11c8c1cf50a7f8961d0f73b39b5ba0da2db36cfadd3fda4a4e8ee2eaacdc5251978
+  data.tar.gz: 5781edd20996ca251937563e1fa15a6fa453a250654aa8191fade92b56970edcb205fe1f5cb37659cbd80460451d0cac858a32f8733919aa6b29bf26640eb519

data/.travis.yml

@@ -89,6 +89,10 @@ matrix:
   - rvm: ruby-head
     gemfile: gemfiles/rails4.gemfile
   allow_failures:
+  - rvm: rbx-2
+    gemfile: gemfiles/rails4.gemfile
+  - rvm: rbx-2
+    gemfile: gemfiles/rails5.gemfile
   - rvm: jruby-9.0.5.0
     gemfile: gemfiles/rails5.gemfile
   - rvm: jruby-head

data/Gemfile

@@ -2,7 +2,7 @@ source "https://rubygems.org"
 
 gemspec
 
-group :test do
+group :development, :test do
 	gem "sqlite3", :platforms => [:mri, :mswin, :mingw, :x64_mingw]
 	gem "mysql2", :platforms => [:mri, :mswin, :mingw, :x64_mingw]
     gem "pg", :platforms => [:mri, :mingw, :x64_mingw]
@@ -13,7 +13,7 @@ group :test do
 	gem "activerecord-jdbcpostgresql-adapter", :platforms => :jruby
 
     gem "tiny_tds", :platforms => [:mri, :mingw, :x64_mingw]
-    gem "activerecord-sqlserver-adapter", :platforms => [:mri, :mingw, :x64_mingw]
+    gem "activerecord-sqlserver-adapter", '~> 4.2.0', :platforms => [:mri, :mingw, :x64_mingw]    
 
 	gem 'activesupport', '~> 4.0'
   	gem 'activemodel', '~> 4.0'

data/SQL_Challenges.md

@@ -0,0 +1,29 @@
+# SQL Challenges
+
+It should be possible to do any advanced SQL functions of any RDBMS in any other using classical SQL routines. We hope so.
+But here are some of the features we did not succeed to create in some cases. Any help would be very useful.
+A good way could be to create user defined functions to ensure a total transparent compatibility and to encapsulate these improvements.
+
+
+## SQLite (without extension)
+- CEIL and FLOOR without pcre
+- FIND_IN_SET
+- LOCATE
+- REGEXP
+- SOUNDEX
+
+## PostgreSQL (without extension)
+- SOUNDEX
+
+
+## Oracle
+- Maths Operators on string ('a' <= 'b')
+
+
+## SQL Server (any version > 2005, without extension)
+- REGEXP
+- (L/R)TRIM(str, 'x') -> TRIM with arguments
+- Maths Operators on string ('a' <= 'b')
+- GROUP_CONCAT
+- FIND_IN_SET
+- any date format (YYYY/MM/DD HH:MM:SS:MMM for example)

data/arel_extensions.gemspec

@@ -1,27 +1,27 @@
 # # -*- encoding: utf-8 -*-
 $:.push File.expand_path("../lib", __FILE__)
-# require "arel_extensions"
+require "arel_extensions/version"
 
 Gem::Specification.new do |s|
   s.name        = "arel_extensions"
-  s.version     = '0.8.7'
+  s.version     = ArelExtensions::VERSION
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Yann Azoury", "Mathilde Pechdimaldjian", "Félix Bellanger"]
   s.email       = ["yann.azoury@faveod.com", "mathilde.pechdimaldjian@gmail.com", "felix.bellanger@faveod.com"]
   s.homepage    = "https://github.com/Faveod/arel-extensions"
   s.description = "Adds new features to Arel"
   s.summary     = "Extending Arel"
-  s.license     = %q{MIT}
+  s.license     = 'MIT'
 
   s.rdoc_options = ["--main", "README.md"]
-  s.extra_rdoc_files = ["MIT-LICENSE.txt", "README.md"]
+  s.extra_rdoc_files = ["MIT-LICENSE.txt", "README.md", 'functions.html']
 
   # Manifest
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths = ["lib"]
 
-  s.add_dependency('arel', '~> 6.0')
+  s.add_dependency('arel', '>= 6.0')
 
   s.add_development_dependency('minitest', '~> 5.9')
   s.add_development_dependency('rdoc', '~> 4.0')

data/functions.html

@@ -199,7 +199,7 @@
     <td class="tg-j6lv">TRIM()<br></td>
     <td class="tg-j6lv">TRIM()</td>
     <td class="tg-baqh">✔</td>
-    <td class="tg-baqh">✔</td>
+    <td class="tg-baqh">LTRIM(RTRIM())</td>
     <td class="tg-j6lv">TRIM()</td>
   </tr>
   <tr>

data/gemfiles/rails4.gemfile

@@ -12,7 +12,7 @@ group :development, :test do
     gem "pg", :platforms => [:mri, :mingw, :x64_mingw]
 
     gem "tiny_tds", :platforms => [:mri, :mingw, :x64_mingw]
-    gem "activerecord-sqlserver-adapter", :platforms => [:mri, :mingw, :x64_mingw]
+    gem "activerecord-sqlserver-adapter", '~> 4.2.0', :platforms => [:mri, :mingw, :x64_mingw]
 
 	gem 'ruby-oci8', :platforms => [:mri, :mswin, :mingw] if ENV.has_key? 'ORACLE_HOME'
 	gem 'activerecord-oracle_enhanced-adapter', '~> 1.6.0' if ENV.has_key? 'ORACLE_HOME'

data/init/mssql.sql

@@ -1,6 +1,44 @@
-CREATE FUNCTION TRIM(@string VARCHAR(MAX))
+IF OBJECT_ID (N'dbo.TRIM', N'FN') IS NOT NULL
+    DROP FUNCTION dbo.TRIM;
+GO
+CREATE FUNCTION dbo.TRIM (@string VARCHAR(MAX))
 RETURNS VARCHAR(MAX)
+AS
 BEGIN
-RETURN LTRIM(RTRIM(@string))
-END
+	RETURN LTRIM(RTRIM(@string));
+END;
+GO
+
+-----------------------------
+-- GO
+
+IF OBJECT_ID (N'dbo.FIND_IN_SET', N'FN') IS NOT NULL
+    DROP FUNCTION dbo.FIND_IN_SET;
 GO
+-- CREATE FUNCTION dbo.FIND_IN_SET(@value VARCHAR(MAX), @list VARCHAR(MAX), @delim VARCHAR(MAX))
+--	RETURNS VARCHAR(MAX)
+--	AS BEGIN
+--		RETURN LTRIM(RTRIM(@value));
+--	END;
+
+-- GO
+
+--IF OBJECT_ID (N'dbo.SplitString', N'FN') IS NOT NULL
+--    DROP FUNCTION dbo.SplitString;
+--GO
+--CREATE FUNCTION dbo.SplitString (@List NVARCHAR(MAX), @Delim VARCHAR(255))
+--RETURNS TABLE
+--AS
+--BEGIN
+--    RETURN ( SELECT [Value] FROM 
+--      ( 
+--        SELECT 
+--          [Value] = LTRIM(RTRIM(SUBSTRING(@List, [Number],
+--          CHARINDEX(@Delim, @List + @Delim, [Number]) - [Number])))
+--        FROM (SELECT Number = ROW_NUMBER() OVER (ORDER BY name)
+--          FROM sys.all_objects) AS x
+--          WHERE Number <= LEN(@List)
+--          AND SUBSTRING(@Delim + @List, [Number], LEN(@Delim)) = @Delim
+--      ) AS y
+--    );
+--END;

data/lib/arel_extensions/nodes/blank.rb

@@ -4,7 +4,8 @@ module ArelExtensions
     	@@return_type = :boolean
 
     	def initialize expr
-        	super [expr.first.coalesce('').trim.trim("\t").trim("\n")]
+#        	super [expr.first.coalesce('').trim.trim("\t").trim("\n")]
+        	super expr
     	end
     end
   end

data/lib/arel_extensions/nodes/date_diff.rb

@@ -90,8 +90,32 @@ module ArelExtensions
           elsif @date_type == :datetime
             Arel.sql("INTERVAL '%s' SECOND" % v.to_i)
           end
-#        elsif Arel::Attributes::Attribute === v
-#          v
+        else
+          v
+        end
+      end
+
+      def mssql_value(v = nil)
+        v ||= self.expressions.last
+        if defined?(ActiveSupport::Duration) && ActiveSupport::Duration === v
+          if @date_type == :date
+            v.inspect.to_i
+          elsif @date_type == :datetime
+            v.to_i
+          end
+        else
+          v
+        end
+      end
+
+      def mssql_datepart(v = nil)
+        v ||= self.expressions.last
+        if defined?(ActiveSupport::Duration) && ActiveSupport::Duration === v
+          if @date_type == :date
+            Arel.sql('day')
+          elsif @date_type == :datetime
+            Arel.sql('second')
+          end
         else
           v
         end

data/lib/arel_extensions/version.rb

@@ -1,4 +1,4 @@
 # -*- encoding : utf-8 -*-
 module ArelExtensions
-  VERSION = "0.8.7".freeze
+  VERSION = "0.9.0".freeze
 end

data/lib/arel_extensions/visitors.rb

@@ -3,4 +3,21 @@ require 'arel_extensions/visitors/mysql'
 require 'arel_extensions/visitors/oracle'
 require 'arel_extensions/visitors/postgresql'
 require 'arel_extensions/visitors/sqlite'
-require 'arel_extensions/visitors/mssql'
+require 'arel_extensions/visitors/mssql'
+
+Arel::Visitors::MSSQL.class_eval do
+	include ArelExtensions::Visitors::MSSQL
+end
+
+begin 
+	require 'arel_sqlserver'
+	if Arel::VERSION.to_i == 6
+		if Arel::Visitors::VISITORS['sqlserver'] && Arel::Visitors::VISITORS['sqlserver'] != Arel::Visitors::MSSQL
+			Arel::Visitors::VISITORS['sqlserver'].class_eval do
+		  		include ArelExtensions::Visitors::MSSQL
+			end 
+		end
+	end
+rescue LoadError
+rescue => e
+end

data/lib/arel_extensions/visitors/mssql.rb

@@ -1,12 +1,25 @@
 module ArelExtensions
   module Visitors
-    Arel::Visitors::MSSQL.class_eval do
+    module MSSQL
+      Arel::Visitors::MSSQL::DATE_MAPPING = {'d' => 'day', 'm' => 'month', 'y' => 'year', 'wd' => 'weekday', 'w' => 'week'}
       Arel::Visitors::MSSQL::DATE_FORMAT_DIRECTIVES = {
-        '%Y' => 'yy', '%C' => '', '%y' => 'yy', '%m' => 'mm', '%B' =>   '', '%b' => '', '%^b' => '',      # year, month
-        '%d' => 'dd', '%e' => '', '%j' =>   '', '%w' => 'dw', '%A' => '',                               # day, weekday
+        '%Y' => 'YYYY', '%C' => '', '%y' => 'YY', '%m' => 'MM', '%B' =>   '', '%b' => '', '%^b' => '',      # year, month
+        '%d' => 'DD', '%e' => '', '%j' =>   '', '%w' => 'dw', '%A' => '',                               # day, weekday
         '%H' => 'hh', '%k' => '', '%I' =>   '', '%l' =>   '', '%P' => '', '%p' => '',                 # hours
         '%M' => 'mi', '%S' => 'ss', '%L' => 'ms', '%N' => 'ns', '%z' => 'tz'
       }
+      # TODO all others... http://www.sql-server-helper.com/tips/date-formats.aspx
+      Arel::Visitors::MSSQL::DATE_CONVERT_FORMATS = {
+        'YYYY-MM-DD' => 120,
+        'YY-MM-DD'  => 120,
+        'MM/DD/YYYY' => 101,
+        'MM-DD-YYYY' => 110,
+        'YYYY/MM/DD' => 111,
+        'DD-MM-YYYY' => 105,
+        'DD-MM-YY'   => 5,
+        'DD.MM.YYYY' => 104,
+        'YYYY-MM-DDTHH:MM:SS:MMM' => 126
+      }
 
       # Math Functions
       def visit_ArelExtensions_Nodes_Ceil o, collector
@@ -16,7 +29,16 @@ module ArelExtensions
         collector
       end
 
-      def visit_ArelExtensions_Nodes_Concat o, collector
+      def visit_ArelExtensions_Nodes_IsNull o, collector
+        collector << "("
+        collector = visit o.left, collector
+#         collector << Arel::Visitors::MSSQL::COMMA
+        collector << " IS NULL)"
+        collector
+      end
+
+      # Deprecated
+      def visit_ArelExtensions_Nodes_ConcatOld o, collector
         arg = o.left.relation.engine.columns.find{|c| c.name == o.left.name.to_s}.type
         if(o.right.is_a?(Arel::Attributes::Attribute))
           collector = visit o.left, collector
@@ -24,7 +46,10 @@ module ArelExtensions
           collector = visit o.right, collector
           collector
         elsif ( arg == :date || arg == :datetime)
-          collector << "DATEADD(day,#{o.right},"
+          collector << "DATEADD(day"
+          collector << Arel::Visitors::MSSQL::COMMA
+          collector = visit o.right, collector
+          collector << Arel::Visitors::MSSQL::COMMA
           collector = visit o.left, collector
           collector
         else
@@ -35,8 +60,19 @@ module ArelExtensions
         end
       end
 
+      def visit_ArelExtensions_Nodes_Concat o, collector
+        collector << "CONCAT("
+        o.expressions.each_with_index { |arg, i|
+          collector << Arel::Visitors::MSSQL::COMMA unless i == 0
+          collector = visit arg, collector
+        }
+        collector << ")"
+        collector
+      end
+
       def visit_ArelExtensions_Nodes_DateDiff o, collector
-        collector << "DATEDIFF(day,"
+        collector << "DATEDIFF(day"
+        collector << Arel::Visitors::MSSQL::COMMA
         collector = visit o.left, collector
         collector << Arel::Visitors::MSSQL::COMMA
         collector = visit o.right, collector
@@ -44,94 +80,190 @@ module ArelExtensions
         collector
       end
 
+      def visit_ArelExtensions_Nodes_DateAdd o, collector
+        collector << "DATEADD("
+        collector << o.mssql_datepart(o.right)
+        collector << Arel::Visitors::MSSQL::COMMA
+        collector = visit o.mssql_value(o.right), collector
+        collector << Arel::Visitors::MSSQL::COMMA
+        collector = visit o.left, collector
+        collector << ")"
+        collector
+      end
 
       def visit_ArelExtensions_Nodes_Duration o, collector
-        #visit left for period
-        if(o.left == "d")
-          collector << "DAY("
-        elsif(o.left == "m")
-          collector << "MONTH("
-        elsif (o.left == "w")
-          collector << "WEEK"
-        elsif (o.left == "y")
-          collector << "YEAR("
-        end
-        #visit right
+        collector << 'DATEPART('
+        collector << Arel::Visitors::MSSQL::DATE_MAPPING[o.left]
+        collector << Arel::Visitors::MSSQL::COMMA
         collector = visit o.right, collector
         collector << ")"
         collector
       end
 
-     def visit_ArelExtensions_Nodes_Length o, collector
-       collector << "LEN("
-       collector = visit o.expr, collector
-       collector << ")"
-       collector
-     end
+      def visit_ArelExtensions_Nodes_Length o, collector
+        collector << "LEN("
+        collector = visit o.expr, collector
+        collector << ")"
+        collector
+      end
 
+      def visit_ArelExtensions_Nodes_Round o, collector
+        collector << "ROUND("
+        o.expressions.each_with_index { |arg, i|
+          collector << Arel::Visitors::MSSQL::COMMA unless i == 0
+          collector = visit arg, collector
+        }
+        if o.expressions.length == 1
+          collector << Arel::Visitors::MSSQL::COMMA
+          collector << "0"
+        end
+        collector << ")"
+        collector
+      end
 
       def visit_ArelExtensions_Nodes_Locate o, collector
         collector << "CHARINDEX("
-        collector = visit o.val, collector
+        collector = visit o.right, collector
         collector << Arel::Visitors::MSSQL::COMMA
-        collector = visit o.expr, collector
+        collector = visit o.left, collector
         collector << ")"
         collector
       end
 
-      def visit_ArelExtensions_Nodes_Format o, collector
-        collector << "CONCAT("
+      # TODO manage 2nd argument
+      def visit_ArelExtensions_Nodes_Trim o, collector
+        collector << "LTRIM(RTRIM("
+        collector = visit o.left, collector
+        collector << "))"
+        collector
+      end
+
+      # TODO manage 2nd argument
+      def visit_ArelExtensions_Nodes_Ltrim o, collector
+        collector << "LTRIM("
+        collector = visit o.left, collector
+        collector << ")"
+        collector
+      end
+
+      # TODO manage 2nd argument
+      def visit_ArelExtensions_Nodes_Rtrim o, collector
+        collector << "RTRIM("
+        collector = visit o.left, collector
+        collector << ")"
+        collector
+      end
 
-        t = o.iso_format.split('%')
-        t.each_with_index {|str, i|
-          if i == 0 && f[0] != '%'
-            collector = visit Arel::Nodes.build_quoted(str), collector
-          elsif str.length > 0
-            if !Arel::Visitors::MSSQL::DATE_FORMAT_DIRECTIVES['%' + str[0]].blank?
-              collector << 'DATEPART('
-              collector << Arel::Visitors::MSSQL::DATE_FORMAT_DIRECTIVES['%' + str[0]]
-              collector << Arel::Visitors::MSSQL::COMMA
-              collector = visit o.left, collector
-              collector << ')'
+      def visit_ArelExtensions_Nodes_Blank o, collector
+        collector << 'CASE WHEN LEN(LTRIM(RTRIM(ISNULL('
+        collector = visit o.left, collector
+        collector << ", '')))) = 0 THEN 1 ELSE 0 END"
+        collector
+      end
+
+      def visit_ArelExtensions_Nodes_Format o, collector
+        f = o.iso_format.dup
+        Arel::Visitors::MSSQL::DATE_FORMAT_DIRECTIVES.each { |d, r| f.gsub!(d, r) }
+        if Arel::Visitors::MSSQL::DATE_CONVERT_FORMATS[f]
+          collector << "CONVERT(VARCHAR(#{f.length})"
+          collector << Arel::Visitors::MSSQL::COMMA
+          collector = visit o.left, collector
+          collector << Arel::Visitors::MSSQL::COMMA
+          collector << Arel::Visitors::MSSQL::DATE_CONVERT_FORMATS[f].to_s
+          collector << ')'
+          collector
+        else
+          collector << "("
+          t = o.iso_format.split('%')
+          t.each_with_index {|str, i|
+            if i == 0 && t[0] != '%'
+              collector = visit Arel::Nodes.build_quoted(str), collector
               if str.length > 1
                 collector << Arel::Visitors::MSSQL::COMMA
                 collector = visit Arel::Nodes.build_quoted(str.sub(/\A./, '')), collector
               end
+            elsif str.length > 0
+              if !Arel::Visitors::MSSQL::DATE_FORMAT_DIRECTIVES['%' + str[0]].blank?
+                collector << 'LTRIM(STR(DATEPART('
+                collector << Arel::Visitors::MSSQL::DATE_FORMAT_DIRECTIVES['%' + str[0]]
+                collector << Arel::Visitors::MSSQL::COMMA
+                collector = visit o.left, collector
+                collector << ')))'
+                if str.length > 1
+                  collector << ' + '
+                  collector = visit Arel::Nodes.build_quoted(str.sub(/\A./, '')), collector
+                end
+              end
             end
-          end
-          collector << Arel::Visitors::MSSQL::COMMA unless i < (t.length - 1)
-        }
+            collector << ' + ' if t[i + 1]
+          }
 
-        collector << ")"
-        collector
+          collector << ')'
+          collector
+        end
       end
 
       def visit_ArelExtensions_Nodes_Replace o, collector
         collector << "REPLACE("
-        collector = visit o.expr,collector
-        collector << Arel::Visitors::MSSQL::COMMA
-        collector = visit o.left, collector
- 
-        collector << Arel::Visitors::MSSQL::COMMA
-        collector = visit o.right, collector
+        o.expressions.each_with_index { |arg, i|
+          collector << Arel::Visitors::MSSQL::COMMA unless i == 0
+          collector = visit arg, collector
+        }
         collector << ")"
         collector
       end
 
 
+      # TODO manage case insensitivity
+      def visit_ArelExtensions_Nodes_IMatches o, collector
+        collector = infix_value o, collector, ' LIKE '
+        if o.escape
+          collector << ' ESCAPE '
+          visit o.escape, collector
+        else
+          collector
+        end
+      end
+
+      # TODO manage case insensitivity
+      def visit_ArelExtensions_Nodes_IDoesNotMatch o, collector
+        collector = infix_value o, collector, ' NOT LIKE '
+        if o.escape
+          collector << ' ESCAPE '
+          collector = visit o.escape, collector
+        end
+        collector
+      end
+
       # SQL Server does not know about REGEXP
       def visit_Arel_Nodes_Regexp o, collector
         collector = visit o.left, collector
-        collector << "LIKE '% #{o.right}%'"
+        collector << "LIKE '%#{o.right}%'"
         collector
       end
 
       def visit_Arel_Nodes_NotRegexp o, collector
         collector = visit o.left, collector
-        collector << "NOT LIKE '% #{o.right}%'"
+        collector << "NOT LIKE '%#{o.right}%'"
         collector
       end
 
+      # TODO
+      def visit_ArelExtensions_Nodes_GroupConcat o, collector
+        collector << "(LISTAGG("
+        collector = visit o.left, collector
+        if o.right
+          collector << Arel::Visitors::Oracle::COMMA
+          collector = visit o.right, collector
+        end
+        collector << ") WITHIN GROUP (ORDER BY "
+        collector = visit o.left, collector
+        collector << "))"
+        collector
+      end
+
+
+
     end
   end
-end
+end

data/lib/arel_extensions/visitors/to_sql.rb

@@ -153,9 +153,11 @@ module ArelExtensions
       end
 
       def visit_ArelExtensions_Nodes_Blank o, collector
-        collector << '('
+        collector << 'LENGTH(TRIM(COALESCE('
         collector = visit o.left, collector
-        collector << " = '')"
+        collector << Arel::Visitors::ToSql::COMMA
+        collector = visit Arel::Nodes.build_quoted(''), collector
+        collector << "))) = 0"
         collector
       end
 
@@ -271,7 +273,7 @@ module ArelExtensions
         collector << "DATE_ADD("
         collector = visit o.left, collector
         collector << Arel::Visitors::ToSql::COMMA
-        collector = visit o.right, collector
+        collector = visit o.sqlite_value(o.right), collector
         collector << ")"
         collector
       end

data/test/database.yml

@@ -3,7 +3,7 @@ sqlite:
   database: ":memory:"
   timeout: 500
 jdbc-sqlite:
-  adapter: jdbcsqlite3 
+  adapter: jdbcsqlite3
   database: ":memory:"
   timeout: 500
 mysql:
@@ -41,7 +41,6 @@ ibm_db:
 mssql:
   adapter: sqlserver
   host: localhost
-  dataserver: localhost\SQL2014
   database: master
   username: sa
   password: Password12!

data/test/support/fake_record.rb

@@ -45,6 +45,10 @@ module FakeRecord
       @tables.include? name.to_s
     end
 
+    def data_source_exists? name
+      @tables.include? name.to_s
+    end
+
     def columns name, message = nil
       @columns[name.to_s]
     end
@@ -110,6 +114,10 @@ module FakeRecord
       connection.tables.include? name.to_s
     end
 
+    def data_source_exists? name
+      connection.tables.include? name.to_s
+    end
+
     def columns_hash
       connection.columns_hash
     end

data/test/with_ar/all_agnostic_test.rb

@@ -5,6 +5,7 @@ module ArelExtensions
   module WthAr
 
     class ListTest < Minitest::Test
+      require 'minitest/pride'
       def setup_db
         ActiveRecord::Base.configurations = YAML.load_file('test/database.yml')
         if ENV['DB'] == 'oracle' && ((defined?(RUBY_ENGINE) && RUBY_ENGINE == "rbx") || (RUBY_PLATFORM == 'java')) # not supported
@@ -39,7 +40,13 @@ module ArelExtensions
         end
         if File.exist?("init/#{@env_db}.sql")
           sql = File.read("init/#{@env_db}.sql")
-          @cnx.execute(sql) unless sql.blank?
+          if @env_db == 'mssql'
+            sql.split(/^GO\s*$/).each {|str|
+              @cnx.execute(str.strip) unless str.blank?
+            }
+          else
+            @cnx.execute(sql) unless sql.blank?
+          end
         end
         @cnx.drop_table(:user_tests) rescue nil 
         @cnx.create_table :user_tests do |t|
@@ -138,16 +145,25 @@ module ArelExtensions
       end
 
       def test_sum
-        assert_equal 68, User.select((@age.sum + 1).as("res")).take(50).first.res
-        assert_equal 134, User.select((@age.sum + @age.sum).as("res")).take(50).first.res
-        assert_equal 201, User.select(((@age * 3).sum).as("res")).take(50).first.res
-        assert_equal 4009, User.select(((@age * @age).sum).as("res")).take(50).first.res
+        if @env_db == 'mssql'
+          skip "SQL Server forces order?" # TODO
+          assert_equal 68, User.select((@age.sum + 1).as("res"), User.arel_table[:id].sum).take(50).reorder(@age).first.res
+          assert_equal 134, User.reorder(nil).select((@age.sum + @age.sum).as("res"), User.arel_table[:id].sum).take(50).first.res
+          assert_equal 201, User.reorder(nil).select(((@age * 3).sum).as("res"), User.arel_table[:id].sum).take(50).first.res
+          assert_equal 4009, User.reorder(nil).select(((@age * @age).sum).as("res"), User.arel_table[:id].sum).take(50).first.res
+        else
+          assert_equal 68, User.select((@age.sum + 1).as("res")).take(50).first.res
+          assert_equal 134, User.select((@age.sum + @age.sum).as("res")).take(50).first.res
+          assert_equal 201, User.select(((@age * 3).sum).as("res")).take(50).first.res
+          assert_equal 4009, User.select(((@age * @age).sum).as("res")).take(50).first.res
+        end
       end
 
       # String Functions
       def test_concat
         assert_equal 'Camille Camille', t(@camille, @name + ' ' + @name)
         assert_equal 'Laure 2', t(@laure, @name + ' ' + 2)
+        skip "TODO: find a way... to do group_concat/listagg in SQL Server" if @env_db == 'mssql'
         if @env_db == 'postgresql'
           assert_equal "Lucas Sophie", t(User.reorder(nil).from(User.select(:name).where(:name => ['Lucas', 'Sophie']).reorder(:name).as('user_tests')), @name.group_concat(' '))
         else
@@ -170,12 +186,14 @@ module ArelExtensions
 
       def test_find_in_set
         skip "Sqlite version can't load extension for find_in_set" if $sqlite && $load_extension_disabled
+        skip "SQL Server does not know about FIND_IN_SET" if @env_db == 'mssql'
         assert_equal 5, t(@neg, @comments & 2)
         assert_equal 0, t(@neg, @comments & 6) # not found
       end
 
       def test_string_comparators
         skip "Oracle can't use math operators to compare strings" if @env_db == 'oracle' # use GREATEST ?
+        skip "SQL Server can't use math operators to compare strings" if @env_db == 'mssql' # use GREATEST ?
         if @env_db == 'postgresql' # may return real boolean
           assert t(@neg, @name >= 'Mest') == true || t(@neg, @name >= 'Mest') == 't' # depends of ar version
           assert t(@neg, @name <= (@name + 'Z')) == true || t(@neg, @name <= (@name + 'Z')) == 't'
@@ -187,6 +205,7 @@ module ArelExtensions
 
       def test_regexp_not_regexp
         skip "Sqlite version can't load extension for regexp" if $sqlite && $load_extension_disabled
+        skip "SQL Server does not know about REGEXP without extensions" if @env_db == 'mssql'
         assert_equal 1, User.where(@name =~ '^M').count
         assert_equal 6, User.where(@name !~ '^L').count
         assert_equal 1, User.where(@name =~ /^M/).count
@@ -213,9 +232,10 @@ module ArelExtensions
 
       def test_trim
         assert_equal "Myung", t(@myung, @name.trim)
+        assert_equal "Myung", t(@myung, @name.trim.ltrim.rtrim)
+        skip "SQL Server does not manage argument for (L/R)TRIM" if @env_db == 'mssql'
         assert_equal "Myun", t(@myung, @name.rtrim("g"))
         assert_equal "yung", t(@myung, @name.ltrim("M"))
-        assert_equal "Myung", t(@myung, @name.trim.ltrim.rtrim)
         assert_equal "yung", t(@myung, (@name + "M").trim("M"))
         skip "Oracle does not accept multi char trim" if @env_db == 'oracle'
         assert_equal "", t(@myung, @name.rtrim(@name))
@@ -237,6 +257,7 @@ module ArelExtensions
 
       def test_format
         assert_equal '2016-05-23', t(@lucas, @created_at.format('%Y-%m-%d'))
+        skip "SQL Server does  not accept any format" if @env_db == 'mssql'
         assert_equal '2014/03/03 12:42:00', t(@lucas, @updated_at.format('%Y/%m/%d %H:%M:%S'))
       end
 
@@ -276,7 +297,7 @@ module ArelExtensions
         assert_equal 5, t(@camille, @created_at.month).to_i
         assert_equal 8, User.where(@created_at.month.eq("05")).count
         #Week
-        assert_equal 21, t(@arthur, @created_at.week).to_i
+        assert_equal (@env_db == 'mssql' ? 22 : 21), t(@arthur, @created_at.week).to_i
         assert_equal 8, User.where(@created_at.month.eq("05")).count
         #Day
         assert_equal 23, t(@laure, @created_at.day).to_i
@@ -327,7 +348,7 @@ module ArelExtensions
 
       def test_wday
         d = Date.new(2016, 6, 26)
-        assert_equal(@env_db == 'oracle' ? 2 : 1, t(@myung, @created_at.wday).to_i) # monday
+        assert_equal(@env_db == 'oracle' || @env_db == 'mssql' ? 2 : 1, t(@myung, @created_at.wday).to_i) # monday
         assert_equal 0, User.select(d.wday).as("res").first.to_i
       end
 

data/test/with_ar/insert_agnostic_test.rb

@@ -19,7 +19,9 @@ module ArelExtensions
         Arel::Table.engine = ActiveRecord::Base
         if File.exist?("init/#{@env_db}.sql")
           sql = File.read("init/#{@env_db}.sql")
-          @cnx.execute(sql) unless sql.blank?
+          unless sql.blank?
+            @cnx.execute(sql) rescue $stderr << "can't create functions"
+          end
         end
         @cnx.drop_table(:user_tests) rescue nil 
         @cnx.create_table :user_tests do |t|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: arel_extensions
 version: !ruby/object:Gem::Version
-  version: 0.8.7
+  version: 0.9.0
 platform: ruby
 authors:
 - Yann Azoury
@@ -10,20 +10,20 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-28 00:00:00.000000000 Z
+date: 2016-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: arel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '6.0'
 - !ruby/object:Gem::Dependency
@@ -78,6 +78,7 @@ extensions: []
 extra_rdoc_files:
 - MIT-LICENSE.txt
 - README.md
+- functions.html
 files:
 - ".gitignore"
 - ".travis.yml"
@@ -90,6 +91,7 @@ files:
 - MIT-LICENSE.txt
 - README.md
 - Rakefile
+- SQL_Challenges.md
 - TODO
 - appveyor.yml
 - arel_extensions.gemspec