arel 5.0.0 → 5.0.1.20140414130214

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e4a4617ad12bc06100404774da8861b906302a0
-  data.tar.gz: ef0b304f87d0607f4225cda23a84fe972fa5f5d5
+  metadata.gz: 86a3156add2973e4e2cd8b3a852e82c26c073601
+  data.tar.gz: 06fc106d1ef5fdc41de327a78a8e0b467096202b
 SHA512:
-  metadata.gz: e8f247d114fe817f8efa0810ed924f791fda25b55fa2f998449150c31e42dd1c8c10bf56d2c3afbcc4f6344962ada47ef0b503deedc995df10eb9c103827f1ba
-  data.tar.gz: 6fad98f033050e0556bed7ba338b8e7456b2758c62d58f98709c768f3e1496adf1a9f3d2e241be1c0f289c4fd91c694adec01c452f933f8caeef6495ccdca901
+  metadata.gz: ba39500686768a6865b688ce693dd6bc69e2e7ea1a7acb52ab0ad1f0d00fefb85b537f4c5405e865abe67016c166f06503ded328c3b79c2a34156c8ed75e6293
+  data.tar.gz: 1d916874f785a6fc85a2df91633edbc4b607612c876160e6fce14d03ebc17694fd87be197b793ec44f89a68a9815dba07161717333fb15575e36419efae16508

data/.travis.yml

@@ -1,9 +1,13 @@
 script: "rake test"
 rvm:
-  - rbx-19mode
+  - rbx
   - jruby
   - 1.9.3
   - 2.0.0
+  - 2.1.0
+matrix:
+  allow_failures:
+    - rvm: rbx
 notifications:
   email: false
   irc:

data/Gemfile

@@ -5,7 +5,7 @@
 source "https://rubygems.org/"
 
 
-gem "minitest", "~>4.4", :group => [:development, :test]
+gem "minitest", "~>5.1", :group => [:development, :test]
 gem "rdoc", "~>4.0", :group => [:development, :test]
 gem "hoe", "~>3.5", :group => [:development, :test]
 

data/History.txt

@@ -1,3 +1,10 @@
+== 5.0.1 / 2014-04-14
+
+ * Bug Fixes
+
+  * Fix `SqlLiteral` YAML serialization
+  * PostgreSQL bugfix for invalid SQL in subqueries
+
 == 5.0.0 / 2013-12-04
 
 * Enhancements
@@ -8,6 +15,13 @@
 
   * Fix serializing a relation when calling `to_yaml`
 
+=== 4.0.2 / 2014-02-05
+
+ * Bug Fixes
+
+  * Fix `SqlLiteral` YAML serialization
+  * PostgreSQL bugfix for invalid SQL in subqueries
+
 == 4.0.1 / 2013-10-22
 
 * Enhancements

data/README.markdown

@@ -87,12 +87,6 @@ All operators are chainable in this way, and they are chainable any number of ti
 users.where(users[:name].eq('bob')).where(users[:age].lt(25))
 ```
 
-Of course, many of the operators take multiple arguments, so the last example can be written more tersely:
-
-```ruby
-users.where(users[:name].eq('bob'), users[:age].lt(25))
-```
-
 The `OR` operator works like this:
 
 ```ruby

data/arel.gemspec

@@ -1,13 +1,14 @@
 # -*- encoding: utf-8 -*-
-# stub: arel 5.0.0.20131204235845 ruby lib
+# stub: arel 5.0.1.20140414130214 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "arel"
-  s.version = "5.0.0.20131204235845"
+  s.version = "5.0.1.20140414130214"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib"]
   s.authors = ["Aaron Patterson", "Bryan Halmkamp", "Emilio Tagua", "Nick Kallen"]
-  s.date = "2013-12-05"
+  s.date = "2014-04-14"
   s.description = "Arel is a SQL AST manager for Ruby. It\n\n1. Simplifies the generation of complex SQL queries\n2. Adapts to various RDBMSes\n\nIt is intended to be a framework framework; that is, you can build your own ORM\nwith it, focusing on innovative object and collection modeling as opposed to\ndatabase compatibility and query generation."
   s.email = ["aaron@tenderlovemaking.com", "bryan@brynary.com", "miloops@gmail.com", "nick@example.org"]
   s.extra_rdoc_files = ["History.txt", "MIT-LICENSE.txt", "Manifest.txt", "README.markdown"]
@@ -15,9 +16,8 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/rails/arel"
   s.licenses = ["MIT"]
   s.rdoc_options = ["--main", "README.markdown"]
-  s.require_paths = ["lib"]
   s.rubyforge_project = "arel"
-  s.rubygems_version = "2.1.11"
+  s.rubygems_version = "2.2.2"
   s.summary = "Arel is a SQL AST manager for Ruby"
   s.test_files = ["test/attributes/test_attribute.rb", "test/nodes/test_and.rb", "test/nodes/test_as.rb", "test/nodes/test_ascending.rb", "test/nodes/test_bin.rb", "test/nodes/test_count.rb", "test/nodes/test_delete_statement.rb", "test/nodes/test_descending.rb", "test/nodes/test_distinct.rb", "test/nodes/test_equality.rb", "test/nodes/test_extract.rb", "test/nodes/test_false.rb", "test/nodes/test_grouping.rb", "test/nodes/test_infix_operation.rb", "test/nodes/test_insert_statement.rb", "test/nodes/test_named_function.rb", "test/nodes/test_node.rb", "test/nodes/test_not.rb", "test/nodes/test_or.rb", "test/nodes/test_over.rb", "test/nodes/test_select_core.rb", "test/nodes/test_select_statement.rb", "test/nodes/test_sql_literal.rb", "test/nodes/test_sum.rb", "test/nodes/test_table_alias.rb", "test/nodes/test_true.rb", "test/nodes/test_update_statement.rb", "test/nodes/test_window.rb", "test/test_attributes.rb", "test/test_crud.rb", "test/test_delete_manager.rb", "test/test_factory_methods.rb", "test/test_insert_manager.rb", "test/test_select_manager.rb", "test/test_table.rb", "test/test_update_manager.rb", "test/visitors/test_bind_visitor.rb", "test/visitors/test_depth_first.rb", "test/visitors/test_dispatch_contamination.rb", "test/visitors/test_dot.rb", "test/visitors/test_ibm_db.rb", "test/visitors/test_informix.rb", "test/visitors/test_join_sql.rb", "test/visitors/test_mssql.rb", "test/visitors/test_mysql.rb", "test/visitors/test_oracle.rb", "test/visitors/test_postgres.rb", "test/visitors/test_sqlite.rb", "test/visitors/test_to_sql.rb"]
 
@@ -25,17 +25,17 @@ Gem::Specification.new do |s|
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<minitest>, ["~> 5.0"])
+      s.add_development_dependency(%q<minitest>, ["~> 5.3"])
       s.add_development_dependency(%q<rdoc>, ["~> 4.0"])
-      s.add_development_dependency(%q<hoe>, ["~> 3.7"])
+      s.add_development_dependency(%q<hoe>, ["~> 3.6"])
     else
-      s.add_dependency(%q<minitest>, ["~> 5.0"])
+      s.add_dependency(%q<minitest>, ["~> 5.3"])
       s.add_dependency(%q<rdoc>, ["~> 4.0"])
-      s.add_dependency(%q<hoe>, ["~> 3.7"])
+      s.add_dependency(%q<hoe>, ["~> 3.6"])
     end
   else
-    s.add_dependency(%q<minitest>, ["~> 5.0"])
+    s.add_dependency(%q<minitest>, ["~> 5.3"])
     s.add_dependency(%q<rdoc>, ["~> 4.0"])
-    s.add_dependency(%q<hoe>, ["~> 3.7"])
+    s.add_dependency(%q<hoe>, ["~> 3.6"])
   end
 end

data/lib/arel.rb

@@ -32,7 +32,7 @@ require 'arel/sql_literal'
 ####
 
 module Arel
-  VERSION = '5.0.0'
+  VERSION = '5.0.1'
 
   def self.sql raw_sql
     Arel::Nodes::SqlLiteral.new raw_sql

data/lib/arel/select_manager.rb

@@ -2,6 +2,8 @@ module Arel
   class SelectManager < Arel::TreeManager
     include Arel::Crud
 
+    STRING_OR_SYMBOL_CLASS = [Symbol, String]
+
     def initialize engine, table = nil
       super(engine)
       @ast   = Nodes::SelectStatement.new
@@ -128,7 +130,7 @@ module Arel
       # FIXME: converting these to SQLLiterals is probably not good, but
       # rails tests require it.
       @ctx.projections.concat projections.map { |x|
-        [Symbol, String].include?(x.class) ? SqlLiteral.new(x.to_s) : x
+        STRING_OR_SYMBOL_CLASS.include?(x.class) ? SqlLiteral.new(x.to_s) : x
       }
       self
     end
@@ -152,7 +154,7 @@ module Arel
     def order *expr
       # FIXME: We SHOULD NOT be converting these to SqlLiteral automatically
       @ast.orders.concat expr.map { |x|
-        String === x || Symbol === x ? Nodes::SqlLiteral.new(x.to_s) : x
+        STRING_OR_SYMBOL_CLASS.include?(x.class) ? Nodes::SqlLiteral.new(x.to_s) : x
       }
       self
     end

data/lib/arel/tree_manager.rb

@@ -4,9 +4,12 @@ module Arel
 
     attr_reader :ast, :engine
 
+    attr_accessor :bind_values
+
     def initialize engine
       @engine = engine
       @ctx    = nil
+      @bind_values = []
     end
 
     def to_dot

data/lib/arel/visitors/mssql.rb

@@ -62,8 +62,8 @@ module Arel
         x.projections.length == 1 && Arel::Nodes::Count === x.projections.first
       end
 
-      # fixme raise exception of there is no pk?
-      # fixme!! Table.primary_key will be depricated. What is the replacement??
+      # FIXME raise exception of there is no pk?
+      # FIXME!! Table.primary_key will be deprecated. What is the replacement??
       def find_left_table_pk o, a
         return visit o.primary_key, a if o.instance_of? Arel::Table
         find_left_table_pk o.left, a if o.kind_of? Arel::Nodes::Join

data/lib/arel/visitors/postgresql.rb

@@ -4,10 +4,12 @@ module Arel
       private
 
       def visit_Arel_Nodes_Matches o, a
+        a = o.left if Arel::Attributes::Attribute === o.left
         "#{visit o.left, a} ILIKE #{visit o.right, a}"
       end
 
       def visit_Arel_Nodes_DoesNotMatch o, a
+        a = o.left if Arel::Attributes::Attribute === o.left
         "#{visit o.left, a} NOT ILIKE #{visit o.right, a}"
       end
 

data/lib/arel/visitors/to_sql.rb

@@ -42,6 +42,10 @@ module Arel
       # `getconstant` should be a hash lookup, and no object is duped when the
       # value of the constant is pushed on the stack.  Hence the crazy
       # constants below.
+      #
+      # `matches` and `doesNotMatch` operate case-insensitively via Visitor subclasses
+      # specialized for specific databases when necessary.
+      #
 
       WHERE    = ' WHERE '    # :nodoc:
       SPACE    = ' '          # :nodoc:

data/test/nodes/test_ascending.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 module Arel
   module Nodes
-    class TestAscending < MiniTest::Unit::TestCase
+    class TestAscending < Minitest::Test
       def test_construct
         ascending = Ascending.new 'zomg'
         assert_equal 'zomg', ascending.expr

data/test/nodes/test_bin.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 module Arel
   module Nodes
-    class TestBin < MiniTest::Unit::TestCase
+    class TestBin < Minitest::Test
       def test_new
         assert Arel::Nodes::Bin.new('zomg')
       end

data/test/nodes/test_descending.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 module Arel
   module Nodes
-    class TestDescending < MiniTest::Unit::TestCase
+    class TestDescending < Minitest::Test
       def test_construct
         descending = Descending.new 'zomg'
         assert_equal 'zomg', descending.expr

data/test/nodes/test_infix_operation.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 module Arel
   module Nodes
-    class TestInfixOperation < MiniTest::Unit::TestCase
+    class TestInfixOperation < Minitest::Test
       def test_construct
         operation = InfixOperation.new :+, 1, 2
         assert_equal :+, operation.operator

data/test/nodes/test_named_function.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 module Arel
   module Nodes
-    class TestNamedFunction < MiniTest::Unit::TestCase
+    class TestNamedFunction < Minitest::Test
       def test_construct
         function = NamedFunction.new 'omg', 'zomg'
         assert_equal 'omg', function.name

data/test/nodes/test_node.rb

@@ -1,7 +1,7 @@
 require 'helper'
 
 module Arel
-  class TestNode < MiniTest::Unit::TestCase
+  class TestNode < Minitest::Test
     def test_includes_factory_methods
       assert Node.new.respond_to?(:create_join)
     end

data/test/nodes/test_select_core.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 module Arel
   module Nodes
-    class TestSelectCore < MiniTest::Unit::TestCase
+    class TestSelectCore < Minitest::Test
       def test_clone
         core = Arel::Nodes::SelectCore.new
         core.froms       = %w[a b c]

data/test/test_crud.rb

@@ -45,7 +45,7 @@ module Arel
         table = Table.new :users
         fc = FakeCrudder.new
         fc.from table
-        stmt = fc.compile_update [[table[:id], 'foo']], table.primary_key
+        stmt = fc.compile_update [[table[:id], 'foo']], Arel::Attributes::Attribute.new(table, 'id')
         assert_instance_of Arel::UpdateManager, stmt
       end
     end

data/test/test_factory_methods.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 module Arel
   module FactoryMethods
-    class TestFactoryMethods < MiniTest::Unit::TestCase
+    class TestFactoryMethods < Minitest::Test
       class Factory
         include Arel::FactoryMethods
       end

data/test/test_select_manager.rb

@@ -1,58 +1,6 @@
 require 'helper'
 
 module Arel
-  class EngineProxy
-    attr_reader :executed
-    attr_reader :connection_pool
-    attr_reader :spec
-    attr_reader :config
-
-    def initialize engine
-      @engine = engine
-      @executed = []
-      @connection_pool = self
-      @spec = self
-      @config = { :adapter => 'sqlite3' }
-    end
-
-    def with_connection
-      yield self
-    end
-
-    def connection
-      self
-    end
-
-    def quote_table_name thing; @engine.connection.quote_table_name thing end
-    def quote_column_name thing; @engine.connection.quote_column_name thing end
-    def quote thing, column; @engine.connection.quote thing, column end
-    def columns table, message = nil
-      @engine.connection.columns table, message
-    end
-
-    def columns_hash
-      @engine.connection.columns_hash
-    end
-
-    def table_exists? name
-      @engine.connection.table_exists? name
-    end
-
-    def tables
-      @engine.connection.tables
-    end
-
-    def visitor
-      @engine.connection.visitor
-    end
-
-    def execute sql, name = nil, *args
-      @executed << sql
-    end
-    alias :update :execute
-    alias :delete :execute
-    alias :insert :execute
-  end
 
   describe 'select manager' do
     def test_join_sources
@@ -61,6 +9,13 @@ module Arel
       assert_equal "SELECT FROM 'foo'", manager.to_sql
     end
 
+    def test_manager_stores_bind_values
+      manager = Arel::SelectManager.new Table.engine
+      assert_equal [], manager.bind_values
+      manager.bind_values = [1]
+      assert_equal [1], manager.bind_values
+    end
+
     describe 'backwards compatibility' do
       describe 'project' do
         it 'accepts symbols as sql literals' do
@@ -874,9 +829,8 @@ module Arel
 
     describe 'delete' do
       it "copies from" do
-        engine  = EngineProxy.new Table.engine
         table   = Table.new :users
-        manager = Arel::SelectManager.new engine
+        manager = Arel::SelectManager.new Table.engine
         manager.from table
         stmt = manager.compile_delete
 
@@ -884,9 +838,8 @@ module Arel
       end
 
       it "copies where" do
-        engine  = EngineProxy.new Table.engine
         table   = Table.new :users
-        manager = Arel::SelectManager.new engine
+        manager = Arel::SelectManager.new Table.engine
         manager.from table
         manager.where table[:id].eq 10
         stmt = manager.compile_delete
@@ -916,12 +869,11 @@ module Arel
 
     describe 'update' do
       it 'copies limits' do
-        engine  = EngineProxy.new Table.engine
         table   = Table.new :users
-        manager = Arel::SelectManager.new engine
+        manager = Arel::SelectManager.new Table.engine
         manager.from table
         manager.take 1
-        stmt = manager.compile_update(SqlLiteral.new('foo = bar'), table.primary_key)
+        stmt = manager.compile_update(SqlLiteral.new('foo = bar'), Arel::Attributes::Attribute.new(table, 'id'))
         stmt.key = table['id']
 
         stmt.to_sql.must_be_like %{
@@ -931,12 +883,11 @@ module Arel
       end
 
       it 'copies order' do
-        engine  = EngineProxy.new Table.engine
         table   = Table.new :users
-        manager = Arel::SelectManager.new engine
+        manager = Arel::SelectManager.new Table.engine
         manager.from table
         manager.order :foo
-        stmt = manager.compile_update(SqlLiteral.new('foo = bar'), table.primary_key)
+        stmt = manager.compile_update(SqlLiteral.new('foo = bar'), Arel::Attributes::Attribute.new(table, 'id'))
         stmt.key = table['id']
 
         stmt.to_sql.must_be_like %{
@@ -946,22 +897,20 @@ module Arel
       end
 
       it 'takes a string' do
-        engine  = EngineProxy.new Table.engine
         table   = Table.new :users
-        manager = Arel::SelectManager.new engine
+        manager = Arel::SelectManager.new Table.engine
         manager.from table
-        stmt = manager.compile_update(SqlLiteral.new('foo = bar'), table.primary_key)
+        stmt = manager.compile_update(SqlLiteral.new('foo = bar'), Arel::Attributes::Attribute.new(table, 'id'))
 
         stmt.to_sql.must_be_like %{ UPDATE "users" SET foo = bar }
       end
 
       it 'copies where clauses' do
-        engine  = EngineProxy.new Table.engine
         table   = Table.new :users
-        manager = Arel::SelectManager.new engine
+        manager = Arel::SelectManager.new Table.engine
         manager.where table[:id].eq 10
         manager.from table
-        stmt = manager.compile_update({table[:id] => 1}, table.primary_key)
+        stmt = manager.compile_update({table[:id] => 1}, Arel::Attributes::Attribute.new(table, 'id'))
 
         stmt.to_sql.must_be_like %{
           UPDATE "users" SET "id" = 1 WHERE "users"."id" = 10
@@ -969,13 +918,12 @@ module Arel
       end
 
       it 'copies where clauses when nesting is triggered' do
-        engine  = EngineProxy.new Table.engine
         table   = Table.new :users
-        manager = Arel::SelectManager.new engine
+        manager = Arel::SelectManager.new Table.engine
         manager.where table[:foo].eq 10
         manager.take 42
         manager.from table
-        stmt = manager.compile_update({table[:id] => 1}, table.primary_key)
+        stmt = manager.compile_update({table[:id] => 1}, Arel::Attributes::Attribute.new(table, 'id'))
 
         stmt.to_sql.must_be_like %{
           UPDATE "users" SET "id" = 1 WHERE "users"."id" IN (SELECT "users"."id" FROM "users" WHERE "users"."foo" = 10 LIMIT 42)
@@ -983,11 +931,10 @@ module Arel
       end
 
       it 'executes an update statement' do
-        engine  = EngineProxy.new Table.engine
         table   = Table.new :users
-        manager = Arel::SelectManager.new engine
+        manager = Arel::SelectManager.new Table.engine
         manager.from table
-        stmt = manager.compile_update({table[:id] => 1}, table.primary_key)
+        stmt = manager.compile_update({table[:id] => 1}, Arel::Attributes::Attribute.new(table, 'id'))
 
         stmt.to_sql.must_be_like %{
           UPDATE "users" SET "id" = 1
@@ -1005,16 +952,14 @@ module Arel
 
       it 'takes strings' do
         manager = Arel::SelectManager.new Table.engine
-        manager.project Nodes::SqlLiteral.new('*')
+        manager.project '*'
         manager.to_sql.must_be_like %{ SELECT * }
       end
 
       it "takes sql literals" do
         manager = Arel::SelectManager.new Table.engine
         manager.project Nodes::SqlLiteral.new '*'
-        manager.to_sql.must_be_like %{
-          SELECT *
-        }
+        manager.to_sql.must_be_like %{ SELECT * }
       end
     end
 

data/test/visitors/test_bind_visitor.rb

@@ -4,7 +4,7 @@ require 'support/fake_record'
 
 module Arel
   module Visitors
-    class TestBindVisitor < MiniTest::Unit::TestCase 
+    class TestBindVisitor < Minitest::Test
       
       ##
       # Tests visit_Arel_Nodes_Assignment correctly

data/test/visitors/test_depth_first.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 module Arel
   module Visitors
-    class TestDepthFirst < MiniTest::Unit::TestCase
+    class TestDepthFirst < Minitest::Test
       Collector = Struct.new(:calls) do
         def call object
           calls << object

data/test/visitors/test_dot.rb

@@ -2,7 +2,7 @@ require 'helper'
 
 module Arel
   module Visitors
-    class TestDot < MiniTest::Unit::TestCase
+    class TestDot < Minitest::Test
       def setup
         @visitor = Visitors::Dot.new
       end

data/test/visitors/test_postgres.rb

@@ -5,6 +5,8 @@ module Arel
     describe 'the postgres visitor' do
       before do
         @visitor = PostgreSQL.new Table.engine.connection
+        @table = Table.new(:users)
+        @attr = @table[:id]
       end
 
       describe 'locking' do
@@ -43,6 +45,40 @@ module Arel
         core.set_quantifier = Arel::Nodes::Distinct.new
         assert_equal 'SELECT DISTINCT', @visitor.accept(core)
       end
+
+      describe "Nodes::Matches" do
+        it "should know how to visit" do
+          node = @table[:name].matches('foo%')
+          @visitor.accept(node).must_be_like %{
+            "users"."name" ILIKE 'foo%'
+          }
+        end
+
+        it 'can handle subqueries' do
+          subquery = @table.project(:id).where(@table[:name].matches('foo%'))
+          node = @attr.in subquery
+          @visitor.accept(node).must_be_like %{
+            "users"."id" IN (SELECT id FROM "users" WHERE "users"."name" ILIKE 'foo%')
+          }
+        end
+      end
+
+      describe "Nodes::DoesNotMatch" do
+        it "should know how to visit" do
+          node = @table[:name].does_not_match('foo%')
+          @visitor.accept(node).must_be_like %{
+            "users"."name" NOT ILIKE 'foo%'
+          }
+        end
+
+        it 'can handle subqueries' do
+          subquery = @table.project(:id).where(@table[:name].does_not_match('foo%'))
+          node = @attr.in subquery
+          @visitor.accept(node).must_be_like %{
+            "users"."id" IN (SELECT id FROM "users" WHERE "users"."name" NOT ILIKE 'foo%')
+          }
+        end
+      end
     end
   end
 end

data/test/visitors/test_to_sql.rb

@@ -92,7 +92,14 @@ module Arel
         assert_equal 'omg(*, *)', @visitor.accept(function)
       end
 
-      describe 'equality' do
+      describe 'Nodes::Equality' do
+        it "should escape strings" do
+          test = Table.new(:users)[:name].eq 'Aaron Patterson'
+          @visitor.accept(test).must_be_like %{
+            "users"."name" = 'Aaron Patterson'
+          }
+        end
+
         it 'should handle false' do
           sql = @visitor.accept Nodes::Equality.new(false, false)
           sql.must_be_like %{ 'f' = 'f' }
@@ -103,6 +110,23 @@ module Arel
           sql = @visitor.accept Nodes::Equality.new(table[:id], '1-fooo')
           sql.must_be_like %{ "users"."id" = 1 }
         end
+
+        it 'should handle nil' do
+          sql = @visitor.accept Nodes::Equality.new(@table[:name], nil)
+          sql.must_be_like %{ "users"."name" IS NULL }
+        end
+      end
+
+      describe 'Nodes::NotEqual' do
+        it 'should handle false' do
+          sql = @visitor.accept Nodes::NotEqual.new(@table[:active], false)
+          sql.must_be_like %{ "users"."active" != 'f' }
+        end
+
+        it 'should handle nil' do
+          sql = @visitor.accept Nodes::NotEqual.new(@table[:name], nil)
+          sql.must_be_like %{ "users"."name" IS NOT NULL }
+        end
       end
 
       it "should visit string subclass" do
@@ -194,6 +218,40 @@ module Arel
         @visitor.accept(test).must_be_like %{ "users"."bool" = 't' }
       end
 
+      describe "Nodes::Matches" do
+        it "should know how to visit" do
+          node = @table[:name].matches('foo%')
+          @visitor.accept(node).must_be_like %{
+            "users"."name" LIKE 'foo%'
+          }
+        end
+
+        it 'can handle subqueries' do
+          subquery = @table.project(:id).where(@table[:name].matches('foo%'))
+          node = @attr.in subquery
+          @visitor.accept(node).must_be_like %{
+            "users"."id" IN (SELECT id FROM "users" WHERE "users"."name" LIKE 'foo%')
+          }
+        end
+      end
+
+      describe "Nodes::DoesNotMatch" do
+        it "should know how to visit" do
+          node = @table[:name].does_not_match('foo%')
+          @visitor.accept(node).must_be_like %{
+            "users"."name" NOT LIKE 'foo%'
+          }
+        end
+
+        it 'can handle subqueries' do
+          subquery = @table.project(:id).where(@table[:name].does_not_match('foo%'))
+          node = @attr.in subquery
+          @visitor.accept(node).must_be_like %{
+            "users"."id" IN (SELECT id FROM "users" WHERE "users"."name" NOT LIKE 'foo%')
+          }
+        end
+      end
+
       describe "Nodes::Ordering" do
         it "should know how to visit" do
           node = @attr.desc
@@ -378,15 +436,6 @@ module Arel
         end
       end
 
-      describe 'Equality' do
-        it "should escape strings" do
-          test = Table.new(:users)[:name].eq 'Aaron Patterson'
-          @visitor.accept(test).must_be_like %{
-            "users"."name" = 'Aaron Patterson'
-          }
-        end
-      end
-
       describe 'Constants' do
         it "should handle true" do
           test = Table.new(:users).create_true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: arel
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.1.20140414130214
 platform: ruby
 authors:
 - Aaron Patterson
@@ -11,50 +11,50 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-05 00:00:00.000000000 Z
+date: 2014-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '5.3'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '4.0'
 - !ruby/object:Gem::Dependency
   name: hoe
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '3.6'
 description: |-
   Arel is a SQL AST manager for Ruby. It
 
@@ -77,9 +77,9 @@ extra_rdoc_files:
 - Manifest.txt
 - README.markdown
 files:
-- .autotest
-- .gemtest
-- .travis.yml
+- ".autotest"
+- ".gemtest"
+- ".travis.yml"
 - Gemfile
 - History.txt
 - MIT-LICENSE.txt
@@ -216,23 +216,23 @@ licenses:
 metadata: {}
 post_install_message: 
 rdoc_options:
-- --main
+- "--main"
 - README.markdown
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: arel
-rubygems_version: 2.1.11
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Arel is a SQL AST manager for Ruby