arel 0.1.0 → 0.2.0

data/spec/arel/engines/memory/unit/relations/insert_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Insert do
@@ -14,13 +14,13 @@ module Arel
       it "manufactures an array of hashes of attributes to values" do
         @relation                                                         \
           .insert(@relation[:id] => 4, @relation[:name] => 'guinea fowl') \
-        .let do |relation|
-          relation.call.should == [
-            Row.new(relation, [1, 'duck']),
-            Row.new(relation, [2, 'duck']),
-            Row.new(relation, [3, 'goose']),
-            Row.new(relation, [4, 'guinea fowl'])
-          ]
+         do |relation|
+           relation.should == [
+             Row.new(relation, [1, 'duck']),
+             Row.new(relation, [2, 'duck']),
+             Row.new(relation, [3, 'goose']),
+             Row.new(relation, [4, 'guinea fowl'])
+           ]
         end
       end
     end

data/spec/arel/engines/memory/unit/relations/join_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Join do

data/spec/arel/engines/memory/unit/relations/order_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Order do

data/spec/arel/engines/memory/unit/relations/project_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Project do

data/spec/arel/engines/memory/unit/relations/skip_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Skip do

data/spec/arel/engines/memory/unit/relations/take_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Take do

data/spec/arel/engines/memory/unit/relations/where_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Where do

data/spec/arel/engines/sql/integration/joins/with_adjacency_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Join do

data/spec/arel/engines/sql/integration/joins/with_aggregations_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Join do

data/spec/arel/engines/sql/integration/joins/with_compounds_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Join do

data/spec/arel/engines/sql/unit/engine_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Sql::Engine do

data/spec/arel/engines/sql/unit/predicates/binary_spec.rb

@@ -1,113 +1,116 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
-  describe Binary do
-    before do
-      @relation = Table.new(:users)
-      @attribute1 = @relation[:id]
-      @attribute2 = @relation[:name]
+  module Predicates
+    describe Binary do
       class ConcreteBinary < Binary
         def predicate_sql
           "<=>"
         end
       end
-    end
 
-    describe "with compound predicates" do
       before do
-        @operand1 = ConcreteBinary.new(@attribute1, 1)
-        @operand2 = ConcreteBinary.new(@attribute2, "name")
+        @relation = Arel::Table.new(:users)
+        @attribute1 = @relation[:id]
+        @attribute2 = @relation[:name]
       end
 
-      describe Or do
-        describe "#to_sql" do
-          it "manufactures sql with an OR operation" do
-            sql = Or.new(@operand1, @operand2).to_sql
+      describe "with compound predicates" do
+        before do
+          @operand1 = ConcreteBinary.new(@attribute1, 1)
+          @operand2 = ConcreteBinary.new(@attribute2, "name")
+        end
 
-            adapter_is :mysql do
-              sql.should be_like(%Q{(`users`.`id` <=> 1 OR `users`.`name` <=> 'name')})
-            end
+        describe Or do
+          describe "#to_sql" do
+            it "manufactures sql with an OR operation" do
+              sql = Or.new(@operand1, @operand2).to_sql
 
-            adapter_is :postgresql do
-              sql.should be_like(%Q{("users"."id" <=> 1 OR "users"."name" <=> E'name')})
-            end
+              adapter_is :mysql do
+                sql.should be_like(%Q{(`users`.`id` <=> 1 OR `users`.`name` <=> 'name')})
+              end
+
+              adapter_is :postgresql do
+                sql.should be_like(%Q{("users"."id" <=> 1 OR "users"."name" <=> E'name')})
+              end
 
-            adapter_is :sqlite3 do
-              sql.should be_like(%Q{("users"."id" <=> 1 OR "users"."name" <=> 'name')})
+              adapter_is :sqlite3 do
+                sql.should be_like(%Q{("users"."id" <=> 1 OR "users"."name" <=> 'name')})
+              end
             end
           end
         end
-      end
 
-      describe And do
-        describe "#to_sql" do
-          it "manufactures sql with an AND operation" do
-            sql = And.new(@operand1, @operand2).to_sql
+        describe And do
+          describe "#to_sql" do
+            it "manufactures sql with an AND operation" do
+              sql = And.new(@operand1, @operand2).to_sql
 
-            adapter_is :mysql do
-              sql.should be_like(%Q{(`users`.`id` <=> 1 AND `users`.`name` <=> 'name')})
-            end
+              adapter_is :mysql do
+                sql.should be_like(%Q{(`users`.`id` <=> 1 AND `users`.`name` <=> 'name')})
+              end
 
-            adapter_is :sqlite3 do
-              sql.should be_like(%Q{("users"."id" <=> 1 AND "users"."name" <=> 'name')})
-            end
+              adapter_is :sqlite3 do
+                sql.should be_like(%Q{("users"."id" <=> 1 AND "users"."name" <=> 'name')})
+              end
 
-            adapter_is :postgresql do
-              sql.should be_like(%Q{("users"."id" <=> 1 AND "users"."name" <=> E'name')})
+              adapter_is :postgresql do
+                sql.should be_like(%Q{("users"."id" <=> 1 AND "users"."name" <=> E'name')})
+              end
             end
           end
         end
       end
-    end
 
-    describe '#to_sql' do
-      describe 'when relating two attributes' do
-        it 'manufactures sql with a binary operation' do
-          sql = ConcreteBinary.new(@attribute1, @attribute2).to_sql
+      describe '#to_sql' do
+        describe 'when relating two attributes' do
+          it 'manufactures sql with a binary operation' do
+            sql = ConcreteBinary.new(@attribute1, @attribute2).to_sql
 
-          adapter_is :mysql do
-            sql.should be_like(%Q{`users`.`id` <=> `users`.`name`})
-          end
+            adapter_is :mysql do
+              sql.should be_like(%Q{`users`.`id` <=> `users`.`name`})
+            end
 
-          adapter_is_not :mysql do
-            sql.should be_like(%Q{"users"."id" <=> "users"."name"})
+            adapter_is_not :mysql do
+              sql.should be_like(%Q{"users"."id" <=> "users"."name"})
+            end
           end
         end
-      end
 
-      describe 'when relating an attribute and a value' do
-        before do
-          @value = "1-asdf"
-        end
+        describe 'when relating an attribute and a value' do
+          before do
+            @value = "1-asdf"
+          end
 
-        describe 'when relating to an integer attribute' do
-          it 'formats values as integers' do
-            sql = ConcreteBinary.new(@attribute1, @value).to_sql
+          describe 'when relating to an integer attribute' do
+            it 'formats values as integers' do
+              sql = ConcreteBinary.new(@attribute1, @value).to_sql
 
-            adapter_is :mysql do
-              sql.should be_like(%Q{`users`.`id` <=> 1})
-            end
+              adapter_is :mysql do
+                sql.should be_like(%Q{`users`.`id` <=> 1})
+              end
 
-            adapter_is_not :mysql do
-              sql.should be_like(%Q{"users"."id" <=> 1})
+              adapter_is_not :mysql do
+                sql.should be_like(%Q{"users"."id" <=> 1})
+              end
             end
           end
-        end
 
-        describe 'when relating to a string attribute' do
-          it 'formats values as strings' do
-            sql = ConcreteBinary.new(@attribute2, @value).to_sql
+          describe 'when relating to a string attribute' do
+            it 'formats values as strings' do
+              sql = ConcreteBinary.new(@attribute2, @value).to_sql
 
-            adapter_is :mysql do
-              sql.should be_like(%Q{`users`.`name` <=> '1-asdf'})
-            end
+              adapter_is :mysql do
+                sql.should be_like(%Q{`users`.`name` <=> '1-asdf'})
+              end
 
-            adapter_is :sqlite3 do
-              sql.should be_like(%Q{"users"."name" <=> '1-asdf'})
-            end
+              adapter_is :sqlite3 do
+                sql.should be_like(%Q{"users"."name" <=> '1-asdf'})
+              end
 
-            adapter_is :postgresql do
-              sql.should be_like(%Q{"users"."name" <=> E'1-asdf'})
+              adapter_is :postgresql do
+                sql.should be_like(%Q{"users"."name" <=> E'1-asdf'})
+              end
             end
           end
         end

data/spec/arel/engines/sql/unit/predicates/equality_spec.rb

@@ -1,43 +1,60 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
-  describe Equality do
-    before do
-      @relation1 = Table.new(:users)
-      @relation2 = Table.new(:photos)
-      @attribute1 = @relation1[:id]
-      @attribute2 = @relation2[:user_id]
-    end
+  module Predicates
+    describe Equality do
+      before do
+        @relation1 = Arel::Table.new(:users)
+        @relation2 = Arel::Table.new(:photos)
+        @attribute1 = @relation1[:id]
+        @attribute2 = @relation2[:user_id]
+      end
 
-    describe '#to_sql' do
-      describe 'when relating to a non-nil value' do
-        it "manufactures an equality predicate" do
-          sql = Equality.new(@attribute1, @attribute2).to_sql
+      describe '#to_sql' do
+        describe 'when relating to a non-nil value' do
+          it "manufactures an equality predicate" do
+            sql = Equality.new(@attribute1, @attribute2).to_sql
 
-          adapter_is :mysql do
-            sql.should be_like(%Q{`users`.`id` = `photos`.`user_id`})
-          end
+            adapter_is :mysql do
+              sql.should be_like(%Q{`users`.`id` = `photos`.`user_id`})
+            end
 
-          adapter_is_not :mysql do
-            sql.should be_like(%Q{"users"."id" = "photos"."user_id"})
+            adapter_is_not :mysql do
+              sql.should be_like(%Q{"users"."id" = "photos"."user_id"})
+            end
           end
         end
-      end
 
-      describe 'when relation to a nil value' do
-        before do
-          @nil = nil
-        end
+        describe 'when relation to a nil value' do
+          before do
+            @nil = nil
+          end
+
+          it "manufactures an is null predicate" do
+            sql = Equality.new(@attribute1, @nil).to_sql
 
-        it "manufactures an is null predicate" do
-          sql = Equality.new(@attribute1, @nil).to_sql
+            adapter_is :mysql do
+              sql.should be_like(%Q{`users`.`id` IS NULL})
+            end
 
-          adapter_is :mysql do
-            sql.should be_like(%Q{`users`.`id` IS NULL})
+            adapter_is_not :mysql do
+              sql.should be_like(%Q{"users"."id" IS NULL})
+            end
           end
+        end
+
+        describe "when relating to a nil Value" do
+          it "manufactures an IS NULL predicate" do
+            value = nil.bind(@relation1)
+            sql = Equality.new(@attribute1, value).to_sql
+
+            adapter_is :mysql do
+              sql.should be_like(%Q{`users`.`id` IS NULL})
+            end
 
-          adapter_is_not :mysql do
-            sql.should be_like(%Q{"users"."id" IS NULL})
+            adapter_is_not :mysql do
+              sql.should be_like(%Q{"users"."id" IS NULL})
+            end
           end
         end
       end

data/spec/arel/engines/sql/unit/predicates/in_spec.rb

@@ -1,83 +1,104 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
-  describe In do
-    before do
-      @relation = Table.new(:users)
-      @attribute = @relation[:id]
-    end
+  module Predicates
+    describe In do
+      before do
+        @relation = Arel::Table.new(:users)
+        @attribute = @relation[:id]
+      end
 
-    describe '#to_sql' do
-      describe 'when relating to an array' do
-        describe 'when the array\'s elements are the same type as the attribute' do
-          before do
-            @array = [1, 2, 3]
+      describe '#to_sql' do
+        describe 'when relating to an array' do
+          describe 'when the array\'s elements are the same type as the attribute' do
+            before do
+              @array = [1, 2, 3]
+            end
+
+            it 'manufactures sql with a comma separated list' do
+              sql = In.new(@attribute, @array).to_sql
+
+              adapter_is :mysql do
+                sql.should be_like(%Q{`users`.`id` IN (1, 2, 3)})
+              end
+
+              adapter_is_not :mysql do
+                sql.should be_like(%Q{"users"."id" IN (1, 2, 3)})
+              end
+            end
           end
 
-          it 'manufactures sql with a comma separated list' do
-            sql = In.new(@attribute, @array).to_sql
+          describe 'when the array\'s elements are not same type as the attribute' do
+            before do
+              @array = ['1-asdf', 2, 3]
+            end
 
-            adapter_is :mysql do
-              sql.should be_like(%Q{`users`.`id` IN (1, 2, 3)})
+            it 'formats values in the array as the type of the attribute' do
+              sql = In.new(@attribute, @array).to_sql
+
+              adapter_is :mysql do
+                sql.should be_like(%Q{`users`.`id` IN (1, 2, 3)})
+              end
+
+              adapter_is_not :mysql do
+                sql.should be_like(%Q{"users"."id" IN (1, 2, 3)})
+              end
+            end
+          end
+
+          describe 'when the array is empty' do
+            before do
+              @array = []
             end
 
-            adapter_is_not :mysql do
-              sql.should be_like(%Q{"users"."id" IN (1, 2, 3)})
+            it 'manufactures sql with a comma separated list' do
+              sql = In.new(@attribute, @array).to_sql
+
+              adapter_is :mysql do
+                sql.should be_like(%Q{`users`.`id` IN (NULL)})
+              end
+
+              adapter_is_not :mysql do
+                sql.should be_like(%Q{"users"."id" IN (NULL)})
+              end
             end
           end
+
         end
 
-        describe 'when the array\'s elements are not same type as the attribute' do
+        describe 'when relating to a range' do
           before do
-            @array = ['1-asdf', 2, 3]
+            @range = 1..2
           end
 
-          it 'formats values in the array as the type of the attribute' do
-            sql = In.new(@attribute, @array).to_sql
+          it 'manufactures sql with a between' do
+            sql = In.new(@attribute, @range).to_sql
 
             adapter_is :mysql do
-              sql.should be_like(%Q{`users`.`id` IN (1, 2, 3)})
+              sql.should be_like(%Q{`users`.`id` BETWEEN 1 AND 2})
             end
 
             adapter_is_not :mysql do
-              sql.should be_like(%Q{"users"."id" IN (1, 2, 3)})
+              sql.should be_like(%Q{"users"."id" BETWEEN 1 AND 2})
             end
           end
         end
-      end
-
-      describe 'when relating to a range' do
-        before do
-          @range = 1..2
-        end
 
-        it 'manufactures sql with a between' do
-          sql = In.new(@attribute, @range).to_sql
+        describe 'when relating to a relation' do
+          it 'manufactures sql with a subselect' do
+            sql = In.new(@attribute, @relation).to_sql
 
-          adapter_is :mysql do
-            sql.should be_like(%Q{`users`.`id` BETWEEN 1 AND 2})
-          end
-
-          adapter_is_not :mysql do
-            sql.should be_like(%Q{"users"."id" BETWEEN 1 AND 2})
-          end
-        end
-      end
-
-      describe 'when relating to a relation' do
-        it 'manufactures sql with a subselect' do
-          sql = In.new(@attribute, @relation).to_sql
-
-          adapter_is :mysql do
-            sql.should be_like(%Q{
-              `users`.`id` IN (SELECT `users`.`id`, `users`.`name` FROM `users`)
-            })
-          end
+            adapter_is :mysql do
+              sql.should be_like(%Q{
+                `users`.`id` IN (SELECT `users`.`id`, `users`.`name` FROM `users`)
+              })
+            end
 
-          adapter_is_not :mysql do
-            sql.should be_like(%Q{
-              "users"."id" IN (SELECT "users"."id", "users"."name" FROM "users")
-            })
+            adapter_is_not :mysql do
+              sql.should be_like(%Q{
+                "users"."id" IN (SELECT "users"."id", "users"."name" FROM "users")
+              })
+            end
           end
         end
       end

data/spec/arel/engines/sql/unit/predicates/predicates_spec.rb

@@ -1,62 +1,64 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
-  describe Predicate do
-    before do
-      @relation = Table.new(:users)
-      @attribute1 = @relation[:id]
-      @attribute2 = @relation[:name]
-      @operand1 = Equality.new(@attribute1, 1)
-      @operand2 = Equality.new(@attribute2, "name")
-    end
+  module Predicates
+    describe Predicate do
+      before do
+        @relation = Arel::Table.new(:users)
+        @attribute1 = @relation[:id]
+        @attribute2 = @relation[:name]
+        @operand1 = Arel::Predicates::Equality.new(@attribute1, 1)
+        @operand2 = Arel::Predicates::Equality.new(@attribute2, "name")
+      end
 
-    describe "when being combined with another predicate with AND logic" do
-      describe "#to_sql" do
-        it "manufactures sql with an AND operation" do
-          sql = @operand1.and(@operand2).to_sql
+      describe "when being combined with another predicate with AND logic" do
+        describe "#to_sql" do
+          it "manufactures sql with an AND operation" do
+            sql = @operand1.and(@operand2).to_sql
 
-          adapter_is :mysql do
-            sql.should be_like(%Q{
-              (`users`.`id` = 1 AND `users`.`name` = 'name')
-            })
-          end
+            adapter_is :mysql do
+              sql.should be_like(%Q{
+                (`users`.`id` = 1 AND `users`.`name` = 'name')
+              })
+            end
 
-          adapter_is :sqlite3 do
-            sql.should be_like(%Q{
-              ("users"."id" = 1 AND "users"."name" = 'name')
-            })
-          end
+            adapter_is :sqlite3 do
+              sql.should be_like(%Q{
+                ("users"."id" = 1 AND "users"."name" = 'name')
+              })
+            end
 
-          adapter_is :postgresql do
-            sql.should be_like(%Q{
-              ("users"."id" = 1 AND "users"."name" = E'name')
-            })
+            adapter_is :postgresql do
+              sql.should be_like(%Q{
+                ("users"."id" = 1 AND "users"."name" = E'name')
+              })
+            end
           end
         end
       end
-    end
 
-    describe "when being combined with another predicate with OR logic" do
-      describe "#to_sql" do
-        it "manufactures sql with an OR operation" do
-          sql = @operand1.or(@operand2).to_sql
+      describe "when being combined with another predicate with OR logic" do
+        describe "#to_sql" do
+          it "manufactures sql with an OR operation" do
+            sql = @operand1.or(@operand2).to_sql
 
-          adapter_is :mysql do
-            sql.should be_like(%Q{
-              (`users`.`id` = 1 OR `users`.`name` = 'name')
-            })
-          end
+            adapter_is :mysql do
+              sql.should be_like(%Q{
+                (`users`.`id` = 1 OR `users`.`name` = 'name')
+              })
+            end
 
-          adapter_is :sqlite3 do
-            sql.should be_like(%Q{
-              ("users"."id" = 1 OR "users"."name" = 'name')
-            })
-          end
+            adapter_is :sqlite3 do
+              sql.should be_like(%Q{
+                ("users"."id" = 1 OR "users"."name" = 'name')
+              })
+            end
 
-          adapter_is :postgresql do
-            sql.should be_like(%Q{
-              ("users"."id" = 1 OR "users"."name" = E'name')
-            })
+            adapter_is :postgresql do
+              sql.should be_like(%Q{
+                ("users"."id" = 1 OR "users"."name" = E'name')
+              })
+            end
           end
         end
       end

data/spec/arel/engines/sql/unit/primitives/attribute_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', '..', '..', '..', '..', 'spec_helper')
+require 'spec_helper'
 
 module Arel
   describe Attribute do