arel-helpers 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5b9e21c4189a1c32c6361aca598fa70d942f5f2d
-  data.tar.gz: 10815ed87668b9fd619cfcdb83c4efef8ea0ad82
+  metadata.gz: 6356cdb2e00758c2e17276118d916f727a1be308
+  data.tar.gz: 26faaf1834fd66939b376ef0caa88f7e85d6bc41
 SHA512:
-  metadata.gz: ca0257e7a5fe7e7ca769fd4fb60ab7016f8fd6d7e520e65527b8522db0ab07afb41c3e92ae02f009c73bcf1e0ab93d939b4256e51fa40bc46b24a90656e4c72a
-  data.tar.gz: 3a5b57d717d31d94d87008fca7cab200d50dbfff13a25a2f9050c4c24365c4e6d8197f3e491180df7785ca24abc201b2440b7192f6ae2a1dfe142a8a63ff3ba2
+  metadata.gz: e07f4c676161cd241f861b48aef16411f262f09fc53d9773432e185804e062c41d117d196f553b2fb3fff834c42ec7fbd3e081ad42ed741a6ced87f66d7c1a73
+  data.tar.gz: 9a72da308ac57e7df7dab0fce3c2909d6478f8c96170ede5c98fcf940f51f415c529838150dca14fd83ced259846c84601d312fb406b59a1545d120c43fa46c1

data/History.txt

@@ -37,3 +37,7 @@
 == 2.3.0
 
 * Adding support for Rails 5 (@vkill #24, @camertron #26)
+
+== 2.4.0
+
+* Adding support for Rails 5.1 (@hasghari #30)

data/README.md

@@ -96,6 +96,23 @@ Post.joins(
 
 Easy peasy.
 
+Note that pretty much anything you can pass to ActiveRecord's `#join` method you can also pass to `#join_association`'s second argument. For example, you can pass a hash to indicate a set of nested associations:
+
+```ruby
+Post.joins(
+  ArelHelpers.join_association(Post, { comments: :author })
+)
+```
+
+This might execute the following query:
+
+```sql
+SELECT "posts".*
+FROM "posts"
+INNER JOIN "comments" ON "comments"."post_id" = "posts"."id"
+INNER JOIN "authors" ON "authors"."id" = "comments"."author_id"
+```
+
 `#join_association` also allows you to customize the join conditions via a block:
 
 ```ruby

data/lib/arel-helpers/join_association.rb

@@ -108,7 +108,7 @@ module ArelHelpers
         constraints = join_dependency.join_constraints([], join_type)
 
         binds = constraints.flat_map do |info|
-          prepared_binds = table.connection.prepare_binds_for_database(info.binds)
+          prepared_binds = info.binds.map(&:value_for_database)
           prepared_binds.map { |value| table.connection.quote(value) }
         end
 

data/lib/arel-helpers/version.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
 
 module ArelHelpers
-  VERSION = "2.3.0"
+  VERSION = '2.4.0'
 end

data/spec/env/migrations.rb

@@ -1,6 +1,8 @@
 # encoding: UTF-8
 
-class CreatePostsTable < ActiveRecord::Migration
+SuperClass = ActiveRecord::VERSION::MAJOR >= 5 && ActiveRecord::VERSION::MINOR >= 1 ? ActiveRecord::Migration[5.1] : ActiveRecord::Migration
+
+class CreatePostsTable < SuperClass
   def change
     create_table :posts do |t|
       t.column :title, :string
@@ -8,7 +10,7 @@ class CreatePostsTable < ActiveRecord::Migration
   end
 end
 
-class CreateCommentsTable < ActiveRecord::Migration
+class CreateCommentsTable < SuperClass
   def change
     create_table :comments do |t|
       t.references :post
@@ -16,7 +18,7 @@ class CreateCommentsTable < ActiveRecord::Migration
   end
 end
 
-class CreateAuthorsTable < ActiveRecord::Migration
+class CreateAuthorsTable < SuperClass
   def change
     create_table :authors do |t|
       t.references :comment
@@ -25,7 +27,7 @@ class CreateAuthorsTable < ActiveRecord::Migration
   end
 end
 
-class CreateFavoritesTable < ActiveRecord::Migration
+class CreateFavoritesTable < SuperClass
   def change
     create_table :favorites do |t|
       t.references :post
@@ -33,7 +35,7 @@ class CreateFavoritesTable < ActiveRecord::Migration
   end
 end
 
-class CreateCollabPostsTable < ActiveRecord::Migration
+class CreateCollabPostsTable < SuperClass
   def change
     create_table :collab_posts do |t|
       t.references :authors
@@ -41,13 +43,13 @@ class CreateCollabPostsTable < ActiveRecord::Migration
   end
 end
 
-class CreateCardsTable < ActiveRecord::Migration
+class CreateCardsTable < SuperClass
   def change
     create_table :cards
   end
 end
 
-class CreateCardLocationsTable < ActiveRecord::Migration
+class CreateCardLocationsTable < SuperClass
   def change
     create_table :card_locations do |t|
       t.references :location
@@ -56,13 +58,13 @@ class CreateCardLocationsTable < ActiveRecord::Migration
   end
 end
 
-class CreateLocationsTable < ActiveRecord::Migration
+class CreateLocationsTable < SuperClass
   def change
     create_table :locations
   end
 end
 
-class CreateCommunityTicketsTable < ActiveRecord::Migration
+class CreateCommunityTicketsTable < SuperClass
   def change
     create_table :community_tickets
   end

data/spec/join_association_spec.rb

@@ -29,6 +29,20 @@ describe ArelHelpers do
           'SELECT "posts".* FROM "posts" INNER JOIN "comments" ON "comments"."post_id" = "posts"."id" INNER JOIN "authors" ON "authors"."id" = "comments"."author_id"'
     end
 
+    it "should work for a nested hash of association names" do
+      Post
+        .joins(ArelHelpers.join_association(Post, { comments: :author }))
+        .to_sql.should ==
+          'SELECT "posts".* FROM "posts" INNER JOIN "comments" ON "comments"."post_id" = "posts"."id" INNER JOIN "authors" ON "authors"."id" = "comments"."author_id"'
+    end
+
+    it "should work with outer joins when given a nested hash of association names" do
+      Post
+        .joins(ArelHelpers.join_association(Post, { comments: :author }, Arel::Nodes::OuterJoin))
+        .to_sql.should ==
+          'SELECT "posts".* FROM "posts" LEFT OUTER JOIN "comments" ON "comments"."post_id" = "posts"."id" LEFT OUTER JOIN "authors" ON "authors"."id" = "comments"."author_id"'
+    end
+
     it "should be able to handle multiple associations" do
       Post.joins(ArelHelpers.join_association(Post, [:comments, :favorites])).to_sql.should ==
         'SELECT "posts".* FROM "posts" INNER JOIN "comments" ON "comments"."post_id" = "posts"."id" INNER JOIN "favorites" ON "favorites"."post_id" = "posts"."id"'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arel-helpers
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Cameron Dutro
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-24 00:00:00.000000000 Z
+date: 2017-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord