ardm 0.4.0.ar427 → 0.4.0

data/Gemfile

@@ -14,15 +14,14 @@ group :test do
 end
 
 group :ar do
-  gem 'activerecord', '= 4.2.7.1'
+  gem 'activerecord', '~> 4.0.0'
 end
 
 group :dm do
-  gem 'ardm-core', '~> 1.3'
+  gem 'dm-core', '~> 1.2'
   gem 'dm-sqlite-adapter', '~> 1.2'
-  # gem 'dm-types', '~> 1.2', git: "git://github.com/engineyard/dm-types.git", branch: "1.2-multijson"
-  gem "ardm-types", '~> 1.1'
+  gem 'dm-types', '~> 1.2', git: "git://github.com/engineyard/dm-types.git", branch: "1.2-multijson"
   gem 'dm-validations', '~> 1.2'
-  gem 'ardm-transactions', '~> 1.2'
-  gem 'ardm-migrations', '~> 1.3'
+  gem 'dm-transactions', '~> 1.2'
+  gem 'dm-migrations', '~> 1.2'
 end

data/lib/ardm/ar.rb

@@ -45,24 +45,3 @@ end
 ::ActiveRecord::Relation.class_eval do
   include Ardm::Ar::Relation
 end
-
-ActiveRecord::Scoping::Named::ClassMethods.class_eval do
-  def all(options = {})
-    scope_of_all = if current_scope
-                     current_scope.clone
-                   else
-                     default_scoped
-                   end
-    if options.any?
-      scope_of_all.all.all(options)
-    else
-      scope_of_all
-    end
-  end
-end
-
-# ActiveRecord::ConnectionAdapters::Column.class_eval do
-#   def default=(arg)
-#     @default = arg
-#   end
-# end

data/lib/ardm/ar/property.rb

@@ -113,61 +113,28 @@ module Ardm
         end
 
         def columns
-          @columns ||= _ardm_load_columns(super)
+          @columns ||= _ardm_load_columns
         end
 
-        def _ardm_load_columns(ar_columns)
-          to_return = ar_columns
-          properties.each do |property|
+        def _ardm_load_columns
+          properties.map do |property|
             sql_type = connection.type_to_sql(
               property.dump_as.name.to_sym,
               property.options[:limit],
               property.options[:precision],
               property.options[:scale]
             )
-            if column = ar_columns.detect{|c| c.name.to_s == property.name.to_s}
-              #TODO: property.key?
-              err_prefix = "WARNING: DM/AR mismatch for #{self.name}.#{property.name.to_s} on"
-
-              #TODO: do some fuzzy matching so we only get warnings when there is a clear conflict:
-              # if column.sql_type != sql_type
-              # puts "#{err_prefix} sql_type #{sql_type} vs #{column.sql_type}"
-              # end
-
-              if column.null != property.allow_nil?
-                puts "#{err_prefix} allow_nil #{property.allow_nil?} vs #{column.null}"
-              end
 
-              #TODO: is this needed, or does default-setting get handled elsewhere?
-              # if column.default != property.default
-              #   puts "#{err_prefix} default #{property.default} vs #{column.default}"
-              # end
-              # column.default = property.default
+            column = ::ActiveRecord::ConnectionAdapters::Column.new(
+              property.field.to_s, #property.name.to_s,
+              nil,#property.dump(property.default),
+              sql_type,
+              property.allow_nil?
+            )
 
-            else
-              puts "WARNING: DM defines property #{self.name}.#{property.name.to_s} but AR found no corresponding column"
-            end
+            column.primary = property.key?
+            column
           end
-          to_return
-
-          # WAS:
-          # sql_type = connection.type_to_sql(
-          #   property.dump_as.name.to_sym,
-          #   property.options[:limit],
-          #   property.options[:precision],
-          #   property.options[:scale]
-          # )
-          #
-          # column = ::ActiveRecord::ConnectionAdapters::Column.new(
-          #   property.field.to_s, #property.name.to_s, #name
-          #   nil,#property.dump(property.default), #default
-          #   property.cast_type,
-          #   sql_type, #sql_type
-          #   property.allow_nil? #null
-          # )
-          #
-          # column.primary = property.key?
-          # column
         end
 
         # Hook into the query system when we would be finding composed_of
@@ -342,9 +309,6 @@ module Ardm
           end
           read_attribute property.field
         end
-      rescue => e
-        puts "ERROR on attribute_get #{self.class.name}.#{name}"
-        raise e
       end
 
       # This not the same as write_attribute in AR

data/lib/ardm/ar/relation.rb

@@ -11,19 +11,9 @@ module Ardm
         alias_method :update_without_ardm, :update
         alias_method :first_without_ardm, :first
         alias_method :first_without_ardm!, :first!
-        alias_method :equal_without_ardm, :==
-        alias_method :method_missing_without_ardm, :method_missing
 
         # we need to overrite the implementation in the class
         class_eval do
-          def ==(other)
-            result = self.equal_without_ardm(other)
-            if !result && other.is_a?(Relation)
-              result ||= self.equal_without_ardm(other.to_a)
-            end
-            result
-          end
-
           def update(*a)
             if a.size == 1
               # need to translate attributes
@@ -70,20 +60,15 @@ module Ardm
           def first_or_initialize(attributes = nil, options = {}, &block)
             all(attributes).first || all(attributes).create(options, &block)
           end
-
-          def method_missing(method, *args, &block)
-            if assoc = self.model.reflect_on_association(method)
-              puts "WARNING: suspected query chain (not supported) a #{self.model.name} #{assoc.macro} '#{method}'"
-              puts caller[0,3]
-              if ENV["RAISE_ON_QUERY_CHAIN_CALLS"]
-                raise "WARNING: suspected query chain (not supported) a #{self.model.name} #{assoc.macro} '#{method}'"
-              end
-            end
-            method_missing_without_ardm(method, *args, &block)
-          end
         end
       end
 
+      def method_missing(meth, *a, &b)
+        super
+      rescue => e
+        raise NoMethodError, "Relation chain? #{self}.#{meth}\n#{e}"
+      end
+
       def all(options={})
         apply_finder_options(options)
       end
@@ -116,33 +101,21 @@ module Ardm
         end
 
         conditions.each do |key, value|
-          if value.is_a?(ActiveRecord::Relation)
-            value = value.to_a
-          end
-          key_to_reflect_on = key
-          if key.is_a?(Ardm::Query::Operator)
-            key_to_reflect_on = key.target
-          end
-          if assoc = relation.reflect_on_association(key_to_reflect_on)
+          if assoc = relation.reflect_on_association(key)
             conditions.delete(key)
             # strip out assocations
             case assoc.macro
             when :belongs_to
-              if key.is_a?(Ardm::Query::Operator)
-                #TODO: might not work for all types of value... but works when value is nil (existing DM specs drive development)
-                relation = key.to_arel(self, value).scope
-              else
-                id = value.is_a?(Hash) ? value.with_indifferent_access[:id] : value
-                relation = if value.is_a?(::ActiveRecord::Relation)
-                             if value.values.empty?
-                               relation.where.not(assoc.foreign_key => nil)
-                             else
-                               relation.where(assoc.foreign_key => value)
-                             end
+              id = value.is_a?(Hash) ? value.with_indifferent_access[:id] : value
+              relation = if value.is_a?(::ActiveRecord::Relation)
+                           if value.values.empty?
+                             relation.where.not(assoc.foreign_key => nil)
                            else
-                             relation.where(assoc.foreign_key => id)
+                             relation.where(assoc.foreign_key => value)
                            end
-              end
+                         else
+                           relation.where(assoc.foreign_key => id)
+                         end
             when :has_one
               foreign_class = assoc.options[:class_name].constantize
               foreign_key   = assoc.foreign_key
@@ -154,47 +127,21 @@ module Ardm
               end
 
               relation = if value.is_a?(::ActiveRecord::Base)
-                           relation.where(parent_key => value.send(foreign_key))
+                           relation.where(parent_key => value.send(assoc.foreign_key))
                          elsif value.is_a?(::ActiveRecord::Relation)
                            relation.where(parent_key => value.select(foreign_key))
                          elsif value.nil?
-                           if key.is_a?(Ardm::Query::Operator) && (key.operator == :not_eq)
-                             relation.where(parent_key => foreign_class.select(foreign_key).compact.map(&foreign_key).to_a)
-                           else
-                             relation.where.not(parent_key => foreign_class.select(foreign_key).compact.map(&foreign_key).to_a)
-                           end
-                           #should EQ:
-                           # relation.select{|o| o.send(assoc.name) == value}
-                         elsif value.is_a?(::Array) && value.first.is_a?(::ActiveRecord::Base)
-                           foreign_key_values = value.map(&foreign_key.to_sym)
-                           relation.where(parent_key => foreign_key_values)
+                           relation.where.not(parent_key => foreign_class.select(foreign_key).where.not(foreign_key => value))
                          else
                            relation.where(parent_key => foreign_class.select(foreign_key).where(value))
                          end
             when :has_many
-              if assoc.options[:through]
-                raise "Unsupported query on has_many through (#{options.inspect})"
-              end
-              foreign_class = assoc.options[:class_name] && assoc.options[:class_name].constantize
+              foreign_class = assoc.options[:class_name].constantize
               foreign_key   = assoc.foreign_key
               parent_key    = assoc.options[:child_key] || klass.primary_key
 
-              relation = if value.is_a?(::ActiveRecord::Base)
-                           relation.where(id: foreign_class.where(parent_key => value.send(parent_key)).map(&foreign_key))
-                         elsif value.is_a?(Hash)
-                           relation.where(id: foreign_class.where(parent_key => value[parent_key.to_s]).map(&foreign_key))
-                         elsif value.is_a?(::ActiveRecord::Relation)
-                           relation.where(id: foreign_class.where(parent_key => value.select(parent_key).to_a).map(&foreign_key))
-                         elsif value.is_a?(Array)
-                           relation.where(id: foreign_class.where(parent_key => value.map{|v| v.send(parent_key)}).map(&foreign_key))
-                         elsif value.nil?
-                           raise "Unsupported query on has_many (#{options.inspect})"
-                           #better to fail than return the wrong thing
-                           # if key.is_a?(Ardm::Query::Operator) && (key.operator == :not_eq)
-                           #   relation.where(parent_key => foreign_class.select(foreign_key).compact.map(&foreign_key).to_a)
-                           # else
-                           #   relation.where.not(parent_key => foreign_class.select(foreign_key).compact.map(&foreign_key).to_a)
-                           # end
+              relation = if value.is_a?(::ActiveRecord::Relation)
+                           relation.where(foreign_key => value)
                          else
                            relation.where(parent_key => foreign_class.select(foreign_class.primary_key).where.not(foreign_key => value))
                          end
@@ -247,15 +194,6 @@ module Ardm
         end
       end
 
-      def query
-        self.to_sql
-      end
-
-      def ==(other)
-        puts "COMPARING to #{other}"
-        super(other)
-      end
-
       def destroy!
         delete_all
       end

data/lib/ardm/property/enum.rb

@@ -9,8 +9,6 @@ module Ardm
       load_as ::Object
       dump_as ::Integer
 
-      class InvalidValueError < StandardError; end
-
       def initialize(model, name, options = {})
         @flag_map = {}
 
@@ -27,18 +25,14 @@ module Ardm
       end
 
       def load(value)
-        flag_map[value.to_i] || value
+        flag_map[value.to_i]
       end
 
       def dump(value)
-        result =  case value
-                  when ::Array then value.collect { |v| dump(v) }
-                  else              flag_map.invert[typecast(value)]
-                  end
-        if value && !result
-          raise InvalidValueError.new("Invalid value for ENUM #{self.model.name}.#{name}, given: #{value}")
+        case value
+        when ::Array then value.collect { |v| dump(v) }
+        else              flag_map.invert[typecast(value)]
         end
-        result
       end
 
       def typecast(value)

data/lib/ardm/version.rb

@@ -1,3 +1,3 @@
 module Ardm
-  VERSION = '0.4.0.ar427'
+  VERSION = '0.4.0'
 end

data/spec/integration/enum_spec.rb

@@ -57,13 +57,22 @@ try_spec do
 
     describe 'with value unknown to enumeration property' do
       before do
-        @resource = Ardm::Fixtures::Ticket.new
+        @resource = Ardm::Fixtures::Ticket.new(:status => :undecided)
+        @resource.valid?
       end
 
-      it "raises" do
-        expect { @resource.status = :undecided }.to(raise_error(Ardm::Property::Enum::InvalidValueError) do |error|
-          expect(error.message).to eq("Invalid value for ENUM Ardm::Fixtures::Ticket.status, given: undecided")
-        end)
+      # TODO: consider sharing shared spec exampels with dm-validations,
+      #       which has 'invalid model' shared group
+      it 'is invalid (auto validation for :within kicks in)' do
+        expect(@resource).not_to be_valid
+      end
+
+      it 'has errors' do
+        expect(@resource.errors).not_to be_empty
+      end
+
+      it 'has a meaningful error message on invalid property' do
+        expect(@resource.errors[:status]).to include('must be one of unconfirmed, confirmed, assigned, resolved, not_applicable')
       end
     end
   end

data/spec/integration/ip_address_spec.rb

@@ -5,10 +5,6 @@ try_spec do
   require './spec/fixtures/network_node'
 
   describe Ardm::Fixtures::NetworkNode do
-    before do
-      skip "IPAddress property not working"
-    end
-
     def run_ipv4
       be_runs_ipv4
     end

data/spec/shared/finder_shared.rb

@@ -25,9 +25,9 @@ shared_examples 'Finder Interface' do
     skip(message) if condition
   end
 
-  # it 'should be Enumerable', :dm do
-  #   expect(@articles).to be_kind_of(Enumerable)
-  # end
+  it 'should be Enumerable', :dm do
+    expect(@articles).to be_kind_of(Enumerable)
+  end
 
   [ :[], :slice ].each do |method|
     it { expect(@articles).to respond_to(method) }
@@ -60,7 +60,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should return a Collection', :dm do
-          skip "doesn't return a collection anymore..."
           expect(@return).to be_kind_of(Ardm::Collection)
           @return.should be_kind_of(Ardm::Collection)
         end
@@ -70,7 +69,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should scope the Collection', :dm do
-          skip "can't call reload on a non-collection"
           expect(@resources.reload).to eq(@copy.entries.send(method, 5, 5))
         end
       end
@@ -81,7 +79,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should return a Collection', :dm do
-          skip "doesn't return a collection anymore..."
           expect(@return).to be_kind_of(Ardm::Collection)
         end
 
@@ -90,7 +87,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should scope the Collection', :dm do
-          skip "can't call reload on a non-collection"
           expect(@resources.reload).to eq(@copy.entries.send(method, 5..10))
         end
       end
@@ -113,7 +109,6 @@ shared_examples 'Finder Interface' do
 
       describe 'with a negative offset and length' do
         before do
-          skip "doesn't return a collection anymore..."
           @return = @resources = @articles.send(method, -5, 5)
         end
 
@@ -126,7 +121,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should scope the Collection', :dm do
-          skip "can't call reload on a non-collection"
           expect(@resources.reload).to eq(@copy.entries.send(method, -5, 5))
         end
       end
@@ -137,7 +131,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should return a Collection', :dm do
-          skip "doesn't return a collection anymore..."
           expect(@return).to be_kind_of(Ardm::Collection)
         end
 
@@ -146,7 +139,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should scope the Collection', :dm do
-          skip "can't call reload on a non-collection"
           expect(@resources.reload).to eq(@copy.entries.send(method, -5..-2))
         end
       end
@@ -157,7 +149,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should return a Collection', :dm do
-          skip "doesn't return a collection anymore..."
           expect(@return).to be_kind_of(Ardm::Collection)
         end
 
@@ -188,12 +179,10 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should return a Collection' do
-          skip "doesn't return a collection anymore..."
           expect(@return).to be_kind_of(Ardm::Collection)
         end
 
         it 'should be empty' do
-          skip "it's nil"
           expect(@return).to be_empty
         end
       end
@@ -204,12 +193,10 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should return a Collection' do
-          skip "doesn't return a collection anymore..."
           expect(@return).to be_kind_of(Ardm::Collection)
         end
 
         it 'should be empty' do
-          skip "it's nil"
           expect(@return).to be_empty
         end
       end
@@ -315,7 +302,6 @@ shared_examples 'Finder Interface' do
 
     describe 'with a query that is out of range', :dm do
       it 'should raise an exception' do
-        skip "doesn't raise"
         expect {
           @articles.all(:limit => 10).all(:offset => 10)
         }.to raise_error(RangeError, 'offset 10 and limit 0 are outside allowed range')
@@ -337,7 +323,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -356,7 +341,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -366,6 +350,7 @@ shared_examples 'Finder Interface' do
           @collection = @article_model.all(
             Hash[ @article_model.key.zip(@original.key) ]
           )
+
           @return = @articles.all(:original => @collection)
         end
 
@@ -378,7 +363,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
 
@@ -398,7 +382,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should not have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).not_to be_valid
         end
       end
@@ -417,7 +400,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
 
@@ -446,7 +428,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
 
@@ -463,7 +444,6 @@ shared_examples 'Finder Interface' do
 
       describe 'with a Hash' do
         before do
-          skip "query with Hash is not currently supported"
           @return = @articles.all(:previous => @new.attributes)
         end
 
@@ -476,7 +456,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -495,7 +474,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -518,7 +496,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -537,7 +514,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should not have a valid query', :dm do
-          skip "query is just a string now..."
           expect(@return.query).not_to be_valid
         end
       end
@@ -562,7 +538,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
 
@@ -571,7 +546,6 @@ shared_examples 'Finder Interface' do
           # ar:
           # SELECT "articles".* FROM "articles" WHERE ("articles"."original_id" IS NOT NULL)
           # SELECT "articles".* FROM "articles" WHERE ("articles"."id" NOT IN (SELECT original_id FROM "articles" WHERE ("articles"."original_id" IS NOT NULL)))
-          skip "TODO: come back here"
           puts "@return:#{@return.to_sql}"
           puts "negated:#{@articles.all(:previous.not => @article_model.all(:original.not => nil)).to_sql}"
           expect(@return).to eq(@articles.all(:previous.not => @article_model.all(:original.not => nil)))
@@ -592,7 +566,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
 
@@ -616,12 +589,11 @@ shared_examples 'Finder Interface' do
           expect(@return).to be_kind_of(Ardm::Collection)
         end
 
-        it 'should be expected Resources', focus: true do
+        it 'should be expected Resources' do
           expect(@return).to eq([ @article ])
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -640,7 +612,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -663,7 +634,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -682,14 +652,12 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should not have a valid query' do
-          skip "valid can't be checked on query anymore.."
           expect(@return.query).not_to be_valid
         end
       end
 
       describe 'with a nil value' do
         before do
-          skip "nil on has_many not supported (explicitly)"
           @return = @articles.all(:revisions => nil)
         end
 
@@ -709,7 +677,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
 
@@ -720,7 +687,6 @@ shared_examples 'Finder Interface' do
 
       describe 'with a negated nil value' do
         before do
-          skip "nil on has_many not supported (explicitly)"
           @return = @articles.all(:revisions.not => nil)
         end
 
@@ -733,7 +699,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
 
@@ -745,7 +710,6 @@ shared_examples 'Finder Interface' do
 
     describe 'with a query using a m:m relationship' do
       before do
-        skip "has_many through not supported (explicitly)"
         @publication = @article.publications.create(:name => 'Ardm Now')
       end
 
@@ -765,7 +729,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -786,7 +749,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -811,7 +773,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
       end
@@ -850,7 +811,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
 
@@ -875,7 +835,6 @@ shared_examples 'Finder Interface' do
         end
 
         it 'should have a valid query', :dm do
-          skip "undefined method `valid?' for #<String"
           expect(@return.query).to be_valid
         end
 
@@ -936,7 +895,7 @@ shared_examples 'Finder Interface' do
       @copy.to_a
     end
 
-    it { is_expected.to equal(@articles.to_a) }
+    it { is_expected.to equal(@articles) }
 
     it { expect(method(:subject)).to change { yields.dup }.from([]).to(@copy.to_a) }
   end
@@ -944,9 +903,6 @@ shared_examples 'Finder Interface' do
   it { expect(@articles).to respond_to(:fetch) }
 
   describe '#fetch' do
-    before do
-      skip "Who uses fetch anyway..."
-    end
     subject { @articles.fetch(*args, &block) }
 
     let(:block) { nil }
@@ -998,7 +954,6 @@ shared_examples 'Finder Interface' do
 
     describe 'with a belongs_to relationship method' do
       before do
-        skip "rspec doens't know what rescue_if means.."
         rescue_if 'Model#method_missing should delegate to relationships', @articles.kind_of?(Class) do
           @articles.create(:body => 'Another Article', :original => @original)
 
@@ -1033,7 +988,6 @@ shared_examples 'Finder Interface' do
 
       describe 'with no arguments' do
         before do
-          skip "query chains not supported"
           @return = @articles.previous
         end
 
@@ -1053,7 +1007,6 @@ shared_examples 'Finder Interface' do
 
       describe 'with arguments' do
         before do
-          skip "query chain not supported"
           @return = @articles.previous(:fields => [ :id ])
         end
 
@@ -1093,7 +1046,6 @@ shared_examples 'Finder Interface' do
 
       describe 'with no arguments' do
         before do
-          skip "query chain not supported"
           @return = @collection = @articles.revisions
         end
 
@@ -1112,7 +1064,6 @@ shared_examples 'Finder Interface' do
 
       describe 'with arguments' do
         before do
-          skip "query chain not supported"
           @return = @collection = @articles.revisions(:fields => [ :id ])
         end
 
@@ -1168,7 +1119,6 @@ shared_examples 'Finder Interface' do
 
       describe 'with arguments' do
         before do
-          skip "query chain not supported"
           @return = @collection = @articles.publications(:fields => [ :id ])
         end
 

metadata

@@ -1,8 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: ardm
 version: !ruby/object:Gem::Version
-  version: 0.4.0.ar427
-  prerelease: 6
+  version: 0.4.0
+  prerelease: 
 platform: ruby
 authors:
 - Martin Emde
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-19 00:00:00.000000000 Z
+date: 2015-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -377,9 +377,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
-  - - ! '>'
+  - - ! '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23.2
@@ -387,4 +387,3 @@ signing_key:
 specification_version: 3
 summary: ActiveRecord plugin to provide a smooth migration from DataMapper to ActiveRecord
 test_files: []
-has_rdoc: