ardm-validations 1.2.0

data/spec/integration/acceptance_validator/spec_helper.rb

@@ -0,0 +1,7 @@
+# put validator specific fixture models and helpers here
+#
+# make sure you check out spec/fixtures to see fixture models
+# already written
+#
+# DataMapper developers feels strongly against foobars in the spec
+# suite

data/spec/integration/automatic_validation/custom_messages_for_inferred_validation_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+require 'integration/automatic_validation/spec_helper'
+
+describe 'Inferred validations' do
+  it "allow overriding a single error message" do
+    custom_boat = Class.new do
+      include DataMapper::Resource
+
+      def self.name
+        'Boat'
+      end
+
+      property :id,   DataMapper::Property::Serial
+      property :name, String, :required => true, :message => "This boat must have name"
+    end
+    boat = custom_boat.new
+    boat.should_not be_valid
+    boat.errors.on(:name).should == [ 'This boat must have name' ]
+  end
+
+  it "should have correct error messages" do
+    custom_boat = Class.new do
+      include DataMapper::Resource
+
+      def self.name
+        'Boat'
+      end
+
+      property :id,   DataMapper::Property::Serial
+      property :name, String, :required => true, :length => 5..20, :format => /^[a-z]+$/,
+               :messages => {
+                 :presence => "This boat must have name",
+                 :length => "Name must have at least 4 and at most 20 chars",
+                 :format => "Please use only small letters"
+               }
+    end
+
+    boat = custom_boat.new
+    boat.should_not be_valid
+    boat.errors.on(:name).should == [ 'This boat must have name' ]
+
+    boat.name = "%%"
+    boat.should_not be_valid
+    boat.errors.on(:name).should == [
+      'Name must have at least 4 and at most 20 chars',
+      'Please use only small letters',
+    ]
+
+    boat.name = "%%asd"
+    boat.should_not be_valid
+    boat.errors.on(:name).should == [ 'Please use only small letters' ]
+
+    boat.name = "superboat"
+    boat.should be_valid
+    boat.errors.on(:name).should be_nil
+  end
+end

data/spec/integration/automatic_validation/disabling_inferred_validation_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+require 'integration/automatic_validation/spec_helper'
+
+describe "A class with inferred validations disabled for all properties with an option" do
+  before :all do
+    @klass = Class.new do
+      include DataMapper::Resource
+
+      def self.name
+        'InferredValidation'
+      end
+
+      property :id,   DataMapper::Property::Serial,                     :auto_validation => false
+      property :name, String,                        :required => true, :auto_validation => false
+      property :bool, DataMapper::Property::Boolean, :required => true, :auto_validation => false
+    end
+
+    @model = @klass.new
+  end
+
+  describe "when instantiated w/o any attributes" do
+    it_should_behave_like "valid model"
+  end
+end
+
+
+describe "A class with inferred validations disabled for all properties with a block" do
+  before :all do
+    @klass = Class.new do
+      include DataMapper::Resource
+
+      def self.name
+        'InferredValidation'
+      end
+
+      without_auto_validations do
+        property :id,   DataMapper::Property::Serial
+        property :name, String,                        :required => true
+        property :bool, DataMapper::Property::Boolean, :required => true
+      end
+    end
+
+    @model = @klass.new
+  end
+
+  describe "when instantiated w/o any attributes" do
+    it_should_behave_like "valid model"
+  end
+end

data/spec/integration/automatic_validation/inferred_boolean_properties_validation_spec.rb

@@ -0,0 +1,100 @@
+require 'spec_helper'
+require 'integration/automatic_validation/spec_helper'
+
+describe "A model with a Boolean property" do
+  before :all do
+    @model = HasNullableBoolean.new(:id => 1)
+  end
+
+  describe "assigned a true" do
+    before :all do
+      @model.bool = true
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "assigned a false" do
+    before :all do
+      @model.bool = false
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "assigned a nil" do
+    before :all do
+      @model.bool = nil
+    end
+
+    it_should_behave_like "valid model"
+  end
+end
+
+describe "A model with a required Boolean property" do
+  before :all do
+    @model = HasRequiredBoolean.new(:id => 1)
+  end
+
+  describe "assigned a true" do
+    before :all do
+      @model.bool = true
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "assigned a false" do
+    before :all do
+      @model.bool = false
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "assigned a nil" do
+    before :all do
+      @model.bool = nil
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has a meaningful error message" do
+      @model.errors.on(:bool).should == [ 'Bool must not be nil' ]
+    end
+  end
+end
+
+describe "A model with a required paranoid Boolean property" do
+  before :all do
+    @model = HasRequiredParanoidBoolean.new(:id => 1)
+  end
+
+  describe "assigned a true" do
+    before :all do
+      @model.bool = true
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "assigned a false" do
+    before :all do
+      @model.bool = false
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "assigned a nil" do
+    before :all do
+      @model.bool = nil
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has a meaningful error message" do
+      @model.errors.on(:bool).should == [ 'Bool must not be nil' ]
+    end
+  end
+end

data/spec/integration/automatic_validation/inferred_float_property_validation_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+require 'integration/automatic_validation/spec_helper'
+
+
+{ :float => Float, :big_decimal => BigDecimal }.each do |column, type|
+  describe "#{type} property" do
+    before :all do
+      SailBoat.auto_migrate!
+
+      @model = SailBoat.new(:id => 1)
+    end
+
+    describe "with an integer value" do
+      before :all do
+        @model.attributes = {column => 1}
+      end
+
+      it_should_behave_like "valid model"
+    end
+
+    describe "with a float value" do
+      before :all do
+        @model.attributes = {column => 1.0}
+      end
+
+      it_should_behave_like "valid model"
+    end
+
+    describe "with a BigDecimal value" do
+      before :all do
+        @model.attributes = {column => BigDecimal('1')}
+      end
+
+      it_should_behave_like "valid model"
+    end
+
+    describe "with an uncoercible value" do
+      before :all do
+        @model.attributes = {column => "foo"}
+      end
+
+      it_should_behave_like "invalid model"
+    end
+  end
+end

data/spec/integration/automatic_validation/inferred_format_validation_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+require 'integration/automatic_validation/spec_helper'
+
+describe 'SailBoat', "with a :format option on a property" do
+  before :all do
+    SailBoat.auto_migrate!
+
+    @model = SailBoat.new
+    @model.should be_valid_for_format_test
+  end
+
+  describe "and value that matches the format" do
+    before :all do
+      @model.code = 'A1234'
+    end
+
+    it "passes inferred format validation" do
+      @model.should be_valid_for_format_test
+    end
+  end
+
+  describe "and value that DOES NOT match the format" do
+    before :all do
+      @model.code = 'BAD CODE'
+    end
+
+    it "does not pass inferred format validation" do
+      @model.should_not be_valid_for_format_test
+    end
+
+    it "has a meaningful error message" do
+      @model.errors.on(:code).should == [ 'Code has an invalid format' ]
+    end
+  end
+end

data/spec/integration/automatic_validation/inferred_integer_properties_validation_spec.rb

@@ -0,0 +1,70 @@
+require 'spec_helper'
+require 'integration/automatic_validation/spec_helper'
+
+describe "A model with an Integer property" do
+  before :all do
+    SailBoat.auto_migrate!
+
+    @model = SailBoat.new
+  end
+
+  # success case
+  describe "assigned to an integer" do
+    before :all do
+      @model.id = 1
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "assigned a value coercible into an integer" do
+    before :all do
+      @model.id = 1.0
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "assigned a value not coercible into an integer" do
+    before :all do
+      @model.id = "foo"
+    end
+
+    it "is invalid" do
+      @model.should_not be_valid
+    end
+
+    it "has a meaningful default error message" do
+      @model.errors.on(:id).should == [ 'Id must be an integer' ]
+    end
+  end
+
+  describe "assigned to a too-small integer" do
+    before :all do
+      @model.id = 0
+    end
+
+    it "is invalid" do
+      @model.should_not be_valid
+    end
+
+    it "has a meaningful default error message" do
+      @model.errors.on(:id).should == [ 'Id must be greater than or equal to 1' ]
+    end
+  end
+
+  describe "assigned to a too-large integer" do
+    before :all do
+      @model.id = 11
+    end
+
+    it "is invalid" do
+      @model.should_not be_valid
+    end
+
+    it "has a meaningful default error message" do
+      @model.errors.on(:id).should == [ 'Id must be less than or equal to 10' ]
+    end
+  end
+
+end

data/spec/integration/automatic_validation/inferred_length_validation_spec.rb

@@ -0,0 +1,142 @@
+require 'spec_helper'
+require 'integration/automatic_validation/spec_helper'
+
+describe 'SailBoat' do
+  before :all do
+    SailBoat.auto_migrate!
+
+    @model      = SailBoat.new(:id => 1)
+    @model.should be_valid_for_length_test_1
+  end
+
+
+  describe "with a nil value on property that allows nil" do
+    before :all do
+      @model.allow_nil = nil
+    end
+
+    it "is valid" do
+      @model.should be_valid_for_nil_test
+    end
+  end
+
+
+  describe "with 11 characters long description" do
+    before :all do
+      @model.description = 'ABCDEFGHIJK' #11
+    end
+
+    # validates_length_of is inferred from property's :length option
+    it "is invalid" do
+      @model.should_not be_valid_for_length_test_1
+      @model.errors.on(:description).should == [ 'Description must be at most 10 characters long' ]
+    end
+  end
+
+
+  describe "with 9 characters long description" do
+    before :all do
+      @model.description = 'ABCDEFGHI' # 9
+    end
+
+    # validates_length_of is inferred from property's :length option
+    it_should_behave_like "valid model"
+  end
+
+  describe "with 2 character long note" do
+    before :all do
+      @model = SailBoat.new(:notes => "AB")
+    end
+
+    it "is valid" do
+      @model.should be_valid_for_length_test_2
+    end
+  end
+
+  describe "with 10 character long note" do
+    before :all do
+      @model = SailBoat.new(:notes => "ABCDEFGHIJ")
+    end
+
+    it "is valid" do
+      @model.should be_valid_for_length_test_2
+    end
+  end
+
+  describe "with 11 character long note" do
+    before :all do
+      @model = SailBoat.new(:notes => "ABCDEFGHIJK")
+    end
+
+    it "is invalid" do
+      @model.should_not be_valid_for_length_test_2
+    end
+
+    it "has a meaningful error message" do
+      @model.errors.on(:notes).should  == [ 'Notes must be between 2 and 10 characters long' ]
+    end
+  end
+end
+
+
+
+describe 'DataMapper::Validations::Fixtures::SmsMessage' do
+  before :all do
+    DataMapper::Validations::Fixtures::SmsMessage.auto_migrate!
+
+    @model = DataMapper::Validations::Fixtures::SmsMessage.new(:id => 10)
+  end
+
+  describe "with 2 character long note" do
+    before :all do
+      @model.body = "ab"
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "with 10 character long note" do
+    before :all do
+      @model.body = "ABCDEFGHIJ"
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "with 499 character long note" do
+    before :all do
+      @model.body = "a" * 499
+    end
+
+    it_should_behave_like "valid model"
+  end
+
+  describe "with 503 character long note" do
+    before :all do
+      @model.body = "a" * 503
+    end
+
+    it_should_behave_like "invalid model"
+
+    it "has a meaningful error message" do
+      @model.errors.on(:body).should == [ 'Body must be between 1 and 500 characters long' ]
+    end
+  end
+
+  describe 'with an infinitely long note' do
+    before do
+      @original = @model.class.properties[:body]
+    end
+
+    after do
+      @model.class.property(@original.name, @original.class, @original.options)
+    end
+
+    it "should raise when trying to set the upper bound of a property length range to Infinity" do
+      expected_msg = "Infinity is no valid upper bound for a length range"
+      lambda {
+        @model.class.property :body, String, :length => (1..1.0/0)
+      }.should raise_error(ArgumentError, expected_msg)
+    end
+  end
+end