arclight 1.0.0.beta2 → 1.0.0.beta4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b1390f6e3757bd6b696874a8eb4e02c06e31a3c51d03a85bb25880e6536133fd
-  data.tar.gz: e55f6e430f6b88974ca1c73b8353fe2869936b43c784027fb7c443eebce94170
+  metadata.gz: de99e4c2ae0648272400bc3f6e1ebc44d72c4eba1dd5a5da249c24cc3c81fbd9
+  data.tar.gz: 223999c19a620b8dfbabdf237799f2284aa45ca7eccfc2a9c78f9b3afd1454e2
 SHA512:
-  metadata.gz: d685048894b2c9ef5821c845c1630e8b375ccb9192cff406a1d58fc38475f07b03055c28c9d1568489a6bbd8c68ba856f359feb780d3a4fe4bba0355e9994d41
-  data.tar.gz: 2a3593117293b05a325d140a58f60cdfd34218b40222f7a13ccf7f9c1d62a07a244e08ee894fd5b991efa0d2da6c7521c8fde8e8fb5fa33eec62529e2ca1cb6a
+  metadata.gz: dffd784bd5b96d60bc8ff647330ce887347437b22e6fdf3b02dd918bd94c9159f340491a47c41c12367d3681d749501992d1e00155477e152f2c9f4c9dbb631e
+  data.tar.gz: 56ec25a1e40465b4ecee490243da9959c5559a1060813e8a5a579ea1275950f9d07b5222f378820ea584b7a922b0b00249496d1e6a4c8272eb2c1dbcee38d222

data/.github/workflows/ruby.yml

@@ -13,7 +13,6 @@ jobs:
       matrix:
         rails_version: [7.0.4]
         ruby: ['3.0', '3.1', '3.2']
-        blacklight_version: [8.0.0.beta7]
     env:
       RAILS_VERSION: ${{ matrix.rails_version }}
     steps:

data/.rubocop.yml

@@ -200,9 +200,9 @@ RSpec/SubjectDeclaration: # new in 2.5
   Enabled: true
 RSpec/VerifiedDoubleReference: # new in 2.10.0
   Enabled: true
-RSpec/Capybara/SpecificFinders: # new in 2.13
+Capybara/SpecificFinders: # new in 2.13
   Enabled: true
-RSpec/Capybara/SpecificMatcher: # new in 2.12
+Capybara/SpecificMatcher: # new in 2.12
   Enabled: true
 RSpec/FactoryBot/SyntaxMethods: # new in 2.7
   Enabled: true
@@ -314,9 +314,9 @@ Style/RedundantStringEscape: # new in 1.37
   Enabled: true
 RSpec/SortMetadata: # new in 2.14
   Enabled: true
-RSpec/Capybara/NegationMatcher: # new in 2.14
+Capybara/NegationMatcher: # new in 2.14
   Enabled: true
-RSpec/Capybara/SpecificActions: # new in 2.14
+Capybara/SpecificActions: # new in 2.14
   Enabled: true
 RSpec/FactoryBot/ConsistentParenthesesStyle: # new in 2.14
   Enabled: false # https://github.com/rspec/rspec-rails/issues/2635
@@ -327,4 +327,36 @@ Rails/ActionOrder: # new in 2.17
 Rails/IgnoredColumnsAssignment: # new in 2.17
   Enabled: true
 Rails/WhereNotWithMultipleConditions: # new in 2.17
+  Enabled: true
+Gemspec/DevelopmentDependencies: # new in 1.44
+  Enabled: true
+Lint/UselessRescue: # new in 1.43
+  Enabled: true
+Style/ArrayIntersect: # new in 1.40
+  Enabled: true
+Style/ComparableClamp: # new in 1.44
+  Enabled: true
+Style/ConcatArrayLiterals: # new in 1.41
+  Enabled: true
+Style/MapToSet: # new in 1.42
+  Enabled: true
+Style/MinMaxComparison: # new in 1.42
+  Enabled: true
+Style/RedundantConstantBase: # new in 1.40
+  Enabled: true
+Style/RedundantDoubleSplatHashBraces: # new in 1.41
+  Enabled: true
+Style/RedundantHeredocDelimiterQuotes: # new in 1.45
+  Enabled: true
+Capybara/MatchStyle: # new in 2.17
+  Enabled: true
+RSpec/DuplicatedMetadata: # new in 2.16
+  Enabled: true
+RSpec/PendingWithoutReason: # new in 2.16
+  Enabled: true
+RSpec/FactoryBot/FactoryNameStyle: # new in 2.16
+  Enabled: false # https://github.com/rubocop/rubocop-rspec/issues/1587
+RSpec/Rails/MinitestAssertions: # new in 2.17
+  Enabled: true
+Rails/ResponseParsedBody: # new in 2.18
   Enabled: true

data/.rubocop_todo.yml

@@ -1,39 +1,40 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2022-10-05 03:27:31 UTC using RuboCop version 1.36.0.
+# on 2023-02-27 17:35:23 UTC using RuboCop version 1.46.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.
+# Offense count: 10
+# Configuration parameters: EnforcedStyle, AllowedGems, Include.
+# SupportedStyles: Gemfile, gems.rb, gemspec
+# Include: **/*.gemspec, **/Gemfile, **/gems.rb
+Gemspec/DevelopmentDependencies:
+  Exclude:
+    - 'arclight.gemspec'
+
+# Offense count: 1
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 19
 
-# Offense count: 2
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Offense count: 1
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 8
 
-# Offense count: 4
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Offense count: 3
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 17
+  Max: 11
 
-# Offense count: 1
-# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
+# Offense count: 2
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 9
 
-# Offense count: 1
-# Configuration parameters: ForbiddenDelimiters.
-# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
-Naming/HeredocDelimiterNaming:
-  Exclude:
-    - 'spec/features/autocomplete_spec.rb'
-
-# Offense count: 80
+# Offense count: 60
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -47,38 +48,32 @@ RSpec/DescribedClass:
   Exclude:
     - 'spec/presenters/arclight/show_presenter_spec.rb'
 
-# Offense count: 62
+# Offense count: 60
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 49
 
-# Offense count: 2
-RSpec/ExpectInHook:
-  Exclude:
-    - 'spec/helpers/arclight_helper_spec.rb'
-
-# Offense count: 1
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
-# Include: **/*_spec*rb*, **/spec/**/*
-RSpec/FilePath:
-  Exclude:
-    - 'spec/lib/arclight/viewers/oembed_spec.rb'
-
-# Offense count: 132
+# Offense count: 112
 RSpec/MultipleExpectations:
-  Max: 25
+  Max: 22
 
-# Offense count: 30
+# Offense count: 37
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 10
 
-# Offense count: 19
+# Offense count: 22
 # Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:
   Max: 5
 
-# Offense count: 7
+# Offense count: 2
+RSpec/PendingWithoutReason:
+  Exclude:
+    - 'spec/features/document_tools_spec.rb'
+    - 'spec/features/google_form_request_spec.rb'
+
+# Offense count: 5
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.
 # SupportedStyles: inflected, explicit
@@ -87,13 +82,7 @@ RSpec/PredicateMatcher:
     - 'spec/helpers/arclight_helper_spec.rb'
     - 'spec/lib/arclight/year_range_spec.rb'
 
-# Offense count: 3
-RSpec/StubbedMock:
-  Exclude:
-    - 'spec/helpers/arclight_helper_spec.rb'
-    - 'spec/lib/arclight/viewer_spec.rb'
-
-# Offense count: 2
+# Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
 Rails/Blank:
@@ -112,7 +101,7 @@ Rails/OutputSafety:
   Exclude:
     - 'app/helpers/arclight/field_config_helpers.rb'
 
-# Offense count: 7
+# Offense count: 6
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Include.
 # Include: **/Rakefile, **/*.rake
@@ -125,3 +114,9 @@ Rails/RakeEnvironment:
 Security/Open:
   Exclude:
     - 'lib/tasks/index.rake'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantConstantBase:
+  Exclude:
+    - 'spec/spec_helper.rb'

data/CONTRIBUTORS.md

@@ -45,7 +45,7 @@ Individual project contributors include ([emoji key](https://allcontributors.org
   </tr>
   <tr>
     <td align="center"><a href="https://github.com/gordonleacock"><img src="https://avatars3.githubusercontent.com/u/12927191?v=4" width="125px;" alt="Gordon Leacock"/><br /><sub><b>Gordon Leacock</b></sub></a><br /><a href="https://github.com/projectblacklight/arclight/commits?author=gordonleacock" title="Code">💻</a> <a href="https://github.com/projectblacklight/arclight/commits?author=gordonleacock" title="Documentation">📖</a></td>
-    <td align="center"><a href="https://matienzo.org/"><img src="https://avatars0.githubusercontent.com/u/73732?v=4" width="125px;" alt="Mark A. Matienzo"/><br /><sub><b>Mark A. Matienzo</b></sub></a><br /><a href="#projectManagement-anarchivist" title="Project Management">📆</a> <a href="#business-anarchivist" title="Business development">💼</a> <a href="#analysis-anarchivist" title="Functional requirements and related research">🔬</a> <a href="#productOwner-anarchivist" title="Product owner">🗺</a></td>
+    <td align="center"><a href="https://matienzo.org/"><img src="https://avatars0.githubusercontent.com/u/73732?v=4" width="125px;" alt="María A. Matienzo"/><br /><sub><b>María A. Matienzo</b></sub></a><br /><a href="#projectManagement-anarchivist" title="Project Management">📆</a> <a href="#business-anarchivist" title="Business development">💼</a> <a href="#analysis-anarchivist" title="Functional requirements and related research">🔬</a> <a href="#productOwner-anarchivist" title="Product owner">🗺</a></td>
     <td align="center"><a href="https://github.com/archivistsarah"><img src="https://avatars0.githubusercontent.com/u/25084902?v=4" width="125px;" alt="Sarah Newhouse"/><br /><sub><b>Sarah Newhouse</b></sub></a><br /><a href="#analysis-archivistsarah" title="Functional requirements and related research">🔬</a></td>
     <td align="center"><a href="https://github.com/grepcats"><img src="https://avatars0.githubusercontent.com/u/7513448?v=4" width="125px;" alt="Kayla Ondracek"/><br /><sub><b>Kayla Ondracek</b></sub></a><br /><a href="#analysis-grepcats" title="Functional requirements and related research">🔬</a></td>
     <td align="center"><a href="https://github.com/djpillen"><img src="https://avatars3.githubusercontent.com/u/11635158?v=4" width="125px;" alt="Dallas Pillen"/><br /><sub><b>Dallas Pillen</b></sub></a><br /><a href="https://github.com/projectblacklight/arclight/commits?author=djpillen" title="Code">💻</a> <a href="#userTesting-djpillen" title="User Testing">📓</a></td>

data/README.md

@@ -1,3 +1,5 @@
+[![Gem Version](https://badge.fury.io/rb/arclight.svg)](https://badge.fury.io/rb/arclight)
+[![npm version](https://badge.fury.io/js/arclight.svg)](https://badge.fury.io/js/arclight)
 ![Build Status](https://github.com/projectblacklight/arclight/workflows/CI/badge.svg)
 [![All Contributors](https://img.shields.io/badge/all_contributors-17-orange.svg?style=flat-square)](CONTRIBUTORS.md)
 [![Code Climate Test Coverage](https://codeclimate.com/github/projectblacklight/arclight/badges/coverage.svg)](https://codeclimate.com/github/projectblacklight/arclight/coverage)

data/app/assets/javascripts/arclight/oembed_controller.js

@@ -1,6 +1,6 @@
 import { Controller } from '@hotwired/stimulus'
 
-export default class extends Controller {
+export default class OembedController extends Controller {
   static values = {
     url: String
   }
@@ -12,32 +12,23 @@ export default class extends Controller {
       return
     }
 
-    fetch(this.urlTarget)
-      .then((response) => response.text())
+    fetch(this.urlValue)
+      .then((response) => {
+        if (response.ok) return response.text()
+        throw new Error(`HTTP error, status = ${response.status}`)
+      })
       .then((body) => {
-        const oEmbedEndPoint = this.findOEmbedEndPoint(body)
+        const oEmbedEndPoint = OembedController.findOEmbedEndPoint(body)
         if (!oEmbedEndPoint || oEmbedEndPoint.length === 0) {
-          console.warn(`No oEmbed endpoint found in <head> at ${this.urlTarget}`)
+          console.warn(`No oEmbed endpoint found in <head> at ${this.urlValue}`)
           return
         }
         this.loadEndPoint(oEmbedEndPoint)
+      }).catch(error => {
+        console.error(error)
       })
   }
 
-  // Convert data-arclight-oembed-* attributes to URL parameters for the viewer
-  static normalizeParams(attributes) {
-    return Object.keys(attributes).reduce((acc, attribute) => {
-      // Reverse data attribute name conversion. See:
-      // https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/dataset#name_conversion
-      const parameterName = attribute.replace('arclightOembed', '')
-        .replace(/([a-z])([A-Z])/g, '$1-$2')
-        .toLowerCase()
-
-      acc[parameterName] = attributes[attribute]
-      return acc
-    }, {})
-  }
-
   static findOEmbedEndPoint(body, extraParams = {}) {
     // Parse out link elements so image assets are not loaded
     const template = document.createElement('template')

data/app/components/arclight/sidebar_component.html.erb

@@ -1,6 +1,6 @@
 <div class="offcanvas-lg offcanvas-start p-3 p-lg-1" tabindex="-1" id="sidebar">
   <%= collection_context %>
-  <%= render 'show_tools' %>
+  <%= render 'show_tools', document: document %>
   <%= collection_sidebar %>
   <div id="collection-context" class="sidebar-section">
     <h2><%= t('arclight.views.show.has_content') %></h2>

data/arclight.gemspec

@@ -10,10 +10,11 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Darren Hardy', 'Jessie Keck', 'Gordon Leacock', 'Jack Reed']
   spec.email         = ['drh@stanford.edu', 'jessie.keck@gmail.com', 'gordonl@umich.edu', 'phillipjreed@gmail.com']
 
-  spec.summary       = ''
+  spec.summary       = 'A Blacklight-based environment to support discovery and delivery for archives and special collections'
   spec.description   = ''
-  spec.homepage      = 'https://github.com/projectblacklight/arclight'
-  spec.license       = 'Apache-2.0'
+  spec.homepage      = 'https://library.stanford.edu/projects/arclight'
+  spec.metadata = { 'source_code_uri' => 'https://github.com/projectblacklight/arclight' }
+  spec.license = 'Apache-2.0'
 
   spec.required_ruby_version = '>= 3.0.0'
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
@@ -23,7 +24,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'blacklight', '>= 8.0.0.beta', '< 9'
+  spec.add_dependency 'blacklight', '>= 8.0.0', '< 9'
   spec.add_dependency 'gretel'
   spec.add_dependency 'rails', '~> 7.0'
   spec.add_dependency 'traject', '~> 3.0'

data/lib/arclight/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Arclight
-  VERSION = '1.0.0.beta2'
+  VERSION = '1.0.0.beta4'
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "arclight",
-  "version": "1.0.0-beta.2",
+  "version": "1.0.0-beta.4",
   "description": "The frontend for arclight",
   "main": "app/assets/javascript/arclight/arclight.js",
   "files": [
@@ -18,12 +18,12 @@
   },
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/projectblacklight/arclight.git"
+    "url": "https://github.com/projectblacklight/arclight.git"
   },
   "author": "",
   "license": "Apache-2.0",
   "bugs": {
     "url": "https://github.com/projectblacklight/arclight/issues"
   },
-  "homepage": "https://github.com/projectblacklight/arclight#readme"
+  "homepage": "https://library.stanford.edu/projects/arclight"
 }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: arclight
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta2
+  version: 1.0.0.beta4
 platform: ruby
 authors:
 - Darren Hardy
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-02-27 00:00:00.000000000 Z
+date: 2023-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: blacklight
@@ -19,7 +19,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.0.0.beta
+        version: 8.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '9'
@@ -29,7 +29,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 8.0.0.beta
+        version: 8.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '9'
@@ -493,10 +493,11 @@ files:
 - solr/conf/xslt/luke.xsl
 - tasks/arclight.rake
 - template.rb
-homepage: https://github.com/projectblacklight/arclight
+homepage: https://library.stanford.edu/projects/arclight
 licenses:
 - Apache-2.0
-metadata: {}
+metadata:
+  source_code_uri: https://github.com/projectblacklight/arclight
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -515,5 +516,6 @@ requirements: []
 rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
-summary: ''
+summary: A Blacklight-based environment to support discovery and delivery for archives
+  and special collections
 test_files: []