archangel 0.0.8 → 0.3.0

data/spec/features/frontend/pages/homepage_redirect_spec.rb

@@ -5,9 +5,9 @@ require "rails_helper"
 RSpec.feature "Home page", type: :feature do
   describe "when on home page path" do
     it "redirects to /" do
-      home = create(:page, :homepage)
+      resource = create(:page, :homepage)
 
-      visit archangel.frontend_page_path(home.path)
+      visit archangel.frontend_page_path(resource.path)
 
       expect(page.current_path).to eq archangel.frontend_root_path
     end

data/spec/features/frontend/pages/metatags_spec.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+RSpec.feature "Meta tag", type: :feature do
+  describe "site metatags" do
+    let(:site) { create(:site) }
+
+    before do
+      create(:metatag, metatagable: site,
+                       name: "description",
+                       content: "Site description")
+      create(:metatag, metatagable: site,
+                       name: "author",
+                       content: "Archangel")
+    end
+
+    it "contains default meta tags" do
+      resource = create(:page, site: site)
+
+      visit archangel.frontend_page_path(resource.path)
+
+      canonical = "http://www.example.com/#{resource.path}"
+
+      expect(page).to(
+        have_css(
+          "link[rel='canonical'][href='#{canonical}']", visible: false
+        )
+      )
+    end
+
+    it "contains Site meta tags" do
+      resource = create(:page, site: site)
+
+      visit archangel.frontend_page_path(resource.path)
+
+      expect(page).to have_meta(:description, "Site description")
+      expect(page).to have_meta(:author, "Archangel")
+
+      expect(page).to have_title("#{resource.title} | #{site.name}")
+    end
+
+    it "contains Site and Page meta tags" do
+      resource = create(:page, site: site)
+      create(:metatag, metatagable: resource,
+                       name: "description",
+                       content: "Page description")
+      create(:metatag, metatagable: resource,
+                       name: "keywords",
+                       content: "useful,page,keywords")
+
+      visit archangel.frontend_page_path(resource.path)
+
+      expect(page).to have_meta(:description, "Page description")
+      expect(page).to have_meta(:keywords, "useful,page,keywords")
+      expect(page).to have_meta(:author, "Archangel")
+
+      expect(page).to have_title("#{resource.title} | #{site.name}")
+    end
+
+    it "always uses page.title for title (doesn't allow metatag overwrite)" do
+      resource = create(:page, site: site)
+      create(:metatag, metatagable: resource,
+                       name: "title",
+                       content: "Metatag Page Title")
+
+      visit archangel.frontend_page_path(resource.path)
+
+      expect(page).to have_title("#{resource.title} | #{site.name}")
+      expect(page).to_not have_title("Metatag Page Title | #{site.name}")
+    end
+  end
+end

data/spec/helpers/archangel/flash_helper_spec.rb

@@ -28,6 +28,20 @@ module Archangel
         expect(helper.flash_class_for("foo_bar")).to eq("foo_bar")
         expect(helper.flash_class_for("foo      bar")).to eq("foo-bar")
       end
+
+      it "returns class with known characters" do
+        resource = <<-CONTENT
+          abcdefghijklmnopqrstuvwxyz
+          tab	space ABCDEFGHIJKLMNOPQRSTUVWXYZ
+          `-=[]\;',./~!@#$%^&*()_+{}|:"<>?
+          ¡™£¢∞§¶•ªº–≠	œ∑´®†¥¨ˆøπ“‘«åß∂ƒ©˙∆˚¬…æΩ≈ç√∫˜µ≤≥÷
+          0123456789
+        CONTENT
+        expected = "abcdefghijklmnopqrstuvwxyz-tab-space-" \
+                   "abcdefghijklmnopqrstuvwxyz-_-oe-o-ass-ae-c-0123456789"
+
+        expect(helper.flash_class_for(resource)).to eq(expected)
+      end
     end
   end
 end

data/spec/lib/archangel/{command/extension_spec.rb → commands/extension_command_spec.rb}

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
 require "rails_helper"
-require "archangel/command/extension"
+require "archangel/commands/extension_command"
 
 module Archangel
-  module Command
-    RSpec.describe Extension do
+  module Commands
+    RSpec.describe ExtensionCommand do
       describe "#extension" do
         before { allow(STDOUT).to receive(:puts) }
 

data/spec/lib/archangel/commands/theme_command_spec.rb

@@ -0,0 +1,100 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+require "archangel/commands/theme_command"
+
+module Archangel
+  module Commands
+    RSpec.describe ThemeCommand do
+      describe "#theme" do
+        before { allow(STDOUT).to receive(:puts) }
+
+        let(:dummy_path) { "spec/dummy" }
+
+        context "when given an theme name" do
+          let(:theme_name) { "example" }
+          let(:theme_full_name) { "archangel_#{theme_name}_theme" }
+          let(:theme_path) { "#{dummy_path}/#{theme_full_name}" }
+
+          before { before_generation(theme_name) }
+
+          after { after_generation(theme_path) }
+
+          it "should write common directories" do
+            %w[app bin lib spec].each do |dir|
+              expect(glob_directories_in(theme_path)).to include(dir)
+            end
+          end
+
+          it "should write common files" do
+            %w[.editorconfig .gitignore .rspec .rubocop.yml Gemfile
+               MIT-LICENSE Rakefile README.md].each do |file|
+              expect(glob_files_in(theme_path)).to include(file)
+            end
+
+            expect(glob_files_in(theme_path))
+              .to include("#{theme_full_name}.gemspec")
+          end
+        end
+
+        context "when not given an theme name" do
+          let(:theme_name) { nil }
+          let(:theme_full_name) { "archangel_sample_theme" }
+          let(:theme_path) { "#{dummy_path}/#{theme_full_name}" }
+
+          before { before_generation(theme_name) }
+
+          after { after_generation(theme_path) }
+
+          it "should write common files for `sample`" do
+            expect(glob_files_in(theme_path))
+              .to include("#{theme_full_name}.gemspec")
+          end
+        end
+      end
+
+      def before_generation(theme_name)
+        silence_output
+
+        Dir.chdir("spec/dummy") do
+          subject = described_class.new([theme_name])
+          subject.invoke_all
+        end
+      end
+
+      def after_generation(theme_path)
+        enable_output
+
+        FileUtils.rm_rf("#{theme_path}/")
+      end
+
+      def glob_directories_in(theme_path)
+        Dir.glob("#{theme_path}/*")
+           .reject { |file| File.file?(file) }
+           .map { |file| File.basename(file) }
+      end
+
+      def glob_files_in(theme_path)
+        Dir.glob("#{theme_path}/{.[^\.]*,*}")
+           .select { |file| File.file?(file) }
+           .map { |file| File.basename(file) }
+      end
+
+      def silence_output
+        @orig_stderr = $stderr
+        @orig_stdout = $stdout
+
+        $stderr = File.new("/dev/null", "w")
+        $stdout = File.new("/dev/null", "w")
+      end
+
+      def enable_output
+        $stderr = @orig_stderr
+        $stdout = @orig_stdout
+
+        @orig_stderr = nil
+        @orig_stdout = nil
+      end
+    end
+  end
+end

data/spec/lib/archangel/liquid/drops/page_drop_spec.rb

@@ -9,8 +9,6 @@ module Archangel
         let(:resource) do
           create(:page, title: "Test Page",
                         slug: "path-for-page",
-                        meta_keywords: "keywords,for,page",
-                        meta_description: "Description of page",
                         published_at: "2018-04-20 14:20:18")
         end
         let(:resource_drop) { described_class.new(resource) }
@@ -18,12 +16,10 @@ module Archangel
         context "attributes" do
           it "_attributes" do
             expect(resource_drop.class._attributes)
-              .to eq(%i[meta_description meta_keywords published_at title])
+              .to eq(%i[published_at title])
           end
 
           it "returns correct attribute values" do
-            expect(resource_drop.meta_description).to eq("Description of page")
-            expect(resource_drop.meta_keywords).to eq("keywords,for,page")
             expect(resource_drop.published_at).to eq("2018-04-20 14:20:18")
             expect(resource_drop.title).to eq("Test Page")
           end
@@ -40,8 +36,6 @@ module Archangel
         context "#as_json" do
           it "returns hash of attributes" do
             json_object = {
-              meta_description: "Description of page",
-              meta_keywords: "keywords,for,page",
               published_at: "2018-04-20T14:20:18.000Z",
               title: "Test Page"
             }
@@ -53,8 +47,6 @@ module Archangel
         context "#to_json" do
           it "returns hash of attributes" do
             json_object = {
-              meta_description: "Description of page",
-              meta_keywords: "keywords,for,page",
               published_at: "2018-04-20T14:20:18.000Z",
               title: "Test Page"
             }

data/spec/lib/archangel/liquid/drops/site_drop_spec.rb

@@ -7,23 +7,17 @@ module Archangel
     module Drops
       RSpec.describe SiteDrop, type: :liquid_drop do
         let(:resource) do
-          create(:site, name: "Test Site",
-                        locale: "en",
-                        meta_keywords: "keywords,for,site",
-                        meta_description: "Description of site")
+          create(:site, name: "Test Site", locale: "en")
         end
         let(:resource_drop) { described_class.new(resource) }
 
         context "attributes" do
           it "_attributes" do
-            expect(resource_drop.class._attributes)
-              .to eq(%i[locale meta_description meta_keywords name])
+            expect(resource_drop.class._attributes).to eq(%i[locale name])
           end
 
           it "returns correct attribute values" do
             expect(resource_drop.locale).to eq("en")
-            expect(resource_drop.meta_description).to eq("Description of site")
-            expect(resource_drop.meta_keywords).to eq("keywords,for,site")
             expect(resource_drop.name).to eq("Test Site")
           end
 
@@ -37,8 +31,6 @@ module Archangel
           it "returns hash of attributes" do
             json_object = {
               locale: "en",
-              meta_description: "Description of site",
-              meta_keywords: "keywords,for,site",
               name: "Test Site"
             }
 
@@ -50,8 +42,6 @@ module Archangel
           it "returns hash of attributes" do
             json_object = {
               locale: "en",
-              meta_description: "Description of site",
-              meta_keywords: "keywords,for,site",
               name: "Test Site"
             }
 

data/spec/lib/archangel/liquid/tags/noembed_tag_spec.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+module Archangel
+  module Liquid
+    module Tags
+      RSpec.describe NoembedTag, type: :liquid_tag do
+        let(:context) { ::Liquid::Context.new({}, {}, view: view) }
+
+        it "raises error with invalid syntax" do
+          content = "{% noembed %}"
+
+          expect { ::Liquid::Template.parse(content).render(context) }.to(
+            raise_error(::Liquid::SyntaxError)
+          )
+        end
+
+        context "Ruby request" do
+          let(:content_url) { "https://www.youtube.com/watch?v=-X2atEH7nCg" }
+          let(:content) { "{% noembed '#{content_url}' %}" }
+
+          it "returns YouTube video embed" do
+            result = ::Liquid::Template.parse(content).render(context)
+
+            expect(result).to include(
+              "https://www.youtube.com/embed/-X2atEH7nCg?feature=oembed"
+            )
+          end
+
+          it "returns a connection error when the site is down" do
+            allow(Net::HTTP)
+              .to receive(:get_response).and_return(Net::HTTPError)
+
+            result = ::Liquid::Template.parse(content).render(context)
+
+            expect(result).to include("Error connecting to noembed server.")
+          end
+
+          it "returns specific error when an error occurres" do
+            response = Net::HTTPSuccess.new("1.1", 200, nil)
+            allow(response).to receive(:body)
+              .and_return({ error: "Error. Bad things happened." }.to_json)
+            allow(Net::HTTP).to receive(:get_response).and_return(response)
+
+            result = ::Liquid::Template.parse(content).render(context)
+
+            expect(result).to include("Error. Bad things happened.")
+          end
+
+          it "returns generic error when an error occurres" do
+            response = Net::HTTPSuccess.new("1.1", 200, nil)
+            allow(response).to receive(:body)
+              .and_return({ foo: "bar" }.to_json)
+            allow(Net::HTTP).to receive(:get_response).and_return(response)
+
+            result = ::Liquid::Template.parse(content).render(context)
+
+            expect(result).to include("Unknown error.")
+          end
+        end
+
+        context "Javascript request" do
+          it "returns YouTube video embed" do
+            video = "https://player.vimeo.com/video/183344978"
+            content = "{% noembed '#{video}' remote:true %}"
+
+            result = ::Liquid::Template.parse(content).render(context)
+
+            expect(result).to include(CGI.escape(video))
+          end
+        end
+      end
+    end
+  end
+end

data/spec/models/archangel/metatag_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+module Archangel
+  RSpec.describe Metatag, type: :model do
+    context "validations" do
+      it "has a unique name scoped to metatagable_type and metatagable_id" do
+        resource = build(:metatag)
+
+        expect(resource).to(
+          validate_uniqueness_of(:name)
+            .scoped_to(:metatagable_type, :metatagable_id)
+        )
+      end
+    end
+
+    context "associations" do
+      it { is_expected.to belong_to(:metatagable) }
+    end
+  end
+end

data/spec/models/archangel/page_spec.rb

@@ -39,11 +39,12 @@ module Archangel
         expect(resource).to validate_uniqueness_of(:path).scoped_to(:site_id)
       end
 
-      it "has a unique slug scoped to Page" do
+      it "has a unique slug scoped to Parent and Site" do
         resource = build(:page, :with_parent)
 
         expect(resource).to(
-          validate_uniqueness_of(:slug).scoped_to(:parent_id).case_insensitive
+          validate_uniqueness_of(:slug).scoped_to(%i[parent_id site_id])
+                                       .case_insensitive
         )
       end
 
@@ -55,6 +56,8 @@ module Archangel
       it { is_expected.to belong_to(:site) }
       it { is_expected.to belong_to(:parent).class_name("Archangel::Page") }
       it { is_expected.to belong_to(:template).conditions(partial: false) }
+
+      it { is_expected.to have_many(:metatags) }
     end
 
     context "scopes" do

data/spec/models/archangel/site_spec.rb

@@ -23,10 +23,12 @@ module Archangel
 
     it { is_expected.to have_many(:assets) }
     it { is_expected.to have_many(:collections) }
+    it { is_expected.to have_many(:metatags) }
     it { is_expected.to have_many(:pages) }
     it { is_expected.to have_many(:templates) }
     it { is_expected.to have_many(:users) }
     it { is_expected.to have_many(:widgets) }
+
     it { is_expected.to have_many(:entries).through(:collections) }
     it { is_expected.to have_many(:fields).through(:collections) }