archangel 0.0.2 → 0.0.3

data/lib/archangel/command/templates/extension/bin/rails.tt

@@ -0,0 +1,11 @@
+#!/usr/bin/env ruby
+
+ENGINE_ROOT = File.expand_path("../..", __FILE__)
+ENGINE_PATH = File.expand_path("../../lib/<%= extension_name %>/engine", __FILE__)
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile", __FILE__)
+
+require "bundler/setup" if File.exist?(ENV["BUNDLE_GEMFILE"])
+
+require "rails/all"
+require "rails/engine/commands"

data/lib/archangel/command/templates/extension/config/locales/en.yml.tt

@@ -0,0 +1,4 @@
+en:
+  archangel:
+    hello: "Hello world"
+    <%= extension_name %>: <%= class_name %>

data/lib/archangel/command/templates/extension/config/routes.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+Archangel::Engine.routes.draw do
+  # Add your routes here
+end

data/lib/archangel/command/templates/extension/extension.gemspec

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+$LOAD_PATH.push File.expand_path("lib", __dir__)
+
+require "<%= extension_name %>/version"
+
+Gem::Specification.new do |s|
+  s.platform    = Gem::Platform::RUBY
+  s.name        = "<%= extension_name %>"
+  s.version     = <%= class_name %>::VERSION
+  s.authors     = ["Your Name"]
+  s.homepage    = "https://github.com/USERNAME/<%= extension_name %>"
+  s.summary     = "TODO: Summary of <%= class_name %>."
+  s.description = "TODO: Description of <%= class_name %>."
+  s.license     = "MIT"
+
+  s.files = Dir[
+    "{app,config,db,lib}/**/*",
+    "MIT-LICENSE",
+    "Rakefile",
+    "README.md"
+  ]
+
+  s.add_dependency "archangel", "< 1.0"
+end

data/lib/archangel/command/templates/extension/lib/%extension_name%/engine.rb.tt

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module <%= class_name %>
+  class Engine < ::Rails::Engine
+    require "archangel"
+
+    isolate_namespace Archangel
+    engine_name "<%= extension_name %>"
+
+    config.generators do |gen|
+      gen.test_framework :rspec,
+                         fixtures: false,
+                         view_specs: false,
+                         helper_specs: true,
+                         routing_specs: false,
+                         controller_specs: true,
+                         request_specs: true
+      gen.fixture_replacement :factory_bot, dir: "spec/factories"
+    end
+
+    def self.activate
+      Dir[File.join(__dir__, "../../app/**/*_decorator*.rb")].each do |klass|
+        Rails.application.config.cache_classes ? require(klass) : load(klass)
+      end
+    end
+
+    config.to_prepare(&method(:activate).to_proc)
+  end
+end

data/lib/archangel/command/templates/extension/lib/%extension_name%/factories.rb.tt

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+# Define your extensions Factories within this file to enable applications and
+# other extensions to use and override them.
+#
+# Example adding this to your spec_helper will load these Factories for use:
+# require "<%= extension_name %>/factories"
+
+FactoryBot.define do
+end
+
+FactoryBot.modify do
+end

data/lib/archangel/command/templates/extension/lib/%extension_name%/version.rb.tt

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+module <%= class_name %>
+  VERSION = "0.0.1".freeze
+end

data/lib/archangel/command/templates/extension/lib/%extension_name%.rb.tt

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+require "archangel"
+
+require "<%= extension_name %>/engine"
+require "<%= extension_name %>/version"
+
+module <%= class_name %>
+end

data/lib/archangel/command/templates/extension/lib/generators/%extension_name%/install/install_generator.rb.tt

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module <%= class_name %>
+  module Generators
+    class InstallGenerator < ::Rails::Generators::Base
+      class_option :auto_run_migrations, type: :boolean, default: false
+
+      def add_javascripts
+        %w[auth backend frontend].each do |section|
+          append_file "vendor/assets/javascripts/archangel/#{section}.js",
+                      "//= require archangel/#{section}/<%= extension_name %>\n"
+        end
+      end
+
+      def add_stylesheets
+        %w[auth backend frontend].each do |section|
+          inject_into_file "vendor/assets/stylesheets/archangel/#{section}.css",
+                           "*= require archangel/#{section}/<%= extension_name %>\n ",
+                           before: %r{\*/},
+                           verbose: true
+        end
+      end
+
+      def add_migrations
+        run "bundle exec rails railties:install:migrations FROM=<%= extension_name %>"
+      end
+
+      def run_migrations
+        migration_message = "Would you like to run the migrations now? [Y/n]"
+
+        run_migrations = options[:auto_run_migrations] || ["", "y", "Y"]
+                         .include?(ask(migration_message))
+
+        if run_migrations
+          run "bundle exec rails db:migrate"
+        else
+          puts "Skipping `rails db:migrate`, don't forget to run it!"
+        end
+      end
+    end
+  end
+end

data/lib/archangel/command/templates/extension/spec/rails_helper.rb.tt

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require "simplecov"
+
+SimpleCov.start :rails
+
+ENV["RAILS_ENV"] ||= "test"
+
+begin
+  require File.expand_path("dummy/config/environment", __dir__)
+rescue LoadError
+  puts "Could not load test application. Run `bundle exec rake dummy_app` first"
+  exit
+end
+
+if Rails.env.production?
+  abort("The Rails environment is running in production mode!")
+end
+
+require "spec_helper"
+
+require "pry-byebug"
+require "rspec/rails"
+
+# Archangel support files
+require "archangel/testing_support/support"
+
+# Require factories defined in lib/<%= extension_name %>/factories.rb
+require "<%= extension_name %>/factories"
+
+# Local support files
+Dir[Rails.root.join("../support/**/*.rb")].each { |f| require f }
+
+RSpec.configure do |config|
+  config.color = true
+  config.mock_with :rspec
+
+  config.raise_errors_for_deprecations!
+  config.filter_rails_from_backtrace!
+  config.infer_spec_type_from_file_location!
+end

data/lib/archangel/command/templates/extension/spec/spec_helper.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |expectations|
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  config.mock_with :rspec do |mocks|
+    mocks.verify_partial_doubles = true
+  end
+
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  config.disable_monkey_patching!
+
+  config.profile_examples = 10
+
+  config.order = :random
+end

data/lib/archangel/liquid/drop.rb

@@ -60,26 +60,36 @@ module Archangel
       end
 
       def self.associate(type, attrs)
-        options = attrs.extract_options!
         self._associations = _associations.dup
 
+        associate_attributes(type, attrs)
+      end
+
+      def self.associate_attributes(type, attrs)
+        options = attrs.extract_options!
+
         attrs.each do |attr|
           next if method_defined?(attr)
 
-          define_method attr do
-            value = instance_variable_get("@_#{attr}")
-            return value if value
+          define_method_attribute(attr)
 
-            association = object.send(attr)
-            return nil if association.blank?
+          _associations[attr] = { type: type, options: options }
+        end
+      end
 
-            drop_instance =
-              Archangel::Liquid::Drop.dropify(association, options)
+      def self.define_method_attribute(attr)
+        options = attrs.extract_options!
 
-            instance_variable_set("@_#{attr}", drop_instance)
-          end
+        define_method attr do
+          value = instance_variable_get("@_#{attr}")
+          return value if value
+
+          association = object.send(attr)
+          return nil if association.blank?
+
+          drop_instance = Archangel::Liquid::Drop.dropify(association, options)
 
-          self._associations[attr] = { type: type, options: options }
+          instance_variable_set("@_#{attr}", drop_instance)
         end
       end
 

data/lib/archangel/liquid_view.rb

@@ -33,16 +33,20 @@ module Archangel
     # @return [String] the rendered content
     #
     def render(template, local_assigns = {})
-      @view.controller.headers["Content-Type"] ||= "text/html; charset=utf-8"
+      default_controller.headers["Content-Type"] ||= "text/html; charset=utf-8"
 
       assigns = default_assigns(local_assigns)
-      options = { filters: default_filters, registers: default_registers }
+      options = { registers: default_registers }
 
       Archangel::RenderService.call(template, assigns, options)
     end
 
     protected
 
+    def default_controller
+      @view.controller
+    end
+
     def default_assigns(local_assigns)
       assigns = @view.assigns
 
@@ -53,40 +57,12 @@ module Archangel
       assigns.merge(local_assigns.stringify_keys)
     end
 
-    def default_controller
-      @view.controller
-    end
-
-    def default_filters
-      extra_filters = []
-
-      controller_class = default_controller.class
-
-      if controller_class.respond_to?(:liquid_filters)
-        controller_class.liquid_filters.each do |method|
-          extra_filters.merge! default_controller.send(method)
-        end
-      end
-
-      extra_filters
-    end
-
     def default_registers
-      extra_registers = {}
-
-      controller_class = default_controller.class
-
-      if controller_class.respond_to?(:liquid_registers)
-        controller_class.liquid_registers.each do |method|
-          extra_registers.merge! default_controller.send(method)
-        end
-      end
-
       {
         view: @view,
         controller: default_controller,
         helper: ActionController::Base.helpers
-      }.merge extra_registers
+      }
     end
   end
 end

data/lib/archangel/version.rb

@@ -4,7 +4,7 @@ module Archangel
   ##
   # Archangel gem version
   #
-  VERSION = "0.0.2".freeze
+  VERSION = "0.0.3".freeze
 
   ##
   # Archangel version

data/lib/generators/archangel/dummy/dummy_generator.rb

@@ -67,6 +67,7 @@ module Archangel
         opts[:skip_git] = true
         opts[:old_style_hash] = false
         opts[:skip_turbolinks] = true
+        opts[:skip_bootsnap] = true
 
         puts "Generating dummy Rails application..."
 

data/package.json

@@ -12,6 +12,10 @@
     "ruby"
   ],
   "license": "MIT",
+  "engines": {
+    "node": "8.11.1",
+    "yarn": "1.6.0"
+  },
   "repository": {
     "type": "git",
     "url": "archangel/archangel"
@@ -26,8 +30,9 @@
   "scripts": {
     "test": "test"
   },
+  "dependencies": {},
   "devDependencies": {
-    "eslint": "^4.18.2"
-  },
-  "dependencies": {}
+    "eslint": "^4.18.2",
+    "jshint": "^2.9.5"
+  }
 }

data/spec/lib/archangel/command/extension_spec.rb

@@ -0,0 +1,100 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+require "archangel/command/extension"
+
+module Archangel
+  module Command
+    RSpec.describe Extension do
+      describe "#extension" do
+        before { allow(STDOUT).to receive(:puts) }
+
+        let(:dummy_path) { "spec/dummy" }
+
+        context "when given an extension name" do
+          let(:extension_name) { "example" }
+          let(:extension_full_name) { "archangel_#{extension_name}" }
+          let(:extension_path) { "#{dummy_path}/#{extension_full_name}" }
+
+          before { before_generation(extension_name) }
+
+          after { after_generation(extension_path) }
+
+          it "should write common directories" do
+            %w[app bin config lib spec].each do |dir|
+              expect(glob_directories_in(extension_path)).to include(dir)
+            end
+          end
+
+          it "should write common files" do
+            %w[.editorconfig .gitignore .rspec .rubocop.yml Gemfile
+               MIT-LICENSE Rakefile README.md].each do |file|
+              expect(glob_files_in(extension_path)).to include(file)
+            end
+
+            expect(glob_files_in(extension_path))
+              .to include("#{extension_full_name}.gemspec")
+          end
+        end
+
+        context "when not given an extension name" do
+          let(:extension_name) { nil }
+          let(:extension_full_name) { "archangel_sample" }
+          let(:extension_path) { "#{dummy_path}/#{extension_full_name}" }
+
+          before { before_generation(extension_name) }
+
+          after { after_generation(extension_path) }
+
+          it "should write common files for `sample`" do
+            expect(glob_files_in(extension_path))
+              .to include("#{extension_full_name}.gemspec")
+          end
+        end
+      end
+
+      def before_generation(extension_name)
+        silence_output
+
+        Dir.chdir("spec/dummy") do
+          subject = Archangel::Command::Extension.new([extension_name])
+          subject.invoke_all
+        end
+      end
+
+      def after_generation(extension_path)
+        enable_output
+
+        FileUtils.rm_rf("#{extension_path}/")
+      end
+
+      def glob_directories_in(extension_path)
+        Dir.glob("#{extension_path}/*")
+           .reject { |file| File.file?(file) }
+           .map { |file| File.basename(file) }
+      end
+
+      def glob_files_in(extension_path)
+        Dir.glob("#{extension_path}/{.[^\.]*,*}")
+           .select { |file| File.file?(file) }
+           .map { |file| File.basename(file) }
+      end
+
+      def silence_output
+        @orig_stderr = $stderr
+        @orig_stdout = $stdout
+
+        $stderr = File.new("/dev/null", "w")
+        $stdout = File.new("/dev/null", "w")
+      end
+
+      def enable_output
+        $stderr = @orig_stderr
+        $stdout = @orig_stdout
+
+        @orig_stderr = nil
+        @orig_stdout = nil
+      end
+    end
+  end
+end

data/spec/lib/archangel/liquid/drop_spec.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+module Archangel
+  module Liquid
+    RSpec.describe Drop, :library do
+    end
+  end
+end

data/spec/lib/archangel/liquid/drops/page_drop_spec.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+module Archangel
+  module Liquid
+    module Drops
+      RSpec.describe PageDrop, type: :liquid_drop do
+        let(:resource) do
+          create(:page, title: "Test Page",
+                        slug: "path-for-page",
+                        meta_keywords: "keywords,for,page",
+                        meta_description: "Description of page",
+                        published_at: "2018-04-20 14:20:18")
+        end
+        let(:resource_drop) { described_class.new(resource) }
+
+        context "attributes" do
+          it "_attributes" do
+            expect(resource_drop.class._attributes)
+              .to eq(%i[meta_description meta_keywords published_at title])
+          end
+
+          it "returns correct attribute values" do
+            expect(resource_drop.meta_description).to eq("Description of page")
+            expect(resource_drop.meta_keywords).to eq("keywords,for,page")
+            expect(resource_drop.published_at).to eq("2018-04-20 14:20:18")
+            expect(resource_drop.title).to eq("Test Page")
+          end
+
+          it "returns correct #id value" do
+            expect(resource_drop.id).to eq(resource.id.to_s)
+          end
+
+          it "returns correct #path value" do
+            expect(resource_drop.path).to eq("/path-for-page")
+          end
+        end
+
+        context "#as_json" do
+          it "returns hash of attributes" do
+            json_object = {
+              meta_description: "Description of page",
+              meta_keywords: "keywords,for,page",
+              published_at: "2018-04-20T14:20:18.000Z",
+              title: "Test Page"
+            }
+
+            expect(resource_drop.as_json).to eq(json_object.as_json)
+          end
+        end
+
+        context "#to_json" do
+          it "returns hash of attributes" do
+            json_object = {
+              meta_description: "Description of page",
+              meta_keywords: "keywords,for,page",
+              published_at: "2018-04-20T14:20:18.000Z",
+              title: "Test Page"
+            }
+
+            expect(resource_drop.to_json).to eq(json_object.to_json)
+          end
+        end
+
+        context "#inspect" do
+          it "returns inspect string" do
+            expect(resource_drop.inspect)
+              .to include("#<Archangel::Liquid::Drops::PageDrop")
+            expect(resource_drop.inspect)
+              .to include("#<Archangel::Page")
+          end
+        end
+      end
+    end
+  end
+end

data/spec/lib/archangel/liquid/drops/site_drop_spec.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+module Archangel
+  module Liquid
+    module Drops
+      RSpec.describe SiteDrop, type: :liquid_drop do
+        let(:resource) do
+          create(:site, name: "Test Site",
+                        locale: "en",
+                        meta_keywords: "keywords,for,site",
+                        meta_description: "Description of site")
+        end
+        let(:resource_drop) { described_class.new(resource) }
+
+        context "attributes" do
+          it "_attributes" do
+            expect(resource_drop.class._attributes)
+              .to eq(%i[locale meta_description meta_keywords name])
+          end
+
+          it "returns correct attribute values" do
+            expect(resource_drop.locale).to eq("en")
+            expect(resource_drop.meta_description).to eq("Description of site")
+            expect(resource_drop.meta_keywords).to eq("keywords,for,site")
+            expect(resource_drop.name).to eq("Test Site")
+          end
+
+          it "returns correct #favicon value" do
+            expect(resource_drop.favicon)
+              .to match(%r{/assets/archangel/fallback/favicon(.+).ico})
+          end
+
+          it "returns correct #logo value" do
+            expect(resource_drop.logo)
+              .to match(%r{/assets/archangel/fallback/logo(.+).png})
+          end
+        end
+
+        context "#as_json" do
+          it "returns hash of attributes" do
+            json_object = {
+              locale: "en",
+              meta_description: "Description of site",
+              meta_keywords: "keywords,for,site",
+              name: "Test Site"
+            }
+
+            expect(resource_drop.as_json).to eq(json_object.as_json)
+          end
+        end
+
+        context "#to_json" do
+          it "returns hash of attributes" do
+            json_object = {
+              locale: "en",
+              meta_description: "Description of site",
+              meta_keywords: "keywords,for,site",
+              name: "Test Site"
+            }
+
+            expect(resource_drop.to_json).to eq(json_object.to_json)
+          end
+        end
+
+        context "#inspect" do
+          it "returns inspect string" do
+            expect(resource_drop.inspect)
+              .to include("#<Archangel::Liquid::Drops::SiteDrop")
+            expect(resource_drop.inspect)
+              .to include("#<Archangel::Site")
+          end
+        end
+      end
+    end
+  end
+end

data/spec/lib/archangel/liquid/filters/link_to_filter_spec.rb

@@ -11,10 +11,6 @@ module Archangel
           ::Liquid::Context.new({ "site" => site }, {}, view: view)
         end
 
-        def link_to(link_text, *args)
-          link_to(args.first, link_text)
-        end
-
         context "#link_to" do
           let(:link_text) { "Hello world!" }
 

data/spec/lib/archangel/liquid/tags/collection_tag_spec.rb

@@ -7,7 +7,6 @@ module Archangel
     module Tags
       RSpec.describe CollectionTag, type: :liquid_tag do
         let(:site) { create(:site) }
-
         let(:context) do
           ::Liquid::Context.new({ "site" => site }, {}, view: view)
         end

data/spec/lib/archangel/liquid/tags/collectionfor_tag_spec.rb

@@ -7,7 +7,6 @@ module Archangel
     module Tags
       RSpec.describe CollectionforTag, type: :liquid_tag do
         let(:site) { create(:site) }
-
         let(:context) do
           ::Liquid::Context.new({ "site" => site }, {}, view: view)
         end