arcadia_cops 4.0.2 → 4.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6651da173543ee1ffb9d8e31b0dfda75c35ef5454f9d1ff054160ae5d621041a
-  data.tar.gz: d7e2497155d064da862d66b65a1163f5abe01ef1a0afee89df5e879ac46ea281
+  metadata.gz: 6fa3774ee46a2326ed47a8c64c089fd5fb681e2c0f4e1d56d3d09126d2ea72f0
+  data.tar.gz: d0dd3053c5f3f6edc72c04d2932f9d42a0622e9abec2332662e1649156179b48
 SHA512:
-  metadata.gz: dc99132ea7385e8d1e9cd2943b130fd2736dfef8f6a024b8b341fc4748ee519588f290c8af65c5806ef8460427d72ba21a4532a97bc9b36a54f7db12cb1cef59
-  data.tar.gz: '03087562410c086336d1d94f59431675a5b10bef7ad631acd27857e63eb15653c0bbc1fd5357a34f1d9e380f578c11ccee7963a650eb6b10f341a2a48356006f'
+  metadata.gz: 3431f7f1a85ce8dbea1e054057a52ba2604887debe3434f6fcdd98f552130924febe617414720089e4e3aedf956d80d2b2797873c959909385da18519303432a
+  data.tar.gz: 7feddebc66a0eea0b7ce21b0994a526b4a6e4daa52972a4531f25e8e67352e5510ca60634c1a14c0d851238c52dbfb9ddcb753315cd32fb6a2d41c2c7f088421

data/README.md

@@ -18,6 +18,8 @@ Add a new cop to the `enabled.yml`, bump the version, and put in a PR for review
 
 To see all cops including those that aren't enabled run `bundle exec rubocop --show-cops`.
 
+WHen developing custom cops, make sure to add specs and run run `bundle exec rspec` before releasing.
+
 ## Release
 
 Ensure you have bumped the version and run `rake release` to release to rubygems.org.

data/config/config.yml

@@ -4,6 +4,7 @@
 require:
   - rubocop-rails
   - rubocop-rspec
+  - ../lib/arcadia_cops.rb
 
 # Common configuration.
 AllCops:

data/config/enabled.yml

@@ -687,3 +687,9 @@ Style/Not:
 
 Style/NegatedUnless:
   Enabled: true
+
+ArcadiaCops/SimpleModifierConditional:
+  Enabled: true
+
+ArcadiaCops/SimpleUnless:
+  Enabled: true

data/lib/arcadia_cops/simple_modifier_conditional.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module ArcadiaCops
+  # Cop to tackle prevent more complicated modifier if/unless statements
+  # https://github.com/airbnb/ruby/blob/12435e8136d2adf710de999bc0f6bef01215df2c/rubocop-airbnb/lib/rubocop/cop/airbnb/simple_modifier_conditional.rb
+  class SimpleModifierConditional < RuboCop::Cop::Cop
+    MSG = 'Modifier if/unless usage is okay when the body is simple, ' \
+      'the condition is simple, and the whole thing fits on one line. ' \
+      'Otherwise, avoid modifier if/unless.'.freeze
+
+    def_node_matcher :multiple_conditionals?, '(if ({and or :^} ...) ...)'
+
+    def on_if(node)
+      return unless node.modifier_form?
+
+      if multiple_conditionals?(node) || node.multiline?
+        add_offense(node)
+      end
+    end
+  end
+end

data/lib/arcadia_cops/simple_unless.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module ArcadiaCops
+  # Cop to tackle prevent unless statements with multiple conditions
+  # https://github.com/airbnb/ruby/blob/12435e8136d2adf710de999bc0f6bef01215df2c/rubocop-airbnb/lib/rubocop/cop/airbnb/simple_unless.rb
+  class SimpleUnless < RuboCop::Cop::Cop
+    MSG = 'Unless usage is okay when there is only one conditional'.freeze
+
+    def_node_matcher :multiple_conditionals?, '(if ({and or :^} ...) ...)'
+
+    def on_if(node)
+      return unless node.unless?
+
+      add_offense(node) if multiple_conditionals?(node)
+    end
+  end
+end

data/lib/arcadia_cops.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+Dir.glob(File.expand_path('arcadia_cops/*.rb', File.dirname(__FILE__))).map(&method(:require))

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arcadia_cops
 version: !ruby/object:Gem::Version
-  version: 4.0.2
+  version: 4.0.3
 platform: ruby
 authors:
 - engineering
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-07 00:00:00.000000000 Z
+date: 2022-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -66,6 +66,20 @@ dependencies:
     - - ">"
       - !ruby/object:Gem::Version
         version: 2.0.2
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -80,7 +94,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Contains enabled rubocops for arcadia power ruby repos.
+description: Contains enabled rubocops for Arcadia ruby repos.
 email:
 - engineering@arcadia.com
 executables: []
@@ -90,6 +104,9 @@ files:
 - README.md
 - config/config.yml
 - config/enabled.yml
+- lib/arcadia_cops.rb
+- lib/arcadia_cops/simple_modifier_conditional.rb
+- lib/arcadia_cops/simple_unless.rb
 homepage: https://github.com/ArcadiaPower/arcadia_cops/
 licenses:
 - MIT
@@ -112,5 +129,5 @@ requirements: []
 rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
-summary: Arcadia Power Style Cops
+summary: Arcadia Style Cops
 test_files: []