arcadia_cops 4.0.0 → 4.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 714b9d3dc23913b5a89337e4a5551632776738ef54046942157ce6d06c112a7a
-  data.tar.gz: b7c9d8e5a4e0081656dadf9751c6fa268f163464647c088e24a9862e8d3b3160
+  metadata.gz: 6fa3774ee46a2326ed47a8c64c089fd5fb681e2c0f4e1d56d3d09126d2ea72f0
+  data.tar.gz: d0dd3053c5f3f6edc72c04d2932f9d42a0622e9abec2332662e1649156179b48
 SHA512:
-  metadata.gz: 966b8836e19926088a5df02b7f6e466c2afa13c34df55f2000e491bb251f3ea054c806ab255f9f3dc0e63d2b4c17a3a9c4faa35e88bbcbe6b86b1abf9c7e7637
-  data.tar.gz: 5d8b2ed5eb87eaea927afa7f76d7499cd4674b7d781eb10605e64b77ebe6ed453fc6c3b1cfda42b8a6e29d59c20d10324f596f96f27c0cd73b8c66a945e36d15
+  metadata.gz: 3431f7f1a85ce8dbea1e054057a52ba2604887debe3434f6fcdd98f552130924febe617414720089e4e3aedf956d80d2b2797873c959909385da18519303432a
+  data.tar.gz: 7feddebc66a0eea0b7ce21b0994a526b4a6e4daa52972a4531f25e8e67352e5510ca60634c1a14c0d851238c52dbfb9ddcb753315cd32fb6a2d41c2c7f088421

data/README.md

@@ -18,6 +18,8 @@ Add a new cop to the `enabled.yml`, bump the version, and put in a PR for review
 
 To see all cops including those that aren't enabled run `bundle exec rubocop --show-cops`.
 
+WHen developing custom cops, make sure to add specs and run run `bundle exec rspec` before releasing.
+
 ## Release
 
 Ensure you have bumped the version and run `rake release` to release to rubygems.org.

data/config/config.yml

@@ -4,6 +4,7 @@
 require:
   - rubocop-rails
   - rubocop-rspec
+  - ../lib/arcadia_cops.rb
 
 # Common configuration.
 AllCops:

data/config/enabled.yml

@@ -529,9 +529,6 @@ Lint/UselessAssignment:
 Lint/BinaryOperatorWithIdenticalOperands:
   Description: 'Checks for comparison of something with itself.'
 
-Lint/UselessElseWithoutRescue:
-  Description: 'Checks for useless `else` in `begin..end` without `rescue`.'
-
 Lint/UselessSetterCall:
   Description: 'Checks for useless setter call to a local variable.'
 
@@ -680,3 +677,19 @@ RSpec/ScatteredLet:
 
 RSpec/Focus:
   Enabled: true
+
+Style/AndOr:
+  Enabled: true
+  EnforcedStyle: always
+
+Style/Not:
+  Enabled: true
+
+Style/NegatedUnless:
+  Enabled: true
+
+ArcadiaCops/SimpleModifierConditional:
+  Enabled: true
+
+ArcadiaCops/SimpleUnless:
+  Enabled: true

data/lib/arcadia_cops/simple_modifier_conditional.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module ArcadiaCops
+  # Cop to tackle prevent more complicated modifier if/unless statements
+  # https://github.com/airbnb/ruby/blob/12435e8136d2adf710de999bc0f6bef01215df2c/rubocop-airbnb/lib/rubocop/cop/airbnb/simple_modifier_conditional.rb
+  class SimpleModifierConditional < RuboCop::Cop::Cop
+    MSG = 'Modifier if/unless usage is okay when the body is simple, ' \
+      'the condition is simple, and the whole thing fits on one line. ' \
+      'Otherwise, avoid modifier if/unless.'.freeze
+
+    def_node_matcher :multiple_conditionals?, '(if ({and or :^} ...) ...)'
+
+    def on_if(node)
+      return unless node.modifier_form?
+
+      if multiple_conditionals?(node) || node.multiline?
+        add_offense(node)
+      end
+    end
+  end
+end

data/lib/arcadia_cops/simple_unless.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module ArcadiaCops
+  # Cop to tackle prevent unless statements with multiple conditions
+  # https://github.com/airbnb/ruby/blob/12435e8136d2adf710de999bc0f6bef01215df2c/rubocop-airbnb/lib/rubocop/cop/airbnb/simple_unless.rb
+  class SimpleUnless < RuboCop::Cop::Cop
+    MSG = 'Unless usage is okay when there is only one conditional'.freeze
+
+    def_node_matcher :multiple_conditionals?, '(if ({and or :^} ...) ...)'
+
+    def on_if(node)
+      return unless node.unless?
+
+      add_offense(node) if multiple_conditionals?(node)
+    end
+  end
+end

data/lib/arcadia_cops.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+Dir.glob(File.expand_path('arcadia_cops/*.rb', File.dirname(__FILE__))).map(&method(:require))

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arcadia_cops
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.3
 platform: ruby
 authors:
 - engineering
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-23 00:00:00.000000000 Z
+date: 2022-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: 1.29.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: 1.29.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +66,20 @@ dependencies:
     - - ">"
       - !ruby/object:Gem::Version
         version: 2.0.2
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -80,7 +94,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Contains enabled rubocops for arcadia power ruby repos.
+description: Contains enabled rubocops for Arcadia ruby repos.
 email:
 - engineering@arcadia.com
 executables: []
@@ -90,11 +104,14 @@ files:
 - README.md
 - config/config.yml
 - config/enabled.yml
+- lib/arcadia_cops.rb
+- lib/arcadia_cops/simple_modifier_conditional.rb
+- lib/arcadia_cops/simple_unless.rb
 homepage: https://github.com/ArcadiaPower/arcadia_cops/
 licenses:
 - MIT
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -109,8 +126,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key:
+rubygems_version: 3.1.6
+signing_key: 
 specification_version: 4
-summary: Arcadia Power Style Cops
+summary: Arcadia Style Cops
 test_files: []