arcadia_cops 3.5.2 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1de22ddff459b8551fb3042552b94a683600fe2987581029c94d66f9cd982ee8
-  data.tar.gz: f0f15d8212cc4b70c9fc7b13db2f89cdee6eb9b0dc306040ffa159454a2d53e2
+  metadata.gz: 9a2a7f189612deeb9baccc7263d6073b50d2427cfbf872249f5542933c5d14d5
+  data.tar.gz: 64c10b3afbb78922b9bd45d4dc4c3e983d4af5b06c640cfcdf22046e9ad562f5
 SHA512:
-  metadata.gz: 175b4faf9ef5e8679c1aa1ed8b8da37f43bf33eb82b74f6489a8c2aa9702b1ec3b2174221757330763b6fa12209ae2824d6ac0a81e82d247e21ff1a9319089c4
-  data.tar.gz: 8bf405fc5f047876afa618158ee1e7c68a97196d0befa3c87ec7798267d0feb6f79c98cd4f699d98cc92226d471f90c635cf2d3eaf7746a052484a9567f5aa1f
+  metadata.gz: 7eb54852ac6432b17b03179224c483af855e743b2d5f1510f612fe06b46da9e460a8bb32e45304843fc3745f0004f005ebf7d8f429b7804b3d80632b67c070d9
+  data.tar.gz: 929226883a40d7b0a5add124a5c77154feecdc577d37cebbf888016592d6880eefca8d635d4c5a6caca755f21775864fe6b89508b8d06b8f85fd9bcbaeaa7d43

data/README.md

@@ -21,6 +21,8 @@ To see all cops including those that aren't enabled run `bundle exec rubocop --s
 ## Release
 
 Ensure you have bumped the version and run `rake release` to release to rubygems.org.
+If this command appears to be hanging, it's probably expecting an OTP code for authentication.
+Updating rubygems (`gem update --system`) and bundler (`bundle update --bundler`) seem to fix this.
 
 ## Other
 

data/config/config.yml

@@ -1,7 +1,9 @@
 # This is the default configuration file. Enabling and disabling is configured
 # in separate files. This file adds all other parameters apart from Enabled.
 
-require: rubocop-rspec
+require:
+  - rubocop-rails
+  - rubocop-rspec
 
 # Common configuration.
 AllCops:
@@ -70,7 +72,4 @@ AllCops:
   # If a value is specified for TargetRubyVersion then it is used.
   # Else if .ruby-version exists and it contains an MRI version it is used.
   # Otherwise we fallback to the oldest officially supported Ruby version (2.1).
-  TargetRubyVersion: 2.5
-
-Rails:
-  Enabled: false
+  # TargetRubyVersion: 2.5 # SPECIFY IN PROJECT .ruby-version file

data/config/enabled.yml

@@ -6,18 +6,18 @@ Layout/AccessModifierIndentation:
   Description: Check indentation of private/protected visibility modifiers.
   StyleGuide: '#indent-public-private-protected'
 
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Description: >-
                  Align the elements of an array literal if they span more than
                  one line.
   StyleGuide: '#align-multiline-arrays'
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Description: >-
                  Align the elements of a hash literal if they span more than
                  one line.
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Description: Align the parameters of a method call if they span more than one line.
   StyleGuide: "#no-double-indent"
   EnforcedStyle: with_fixed_indentation
@@ -80,10 +80,6 @@ Style/CommentAnnotation:
                  (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
   StyleGuide: '#annotate-keywords'
 
-Naming/ClassAndModuleCamelCase:
-  Description: 'Use CamelCase for classes and modules.'
-  StyleGuide: '#camelcase-classes'
-
 Style/ClassAndModuleChildren:
   Description: 'Checks style of children classes and modules.'
 
@@ -166,7 +162,7 @@ Style/HashSyntax:
                  { :a => 1, :b => 2 }.
   StyleGuide: '#hash-literals'
 
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   Description: 'Checks the indentation of the first key in a hash literal.'
 
 Style/Lambda:
@@ -220,7 +216,7 @@ Layout/SpaceInsideParens:
 Layout/SpaceBeforeSemicolon:
   Description: 'No spaces before semicolons.'
 
-Layout/Tab:
+Layout/IndentationStyle:
   Description: 'No hard tabs.'
   StyleGuide: '#spaces-indentation'
 
@@ -228,7 +224,7 @@ Layout/TrailingWhitespace:
   Description: 'Avoid trailing whitespace.'
   StyleGuide: '#no-trailing-whitespace'
 
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Description: 'Checks trailing blank lines and final newline.'
   StyleGuide: '#newline-eof'
 
@@ -249,14 +245,6 @@ Metrics/AbcSize:
   Enabled: true
   Severity: refactor
 
-######### PERFORMANCE #########
-
-Performance/Size:
-  Description: >-
-                  Use `size` instead of `count` for counting
-                  the number of elements in `Array` and `Hash`.
-  Reference: 'https://github.com/JuanitoFatas/fast-ruby#arraycount-vs-arraysize-code'
-
 ######### RAILS #########
 
 Rails/ActionFilter:
@@ -382,7 +370,7 @@ Lint/DuplicateCaseCondition:
 Lint/DuplicateMethods:
   Description: 'Check for duplicate method definitions.'
 
-Lint/DuplicatedKey:
+Lint/DuplicateHashKey:
   Description: 'Check for duplicate keys in hash literals.'
 
 Lint/EachWithObjectArgument:
@@ -406,7 +394,7 @@ Lint/EmptyWhen:
 Layout/EndAlignment:
   Description: 'Align ends correctly.'
 
-Lint/EndInMethod:
+Style/EndBlock:
   Description: 'END blocks should not be placed inside method definitions.'
 
 Lint/EnsureReturn:
@@ -421,7 +409,7 @@ Lint/FloatOutOfRange:
 Lint/FormatParameterMismatch:
   Description: 'The number of parameters to format/sprint must match the fields.'
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Description: "Don't suppress exception."
   StyleGuide: '#dont-hide-exceptions'
 
@@ -500,7 +488,7 @@ Lint/ShadowingOuterLocalVariable:
                  Do not use the same name as outer local variable
                  for block arguments or block local variables.
 
-Lint/StringConversionInInterpolation:
+Lint/RedundantStringCoercion:
   Description: 'Checks for Object#to_s usage in string interpolation.'
   StyleGuide: '#no-to-s'
 
@@ -510,13 +498,13 @@ Lint/UnderscorePrefixedVariableName:
 Lint/UnifiedInteger:
   Description: 'Use Integer instead of Fixnum or Bignum'
 
-Lint/UnneededCopDisableDirective:
+Lint/RedundantCopDisableDirective:
   Description: >-
                  Checks for rubocop:disable comments that can be removed.
                  Note: this cop is not disabled when disabling all cops.
                  It must be explicitly disabled.
 
-Lint/UnneededSplatExpansion:
+Lint/RedundantSplatExpansion:
   Description: 'Checks for splat unnecessarily being called on literals'
 
 Lint/UnusedBlockArgument:
@@ -538,7 +526,7 @@ Lint/UselessAssignment:
   Description: 'Checks for useless assignment to a local variable.'
   StyleGuide: '#underscore-unused-vars'
 
-Lint/UselessComparison:
+Lint/BinaryOperatorWithIdenticalOperands:
   Description: 'Checks for comparison of something with itself.'
 
 Lint/UselessElseWithoutRescue:
@@ -567,14 +555,11 @@ Layout/FirstArrayElementLineBreak:
   Description: Checks for a line break before the first element in a multi-line array.
 
 Layout/IndentationConsistency:
-  Description: Keep indentation straight.
+  Description: This cop checks for inconsistent indentation.
   StyleGuide: "#spaces-indentation"
-  EnforcedStyle: rails
-
-Lint/Syntax:
-  Description: Checks syntax error
+  EnforcedStyle: indented_internal_methods
 
-Lint/UnneededRequireStatement:
+Lint/RedundantRequireStatement:
   Description: Checks for unnecessary `require` statement.
 
 Naming/AsciiIdentifiers:
@@ -618,7 +603,7 @@ Style/TrailingBodyOnModule:
 
 # RSpec
 
-FactoryBot/AttributeDefinedStatically:
+RSpec/FactoryBot/AttributeDefinedStatically:
   Description: Always declare attribute values as blocks.
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/AttributeDefinedStatically
 
@@ -644,10 +629,6 @@ RSpec/ImplicitExpect:
   EnforcedStyle: is_expected
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitExpect
 
-RSpec/InvalidPredicateMatcher:
-  Description: Checks invalid usage for predicate matcher.
-  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InvalidPredicateMatcher
-
 RSpec/IteratedExpectation:
   Description: Check that `all` matcher is used instead of iterating over an array.
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IteratedExpectation
@@ -699,3 +680,13 @@ RSpec/ScatteredLet:
 
 RSpec/Focus:
   Enabled: true
+
+Style/AndOr:
+  Enabled: true
+  EnforcedStyle: always
+
+Style/Not:
+  Enabled: true
+
+Style/NegatedUnless:
+  Enabled: true

metadata

@@ -1,43 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: arcadia_cops
 version: !ruby/object:Gem::Version
-  version: 3.5.2
+  version: 4.0.1
 platform: ruby
 authors:
-- justin
+- engineering
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-20 00:00:00.000000000 Z
+date: 2022-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.63.1
+        version: '1.26'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.63.1
+        version: '1.26'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.9'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.9'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.32'
+        version: '2.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.32'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -68,7 +82,7 @@ dependencies:
         version: '0'
 description: Contains enabled rubocops for arcadia power ruby repos.
 email:
-- justin@arcadiapower.com
+- engineering@arcadia.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -95,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Arcadia Power Style Cops