arcadia_cops 3.3.0 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1965af731f8b64305883c0dd8c915f4962ce57fc426eafd7bc2a04e8627690ef
-  data.tar.gz: 1c0f3379c1b27fb7bd684f27efb37b7af302cd505304abd653ff03ad0af029e5
+  metadata.gz: 714b9d3dc23913b5a89337e4a5551632776738ef54046942157ce6d06c112a7a
+  data.tar.gz: b7c9d8e5a4e0081656dadf9751c6fa268f163464647c088e24a9862e8d3b3160
 SHA512:
-  metadata.gz: a0a5e7004cf2edf2782076eb6f38c3e4d1918c532e9b35eca0b66e3d959392cbf1487cb789216e58baccab85c4e3e4c36f8ddfa568b38a3c673bc805f295090e
-  data.tar.gz: e08b9b2198adeb29bcc10db25503cc77711e90281050b365fd3a77013a1215ee68223f1b280709d200aa14903c674d6bab66fc1a2f85715610fe27fbb2f81366
+  metadata.gz: 966b8836e19926088a5df02b7f6e466c2afa13c34df55f2000e491bb251f3ea054c806ab255f9f3dc0e63d2b4c17a3a9c4faa35e88bbcbe6b86b1abf9c7e7637
+  data.tar.gz: 5d8b2ed5eb87eaea927afa7f76d7499cd4674b7d781eb10605e64b77ebe6ed453fc6c3b1cfda42b8a6e29d59c20d10324f596f96f27c0cd73b8c66a945e36d15

data/README.md

@@ -21,6 +21,8 @@ To see all cops including those that aren't enabled run `bundle exec rubocop --s
 ## Release
 
 Ensure you have bumped the version and run `rake release` to release to rubygems.org.
+If this command appears to be hanging, it's probably expecting an OTP code for authentication.
+Updating rubygems (`gem update --system`) and bundler (`bundle update --bundler`) seem to fix this.
 
 ## Other
 

data/config/config.yml

@@ -1,7 +1,9 @@
 # This is the default configuration file. Enabling and disabling is configured
 # in separate files. This file adds all other parameters apart from Enabled.
 
-require: rubocop-rspec
+require:
+  - rubocop-rails
+  - rubocop-rspec
 
 # Common configuration.
 AllCops:
@@ -70,7 +72,4 @@ AllCops:
   # If a value is specified for TargetRubyVersion then it is used.
   # Else if .ruby-version exists and it contains an MRI version it is used.
   # Otherwise we fallback to the oldest officially supported Ruby version (2.1).
-  TargetRubyVersion: 2.3
-
-Rails:
-  Enabled: false
+  # TargetRubyVersion: 2.5 # SPECIFY IN PROJECT .ruby-version file

data/config/enabled.yml

@@ -6,18 +6,18 @@ Layout/AccessModifierIndentation:
   Description: Check indentation of private/protected visibility modifiers.
   StyleGuide: '#indent-public-private-protected'
 
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Description: >-
                  Align the elements of an array literal if they span more than
                  one line.
   StyleGuide: '#align-multiline-arrays'
 
-Layout/AlignHash:
+Layout/HashAlignment:
   Description: >-
                  Align the elements of a hash literal if they span more than
                  one line.
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   Description: Align the parameters of a method call if they span more than one line.
   StyleGuide: "#no-double-indent"
   EnforcedStyle: with_fixed_indentation
@@ -80,10 +80,6 @@ Style/CommentAnnotation:
                  (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
   StyleGuide: '#annotate-keywords'
 
-Naming/ClassAndModuleCamelCase:
-  Description: 'Use CamelCase for classes and modules.'
-  StyleGuide: '#camelcase-classes'
-
 Style/ClassAndModuleChildren:
   Description: 'Checks style of children classes and modules.'
 
@@ -106,10 +102,6 @@ Style/TrailingCommaInArguments:
   Description: 'Checks for trailing comma in argument lists.'
   StyleGuide: '#no-trailing-params-comma'
 
-Style/TrailingCommaInArguments:
-  Description: 'Checks for trailing comma in argument lists.'
-  StyleGuide: '#no-trailing-params-comma'
-
 Style/TrailingCommaInArrayLiteral:
   Description: 'Checks for trailing comma in array literals.'
   StyleGuide: '#no-trailing-array-commas'
@@ -170,7 +162,7 @@ Style/HashSyntax:
                  { :a => 1, :b => 2 }.
   StyleGuide: '#hash-literals'
 
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   Description: 'Checks the indentation of the first key in a hash literal.'
 
 Style/Lambda:
@@ -224,7 +216,7 @@ Layout/SpaceInsideParens:
 Layout/SpaceBeforeSemicolon:
   Description: 'No spaces before semicolons.'
 
-Layout/Tab:
+Layout/IndentationStyle:
   Description: 'No hard tabs.'
   StyleGuide: '#spaces-indentation'
 
@@ -232,7 +224,7 @@ Layout/TrailingWhitespace:
   Description: 'Avoid trailing whitespace.'
   StyleGuide: '#no-trailing-whitespace'
 
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Description: 'Checks trailing blank lines and final newline.'
   StyleGuide: '#newline-eof'
 
@@ -253,14 +245,6 @@ Metrics/AbcSize:
   Enabled: true
   Severity: refactor
 
-######### PERFORMANCE #########
-
-Performance/Size:
-  Description: >-
-                  Use `size` instead of `count` for counting
-                  the number of elements in `Array` and `Hash`.
-  Reference: 'https://github.com/JuanitoFatas/fast-ruby#arraycount-vs-arraysize-code'
-
 ######### RAILS #########
 
 Rails/ActionFilter:
@@ -386,7 +370,7 @@ Lint/DuplicateCaseCondition:
 Lint/DuplicateMethods:
   Description: 'Check for duplicate method definitions.'
 
-Lint/DuplicatedKey:
+Lint/DuplicateHashKey:
   Description: 'Check for duplicate keys in hash literals.'
 
 Lint/EachWithObjectArgument:
@@ -410,7 +394,7 @@ Lint/EmptyWhen:
 Layout/EndAlignment:
   Description: 'Align ends correctly.'
 
-Lint/EndInMethod:
+Style/EndBlock:
   Description: 'END blocks should not be placed inside method definitions.'
 
 Lint/EnsureReturn:
@@ -425,7 +409,7 @@ Lint/FloatOutOfRange:
 Lint/FormatParameterMismatch:
   Description: 'The number of parameters to format/sprint must match the fields.'
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Description: "Don't suppress exception."
   StyleGuide: '#dont-hide-exceptions'
 
@@ -504,7 +488,7 @@ Lint/ShadowingOuterLocalVariable:
                  Do not use the same name as outer local variable
                  for block arguments or block local variables.
 
-Lint/StringConversionInInterpolation:
+Lint/RedundantStringCoercion:
   Description: 'Checks for Object#to_s usage in string interpolation.'
   StyleGuide: '#no-to-s'
 
@@ -514,13 +498,13 @@ Lint/UnderscorePrefixedVariableName:
 Lint/UnifiedInteger:
   Description: 'Use Integer instead of Fixnum or Bignum'
 
-Lint/UnneededCopDisableDirective:
+Lint/RedundantCopDisableDirective:
   Description: >-
                  Checks for rubocop:disable comments that can be removed.
                  Note: this cop is not disabled when disabling all cops.
                  It must be explicitly disabled.
 
-Lint/UnneededSplatExpansion:
+Lint/RedundantSplatExpansion:
   Description: 'Checks for splat unnecessarily being called on literals'
 
 Lint/UnusedBlockArgument:
@@ -542,7 +526,7 @@ Lint/UselessAssignment:
   Description: 'Checks for useless assignment to a local variable.'
   StyleGuide: '#underscore-unused-vars'
 
-Lint/UselessComparison:
+Lint/BinaryOperatorWithIdenticalOperands:
   Description: 'Checks for comparison of something with itself.'
 
 Lint/UselessElseWithoutRescue:
@@ -571,14 +555,11 @@ Layout/FirstArrayElementLineBreak:
   Description: Checks for a line break before the first element in a multi-line array.
 
 Layout/IndentationConsistency:
-  Description: Keep indentation straight.
+  Description: This cop checks for inconsistent indentation.
   StyleGuide: "#spaces-indentation"
-  EnforcedStyle: rails
-
-Lint/Syntax:
-  Description: Checks syntax error
+  EnforcedStyle: indented_internal_methods
 
-Lint/UnneededRequireStatement:
+Lint/RedundantRequireStatement:
   Description: Checks for unnecessary `require` statement.
 
 Naming/AsciiIdentifiers:
@@ -622,7 +603,7 @@ Style/TrailingBodyOnModule:
 
 # RSpec
 
-FactoryBot/AttributeDefinedStatically:
+RSpec/FactoryBot/AttributeDefinedStatically:
   Description: Always declare attribute values as blocks.
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/AttributeDefinedStatically
 
@@ -648,10 +629,6 @@ RSpec/ImplicitExpect:
   EnforcedStyle: is_expected
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitExpect
 
-RSpec/InvalidPredicateMatcher:
-  Description: Checks invalid usage for predicate matcher.
-  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/InvalidPredicateMatcher
-
 RSpec/IteratedExpectation:
   Description: Check that `all` matcher is used instead of iterating over an array.
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IteratedExpectation
@@ -679,3 +656,27 @@ Layout/SpaceInsideStringInterpolation:
 Style/ReturnNil:
   Description: Use return instead of return nil.
   EnforcedStyle: return
+
+Style/Dir:
+  Description: Use the `__dir__` method to retrieve the canonicalized absolute path
+    to the current file.
+  Enabled: true
+
+Style/ExpandPathArguments:
+  Description: Use `expand_path(__dir__)` instead of `expand_path('..', __FILE__)`.
+  Enabled: true
+
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Style/RedundantFreeze:
+  Enabled: true
+
+RSpec/ScatteredSetup:
+  Enabled: true
+
+RSpec/ScatteredLet:
+  Enabled: true
+
+RSpec/Focus:
+  Enabled: true

metadata

@@ -1,57 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: arcadia_cops
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 4.0.0
 platform: ruby
 authors:
-- justin
-autorequire: 
+- engineering
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-11-05 00:00:00.000000000 Z
+date: 2021-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.59.0
+        version: '1.13'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.59.0
+        version: '1.13'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.9'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.9'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.29'
+        version: '2.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.29'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -68,7 +82,7 @@ dependencies:
         version: '0'
 description: Contains enabled rubocops for arcadia power ruby repos.
 email:
-- justin@arcadiapower.com
+- engineering@arcadia.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -76,11 +90,11 @@ files:
 - README.md
 - config/config.yml
 - config/enabled.yml
-homepage: https://github.com/ArcadiaPower/rubocop/
+homepage: https://github.com/ArcadiaPower/arcadia_cops/
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -95,9 +109,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Arcadia Power Style Cops
 test_files: []