arca.rb 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81ac40aba0c7a3e67dc24402f3888da7af56ab40d785511da1ca310b2a3054e5
-  data.tar.gz: 41b29c0590307f836ccbe05d57d6f291382f0c545b6a8f1161533de6fcb24622
+  metadata.gz: dd4d89db0b9d4d77abb2b5e6eb0e03d3169893d511a0e2b066f12e3c1d613e2c
+  data.tar.gz: 49b8a96793606351fa4a9ca0b137cab1f7efc2459ef5604d9efffe0a20c5b54f
 SHA512:
-  metadata.gz: ca0895cc00a9f1ebe502fb3021f1305b9073ce1d28b5bab672cac50e124ee2639d88f472659ad17819b6295069e6a28d10603cd48e5d2390eb7fd6b9fe69c03f
-  data.tar.gz: 61c8e280fdd2f2d7e177e21fba6ddd5f2b46e25c1f98a98f93ead854e3ba747eb6c935723c5b02968c87913441152d7cdfd794369ac0ca7f6bd4c87d20542384
+  metadata.gz: 4b6060fe8e15d82e5ca2cf8cfa5f7651899ae10661df16a389b6cb43ddcfbed79f6303b17a126b654d40e1b5830ba78263f6a20f7af6d11a1fe36f89eee8c459
+  data.tar.gz: 02242344d53082a0b5b7f3b6aba1f004184b8aa8ac64e91ac9ed07b7f623a95191fe82582f0acd14256d616d5b2928f59b07471c73351887dcf7fb4b8af7342f

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Arca Changelog
 
+## [1.1.0]
+
+- **WSAA:** Store opcional para TA. Podés pasar `store:` con un objeto que implemente `read(cuit:, env:, service:)` y `write(cuit:, env:, service:, ta:, expires_at:)` para guardar el token en tu backend (p. ej. DB por tenant con cifrado). Sin `store`, se sigue usando el archivo JSON en `tmp/`.
+
 ## [1.0.2] - 2025-02-09
 
 - **Errores:** En WSAA, `persist_ta` ahora encapsula fallos en `Arca::ServerError` en lugar de re-levantar excepciones crudas (mejor encapsulación y menos riesgo de filtrar datos sensibles en logs).

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    arca.rb (1.0.2)
+    arca.rb (1.1.0)
       activesupport
       builder
       httpclient

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2025 ARCA Kit
+Copyright (c) 2025 driveton
 
 MIT License
 

data/README.md

@@ -75,7 +75,7 @@ Opción del constructor: `env: :development` o `env: :production` (symbol o stri
 
 ## Uso
 
-Opciones comunes del constructor: `env`, `cuit`, `key`, `cert`. Opcionales: `savon` (hash pasado a Savon), `ta_path` (WSAA), etc.
+Opciones comunes del constructor: `env`, `cuit`, `key`, `cert`. Opcionales: `savon` (hash pasado a Savon), `ta_path` (WSAA, path del archivo TA), `store` (WSAA, objeto con `read`/`write` para guardar TA en backend propio), etc.
 
 ### Cliente de bajo nivel (`Arca::Client`)
 
@@ -112,6 +112,11 @@ wsaa = Arca::WSAA.new(env: :development, cuit: '20123456789', key: key, cert: ce
 auth = wsaa.auth  # => { token: '...', sign: '...' }
 ```
 
+Opcionalmente podés pasar un **store** para guardar el TA en tu propio backend (por ejemplo DB por tenant con cifrado). Sin `store`, se usa un archivo JSON en `tmp/`. El store debe implementar:
+
+- **`read(cuit:, env:, service:)`** — devuelve `nil` o un Hash con claves simbólicas: `:token`, `:sign`, `:generation_time`, `:expiration_time` (Time o string ISO8601).
+- **`write(cuit:, env:, service:, ta:, expires_at:)`** — se invoca después de un `#login` exitoso; `ta` es el hash del TA y `expires_at` el Time de vencimiento.
+
 ### WSFE (Factura Electrónica)
 ```ruby
 ws = Arca::WSFE.new(env: :development, cuit: '20123456789', key: key, cert: cert)

data/lib/arca/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Arca
-  VERSION = "1.0.2"
+  VERSION = "1.1.0"
 end

data/lib/arca/wsaa.rb

@@ -4,7 +4,7 @@ require "json"
 
 module Arca
   class WSAA
-    attr_reader :key, :cert, :service, :ta, :cuit, :client, :env
+    attr_reader :key, :cert, :service, :ta, :cuit, :client, :env, :store
 
     WSDL = {
       development: "https://wsaahomo.afip.gov.ar/ws/services/LoginCms?wsdl",
@@ -20,6 +20,7 @@ module Arca
       @ttl = options[:ttl] || 2400
       @cuit = options[:cuit]
       @client = Client.new Hash(options[:savon]).reverse_merge(wsdl: WSDL[@env])
+      @store = options[:store]
       @ta_path = options[:ta_path] || default_ta_path
     end
 
@@ -79,6 +80,10 @@ module Arca
     end
 
     def restore_ta
+      if @store
+        return restore_ta_from_store
+      end
+
       return nil unless File.exist?(@ta_path) && !File.empty?(@ta_path)
 
       data = JSON.parse(File.read(@ta_path))
@@ -92,6 +97,27 @@ module Arca
       nil
     end
 
+    def restore_ta_from_store
+      h = @store.read(cuit: @cuit, env: @env, service: @service)
+      return nil if h.nil? || !h.is_a?(Hash)
+
+      {
+        token: h[:token],
+        sign: h[:sign],
+        generation_time: normalize_ta_time(h[:generation_time]),
+        expiration_time: normalize_ta_time(h[:expiration_time])
+      }
+    end
+
+    def normalize_ta_time(value)
+      return nil if value.nil?
+      return value if value.is_a?(Time)
+
+      Time.parse(value.to_s)
+    rescue ArgumentError
+      nil
+    end
+
     def ta_expirado?(ta)
       if ta.nil?
         true
@@ -103,6 +129,25 @@ module Arca
     end
 
     def persist_ta(ta)
+      if @store
+        begin
+          @store.write(
+            cuit: @cuit,
+            env: @env,
+            service: @service,
+            ta: ta,
+            expires_at: ta[:expiration_time]
+          )
+        rescue StandardError => e
+          raise ServerError, e
+        end
+        return
+      end
+
+      persist_ta_to_file(ta)
+    end
+
+    def persist_ta_to_file(ta)
       dir = File.dirname(@ta_path)
       FileUtils.mkdir_p(dir)
 

data/test/arca/wsaa_test.rb

@@ -86,5 +86,62 @@ module Arca
       assert_equal Errno::EACCES, error.cause.class
       assert_match(/Permission denied/, error.cause.message)
     end
+
+    def test_auth_con_store_usa_read_y_no_llama_login_si_ta_valido
+      Time.stubs(:now).returns(Time.local(2010, 1, 1))
+      ta = { token: "stored-token", sign: "stored-sign", generation_time: Time.now, expiration_time: Time.now + 3600 }
+      store = Object.new
+      store.expects(:read).with(cuit: "20123456789", env: :test, service: "wsfe").returns(ta)
+
+      ws = WSAA.new(cuit: "20123456789", env: :test, service: "wsfe", wsdl: Arca::WSFE::WSDL[:test], store: store)
+      ws.expects(:login).never
+
+      assert_equal({ token: "stored-token", sign: "stored-sign" }, ws.auth)
+    end
+
+    def test_auth_con_store_llama_login_y_write_cuando_read_devuelve_nil
+      Time.stubs(:now).returns(Time.local(2010, 1, 1))
+      ta = { token: "new-token", sign: "new-sign", generation_time: Time.now, expiration_time: Time.now + 60 }
+      store = Object.new
+      store.expects(:read).with(cuit: "20123456789", env: :test, service: "wsfe").returns(nil)
+      store.expects(:write).with(cuit: "20123456789", env: :test, service: "wsfe", ta: ta, expires_at: ta[:expiration_time]).returns(nil)
+
+      ws = WSAA.new(cuit: "20123456789", env: :test, service: "wsfe", wsdl: Arca::WSFE::WSDL[:test], store: store)
+      ws.expects(:login).returns(ta)
+
+      ws.auth
+    end
+
+    def test_auth_con_store_normaliza_tiempos_iso8601_de_read
+      Time.stubs(:now).returns(Time.local(2010, 1, 1))
+      gen_str = "2010-01-01T00:00:00-03:00"
+      exp_str = "2010-01-01T02:00:00-03:00"
+      store = Object.new
+      store.expects(:read).with(cuit: "20123456789", env: :test, service: "wsfe").returns({ token: "t", sign: "s", generation_time: gen_str, expiration_time: exp_str })
+
+      ws = WSAA.new(cuit: "20123456789", env: :test, service: "wsfe", wsdl: Arca::WSFE::WSDL[:test], store: store)
+      ws.expects(:login).never
+
+      ws.auth
+      assert_instance_of(Time, ws.ta[:generation_time])
+      assert_instance_of(Time, ws.ta[:expiration_time])
+      assert_equal(Time.parse(gen_str), ws.ta[:generation_time])
+      assert_equal(Time.parse(exp_str), ws.ta[:expiration_time])
+    end
+
+    def test_persist_ta_con_store_encapsula_errores_en_server_error
+      ta = { token: "t", sign: "s", generation_time: Time.now, expiration_time: Time.now + 60 }
+      store = Class.new do
+        def read(*) nil end
+        def write(*) raise Errno::EACCES, "Permission denied" end
+      end.new
+
+      ws = WSAA.new(cuit: "1", env: :test, service: "wsfe", wsdl: Arca::WSFE::WSDL[:test], store: store)
+      assert_same store, ws.store
+
+      error = assert_raises(ServerError) { ws.send(:persist_ta, ta) }
+      assert_equal Errno::EACCES, error.cause.class
+      assert_match(/Permission denied/, error.cause.message)
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: arca.rb
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Arca Kit