arbre 1.7.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 07b4de63d2e89a8ce69753438867bb05800ddc812b83bb630369dfbaec3df59d
-  data.tar.gz: 8299e5287279509ec6578db4686114852e92ed0d386ceeeed22cbd7d1170fc02
+  metadata.gz: '0665748c1473cada55c30990ab9f793067a8a5e35b9b18196806ae6a1f9bb93e'
+  data.tar.gz: afa9e30b8d3152dbfef8d2fccbdf15dda7a314b90ed8e5ae9b44f45b92f977ee
 SHA512:
-  metadata.gz: 9c01bb198d89bf938f853b2e0a4a674625cae8dfbd0fc56ed5fcc8bee974f92b451af63fd10b927c4ea61fcb88e6e78c81be8d2d3d8fe732347ca4b076b223c9
-  data.tar.gz: 020135f9ed8db3a1d085e623250fb33e90d98591960d0ef68251f81e8ec9a93d82c42daff18b539a5884d1a431819a678a8cd046327fb0815b43504069d46d7f
+  metadata.gz: 1343be599798c86f1f37e161f8c3ac8a437bac46d7f278eff760cd9876755b7017774097d92594f9daa1929745322330f823bc19640c09666bb4cb775ba75875
+  data.tar.gz: f5751659a62d3451018bee66c14e8160267c4af97c2cc74846933383de1dd12de1bd93a1e9ccf8732f755ca43b1794b4a5a5be32c17991d27ab179a16d53f880

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Changelog
 
-## Master (unreleased)
+## 2.0.0 [☰](https://github.com/activeadmin/arbre/compare/v1.7.0...v2.0.0)
+
+* Include empty attributes in HTML output. [#543][] by [@javierjulio][]
+* Remove table tag defaults. [#542][] by [@javierjulio][]
+* Remove component CSS class name default. [#545][] by [@javierjulio][]
 
 ## 1.7.0 [☰](https://github.com/activeadmin/arbre/compare/v1.6.0...v1.7.0)
 
@@ -127,6 +131,9 @@ Initial release and extraction from Active Admin
 [#456]: https://github.com/activeadmin/arbre/pull/456
 [#537]: https://github.com/activeadmin/arbre/pull/537
 [#539]: https://github.com/activeadmin/arbre/pull/539
+[#542]: https://github.com/activeadmin/arbre/pull/542
+[#543]: https://github.com/activeadmin/arbre/pull/543
+[#545]: https://github.com/activeadmin/arbre/pull/545
 
 [@aramvisser]: https://github.com/aramvisser
 [@LTe]: https://github.com/LTe

data/docs/index.md

@@ -49,7 +49,7 @@ This provides a simpler alternative to nesting partials.
 The recommended approach is to subclass Arbre::Component and implement a new builder method.
 
 The builder_method defines the method that will be called to build this component
-when using the DSL. The arguments passed into the builder_method will be passed 
+when using the DSL. The arguments passed into the builder_method will be passed
 into the #build method for you.
 
 For example:
@@ -66,7 +66,7 @@ class Panel < Arbre::Component
 end
 ```
 
-By default components are `div` tags with an HTML class corresponding to the component class name.  This can be overridden by redefining the `tag_name` method.
+By default, components are `div` tags. This can be overridden by redefining the `tag_name` method.
 
 Several examples of Arbre components are [included in Active Admin](https://activeadmin.info/12-arbre-components.html)
 
@@ -76,7 +76,7 @@ An [Arbre::Context](http://www.rubydoc.info/gems/arbre/Arbre/Context) is an obje
 
 ```ruby
 html = Arbre::Context.new do
-  panel "Hello World", id: "my-panel" do
+  panel "Hello World", class: "panel", id: "my-panel" do
     span "Inside the panel"
     text_node "Plain text"
   end

data/lib/arbre/component.rb

@@ -1,23 +1,9 @@
 # frozen_string_literal: true
 module Arbre
   class Component < Arbre::HTML::Div
-
     # By default components render a div
     def tag_name
       'div'
     end
-
-    def initialize(*)
-      super
-      add_class default_class_name
-    end
-
-    protected
-
-    # By default, add a css class named after the ruby class
-    def default_class_name
-      self.class.name.demodulize.underscore
-    end
-
   end
 end

data/lib/arbre/context.rb

@@ -26,7 +26,6 @@ module Arbre
   #     html.to_s #=> "Your number 1"
   #
   class Context < Element
-
     # Initialize a new Arbre::Context
     #
     # @param [Hash] assigns A hash of objecs that you would like to be
@@ -44,7 +43,7 @@ module Arbre
       @_current_arbre_element_buffer = [self]
 
       super(self)
-      instance_eval(&block) if block_given?
+      instance_eval(&block) if block
     end
 
     def arbre_context
@@ -98,7 +97,6 @@ module Arbre
 
     private
 
-
     # Caches the rendered HTML so that we don't re-render just to
     # get the content length or to delegate a method to the HTML
     def cached_html
@@ -110,6 +108,5 @@ module Arbre
         html
       end
     end
-
   end
 end

data/lib/arbre/element/builder_methods.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 module Arbre
   class Element
-
     module BuilderMethods
 
       def self.included(klass)
@@ -25,11 +24,11 @@ module Arbre
         tag.parent = current_arbre_element
 
         with_current_arbre_element tag do
-          if block_given? && block.arity > 0
+          if block && block.arity > 0
             tag.build(*args, &block)
           else
             tag.build(*args)
-            append_return_block(yield) if block_given?
+            append_return_block(yield) if block
           end
         end
 
@@ -78,6 +77,5 @@ module Arbre
 
       end
     end
-
   end
 end

data/lib/arbre/element.rb

@@ -185,6 +185,5 @@ module Arbre
         super
       end
     end
-
   end
 end

data/lib/arbre/element_collection.rb

@@ -3,7 +3,6 @@ module Arbre
 
   # Stores a collection of Element objects
   class ElementCollection < Array
-
     def +(other)
       self.class.new(super)
     end

data/lib/arbre/html/attributes.rb

@@ -3,18 +3,12 @@ module Arbre
   module HTML
 
     class Attributes < Hash
-
       def to_s
-        flatten_hash.map do |name, value|
-          next if value_empty?(value)
+        flatten_hash.compact.map do |name, value|
           "#{html_escape(name)}=\"#{html_escape(value)}\""
         end.compact.join ' '
       end
 
-      def any?
-        super{ |k,v| !value_empty?(v) }
-      end
-
       protected
 
       def flatten_hash(hash = self, old_path = [], accumulator = {})
@@ -29,10 +23,6 @@ module Arbre
         accumulator
       end
 
-      def value_empty?(value)
-        value.respond_to?(:empty?) ? value.empty? : !value
-      end
-
       def html_escape(s)
         ERB::Util.html_escape(s)
       end

data/lib/arbre/html/class_list.rb

@@ -6,7 +6,6 @@ module Arbre
 
     # Holds a set of classes
     class ClassList < Set
-
       def self.build_from_string(class_names)
         new.add(class_names)
       end
@@ -22,7 +21,6 @@ module Arbre
       def to_s
         to_a.join(" ")
       end
-
     end
 
   end

data/lib/arbre/html/document.rb

@@ -3,7 +3,6 @@ module Arbre
   module HTML
 
     class Document < Tag
-
       def build(*args)
         super
         build_head
@@ -30,7 +29,7 @@ module Arbre
 
       def build_head
         @head = head do
-          meta :"http-equiv" => "Content-type", content: "text/html; charset=utf-8"
+          meta "http-equiv": "Content-type", content: "text/html; charset=utf-8"
         end
       end
 

data/lib/arbre/html/html5_elements.rb

@@ -28,21 +28,5 @@ module Arbre
       builder_method :para
     end
 
-    class Table < Tag
-      def initialize(*)
-        super
-        set_table_tag_defaults
-      end
-
-      protected
-
-      # Set some good defaults for tables
-      def set_table_tag_defaults
-        set_attribute :border,      0
-        set_attribute :cellspacing, 0
-        set_attribute :cellpadding, 0
-      end
-    end
-
   end
 end

data/lib/arbre/html/tag.rb

@@ -165,7 +165,7 @@ module Arbre
         if record.class.respond_to?(:model_name)
           record.class.model_name.singular
         else
-          record.class.name.underscore.gsub("/", "_")
+          record.class.name.underscore.tr("/", "_")
         end
       end
 
@@ -184,7 +184,6 @@ module Arbre
       def default_id_for_prefix
         nil
       end
-
     end
 
   end

data/lib/arbre/html/text_node.rb

@@ -5,7 +5,6 @@ module Arbre
   module HTML
 
     class TextNode < Element
-
       builder_method :text_node
 
       # Builds a text node from a string

data/lib/arbre/rails/forms.rb

@@ -38,7 +38,6 @@ module Arbre
             super
           end
         end
-
       end
 
       class FormForProxy < FormBuilderProxy
@@ -70,11 +69,9 @@ module Arbre
         def closing_tag
           @closing_tag || ""
         end
-
       end
 
       class FieldsForProxy < FormBuilderProxy
-
         def build(form_builder, *args, &block)
           form_builder.fields_for(*args) do |f|
             @form_builder = f
@@ -86,7 +83,6 @@ module Arbre
         def to_s
           children.to_s
         end
-
       end
 
     end

data/lib/arbre/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Arbre
-  VERSION = "1.7.0"
+  VERSION = "2.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arbre
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Greg Bell
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-08 00:00:00.000000000 Z
+date: 2023-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport