arborist 0.3.0 → 0.4.0

data/spec/arborist/event/node_spec.rb

@@ -27,8 +27,10 @@ describe Arborist::Event::Node do
 
 
 	it "serializes with useful metadata attached" do
-		expect( event.to_h ).to include( :identifier, :parent, :nodetype )
+		expect( event.to_h ).to include( :identifier, :parent, :nodetype, :flapping )
 		expect( event.to_h[:nodetype] ).to eq( 'testnode' )
+		expect( event.to_h[:parent] ).to eq( 'bar' )
+		expect( event.to_h[:flapping] ).to eq( false )
 	end
 
 

data/spec/arborist/event_spec.rb

@@ -60,5 +60,15 @@ describe Arborist::Event do
 
 	end
 
+
+	describe "meta/informational predicate" do
+
+		it "returns false" do
+			event = described_class.new( 'chunky' => 'meat' )
+			expect( event ).to_not be_informational
+		end
+
+	end
+
 end
 

data/spec/arborist/manager_spec.rb

@@ -685,7 +685,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => true )
 			end
 
@@ -694,7 +694,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 				expect( hdr['reason'] ).to match( /respond to #each/ )
 			end
@@ -715,8 +715,6 @@ describe Arborist::Manager do
 				)
 				hdr, body = Arborist::TreeAPI.decode( resmsg )
 
-				sub_id = manager.subscriptions.keys.first
-
 				expect( hdr ).to include( 'success' => true )
 				expect( body ).to be_a( Hash )
 				expect( body ).to include( 'id' )
@@ -753,7 +751,7 @@ describe Arborist::Manager do
 				}.to change { manager.subscriptions.length }.by( 1 ).and(
 					change { manager.root.subscriptions.length }.by( 1 )
 				)
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				_hdr, body = Arborist::TreeAPI.decode( resmsg )
 				node = manager.subscriptions[ body['id'] ]
 				sub = node.subscriptions[ body['id'] ]
 
@@ -773,7 +771,7 @@ describe Arborist::Manager do
 				}.to change { manager.subscriptions.length }.by( 1 ).and(
 					change { manager.root.subscriptions.length }.by( 1 )
 				)
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				_hdr, body = Arborist::TreeAPI.decode( resmsg )
 				expect( body ).to be_a( Hash ).and( include('id') )
 				node = manager.subscriptions[ body['id'] ]
 				sub = node.subscriptions[ body['id'] ]
@@ -795,7 +793,7 @@ describe Arborist::Manager do
 				}.to change { manager.subscriptions.length }.by( 1 ).and(
 					change { manager.root.subscriptions.length }.by( 1 )
 				)
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				_hdr, body = Arborist::TreeAPI.decode( resmsg )
 				expect( body ).to be_a( Hash ).and( include('id') )
 				node = manager.subscriptions[ body['id'] ]
 				sub = node.subscriptions[ body['id'] ]
@@ -824,7 +822,7 @@ describe Arborist::Manager do
 				}.to change { manager.subscriptions.length }.by( -1 ).and(
 					change { manager.root.subscriptions.length }.by( -1 )
 				)
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				_hdr, body = Arborist::TreeAPI.decode( resmsg )
 
 				expect( body ).to include( 'event_type' => 'node.delta', 'criteria' => {'type' => 'host'} )
 			end
@@ -838,7 +836,7 @@ describe Arborist::Manager do
 					msg.send_to( sock )
 					resmsg = sock.receive
 				}.to_not change { manager.subscriptions.length }
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				_hdr, body = Arborist::TreeAPI.decode( resmsg )
 
 				expect( body ).to be_nil
 			end
@@ -891,7 +889,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 				expect( hdr['reason'] ).to match( /no identifier/i )
 			end
@@ -1000,7 +998,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 				expect( hdr['reason'] ).to match( /no host given/i )
 			end
@@ -1016,7 +1014,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 				expect( hdr['reason'] ).to match( /exists/i )
 			end
@@ -1038,7 +1036,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => true )
 
 				node = manager.nodes[ 'sidonie' ]
@@ -1061,7 +1059,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => true )
 
 				expect( manager.nodes['sidonie'] ).to be_an( Arborist::Node )
@@ -1081,7 +1079,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 				expect( manager.nodes['_'].identifier ).to eq( '_' )
 			end
@@ -1099,7 +1097,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 			end
 
@@ -1121,7 +1119,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => true )
 
 				new_parent = manager.nodes[ 'yevaud' ]
@@ -1178,7 +1176,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 				expect( hdr['reason'] ).to match( /no such node/i )
 			end
@@ -1189,7 +1187,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 				expect( hdr['reason'] ).to match( /no identifier/i )
 			end
@@ -1203,7 +1201,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 				expect( hdr['reason'] ).to match( /missing required ack sender/i )
 			end
@@ -1245,7 +1243,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 				expect( hdr['reason'] ).to match( /no such/i )
 			end
@@ -1256,7 +1254,7 @@ describe Arborist::Manager do
 				msg.send_to( sock )
 				resmsg = sock.receive
 
-				hdr, body = Arborist::TreeAPI.decode( resmsg )
+				hdr, _body = Arborist::TreeAPI.decode( resmsg )
 				expect( hdr ).to include( 'success' => false )
 				expect( hdr['reason'] ).to match( /no identifier/i )
 			end

data/spec/arborist/mixins_spec.rb

@@ -12,7 +12,9 @@ describe Arborist, "mixins" do
 	describe Arborist::MethodUtilities, 'used to extend a class' do
 
 		let!( :extended_class ) do
-			klass = Class.new
+			klass = Class.new do
+				def initialize; @foo = nil; end
+			end
 			klass.extend( Arborist::MethodUtilities )
 			klass
 		end

data/spec/arborist/node_spec.rb

@@ -27,6 +27,16 @@ describe Arborist::Node do
 	let( :identifier2 ) { 'the_other_identifier' }
 
 
+	### Suppress $VERBOSE warnings for the duration of a block
+	def with_warnings_suppressed
+		oldwarn = $VERBOSE
+		$VERBOSE = nil
+		yield
+	ensure
+		$VERBOSE = oldwarn
+	end
+
+
 	shared_examples_for "a reachable node" do
 
 		it "is still 'reachable'" do
@@ -114,11 +124,12 @@ describe Arborist::Node do
 			expect( subnode_class.parent_types ).to include( concrete_class )
 		end
 
-
 		it "can be constructed via a factory method on instances of their parent type" do
-			subnode_class = Class.new( described_class ) do
-				def self::name; "TestSubNode"; end
-				def self::plugin_name; "testsub"; end
+			subnode_class = with_warnings_suppressed do
+				Class.new( described_class ) do
+					def self::name; "TestSubNode"; end
+					def self::plugin_name; "testsub"; end
+				end
 			end
 			described_class.derivatives['testsub'] = subnode_class
 
@@ -133,17 +144,19 @@ describe Arborist::Node do
 
 
 		it "can pre-process the factory method arguments" do
-			subnode_class = Class.new( described_class ) do
-				def self::name; "TestSubNode"; end
-				def self::plugin_name; "testsub"; end
-				def args( new_args=nil )
-					@args = new_args if new_args
-					return @args
-				end
-				def modify( attributes )
-					attributes = stringify_keys( attributes )
-					super
-					self.args( attributes['args'] )
+			subnode_class = with_warnings_suppressed do
+				Class.new( described_class ) do
+					def self::name; "TestSubNode"; end
+					def self::plugin_name; "testsub"; end
+					def args( new_args=nil )
+						@args = new_args if new_args
+						return @args
+					end
+					def modify( attributes )
+						attributes = stringify_keys( attributes )
+						super
+						self.args( attributes['args'] )
+					end
 				end
 			end
 			described_class.derivatives['testsub'] = subnode_class
@@ -253,6 +266,36 @@ describe Arborist::Node do
 		end
 
 
+		it "stores a history of its status" do
+			node.status_history_size( 3 )
+
+			node.update( {} )
+			node.update( {} )
+			node.update( { warning: 'whoopsie' } )
+			node.update( {} )
+
+			expect( node.status_history ).to eq( ['up', 'warn', 'up'] )
+		end
+
+
+		it "knows if its status is transitioning frequently" do
+			node.status_history_size( 10 )
+			node.flap_threshold( 3 )
+
+			7.times{ node.update( {} ) }
+			node.update( { error: 'boooM!' } )
+			node.update( { warning: 'whoopsie' } )
+			node.update( {} )
+
+			expect( node ).to be_flapping
+
+			node.flap_threshold( 4 )
+			node.update( {} )
+
+			expect( node ).to_not be_flapping
+		end
+
+
 		it "groups errors from separate monitors by their key" do
 			expect( node ).to be_unknown
 
@@ -374,6 +417,17 @@ describe Arborist::Node do
 				}.to change { node.status }.from( 'up' ).to( 'quieted' )
 			end
 
+
+			it "records its transition to quieted in its status history" do
+				node.status_history_size( 3 )
+				down_event = Arborist::Event.create( :node_down, parent_node )
+
+				expect( node.status ).to eq( 'up' )
+				node.handle_event( down_event )
+				expect( node.status ).to eq( 'quieted' )
+
+				expect( node.status_history ).to eq( ['quieted'] )
+			end
 		end
 
 
@@ -795,12 +849,16 @@ describe Arborist::Node do
 				)
 				old_node.last_contacted = Time.now - 28
 				old_node.dependencies.mark_down( 'svchost-postgres' )
+				old_node.status_history << 'up'
+				old_node.flapping = true
 
 				node.restore( old_node )
 
 				expect( node.status ).to eq( old_node.status )
 				expect( node.status_changed ).to eq( old_node.status_changed )
 				expect( node.status_last_changed ).to eq( old_node.status_last_changed )
+				expect( node.status_history ).to eq( old_node.status_history )
+				expect( node.flapping? ).to eq( old_node.flapping? )
 				expect( node.errors ).to eq( old_node.errors )
 				expect( node.ack ).to eq( old_node.ack )
 				expect( node.properties ).to include( old_node.properties )
@@ -873,6 +931,8 @@ describe Arborist::Node do
 				expect( result[:errors] ).to be_empty
 				expect( result[:dependencies] ).to be_a( Hash )
 				expect( result[:quieted_reasons] ).to be_a( Hash )
+				expect( result[:status_history] ).to eq( node.status_history )
+				expect( result[:flapping] ).to eq( node.flapping? )
 
 				expect( result[:children] ).to be_empty
 			end
@@ -1147,7 +1207,7 @@ describe Arborist::Node do
 	describe "matching" do
 
 		let( :concrete_class ) do
-			cls = Class.new( described_class ) do
+			Class.new( described_class ) do
 				def self::name; "TestNode"; end
 			end
 		end

data/spec/arborist/observer/action_spec.rb

@@ -77,6 +77,31 @@ describe Arborist::Observer::Action do
 
 	end
 
+	context "ignoring flapping nodes" do
+
+		before( :each ) do
+			@call_count = 0
+			@last_call_arguments = nil
+		end
+
+		let( :action ) do
+			described_class.new( ignore_flapping: true ) do |args|
+				@call_count += 1
+				@last_call_arguments = args
+			end
+		end
+
+		let( :flapping_event ) { { 'flapping' => true } }
+
+		it "calls its block if the event is generated by a node that is not flapping" do
+			expect { action.handle_event(event) }.to change { @call_count }.by( 1 )
+		end
+
+		it "doesn't call its block if the event is generated by a flapping node" do
+			expect { action.handle_event(flapping_event) }.to_not change { @call_count }
+		end
+	end
+
 
 	# within: 0, after: 1, during: nil
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: arborist
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Michael Granger
@@ -11,32 +11,27 @@ bindir: bin
 cert_chain:
 - |
   -----BEGIN CERTIFICATE-----
-  MIIEbDCCAtSgAwIBAgIBATANBgkqhkiG9w0BAQUFADA+MQwwCgYDVQQDDANnZWQx
-  GTAXBgoJkiaJk/IsZAEZFglGYWVyaWVNVUQxEzARBgoJkiaJk/IsZAEZFgNvcmcw
-  HhcNMTcwOTI3MDAzMDQ0WhcNMTgwOTI3MDAzMDQ0WjA+MQwwCgYDVQQDDANnZWQx
-  GTAXBgoJkiaJk/IsZAEZFglGYWVyaWVNVUQxEzARBgoJkiaJk/IsZAEZFgNvcmcw
-  ggGiMA0GCSqGSIb3DQEBAQUAA4IBjwAwggGKAoIBgQC/JWGRHO+USzR97vXjkFgt
-  83qeNf2KHkcvrRTSnR64i6um/ziin0I0oX23H7VYrDJC9A/uoUa5nGRJS5Zw/+wW
-  ENcvWVZS4iUzi4dsYJGY6yEOsXh2CcF46+QevV8iE+UmbkU75V7Dy1JCaUOyizEt
-  TH5UHsOtUU7k9TYARt/TgYZKuaoAMZZd5qyVqhF1vV+7/Qzmp89NGflXf2xYP26a
-  4MAX2qqKX/FKXqmFO+AGsbwYTEds1mksBF3fGsFgsQWxftG8GfZQ9+Cyu2+l1eOw
-  cZ+lPcg834G9DrqW2zhqUoLr1MTly4pqxYGb7XoDhoR7dd1kFE2a067+DzWC/ADt
-  +QkcqWUm5oh1fN0eqr7NsZlVJDulFgdiiYPQiIN7UNsii4Wc9aZqBoGcYfBeQNPZ
-  soo/6za/bWajOKUmDhpqvaiRv9EDpVLzuj53uDoukMMwxCMfgb04+ckQ0t2G7wqc
-  /D+K9JW9DDs3Yjgv9k4h7YMhW5gftosd+NkNC/+Y2CkCAwEAAaN1MHMwCQYDVR0T
-  BAIwADALBgNVHQ8EBAMCBLAwHQYDVR0OBBYEFHKN/nkRusdqCJEuq3lgB3fJvyTg
-  MBwGA1UdEQQVMBOBEWdlZEBGYWVyaWVNVUQub3JnMBwGA1UdEgQVMBOBEWdlZEBG
-  YWVyaWVNVUQub3JnMA0GCSqGSIb3DQEBBQUAA4IBgQB/qyi5pCjK8ceoKalfVAjS
-  vG64FEnLnD1bm39T5UaFIRmo+abZtfpg2QhwKvPbPjOicau2+m+MDQ2Cc3tgyaC3
-  dZxcP6w8APFg4AId09uWAZKf0xajvBMS2aOz8Bbmag6fwqRRkTMqsNYnmqcF7aRT
-  DuEzbEMfaOUYjU9RuB48vr4q8yRft0ww+3jq5iwNkrX1buL2pwBbyvgms6D/BV41
-  MaTVMjsHqJUwU2xVfhGtxGAWAer5S1HGYHkbio6mGVtiie0uWjmnzi7ppIlMr48a
-  7BNTsoZ+/JRk3iQWmmNsyFT7xfqBKye7cH11BX8V8P4MeGB5YWlMI+Myj5DZY3fQ
-  st2AGD4rb1l0ia7PfubcBThSIdz61eCb8gRi/RiZZwb3/7+eyEncLJzt2Ob9fGSF
-  X0qdrKi+2aZZ0NGuFj9AItBsVmAvkBGIpX4TEKQp5haEbPpmaqO5nIIhV26PXmyT
-  OMKv6pWsoS81vw5KAGBmfX8nht/Py90DQrbRvakATGI=
+  MIIDbDCCAlSgAwIBAgIBATANBgkqhkiG9w0BAQUFADA+MQ8wDQYDVQQDDAZtYWhs
+  b24xFzAVBgoJkiaJk/IsZAEZFgdtYXJ0aW5pMRIwEAYKCZImiZPyLGQBGRYCbnUw
+  HhcNMTcxMTIyMjIyMTAyWhcNMTgxMTIyMjIyMTAyWjA+MQ8wDQYDVQQDDAZtYWhs
+  b24xFzAVBgoJkiaJk/IsZAEZFgdtYXJ0aW5pMRIwEAYKCZImiZPyLGQBGRYCbnUw
+  ggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDpXGN0YbMVpYv4EoiCxpQw
+  sxKdyhlkvpvENUkpEhbpnEuMKXgUfRHO4T/vBZf0h8eYgwnrHCRhAeIqesFKfoj9
+  mpEJk5JUuADOAz18aT+v24UqAtJdiwBJLuqhslSNB6CFXZv3OOMny9bjoJegz0hI
+  Fht9ppCuNmxJNd+L3zAX8lD01RUWNRC+8L5QLCjViJtjFDDCFfh9NCirs+XnTCzo
+  AJgFbsZIzFJtSiXUtFgscKr4Ik8ruhRbPbYbmx9rf6W74aTMPxggq/d3gj0Eh32y
+  WsXsQ5giVnmkbsRkBNu3QyZ8Xr5+7mvy5AWyqXKOrcW7lnYaob6Z9x/MGXGNeD6j
+  AgMBAAGjdTBzMAkGA1UdEwQCMAAwCwYDVR0PBAQDAgSwMB0GA1UdDgQWBBRY8ea6
+  +6kAaW7ukKph2/4MTAD8/TAcBgNVHREEFTATgRFtYWhsb25AbWFydGluaS5udTAc
+  BgNVHRIEFTATgRFtYWhsb25AbWFydGluaS5udTANBgkqhkiG9w0BAQUFAAOCAQEA
+  00FljTeSNaYUqJ59yLRA+i43wVNiO4ETQQu6fYQCPns12Sm90spOJb3SmTDkJ7CY
+  dixOQg5A3Et1LVS+Z/YfH1TAbb50oTWbZbTW2JknHS0hohq3UF1pvbkk1niZ26er
+  skJ352MUfcyaUkQyMmCjL/BpkDutYH5OCGh+FmK8+mH7SoC9Nr48WwH2prVdHs3y
+  OMWFgB33sXdj1XqOd2Rw1WPgAeMeDqWeIrRMpUhNZOwroaA1MAr60f9NIYxua/vx
+  n0YyneERGuHPSRZFgo72tGOqLpAlWnhPxRNqnayZmsg3hPPI87B6MTUI2UQ7VUdh
+  UrSf3b+cPoC8PNfjp8zsdw==
   -----END CERTIFICATE-----
-date: 2018-08-29 00:00:00.000000000 Z
+date: 2018-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: schedulability
@@ -44,14 +39,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '0.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.1'
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: loggability
   requirement: !ruby/object:Gem::Requirement
@@ -226,14 +221,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.10'
 - !ruby/object:Gem::Dependency
   name: hoe-highline
   requirement: !ruby/object:Gem::Requirement
@@ -338,14 +333,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.16'
+        version: '3.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.16'
+        version: '3.17'
 description: |-
   Arborist is a monitoring toolkit that follows the UNIX philosophy
   of small parts and loose coupling for stability, reliability, and