arachni 1.2.1 → 1.3

data/spec/components/plugins/meta/remedies/discovery_spec.rb

@@ -13,9 +13,10 @@ describe name_from_filename do
     context 'when issues have similar response bodies' do
         it 'marks them as untrusted and adds remarks' do
             run
+
             framework.report.issues.each do |issue|
-                issue.variations.map( &:untrusted? ).uniq == [true]
-                issue.variations.first.remarks[:meta_analysis].should be_true
+                expect(issue).to be_untrusted
+                expect(issue.remarks).to include :meta_analysis
             end
         end
     end

data/spec/components/plugins/meta/remedies/timing_attacks_spec.rb

@@ -20,11 +20,11 @@ describe name_from_filename do
                 next if issue.affected_input_name != 'untrusted_input'
 
                 checked += 1
-                issue.variations.first.should be_untrusted
-                issue.variations.first.remarks[:meta_analysis].should be_true
+                expect(issue).to be_untrusted
+                expect(issue.remarks).to include :meta_analysis
             end
 
-            checked.should > 0
+            expect(checked).to be > 0
         end
     end
 

data/spec/components/plugins/meta/uniformity_spec.rb

@@ -23,7 +23,7 @@ describe name_from_filename do
     it 'logs digests of issues which affect similar parameters across multiple pages' do
         run
 
-        actual_results[0].sort.should == @uniformals[1].map(&:digest).sort
-        actual_results[1].sort.should == @uniformals[0].map(&:digest).sort
+        expect(actual_results[0].sort).to eq(@uniformals[1].map(&:digest).sort)
+        expect(actual_results[1].sort).to eq(@uniformals[0].map(&:digest).sort)
     end
 end

data/spec/components/plugins/restrict_to_dom_state_spec.rb

@@ -11,6 +11,6 @@ describe name_from_filename do
         options.plugins[component_name] = { 'fragment' => 'stuff/blah' }
 
         run
-        framework.sitemap.should == { "#{options.url}#stuff/blah" => 200 }
+        expect(framework.sitemap).to eq({ "#{options.url}#stuff/blah" => 200 })
     end
 end

data/spec/components/plugins/script_spec.rb

@@ -8,6 +8,6 @@ describe name_from_filename do
         options.plugins[component_name] = { 'path' => fixtures_path + '/script_plugin.rb' }
 
         run
-        actual_results.should == 'I\'m a script!'
+        expect(actual_results).to eq('I\'m a script!')
     end
 end

data/spec/components/plugins/uncommon_headers_spec.rb

@@ -50,7 +50,7 @@ describe name_from_filename do
                 },
             ]
 
-            framework.plugins[component_name].merge( results ).should == {
+            expect(framework.plugins[component_name].merge( results )).to eq({
                 "#{url}" => {
                     "Name" => "Value",
                     "Name2" => "Value2"
@@ -58,7 +58,7 @@ describe name_from_filename do
                 "#{url}2" => {
                     "Name22" => "Value22"
                 }
-            }
+            })
         end
     end
 end

data/spec/components/plugins/vector_collector_spec.rb

@@ -38,6 +38,7 @@ __URL__:
     cookie1: val1
   action: __URL__
   method: get
+  source: cookie1=val1; domain=127.0.0.2; path=/; HttpOnly
 __URL__link?link_input=blah:
 - class: Arachni::Element::Cookie
   type: :cookie
@@ -46,8 +47,7 @@ __URL__link?link_input=blah:
     cookie1: val1
   action: __URL__link?link_input=blah
   method: get
-
-
+  source: cookie1=val1; domain=127.0.0.2; path=/; HttpOnly
 YAML
     end
 

data/spec/components/plugins/vector_feed_spec.rb

@@ -67,96 +67,96 @@ describe name_from_filename do
             next if page.code != 200
 
             if page.response.headers.any?
-                page.url.should  == v.first['url']
-                page.code.should == v.first['code']
-                page.body.should == v.first['body']
+                expect(page.url).to  eq(v.first['url'])
+                expect(page.code).to eq(v.first['code'])
+                expect(page.body).to eq(v.first['body'])
 
-                page.response.headers.should == v.first['headers']
+                expect(page.response.headers).to eq(v.first['headers'])
 
                 oks += 1
             end
 
             if page.cookies.any?
-                page.cookies.size.should == 1
+                expect(page.cookies.size).to eq(1)
                 cookie = v.select { |vector| vector['type'] == 'cookie' }.first
-                page.cookies.first.action.should == cookie['action']
-                page.cookies.first.inputs.should == cookie['inputs']
+                expect(page.cookies.first.action).to eq(cookie['action'])
+                expect(page.cookies.first.inputs).to eq(cookie['inputs'])
 
-                page.url.should  == cookie['action']
-                page.code.should == 200
-                page.body.should == ''
+                expect(page.url).to  eq(cookie['action'])
+                expect(page.code).to eq(200)
+                expect(page.body).to eq('')
 
                 oks += 1
             end
 
             if page.links.any?
                 link = v.select { |vector| vector['type'] == 'link' }.first
-                page.links.first.action.should == link['action']
-                page.links.first.inputs.should == link['inputs']
+                expect(page.links.first.action).to eq(link['action'])
+                expect(page.links.first.inputs).to eq(link['inputs'])
 
-                page.url.should  == url
-                page.code.should == 200
-                page.body.should == ''
+                expect(page.url).to  eq(url)
+                expect(page.code).to eq(200)
+                expect(page.body).to eq('')
 
                 oks += 1
             end
 
             if page.forms.any?
                 form = v.select { |vector| vector['type'] == 'form' }.first
-                page.forms.first.action.should == form['action']
-                page.forms.first.inputs.should == form['inputs']
+                expect(page.forms.first.action).to eq(form['action'])
+                expect(page.forms.first.inputs).to eq(form['inputs'])
 
-                page.forms.first.immutables.include?( form['skip'].first ).should be_true
+                expect(page.forms.first.immutables.include?( form['skip'].first )).to be_truthy
 
-                page.url.should  == url
-                page.code.should == 200
-                page.body.should == ''
+                expect(page.url).to  eq(url)
+                expect(page.code).to eq(200)
+                expect(page.body).to eq('')
 
                 oks += 1
             end
 
             if page.headers.any?
                 header = v.select { |vector| vector['type'] == 'header' }.first
-                page.headers.first.action.should == header['action']
-                page.headers.first.inputs.should == header['inputs']
+                expect(page.headers.first.action).to eq(header['action'])
+                expect(page.headers.first.inputs).to eq(header['inputs'])
 
-                page.url.should  == header['action']
-                page.code.should == 200
-                page.body.should == ''
+                expect(page.url).to  eq(header['action'])
+                expect(page.code).to eq(200)
+                expect(page.body).to eq('')
 
                 oks += 1
             end
 
             if page.jsons.any?
                 json = v.select { |vector| vector['type'] == 'json' }.first
-                page.jsons.first.action.should == json['action']
-                page.jsons.first.source.should == json['source']
-                page.jsons.first.inputs.should == { 'name' => 'value' }
+                expect(page.jsons.first.action).to eq(json['action'])
+                expect(page.jsons.first.source).to eq(json['source'])
+                expect(page.jsons.first.inputs).to eq({ 'name' => 'value' })
 
-                page.url.should  == json['action']
-                page.code.should == 200
-                page.body.should == ''
+                expect(page.url).to  eq(json['action'])
+                expect(page.code).to eq(200)
+                expect(page.body).to eq('')
 
                 oks += 1
             end
 
             if page.xmls.any?
                 xml = v.select { |vector| vector['type'] == 'xml' }.first
-                page.xmls.first.action.should == xml['action']
-                page.xmls.first.source.should == xml['source']
-                page.xmls.first.inputs.should == {
+                expect(page.xmls.first.action).to eq(xml['action'])
+                expect(page.xmls.first.source).to eq(xml['source'])
+                expect(page.xmls.first.inputs).to eq({
                     'forgot > username > text()' => 'admin'
-                }
+                })
 
-                page.url.should  == xml['action']
-                page.code.should == 200
-                page.body.should == ''
+                expect(page.url).to  eq(xml['action'])
+                expect(page.code).to eq(200)
+                expect(page.body).to eq('')
 
                 oks += 1
             end
         end
 
-        oks.should == 7
+        expect(oks).to eq(7)
     end
 
     def run_test

data/spec/components/plugins/waf_detector_spec.rb

@@ -14,10 +14,10 @@ describe name_from_filename do
 
                 run
 
-                actual_results.should == {
+                expect(actual_results).to eq({
                     'status'  => 'found',
                     'message' => plugin::STATUSES[:found]
-                }
+                })
             end
         end
 
@@ -27,10 +27,10 @@ describe name_from_filename do
 
                 run
 
-                actual_results.should == {
+                expect(actual_results).to eq({
                     'status'  => 'not_found',
                     'message' => plugin::STATUSES[:not_found]
-                }
+                })
             end
         end
     end
@@ -41,10 +41,10 @@ describe name_from_filename do
 
             run
 
-            actual_results.should == {
+            expect(actual_results).to eq({
                 'status'  => 'inconclusive',
                 'message' => plugin::STATUSES[:inconclusive]
-            }
+            })
         end
     end
 end

data/spec/components/reporters/json_spec.rb

@@ -5,13 +5,13 @@ describe name_from_filename do
 
     test_with_full_report do
         json = IO.read( outfile ).force_encoding( 'UTF-8' )
-        JSON.pretty_generate( full_report.to_hash ).should == json
-        JSON.load( json ).is_a?( Hash ).should be_true
+        expect(JSON.pretty_generate( full_report.to_hash )).to eq(json)
+        expect(JSON.load( json ).is_a?( Hash )).to be_truthy
     end
 
     test_with_empty_report do
         json = IO.read( outfile )
-        JSON.pretty_generate( empty_report.to_hash ).should == json
-        JSON.load( json ).is_a?( Hash ).should be_true
+        expect(JSON.pretty_generate( empty_report.to_hash )).to eq(json)
+        expect(JSON.load( json ).is_a?( Hash )).to be_truthy
     end
 end

data/spec/components/reporters/marshal_spec.rb

@@ -4,10 +4,10 @@ describe name_from_filename do
     include_examples 'reporter'
 
     test_with_full_report do
-        Marshal.dump( full_report.to_h ).should == IO.read( outfile )
+        expect(Marshal.dump( full_report.to_h )).to eq(IO.read( outfile ))
     end
 
     test_with_empty_report do
-        Marshal.dump( empty_report.to_h ).should == IO.read( outfile )
+        expect(Marshal.dump( empty_report.to_h )).to eq(IO.read( outfile ))
     end
 end

data/spec/components/reporters/yaml_spec.rb

@@ -4,11 +4,12 @@ describe name_from_filename do
     include_examples 'reporter'
 
     test_with_full_report do
-        full_report.to_h.to_yaml.recode.should ==
+        expect(full_report.to_h.to_yaml.recode).to eq(
             IO.read( outfile ).force_encoding( 'UTF-8' )
+        )
     end
 
     test_with_empty_report do
-        empty_report.to_h.to_yaml.should == IO.binread( outfile )
+        expect(empty_report.to_h.to_yaml).to eq(IO.binread( outfile ))
     end
 end

data/spec/external/wavsep/active/sqli_spec.rb

@@ -102,9 +102,7 @@ describe 'WAVSEP SQL Injection' do
             # Timing attack issues can be marked as untrusted sometimes to
             # indicate the possibility of a false positive, make sure we've only
             # got trusted issues.
-            issue.should be_trusted
-
-            issue.variations.each { |v| v.should be_trusted }
+            expect(issue).to be_trusted
         end
     end
 end

data/spec/spec_helper.rb

@@ -35,6 +35,10 @@ RSpec.configure do |config|
     config.add_formatter :documentation
     config.include PageHelpers
 
+    config.mock_with :rspec do |mocks|
+        mocks.yield_receiver_to_any_instance_implementation_blocks = true
+    end
+
     config.before( :all ) do
         killall
         reset_all

data/spec/support/factories/element/ui_form.rb

@@ -0,0 +1,14 @@
+Factory.define :ui_form, class: Arachni::Element::UIForm,
+               options: {
+                   url:          'http://test.com',
+                   source:       '<button id="myname" />',
+                   method:       'click',
+                   inputs:       { 'my-input' => 'stuff' },
+                   opening_tags: {
+                       'my-input' => "<input id=\"my-input\" type=\"text\" value=\"stuff\">"
+                   }
+               }
+
+Factory.define :ui_form_dom do
+    Factory[:ui_form].dom
+end

data/spec/support/factories/element/ui_input.rb

@@ -0,0 +1,13 @@
+Factory.define :ui_input, class: Arachni::Element::UIInput,
+               options: {
+                   url:    'http://test.com',
+                   source: '<input id="myname" />',
+                   method: 'input',
+                   inputs: {
+                       'myname' => ''
+                   }
+               }
+
+Factory.define :ui_input_dom do
+    Factory[:ui_input].dom
+end

data/spec/support/factories/issue.rb

@@ -52,16 +52,3 @@ end
 Factory.define :issue_empty do
     Arachni::Issue.new( vector: Factory[:vector] )
 end
-
-Factory.define :issue_with_variations do
-    root = Factory[:active_issue].with_variations
-
-    10.times do |i|
-        root.variations << Factory[:active_issue].as_variation.tap do |issue|
-            issue.vector.affected_input_value = i.to_s
-            issue.vector.seed                 = i.to_s
-        end
-    end
-
-    root
-end

data/spec/support/fixtures/{taint_check/taint.rb → signature_check/signature.rb}

@@ -6,7 +6,7 @@
     web site for more information on licensing and terms of use.
 =end
 
-class Arachni::Checks::Taint < Arachni::Check::Base
+class Arachni::Checks::Signature < Arachni::Check::Base
 
     def run
         audit '--seed', submit: { train: true }
@@ -14,7 +14,7 @@ class Arachni::Checks::Taint < Arachni::Check::Base
 
     def self.info
         {
-            name:        'Taint check',
+            name:        'Signature check',
             description: %q{Test description},
             author:      'Tasos "Zapotek" Laskos <tasos.laskos@arachni-scanner.com>',
             version:     '0.1',

data/spec/support/helpers/browser_cluster/jobs/taint_tracer.rb

@@ -1,32 +1,32 @@
 def browser_cluster_job_taint_tracer_execution_flow_check_pages( pages )
     page = pages.find { |page| page.dom.execution_flow_sinks.any? }
-    page.dom.data_flow_sinks.should be_empty
+    expect(page.dom.data_flow_sinks).to be_empty
 
     sink = page.dom.execution_flow_sinks
-    sink.size.should == 1
+    expect(sink.size).to eq(1)
 
     trace = sink.first.trace
-    trace.size.should == 2
-    trace[0].function.source.should include 'log_execution_flow_sink()'
-    trace[1].function.source.should start_with 'function onsubmit'
+    expect(trace.size).to eq(2)
+    expect(trace[0].function.source).to include 'log_execution_flow_sink()'
+    expect(trace[1].function.source).to start_with 'function onsubmit'
 end
 
 def browser_cluster_job_taint_tracer_data_flow_check_pages( pages )
     page = pages.find { |page| page.dom.data_flow_sinks.any? }
-    page.dom.execution_flow_sinks.should be_empty
+    expect(page.dom.execution_flow_sinks).to be_empty
 
     sink = page.dom.data_flow_sinks
-    sink.size.should == 1
+    expect(sink.size).to eq(1)
 
-    sink.first.function.name.should == 'process'
+    expect(sink.first.function.name).to eq('process')
 end
 
 def browser_cluster_job_taint_tracer_data_flow_with_injector_check_pages( pages )
     page = pages.find { |page| page.dom.data_flow_sinks.any? }
-    page.dom.execution_flow_sinks.should be_empty
+    expect(page.dom.execution_flow_sinks).to be_empty
 
     sink = page.dom.data_flow_sinks
-    sink.size.should == 1
+    expect(sink.size).to eq(1)
 
-    sink.first.function.name.should == 'onClick'
+    expect(sink.first.function.name).to eq('onClick')
 end