arachni 1.1 → 1.2

data/spec/arachni/element/capabilities/analyzable/timeout_spec.rb

@@ -47,7 +47,7 @@ describe Arachni::Element::Capabilities::Analyzable::Timeout do
         context 'when #timing_attack_remark_data is' do
             context 'not nil' do
                 it 'duplicates it' do
-                    h = { stuff: 1 }
+                    h = { stuff: [1] }
 
                     subject.timing_attack_remark_data = h
 

data/spec/arachni/element/cookie/dom_spec.rb

@@ -62,15 +62,6 @@ describe Arachni::Element::Cookie::DOM do
         end
     end
 
-    %w(encode decode).each do |m|
-        describe "##{m}" do
-            it "delegates to #{Arachni::Element::Cookie}.#{m}" do
-                Arachni::Element::Cookie.stub(m) { |arg| "#{arg}1" }
-                subject.send( m, 'blah' ).should == 'blah1'
-            end
-        end
-    end
-
     describe '#type' do
         it 'returns :cookie_dom' do
             subject.type.should == :cookie_dom

data/spec/arachni/element/cookie_spec.rb

@@ -2,6 +2,7 @@ require 'spec_helper'
 
 describe Arachni::Element::Cookie do
     it_should_behave_like 'element'
+    it_should_behave_like 'with_source'
     it_should_behave_like 'with_dom'
     it_should_behave_like 'auditable', single_input: true
 
@@ -452,6 +453,7 @@ describe Arachni::Element::Cookie do
             cookie.name.should == 'coo@ki e2'
             cookie.value.should == 'blah val2@'
             cookie.path.should == '/stuff'
+            cookie.source.should == sc3
         end
 
         context 'when there is no path' do
@@ -465,6 +467,44 @@ describe Arachni::Element::Cookie do
                 cookie.path.should == '/'
             end
         end
+
+        context 'when its value is' do
+            let(:value) { 'a' * size }
+            let(:cookie) { "cookie=#{value}; Expires=Thu, 01 Jan 1970 00:00:01 GMT; Domain=.foo.com; HttpOnly" }
+
+            context "equal to #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE }
+
+                it 'returns empty array' do
+                    described_class.from_set_cookie(
+                        'http://test.com/stuff',
+                        cookie
+                    ).first.value.should be_empty
+                end
+            end
+
+            context "larger than #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE + 1 }
+
+                it 'sets empty value' do
+                    described_class.from_set_cookie(
+                        'http://test.com/stuff',
+                        cookie
+                    ).first.value.should be_empty
+                end
+            end
+
+            context "smaller than #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE - 1 }
+
+                it 'leaves the values alone' do
+                    described_class.from_set_cookie(
+                        'http://test.com/stuff',
+                        cookie
+                    ).first.value.should == value
+                end
+            end
+        end
     end
 
     describe '.from_string' do
@@ -485,6 +525,51 @@ describe Arachni::Element::Cookie do
              c.name.should == 'name2'
              c.value.should == 'value2'
         end
+
+        it 'can handle v1 values' do
+            described_class.from_string(
+                'http://owner-url.com',
+                'cookie="blah stuff"'
+            ).first.value.should == 'blah stuff'
+        end
+
+        context 'when its value is' do
+            let(:value) { 'a' * size }
+            let(:cookie) { "cookie=#{value}" }
+
+            context "equal to #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE }
+
+                it 'sets empty value' do
+                    described_class.from_string(
+                        'http://owner-url.com',
+                        cookie
+                    ).first.value.should be_empty
+                end
+            end
+
+            context "larger than #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE + 1 }
+
+                it 'sets empty value' do
+                    described_class.from_string(
+                        'http://owner-url.com',
+                        cookie
+                    ).first.value.should be_empty
+                end
+            end
+
+            context "smaller than #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE - 1 }
+
+                it 'leaves the values alone' do
+                    described_class.from_string(
+                        'http://owner-url.com',
+                        cookie
+                    ).first.value.should == value
+                end
+            end
+        end
     end
 
 end

data/spec/arachni/element/form/dom_spec.rb

@@ -43,15 +43,6 @@ describe Arachni::Element::Form::DOM do
         end
     end
 
-    %w(encode decode).each do |m|
-        describe "##{m}" do
-            it "delegates to #{Arachni::Element::Form}.#{m}" do
-                Arachni::Element::Form.stub(m) { |arg| "#{arg}1" }
-                subject.send( m, 'blah' ).should == 'blah1'
-            end
-        end
-    end
-
     describe '#parent' do
         it 'returns the parent element' do
             subject.parent.should be_kind_of Arachni::Element::Form

data/spec/arachni/element/form_spec.rb

@@ -1076,12 +1076,55 @@ EOHTML
                     }
                 end
             end
+
+            context 'when its value is' do
+                let(:form) { described_class.from_document( url, form_html ).first }
+                let(:value) { 'a' * size }
+                let(:form_html) do
+                    '<html>
+                        <body>
+                            <form method="post" action="/form" name="my_form">
+                                <input type="text" name="input_1" value="' + value + '">
+                                <input type="text" name="input_2" value="val_2">
+                                <input type="submit">
+                            </form>
+                        </body>
+                    </html>'
+                end
+
+                context "equal to #{described_class::MAX_SIZE}" do
+                    let(:size) { described_class::MAX_SIZE }
+
+                    it 'returns empty array' do
+                        form.inputs['input_1'].should be_empty
+                        form.inputs['input_2'].should == 'val_2'
+                    end
+                end
+
+                context "larger than #{described_class::MAX_SIZE}" do
+                    let(:size) { described_class::MAX_SIZE + 1 }
+
+                    it 'sets empty value' do
+                        form.inputs['input_1'].should be_empty
+                        form.inputs['input_2'].should == 'val_2'
+                    end
+                end
+
+                context "smaller than #{described_class::MAX_SIZE}" do
+                    let(:size) { described_class::MAX_SIZE - 1 }
+
+                    it 'leaves the values alone' do
+                        form.inputs['input_1'].should == value
+                        form.inputs['input_2'].should == 'val_2'
+                    end
+                end
+            end
         end
     end
 
     describe '.encode' do
         it 'form-encodes the passed string' do
-            described_class.encode( '% value\ +=&;' ).should == '%25+value%5C+%2B%3D%26%3B'
+            described_class.encode( '% value\ +=&;' ).should == '%25%20value%5C%20%2B%3D%26%3B'
         end
     end
     describe '#encode' do
@@ -1093,12 +1136,12 @@ EOHTML
 
     describe '.decode' do
         it 'form-decodes the passed string' do
-            described_class.decode( '%25+value%5C+%2B%3D%26%3B' ).should == '% value\ +=&;'
+            described_class.decode( '%25%20value%5C%20%2B%3D%26%3B' ).should == '% value\ +=&;'
         end
     end
     describe '#decode' do
         it 'form-decodes the passed string' do
-            v = '%25+value%5C+%2B%3D%26%3B'
+            v = '%25%20value%5C%20%2B%3D%26%3B'
             subject.decode( v ).should == described_class.decode( v )
         end
     end

data/spec/arachni/element/json_spec.rb

@@ -517,6 +517,26 @@ describe Arachni::Element::JSON do
         context 'when there are no inputs' do
             it 'returns nil'
         end
+
+        context 'when it is' do
+            context "equal to #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE }
+
+                it 'returns nil'
+            end
+
+            context "larger than #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE + 1 }
+
+                it 'returns nil'
+            end
+
+            context "smaller than #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE - 1 }
+
+                it 'leaves parses it'
+            end
+        end
     end
 
 end

data/spec/arachni/element/link/dom_spec.rb

@@ -43,15 +43,6 @@ describe Arachni::Element::Link::DOM do
         end
     end
 
-    %w(encode decode).each do |m|
-        describe "##{m}" do
-            it "delegates to #{Arachni::Element::Link}.#{m}" do
-                Arachni::Element::Link.stub(m) { |arg| "#{arg}1" }
-                subject.send( m, 'blah' ).should == 'blah1'
-            end
-        end
-    end
-
     describe '#parent' do
         it 'returns the parent element' do
             subject.parent.should be_kind_of Arachni::Element::Link

data/spec/arachni/element/link_spec.rb

@@ -254,26 +254,51 @@ describe Arachni::Element::Link do
                 end
             end
         end
-    end
 
-    describe '.encode_query_params' do
-        it "encodes '='" do
-            v = 'stuff='
-            described_class.encode_query_params( v ).should == 'stuff%3D'
-        end
-    end
-    describe '#encode_query_params' do
-        it "encodes '='" do
-            v = 'stuff='
-            subject.encode_query_params( v ).should ==
-                described_class.encode_query_params( v )
+        context 'when its value is' do
+            let(:link) { described_class.from_document( url, link_html ).first }
+            let(:value) { 'a' * size }
+            let(:href) { "test?param=#{value}" }
+            let(:link_html) do
+                tpl = '<html>
+                           <body>
+                               <a href="%s"></a>
+                           </body>
+                      </html>'
+
+                tpl % href[0...size]
+            end
+
+            context "equal to #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE }
+
+                it 'returns empty array' do
+                    link.should be_nil
+                end
+            end
+
+            context "larger than #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE + 1 }
+
+                it 'sets empty value' do
+                    link.should be_nil
+                end
+            end
+
+            context "smaller than #{described_class::MAX_SIZE}" do
+                let(:size) { described_class::MAX_SIZE - 1 }
+
+                it 'leaves the values alone' do
+                    link.inputs['param'].should_not be_empty
+                end
+            end
         end
     end
 
     describe '.encode' do
         it 'URL-encodes the passed string' do
             v = '% value\ +=&;'
-            described_class.encode( v ).should == URI.encode( v )
+            described_class.encode( v ).should == '%25%20value%5C%20%2B%3D%26%3B'
         end
     end
     describe '#encode' do
@@ -285,13 +310,13 @@ describe Arachni::Element::Link do
 
     describe '.decode' do
         it 'URL-decodes the passed string' do
-            v = '%25+value%5C+%2B%3D%26%3B'
+            v = '%25%20value%5C%20%2B%3D%26%3B'
             described_class.decode( v ).should == URI.decode( v )
         end
     end
     describe '#decode' do
         it 'URL-decodes the passed string' do
-            v = '%25+value%5C+%2B%3D%26%3B'
+            v = '%25%20value%5C%20%2B%3D%26%3B'
             subject.decode( v ).should == described_class.decode( v )
         end
     end

data/spec/arachni/element/link_template/dom_spec.rb

@@ -60,14 +60,6 @@ describe Arachni::Element::LinkTemplate::DOM do
         end
     end
 
-    %w(encode decode).each do |m|
-        describe "##{m}" do
-            it 'returns the string as is' do
-                subject.send( m, 'blah' ).should == 'blah'
-            end
-        end
-    end
-
     describe '#parent' do
         it 'returns the parent element' do
             subject.parent.should be_kind_of Arachni::Element::LinkTemplate

data/spec/arachni/element/link_template_spec.rb

@@ -215,12 +215,8 @@ describe Arachni::Element::LinkTemplate do
     end
 
     describe '.encode' do
-        it "double encodes ';'" do
-            described_class.encode( 'test;' ).should == 'test%253B'
-        end
-
-        it "double encodes '/'" do
-            described_class.encode( 'test/' ).should == 'test%2F'
+        it 'URL-encodes the passed string' do
+            described_class.encode( 'test/;' ).should == 'test%2F%3B'
         end
     end
 

data/spec/arachni/element/server_spec.rb

@@ -75,16 +75,30 @@ describe Arachni::Element::Server do
                     name:      'Auditor',
                     shortname: 'auditor_test'
                 }
+                logged_issue.variations.first.proof.should ==
+                    logged_issue.variations.first.page.response.status_line
+
                 logged_issue.name.should == @auditor.class.info[:issue][:name]
                 logged_issue.trusted.should be_true
             end
 
-            it "does not push the response to the #{Arachni::Trainer}" do
-                file = @base_url + 'true'
-                auditable.log_remote_file_if_exists( file )
+            context 'when one issue is logged' do
+                it "does not push the response to the #{Arachni::Trainer}" do
+                    auditable.log_remote_file_if_exists( @base_url + 'true' )
 
-                @framework.trainer.should_not receive(:push)
-                @framework.http.run
+                    @framework.trainer.should_not receive(:push)
+                    @framework.http.run
+                end
+            end
+
+            context 'when multiple issues are logged' do
+                it "pushes the responses to the #{Arachni::Trainer}" do
+                    auditable.log_remote_file_if_exists( @base_url + 'true' )
+                    auditable.log_remote_file_if_exists( "#{url}/each_candidate_dom_element" )
+
+                    @framework.trainer.should receive(:push).twice
+                    @framework.http.run
+                end
             end
         end
 
@@ -94,12 +108,41 @@ describe Arachni::Element::Server do
                 @framework.http.run
                 Arachni::Data.issues.should be_empty
             end
+
+            it "does not push the responses to the #{Arachni::Trainer}" do
+                auditable.log_remote_file_if_exists( @base_url + 'false' )
+
+                @framework.trainer.should_not receive(:push)
+                @framework.http.run
+            end
         end
 
         context 'when issues are too similar' do
+            let(:check_url) { @base_url + 'true' }
+
+            it 'flags them as untrusted' do
+                10.times { auditable.log_remote_file_if_exists( check_url ) }
+                @framework.http.run
+
+                issues.should be_any
+                issues.each do |issue|
+                    issue.should be_untrusted
+                end
+            end
+
+            it 'assigns a remark' do
+                10.times { auditable.log_remote_file_if_exists( check_url ) }
+                @framework.http.run
+
+                issues.should be_any
+
+                issues.each do |issue|
+                    issue.remarks[:meta_analysis].should == [described_class::REMARK]
+                end
+            end
+
             it "does not push the responses to the #{Arachni::Trainer}" do
-                file = @base_url + 'true'
-                10.times { auditable.log_remote_file_if_exists( file ) }
+                10.times { auditable.log_remote_file_if_exists( url ) }
 
                 @framework.trainer.should_not receive(:push)
                 @framework.http.run
@@ -125,11 +168,33 @@ describe Arachni::Element::Server do
         end
 
         context 'without a custom 404 handler' do
+            it 'performs fingerprinting' do
+                url = @base_url + 'true'
+
+                # We run this twice because the cache is empty the first time
+                # around so we don't know what kind of handler we're dealing with.
+
+                auditable.remote_file_exist?( url ) {}
+                @framework.http.run
+
+                request = nil
+                @framework.http.on_complete do |response|
+                    next if url != response.url
+                    request = response.request
+                end
+
+                auditable.remote_file_exist?( url ) {}
+                @framework.http.run
+
+                request.fingerprint?.should be_true
+            end
+
             context 'when a remote file exists' do
                 it 'yields true' do
                     exists = false
                     auditable.remote_file_exist?( @base_url + 'true' ) { |bool| exists = bool }
                     @framework.http.run
+                    exists.should be_true
                 end
 
                 context 'on subsequent calls' do
@@ -165,9 +230,30 @@ describe Arachni::Element::Server do
             end
         end
 
-        context 'without a custom 404 handler' do
+        context 'with a custom 404 handler' do
             before { @_404_url = @base_url + 'custom_404/' }
 
+            it 'does not perform fingerprinting' do
+                url = @_404_url + 'true'
+
+                # We run this twice because the cache is empty the first time
+                # around so we don't know what kind of handler we're dealing with.
+
+                auditable.remote_file_exist?( url ) {}
+                @framework.http.run
+
+                request = nil
+                @framework.http.on_complete do |response|
+                    next if url != response.url
+                    request = response.request
+                end
+
+                auditable.remote_file_exist?( url ) {}
+                @framework.http.run
+
+                request.fingerprint?.should be_false
+            end
+
             context 'and the response' do
                 context 'is static' do
                     it 'yields false' do