arachni 1.0.6 → 1.1

data/spec/arachni/element/capabilities/analyzable/differential_spec.rb

@@ -4,6 +4,8 @@ describe Arachni::Element::Capabilities::Analyzable::Differential do
 
     before :all do
         Arachni::Options.url = @url = web_server_url_for( :differential )
+        Arachni::Options.audit.elements :links
+
         @auditor = Auditor.new( Arachni::Page.from_url( @url ), Arachni::Framework.new )
     end
 
@@ -11,6 +13,43 @@ describe Arachni::Element::Capabilities::Analyzable::Differential do
         @auditor.framework.reset
     end
 
+    subject { Arachni::Element::Link.new( url: url, inputs: inputs ).tap { |e| e.auditor = auditor } }
+    let(:auditor) { @auditor }
+    let(:url) { @url }
+    let(:inputs) { { 'input' => 'blah' } }
+
+    describe '#dup' do
+        context 'when #differential_analysis_options is' do
+            context 'nil' do
+                it 'skips it' do
+                    subject.differential_analysis_options.should be_nil
+                    dupped = subject.dup
+                    dupped.should == dupped
+                    dupped.differential_analysis_options.should be_nil
+                end
+            end
+
+            context 'not nil' do
+                it 'duplicates it' do
+                    h = { stuff: 1 }
+
+                    subject.differential_analysis_options = h
+
+                    dupped = subject.dup
+                    dupped.should == dupped
+                    dupped.differential_analysis_options.should == h
+                    dupped.differential_analysis_options.object_id.should_not == h.object_id
+                end
+            end
+        end
+    end
+
+    describe '#to_rpc_data' do
+        it "does not include 'differential_analysis_options'" do
+            subject.to_rpc_data.should_not include 'differential_analysis_options'
+        end
+    end
+
     describe '#differential_analysis' do
         before do
             @opts = {
@@ -19,112 +58,115 @@ describe Arachni::Element::Capabilities::Analyzable::Differential do
                     { 'good' => 'bad' }
                 ]
             }
-
-            @params = { 'input' => 'blah' }
         end
 
         context 'when the element action matches a skip rule' do
+            let(:url) { 'http://stuff.com/' }
+
             it 'returns false' do
-                auditable = Arachni::Element::Link.new( url: 'http://stuff.com/', inputs: @params )
-                auditable.differential_analysis( @opts ).should be_false
+                subject.differential_analysis( @opts ).should be_false
             end
         end
 
         context 'when response behavior suggests a vuln' do
+            let(:url) { @url + '/true' }
+
             it 'logs an issue' do
-                auditable = Arachni::Element::Link.new( url: @url + '/true', inputs: @params )
-                auditable.auditor = @auditor
-                auditable.differential_analysis( @opts )
-                @auditor.http.run
+                subject.differential_analysis( @opts )
+                auditor.http.run
 
                 results = Arachni::Data.issues.flatten
                 results.should be_any
                 results.first.vector.affected_input_name.should == 'input'
             end
+
+            it 'adds remarks' do
+                subject.differential_analysis( @opts )
+                auditor.http.run
+
+                Arachni::Data.issues.first.variations.first.remarks[:differential_analysis].size.should == 3
+            end
         end
 
-        context 'when responses are\'t consistent with vuln behavior' do
+        context "when responses aren't consistent with vulnerable behavior" do
+            let(:url) { @url + '/false' }
+
             it 'does not log any issues' do
-                auditable = Arachni::Element::Link.new( url: @url + '/false', inputs: @params )
-                auditable.auditor = @auditor
-                auditable.differential_analysis( @opts )
-                @auditor.http.run
+                subject.differential_analysis( @opts )
+                auditor.http.run
 
                 issues.should be_empty
             end
         end
 
         context 'when a request times out' do
+            let(:url) { @url + '/timeout' }
+
             it 'does not log any issues' do
-                auditable = Arachni::Element::Link.new( url: @url + '/timeout', inputs: @params )
-                auditable.auditor = @auditor
-                auditable.differential_analysis( @opts.merge( submit: { timeout: 1_000 } ) )
-                @auditor.http.run
+                subject.differential_analysis( @opts.merge( submit: { timeout: 1_000 } ) )
+                auditor.http.run
 
                 issues.should be_empty
 
                 Arachni::Element::Capabilities::Auditable.reset
 
-                auditable = Arachni::Element::Link.new( url: @url + '/timeout', inputs: @params )
-                auditable.auditor = @auditor
-                auditable.differential_analysis( @opts.merge( timeout: 3_000 ) )
-                @auditor.http.run
-                @auditor.http.run
+                subject.differential_analysis( @opts.merge( timeout: 3_000 ) )
+                auditor.http.run
 
                 issues.should be_any
             end
         end
 
         context 'when a false response has an empty body' do
+            let(:url) { @url + '/empty_false' }
+
             it 'does not log any issues' do
-                auditable = Arachni::Element::Link.new( url: @url + '/empty_false', inputs: @params )
-                auditable.auditor = @auditor
-                auditable.differential_analysis( @opts )
-                @auditor.http.run
+                subject.differential_analysis( @opts )
+                auditor.http.run
 
                 issues.should be_empty
             end
         end
 
         context 'when a true response has an empty body' do
+            let(:url) { @url + '/empty_true' }
+
             it 'does not log any issues' do
-                auditable = Arachni::Element::Link.new( url: @url + '/empty_true', inputs: @params )
-                auditable.auditor = @auditor
-                auditable.differential_analysis( @opts )
-                @auditor.http.run
+                subject.differential_analysis( @opts )
+                auditor.http.run
 
                 issues.should be_empty
             end
         end
 
         context 'when a true response has non 200 status' do
+            let(:url) { @url + '/non200_true' }
+
             it 'does not log any issues' do
-                auditable = Arachni::Element::Link.new( url: @url + '/non200_true', inputs: @params )
-                auditable.auditor = @auditor
-                auditable.differential_analysis( @opts )
-                @auditor.http.run
+                subject.differential_analysis( @opts )
+                auditor.http.run
 
                 issues.should be_empty
             end
         end
 
         context 'when a false response has non 200 status' do
+            let(:url) { @url + '/non200_false' }
+
             it 'does not log any issues' do
-                auditable = Arachni::Element::Link.new( url: @url + '/non200_false', inputs: @params )
-                auditable.auditor = @auditor
-                auditable.differential_analysis( @opts )
-                @auditor.http.run
+                subject.differential_analysis( @opts )
+                auditor.http.run
 
                 issues.should be_empty
             end
         end
 
         context 'when the control responses differ wildly' do
+            let(:url) { @url + '/unstable' }
+
             it 'does not log any issues' do
-                auditable = Arachni::Element::Link.new( url: @url + '/unstable', inputs: @params )
-                auditable.auditor = @auditor
-                auditable.differential_analysis( @opts )
-                @auditor.http.run
+                subject.differential_analysis( @opts )
+                auditor.http.run
 
                 issues.should be_empty
             end

data/spec/arachni/element/capabilities/analyzable/taint_spec.rb

@@ -4,6 +4,8 @@ describe Arachni::Element::Capabilities::Analyzable::Taint do
 
     before :all do
         Arachni::Options.url = @url = web_server_url_for( :taint )
+        Arachni::Options.audit.elements :links
+
         @auditor = Auditor.new( Arachni::Page.from_url( @url ), Arachni::Framework.new )
 
         @positive = Arachni::Element::Link.new( url: @url, inputs: { 'input' => '' } )

data/spec/arachni/element/capabilities/analyzable/timeout_spec.rb

@@ -9,6 +9,8 @@ describe Arachni::Element::Capabilities::Analyzable::Timeout do
 
     before :all do
         Arachni::Options.url = @url = web_server_url_for( :timeout )
+        Arachni::Options.audit.elements :links
+
         @framework = Arachni::Framework.new
     end
 
@@ -41,6 +43,29 @@ describe Arachni::Element::Capabilities::Analyzable::Timeout do
         }
     end
 
+    describe '#dup' do
+        context 'when #timing_attack_remark_data is' do
+            context 'not nil' do
+                it 'duplicates it' do
+                    h = { stuff: 1 }
+
+                    subject.timing_attack_remark_data = h
+
+                    dupped = subject.dup
+                    dupped.should == dupped
+                    dupped.timing_attack_remark_data.should == h
+                    dupped.timing_attack_remark_data.object_id.should_not == h.object_id
+                end
+            end
+        end
+    end
+
+    describe '#to_rpc_data' do
+        it "does not include 'timing_attack_remark_data'" do
+            subject.to_rpc_data.should_not include 'timing_attack_remark_data'
+        end
+    end
+
     describe '#timeout_id' do
         let(:action) { "#{@url}/action" }
 
@@ -256,31 +281,61 @@ describe Arachni::Element::Capabilities::Analyzable::Timeout do
             end
         end
 
-        context 'when the request times out by default' do
-            subject do
-                e = Arachni::Element::Link.new(
-                    url:    @url + '/sleep',
-                    inputs: inputs
-                )
-                e.auditor = auditor
-                e
+        context 'when the request times out' do
+            context 'by default' do
+                subject do
+                    e = Arachni::Element::Link.new(
+                        url:    @url + '/sleep',
+                        inputs: inputs
+                    )
+                    e.auditor = auditor
+                    e
+                end
+
+                it 'does not call the given block' do
+                    candidate = nil
+                    subject.timing_attack_probe( '__TIME__', options ) do |element|
+                        candidate ||= element
+                    end
+                    run
+
+                    candidate.should be_true
+
+                    verified = nil
+                    candidate.timing_attack_verify( 1000 ) do
+                        verified = true
+                    end
+
+                    verified.should be_nil
+                end
             end
 
-            it 'does not call the given block' do
-                candidate = nil
-                subject.timing_attack_probe( '__TIME__', options ) do |element|
-                    candidate ||= element
+            context 'due to filtering' do
+                subject do
+                    e = Arachni::Element::Link.new(
+                        url:    @url + '/waf',
+                        inputs: inputs
+                    )
+                    e.auditor = auditor
+                    e
                 end
-                run
 
-                candidate.should be_true
+                it 'does not call the given block' do
+                    candidate = nil
+                    subject.timing_attack_probe( 'payload-__TIME__', options ) do |element|
+                        candidate ||= element
+                    end
+                    run
 
-                verified = nil
-                candidate.timing_attack_verify( 1000 ) do
-                    verified = true
-                end
+                    candidate.should be_true
 
-                verified.should be_nil
+                    verified = nil
+                    candidate.timing_attack_verify( 1000 ) do
+                        verified = true
+                    end
+
+                    verified.should be_nil
+                end
             end
         end
 
@@ -292,6 +347,19 @@ describe Arachni::Element::Capabilities::Analyzable::Timeout do
     end
 
     describe '#timeout_analysis' do
+        it 'assigns assigns :timing_attack remarks' do
+            subject.timeout_analysis(
+                '__TIME__',
+                options.merge(
+                    timeout_divider: 1000,
+                    timeout:         2000
+                )
+            )
+            run
+
+            issues.first.remarks[:timing_attack].size.should == 3
+        end
+
         context 'when the element action matches a skip rule' do
             subject do
                 Arachni::Element::Link.new(

data/spec/arachni/element/capabilities/with_scope/scope_spec.rb

@@ -21,5 +21,14 @@ describe Arachni::Element::Capabilities::WithScope::Scope do
                 end
             end
         end
+
+        context "when #{Arachni::OptionGroups::Audit}#element?" do
+            context 'is false' do
+                it 'returns true' do
+                    Arachni::Options.audit.stub(:element?) { false }
+                    subject.should be_out
+                end
+            end
+        end
     end
 end

data/spec/arachni/element/cookie/dom_spec.rb

@@ -72,13 +72,13 @@ describe Arachni::Element::Cookie::DOM do
     end
 
     describe '#type' do
-        it 'returns :link_dom' do
+        it 'returns :cookie_dom' do
             subject.type.should == :cookie_dom
         end
     end
 
     describe '.type' do
-        it 'returns :link_dom' do
+        it 'returns :cookie_dom' do
             described_class.type.should == :cookie_dom
         end
     end

data/spec/arachni/element/cookie_spec.rb

@@ -42,10 +42,32 @@ describe Arachni::Element::Cookie do
         end
     end
 
+    describe '#to_rpc_data' do
+        let(:data) { subject.to_rpc_data }
+
+        it "converts initialization_options['expires'] to String" do
+            data['initialization_options']['expires'].should == subject.expires_at.to_s
+        end
+
+        it "converts data['expires'] to String" do
+            data['data']['expires'].should == subject.expires_at.to_s
+        end
+    end
+
+    describe '.from_rpc_data' do
+        let(:restored) { described_class.from_rpc_data data }
+        let(:data) { Arachni::RPC::Serializer.rpc_data( subject ) }
+
+        it "restores initialization_options['expires']" do
+            subject.expires_at.should be_kind_of Time
+            restored.expires_at.to_s.should == subject.expires_at.to_s
+        end
+    end
+
     describe '#mutations' do
-        describe :param_flip do
+        describe :parameter_names do
             it 'creates a new cookie' do
-                subject.mutations( 'seed', param_flip: true ).last.inputs.keys.should ==
+                subject.mutations( 'seed', parameter_names: true ).last.inputs.keys.should ==
                     %w(seed)
             end
         end
@@ -220,7 +242,7 @@ describe Arachni::Element::Cookie do
 
     describe '.encode' do
         it 'encodes the string in a way that makes is suitable to be included in a cookie header' do
-            described_class.encode( 'some stuff \'";%=&' ).should == 'some+stuff+%27%22%3B%25=%26'
+            described_class.encode( 'some stuff \'";%=&' ).should == 'some%20stuff%20%27%22%3B%25%3D%26'
         end
     end
 
@@ -235,7 +257,7 @@ describe Arachni::Element::Cookie do
             )
 
             c.to_set_cookie.should ==
-                'blah%3Dha%25=some+stuff+%3B; Path=/; Domain=127.0.0.2; Secure; HttpOnly'
+                'blah%3Dha%25=some%20stuff%20%3B; Path=/; Domain=127.0.0.2; Secure; HttpOnly'
             described_class.from_set_cookie( url, c.to_set_cookie ).first.should == c
 
             c = described_class.new(
@@ -247,7 +269,7 @@ describe Arachni::Element::Cookie do
 
             described_class.from_set_cookie( url, c.to_set_cookie ).first.should == c
             c.to_set_cookie.should ==
-                'blah%3Dha%25=some+stuff+%3B; Path=/stuff; Domain=127.0.0.2'
+                'blah%3Dha%25=some%20stuff%20%3B; Path=/stuff; Domain=127.0.0.2'
         end
     end
 
@@ -258,7 +280,7 @@ describe Arachni::Element::Cookie do
                 name:  'blah=ha%',
                 value: 'some stuff ;',
             )
-            c.to_s.should == 'blah%3Dha%25=some+stuff+%3B'
+            c.to_s.should == 'blah%3Dha%25=some%20stuff%20%3B'
         end
     end
 
@@ -466,4 +488,3 @@ describe Arachni::Element::Cookie do
     end
 
 end
-