arachni 0.4.2 → 0.4.3

data/spec/arachni/http/cookie_jar_spec.rb

@@ -1,10 +1,10 @@
-require_relative '../../spec_helper'
+require 'spec_helper'
 
 describe Arachni::HTTP::CookieJar do
 
     before do
         @jar = Arachni::HTTP::CookieJar.new
-        @file = spec_path + '/fixtures/cookies.txt'
+        @file = fixtures_path + 'cookies.txt'
     end
 
     describe '.from_file' do
@@ -16,40 +16,13 @@ describe Arachni::HTTP::CookieJar do
         end
 
         context 'when the provided file does not exist' do
-            it 'raises an exception' do
+            it 'raises Arachni::HTTP::CookieJar::Error::CookieJarFileNotFound' do
                 trigger = proc { @jar.class.from_file( 'file' ) }
 
-                raised = false
-                begin
-                    trigger.call
-                rescue Arachni::Error
-                    raised = true
-                end
-                raised.should be_true
-
-                raised = false
-                begin
-                    trigger.call
-                rescue Arachni::HTTP::Error
-                    raised = true
-                end
-                raised.should be_true
-
-                raised = false
-                begin
-                    trigger.call
-                rescue Arachni::HTTP::CookieJar::Error
-                    raised = true
-                end
-                raised.should be_true
-
-                raised = false
-                begin
-                    trigger.call
-                rescue Arachni::HTTP::CookieJar::Error::CookieJarFileNotFound
-                    raised = true
-                end
-                raised.should be_true
+                expect { trigger.call }.to raise_error Arachni::Error
+                expect { trigger.call }.to raise_error Arachni::HTTP::Error
+                expect { trigger.call }.to raise_error Arachni::HTTP::CookieJar::Error
+                expect { trigger.call }.to raise_error Arachni::HTTP::CookieJar::Error::CookieJarFileNotFound
             end
         end
     end
@@ -69,14 +42,8 @@ describe Arachni::HTTP::CookieJar do
         end
 
         context 'when the provided file does not exist' do
-            it 'raises an exception' do
-                raised = false
-                begin
-                    j = @jar.class.from_file( 'file' )
-                rescue Arachni::HTTP::CookieJar::Error::CookieJarFileNotFound
-                    raised = true
-                end
-                raised.should be_true
+            it 'raises Arachni::HTTP::CookieJar::Error::CookieJarFileNotFound' do
+                expect { @jar.class.from_file( 'file' ) }.to raise_error Arachni::HTTP::CookieJar::Error::CookieJarFileNotFound
             end
         end
     end

data/spec/arachni/http_spec.rb

@@ -1,11 +1,11 @@
-require_relative '../spec_helper'
+require 'spec_helper'
 
 describe Arachni::HTTP do
 
     before( :all ) do
         @opts = Arachni::Options.instance
         @http = Arachni::HTTP
-        @url = server_url_for( :http )
+        @url  = web_server_url_for( :http )
     end
     before( :each ){
         @opts.reset
@@ -79,7 +79,7 @@ describe Arachni::HTTP do
     describe 'Arachni::Options#url' do
         context 'when the target URL includes auth credentials' do
             it 'uses them globally' do
-                url = Arachni::Module::Utilities.uri_parse( server_url_for( :http_auth ) )
+                url = Arachni::Module::Utilities.uri_parse( web_server_url_for( :http_auth ) )
                 @opts.url = url.to_s
 
                 # first fail to make sure that our test server is actually working properly
@@ -256,7 +256,7 @@ describe Arachni::HTTP do
 
         context 'when the cookie_jar option is set' do
             it 'adds the contained cookies to the CookieJar' do
-                @opts.cookie_jar = spec_path + '/fixtures/cookies.txt'
+                @opts.cookie_jar = fixtures_path + 'cookies.txt'
                 @http.cookie_jar.cookies.should be_empty
                 @http.reset
                 cookies = @http.cookie_jar.cookies
@@ -264,22 +264,16 @@ describe Arachni::HTTP do
                 cookies.should == Arachni::Module::Utilities.cookies_from_file( '', @opts.cookie_jar )
             end
             context 'but the path is invalid' do
-                it 'raises an exception' do
-                    @opts.cookie_jar = spec_path + '/fixtures/cookies.does_not_exist.txt'
-                    raised = false
-                    begin
-                        @http.reset
-                    rescue Arachni::HTTP::CookieJar::Error::CookieJarFileNotFound
-                        raised = true
-                    end
-                    raised.should be_true
+                it 'raises Arachni::HTTP::CookieJar::Error::CookieJarFileNotFound' do
+                    @opts.cookie_jar = fixtures_path + 'cookies.does_not_exist.txt'
+                    expect{ @http.reset }.to raise_error Arachni::HTTP::CookieJar::Error::CookieJarFileNotFound
                 end
             end
         end
 
         context 'when the cookies option is set' do
             it 'adds those cookies to the CookieJar' do
-                cookie_jar_file = spec_path + '/fixtures/cookies.txt'
+                cookie_jar_file = fixtures_path + 'cookies.txt'
                 @opts.cookies = Arachni::Module::Utilities.cookies_from_file( '', cookie_jar_file )
                 @http.cookie_jar.cookies.should be_empty
                 @http.reset
@@ -421,13 +415,7 @@ describe Arachni::HTTP do
         it 'raises exception when no URL is available' do
             @opts.reset
             @http.reset
-            raised = false
-            begin
-                @http.request
-            rescue
-                raised = true
-            end
-            raised.should be_true
+            expect { @http.request }.to raise_error
         end
 
         describe :no_cookiejar do

data/spec/arachni/issue_spec.rb

@@ -1,10 +1,12 @@
-require_relative '../spec_helper'
+require 'spec_helper'
 
 describe Arachni::Issue do
     before( :all ) do
         @issue_data = {
             name: 'Module name',
             elem: Arachni::Element::LINK,
+            platform: :unix,
+            platform_type: :os,
             method: 'GET',
             description: 'Issue description',
             references: {
@@ -90,6 +92,32 @@ describe Arachni::Issue do
         end
     end
 
+    describe '#audit?' do
+        context 'when the issue was discovered by manipulating an input' do
+            it 'returns true' do
+                Arachni::Issue.new( issue: { var: '1' } ).audit?.should be_true
+            end
+        end
+        context 'when the issue was logged passively' do
+            it 'returns false' do
+                Arachni::Issue.new.audit?.should be_false
+            end
+        end
+    end
+
+    describe '#recon?' do
+        context 'when the issue was discovered by manipulating an input' do
+            it 'returns false' do
+                Arachni::Issue.new( issue: { var: '1' } ).recon?.should be_false
+            end
+        end
+        context 'when the issue was logged passively' do
+            it 'returns true' do
+                Arachni::Issue.new.recon?.should be_true
+            end
+        end
+    end
+
     context 'when there\'s an :issue key' do
         it 'assigns its hash contents to instance vars' do
             issue = Arachni::Issue.new( issue: @issue_data )

data/spec/arachni/mixins/observable_spec.rb

@@ -1,4 +1,4 @@
-require_relative '../../spec_helper'
+require 'spec_helper'
 
 class ObservableTest
     include Arachni::Mixins::Observable
@@ -54,11 +54,9 @@ describe Arachni::Mixins::Observable do
         res2.should == true
     end
 
-    it 'raises NoMethodError on invalid method name' do
-        begin
-            @obs.blah
-        rescue Exception => e
-            e.class.should == NoMethodError
+    context 'on invalid method name' do
+        it 'raises NoMethodError' do
+            expect { @obs.blah }.to raise_error NoMethodError
         end
     end
 

data/spec/arachni/mixins/progress_bar_spec.rb

@@ -1,4 +1,4 @@
-require_relative '../../spec_helper'
+require 'spec_helper'
 require_testee
 
 class ProgressBarTest

data/spec/arachni/module/auditor_spec.rb

@@ -1,4 +1,4 @@
-require_relative '../../spec_helper'
+require 'spec_helper'
 
 class AuditorTest
     include Arachni::Module::Auditor
@@ -47,7 +47,7 @@ describe Arachni::Module::Auditor do
         @opts = Arachni::Options.instance
         @opts.audit :links, :forms, :cookies, :headers
 
-        @opts.url = server_url_for( :auditor )
+        @opts.url = web_server_url_for( :auditor )
         @url      = @opts.url.dup
 
         @framework = Arachni::Framework.new( @opts )
@@ -372,6 +372,18 @@ describe Arachni::Module::Auditor do
             end
         end
 
+        context 'when the payloads are per platform' do
+            it 'assigns the platform of the payload to the issue' do
+                @auditor.load_page_from( @url + '/link' )
+                @auditor.audit( { unix: @seed }, substring: @seed )
+                @framework.http.run
+                @framework.modules.results.size.should == 1
+                issue = @framework.modules.results.first
+                issue.platform.should == :unix
+                issue.platform_type.should == :os
+            end
+        end
+
         context 'when called with opts' do
             describe :elements do
 
@@ -468,7 +480,7 @@ describe Arachni::Module::Auditor do
 
                         # audit until no more new elements appear
                         while page = pages.pop
-                            auditor = Arachni::Module::Base.new( page )
+                            auditor = Arachni::Module::Base.new( page, @framework )
                             auditor.audit( @seed )
                             # run audit requests
                             @framework.http.run
@@ -494,7 +506,7 @@ describe Arachni::Module::Auditor do
 
                         # audit until no more new elements appear
                         while page = pages.pop
-                            auditor = Arachni::Module::Base.new( page )
+                            auditor = Arachni::Module::Base.new( page, @framework )
                             auditor.audit( @seed, train: true )
                             # run audit requests
                             @framework.http.run
@@ -519,7 +531,7 @@ describe Arachni::Module::Auditor do
                         # feed the new pages/elements back to the queue
                         @framework.trainer.on_new_page { |p| updated_pages << p }
 
-                        auditor = Arachni::Module::Base.new( page )
+                        auditor = Arachni::Module::Base.new( page, @framework )
                         auditor.audit( @seed, train: false )
                         @framework.http.run
                         updated_pages.should be_empty

data/spec/arachni/module/key_filler.rb

@@ -1,16 +1,41 @@
-require_relative '../../spec_helper'
+require 'spec_helper'
 
 describe Arachni::Module::KeyFiller do
 
-    before( :all ) do
-        @filler = Arachni::Module::KeyFiller
-        @seeds = {}
-        @filler.regexps.keys.each { |k| @seeds[k] = nil }
-    end
-
     describe '#fill' do
         it 'fills in all inputs with appropriate seed values' do
-            @filler.fill( @seeds ).keys.compact.size == @seeds.size
+            described_class.fill(
+                'nAMe'    => nil,
+                'usEr'    => nil,
+                'uSR'     => nil,
+                'pAsS'    => nil,
+                'tXt'     => nil,
+                'nUm'     => nil,
+                'AmoUnt'  => nil,
+                'mAIL'    => nil,
+                'aCcouNt' => nil,
+                'iD'      => nil
+            ).should == {
+                'nAMe'    => 'arachni_name',
+                'usEr'    => 'arachni_user',
+                'uSR'     => 'arachni_user',
+                'pAsS'    => '5543!%arachni_secret',
+                'tXt'     => 'arachni_text',
+                'nUm'     => '132',
+                'AmoUnt'  => '100',
+                'mAIL'    => 'arachni@email.gr',
+                'aCcouNt' => '12',
+                'iD'      => '1'
+            }
+        end
+
+        context 'when there is a default value' do
+            it 'skips it' do
+                with_values = {
+                    'stuff' => 'blah'
+                }
+                described_class.fill( with_values ) == with_values
+            end
         end
     end
 

data/spec/arachni/module/manager_spec.rb

@@ -1,10 +1,8 @@
-require_relative '../../spec_helper'
+require 'spec_helper'
 
 describe Arachni::Module::Manager do
 
     before( :all ) do
-        opts = Arachni::Options.instance
-        opts.dir['modules'] = spec_path + 'fixtures/modules/'
         @modules = Arachni::Framework.new.modules
 
         @page  = Arachni::Page.new

data/spec/arachni/module/utilities_spec.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
-require_relative '../../spec_helper'
+require 'spec_helper'
 
 describe Arachni::Module::Utilities do
 

data/spec/arachni/options_spec.rb

@@ -1,7 +1,8 @@
-require_relative '../spec_helper'
+require 'spec_helper'
 
 describe Arachni::Options do
     before( :each ) do
+        ENV['ARACHNI_FRAMEWORK_LOGDIR'] = nil
         @opts = Arachni::Options.instance.reset
         @utils = Arachni::Module::Utilities
     end
@@ -13,6 +14,128 @@ describe Arachni::Options do
         Arachni::Options.url.should == url
     end
 
+    describe "#dir['logs']" do
+        context 'when the ARACHNI_FRAMEWORK_LOGDIR environment variable' do
+            context 'has been set' do
+                it 'returns its value' do
+                    ENV['ARACHNI_FRAMEWORK_LOGDIR'] = 'test'
+                    described_class.reset
+                    described_class.dir['logs'].should == 'test/'
+                end
+            end
+            context 'has not been set' do
+                it 'returns the default location' do
+                    described_class.dir['logs'].should == "#{described_class.dir['root']}logs/"
+                end
+            end
+        end
+    end
+
+    describe '#grid?' do
+        describe 'when the option has been enabled' do
+            context 'via #grid=' do
+                it 'returns true' do
+                    Arachni::Options.grid = true
+                    Arachni::Options.grid?.should be_true
+                end
+            end
+
+            context 'via #grid_mode=' do
+                it 'returns true' do
+                    Arachni::Options.grid_mode = :balance
+                    Arachni::Options.grid?.should be_true
+                end
+            end
+        end
+        describe 'when the option has been disabled' do
+            context 'via #grid=' do
+                it 'returns false' do
+                    Arachni::Options.grid = false
+                    Arachni::Options.grid?.should be_false
+                end
+            end
+
+            context 'via #grid_mode=' do
+                it 'returns false' do
+                    Arachni::Options.grid_mode = false
+                    Arachni::Options.grid?.should be_false
+                end
+            end
+        end
+        describe 'by default' do
+            it 'returns false' do
+                Arachni::Options.grid?.should be_false
+            end
+        end
+    end
+
+    describe '#grid=' do
+        context true do
+            it 'is a shorthand for #grid_mode = :balance' do
+                Arachni::Options.grid = true
+                Arachni::Options.grid_mode.should == :balance
+            end
+        end
+    end
+
+    describe '#grid_mode=' do
+        context 'when given' do
+            context String do
+                it 'converts it to Symbol and sets the option' do
+                    Arachni::Options.grid_mode = 'balance'
+                    Arachni::Options.grid_mode.should == :balance
+                end
+            end
+
+            context Symbol do
+                it 'sets the option' do
+                    Arachni::Options.grid_mode = :aggregate
+                    Arachni::Options.grid_mode.should == :aggregate
+                end
+            end
+
+            context 'an invalid option' do
+                it 'raises ArgumentError' do
+                    expect { Arachni::Options.grid_mode = :stuff }.to raise_error ArgumentError
+                end
+            end
+        end
+    end
+
+    describe '#grid_aggregate?' do
+        context 'when in :aggregate mode' do
+            it 'returns true' do
+                Arachni::Options.grid_aggregate?.should be_false
+                Arachni::Options.grid_mode = :aggregate
+                Arachni::Options.grid_aggregate?.should be_true
+            end
+        end
+        context 'when in :balance mode' do
+            it 'returns false' do
+                Arachni::Options.grid_aggregate?.should be_false
+                Arachni::Options.grid_mode = :balance
+                Arachni::Options.grid_aggregate?.should be_false
+            end
+        end
+    end
+
+    describe '#grid_balance?' do
+        context 'when in :balance mode' do
+            it 'returns true' do
+                Arachni::Options.grid_balance?.should be_false
+                Arachni::Options.grid_mode = :balance
+                Arachni::Options.grid_balance?.should be_true
+            end
+        end
+        context 'when in :balance mode' do
+            it 'returns false' do
+                Arachni::Options.grid_balance?.should be_false
+                Arachni::Options.grid_mode = :aggregate
+                Arachni::Options.grid_balance?.should be_false
+            end
+        end
+    end
+
     describe '#no_protocol_for_url' do
         it 'allows URLs without a protocol' do
             trigger = proc { Arachni::Options.url = 'stuff:80' }
@@ -47,6 +170,20 @@ describe Arachni::Options do
         end
     end
 
+    describe '#min_pages_per_instance=' do
+        it 'forces its argument to an Integer' do
+            Arachni::Options.min_pages_per_instance = '55'
+            Arachni::Options.min_pages_per_instance.should == 55
+        end
+    end
+
+    describe '#max_slaves=' do
+        it 'forces its argument to an Integer' do
+            Arachni::Options.max_slaves = '56'
+            Arachni::Options.max_slaves.should == 56
+        end
+    end
+
     describe '#user_agent' do
         it "defaults to Arachni/v#{Arachni::VERSION}" do
             Arachni::Options.user_agent.should == 'Arachni/v' + Arachni::VERSION.to_s
@@ -119,6 +256,53 @@ describe Arachni::Options do
         end
     end
 
+    describe '#do_not_fingerprint' do
+        it 'sets #no_fingerprinting to true' do
+            Arachni::Options.fingerprint?.should be_true
+            Arachni::Options.no_fingerprinting.should be_false
+
+            Arachni::Options.do_not_fingerprint
+            Arachni::Options.fingerprint?.should be_false
+            Arachni::Options.no_fingerprinting.should be_true
+        end
+    end
+
+    describe '#fingerprint' do
+        it 'sets #no_fingerprinting to false' do
+            Arachni::Options.do_not_fingerprint
+            Arachni::Options.fingerprint?.should be_false
+            Arachni::Options.no_fingerprinting.should be_true
+
+            Arachni::Options.fingerprint
+
+            Arachni::Options.fingerprint?.should be_true
+            Arachni::Options.no_fingerprinting.should be_false
+        end
+    end
+
+    describe '#fingerprint?' do
+        context 'by default' do
+            it 'returns true' do
+                Arachni::Options.fingerprint?.should be_true
+            end
+        end
+        context 'when crawling is enabled' do
+            it 'returns true' do
+                Arachni::Options.do_not_fingerprint
+                Arachni::Options.fingerprint?.should be_false
+                Arachni::Options.fingerprint
+                Arachni::Options.fingerprint?.should be_true
+            end
+        end
+        context 'when crawling is disabled' do
+            it 'returns false' do
+                Arachni::Options.fingerprint?.should be_true
+                Arachni::Options.do_not_fingerprint
+                Arachni::Options.fingerprint?.should be_false
+            end
+        end
+    end
+
     describe '#do_not_crawl' do
         it 'sets the link_count_limit to 0' do
             Arachni::Options.do_not_crawl