ar_lazy_preload 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8e76eb3ed4d0d069552b4c805c82d0fb28829559fa63a70adeb81de0e8477409
-  data.tar.gz: 6033b6faf439eeaccc02c525d00cb24bc80521c267ad4e4960b89cc9871506ca
+  metadata.gz: 7060cc83164f3fff3a468514246ecbb5799accc1999dab8581c97db4d10f016a
+  data.tar.gz: 98075d278f0d04fa68ae9b31ddc60e0348b6a896460f512bc27195113095e700
 SHA512:
-  metadata.gz: 1b9b9658859f6b8a138735bcba398d2324671951480e861129530389ceefd242efa2266d08f4dea8d2b02905ab3ec18097629bb6c5a294c427531a903dc26caf
-  data.tar.gz: c7bb4abcddefa8ab551b1fcb5a9eaab508fb02af7e1285ed419ba20e97dfac3cb3186149293d71bb0436e973656c2d03a73ee842063b4aa4a7942ec52aa6031c
+  metadata.gz: aad5db14a66fb29fa11cfbd2968e2b3dbd54110ee51f89d95ca6a5c9538125c46732a03d7d4539f3b1c251b2ae6a5c4c986b3a677d93bd76d6384c6e843c11bb
+  data.tar.gz: 482285553c6d4b1057e0d5ee173eef21f14a7e5c5214c093614ee3730677d3c32f0039b5b387da4b05023713b7868ae75b22d23cf18edd0200f1176fd6b78b4a

data/README.md

@@ -6,6 +6,9 @@
 
 # ArLazyPreload
 
+<a href="https://evilmartians.com/?utm_source=ar_lazy_preload">
+<img src="https://evilmartians.com/badges/sponsored-by-evil-martians.svg" alt="Sponsored by Evil Martians" width="236" height="54"></a>
+
 Lazy loading associations for the ActiveRecord models. `#includes`, `#eager_load` and `#preload` are built-in methods to avoid N+1 problem, but sometimes when DB request is made we don't know what associations we are going to need later (for instance when your API allows client to define a list of loaded associations dynamically). The only possible solution for such cases is to load _all_ the associations we might need, but it can be a huge overhead.
 
 This gem allows to set up _lazy_ preloading for associations - it won't load anything until association is called for a first time, but when it happens - it loads all the associated records for all records from the initial relation in a single query.

data/lib/ar_lazy_preload/context.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require "set"
 require "ar_lazy_preload/associated_context_builder"
 
 module ArLazyPreload
@@ -34,11 +35,17 @@ module ArLazyPreload
 
       preloader.preload(records, association_name)
       AssociatedContextBuilder.prepare(parent_context: self, association_name: association_name)
+      # Our tracking of loading state
+      # Otherwise `#preload` will be called many times even when association is loaded
+      mark_association_as_loaded(association_name)
     end
 
     private
 
     def association_needs_preload?(association_name, node_tree = association_tree)
+      # Check whether association loading state
+      # to avoid calling preload unnecessarily
+      return false if association_loaded?(association_name)
       return true if ArLazyPreload.config.auto_preload?
 
       node_tree.any? do |node|
@@ -50,6 +57,18 @@ module ArLazyPreload
       end
     end
 
+    def mark_association_as_loaded(association_name)
+      loaded_association_names.add(association_name)
+    end
+
+    def association_loaded?(association_name)
+      loaded_association_names.include?(association_name)
+    end
+
+    def loaded_association_names
+      @loaded_association_names ||= Set.new
+    end
+
     def preloader
       @preloader ||= ActiveRecord::Associations::Preloader.new
     end

data/lib/ar_lazy_preload/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ArLazyPreload
-  VERSION = "0.2.4"
+  VERSION = "0.2.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ar_lazy_preload
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - DmitryTsepelev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-21 00:00:00.000000000 Z
+date: 2018-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec