ar_aggregate_by_interval 1.1.4 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d67fb1f746590e8801a28802ab2fd1aba5175f11
-  data.tar.gz: c5618c06679af82e4d078ed02ddc150040cad40f
+  metadata.gz: 1c298fefa29a3f10b604344514cbdb4107f3ae14
+  data.tar.gz: 25ac0e6e1bc2aec6002ead9f3ed97d45cab933ab
 SHA512:
-  metadata.gz: ccdd2612b245ebac746c3e5bb3756a8a021488de55325b5a378fe868ed08c5f1f1987bfd67612257c281d9d5f13cd8997de764fe9c1f00d9f3572037ab0945d0
-  data.tar.gz: 9ccfddcab1829beec3c274ca62bea99f886ef6e9750a3a729d9353cd45e1ca30c588af7212e70fe3bd371ed82098c3b1154e2af7606743f1c1230eb5c73cd3f4
+  metadata.gz: 2e101fa39c200ca502387d95b63c3dae825e25273c57ab04bb5ca05a32b2cd3932f6e6fea0cbf21d3754aec4449e77cd09a9dfe245b16d803269cf12012485f0
+  data.tar.gz: d99af5d4a6cd05e067c933e66a2fd9fc88613b933d8511a4a44557e4a46b3a16579c82b44a63564c3db1b8286ba58ba3288531c83532915cbf80691e4ea7a0ad

data/CHANGELOG.md

@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 This file adheres to [Keep a changelog](http://keepachangelog.com/).
 
+## [1.1.5] - 2015-03-08 (maintenance)
+### Changed
+- Raise ArgumentError instead of NoMethodError or RuntimeError on bad args
+
 ## [1.1.4] - 2015-03-08 (maintenance)
 ### Changed
 - Moved functionality from constructors to methods

data/lib/ar_aggregate_by_interval/utils.rb

@@ -29,7 +29,7 @@ module ArAggregateByInterval
           aggregate_column = nil
         end
       elsif sum_or_count != 'count' && aggregate_column.nil? || !(aggregate_column.is_a?(String) || aggregate_column.is_a?(Symbol))
-        raise "aggregate_column cant be nil with #{sum_or_count}"
+        raise ArgumentError, "aggregate_column cant be nil with #{sum_or_count}"
       end
 
       return {

data/lib/ar_aggregate_by_interval/version.rb

@@ -1,3 +1,3 @@
 module ArAggregateByInterval
-  VERSION = '1.1.4'
+  VERSION = '1.1.5'
 end

data/lib/ar_aggregate_by_interval.rb

@@ -23,7 +23,7 @@ module ArAggregateByInterval
       nil
     end
 
-    return super unless hash_args
+    raise ArgumentError, 'incorrect ArAggregateByInterval arguments' unless hash_args
 
     # convert strings to symbols
     [:group_by_column, :aggregate_column].each do |col|

data/spec/lib/ar_aggregate_by_interval_spec.rb

@@ -129,10 +129,10 @@ describe ArAggregateByInterval do
       subject do
         Blog.count_weekly(:created_at, {}, {})
       end
-      it 'raise NoMethodError' do
+      it 'raise ArgumentError' do
         expect do
           subject
-        end.to raise_error(NoMethodError)
+        end.to raise_error(ArgumentError)
       end
     end
 
@@ -140,10 +140,10 @@ describe ArAggregateByInterval do
       subject do
         Blog.sum_weekly(:created_at, @from, @from)
       end
-      it 'raise NoMethodError' do
+      it 'raise ArgumentError' do
         expect do
           subject
-        end.to raise_error(RuntimeError, /aggregate_column/)
+        end.to raise_error(ArgumentError, /aggregate_column/)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ar_aggregate_by_interval
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors:
 - Jonathan Otto