ar_after_transaction 0.4.0 → 0.6.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA256:
+  metadata.gz: ca30487c699cc7613223724f89d5ab79cf7dc882b529d8864cb62b3fe8a4e236
+  data.tar.gz: a4e3f03ae30f349acd3193a8f9aedcf23f3c15715d3dc8fc345ed7c43210471e
+SHA512:
+  metadata.gz: 88dbdac2ce6163067a3f1b33427fbade19b0ec4d3310ca15a3a37db686a701cc81cf79fc2ffb4f513a5b6de7aca34d75067576df3ebc968a09fbfd885a11a1e7
+  data.tar.gz: 7e15342f954edfb228ce60991bb15b3227d8e0ed85b5d5241b8301e57da1a70cf82cc9cf8167b39e167b71355bb54331d1f9aeff570979e2330299d98360a696

data/Readme.md

@@ -1,3 +1,7 @@
+[![Gem Version](https://badge.fury.io/rb/ar_after_transaction.png)](http://badge.fury.io/rb/ar_after_transaction)
+[![Build Status](https://travis-ci.org/grosser/ar_after_transaction.png)](https://travis-ci.org/grosser/ar_after_transaction)
+[![Dependency Status](https://gemnasium.com/grosser/ar_after_transaction.png)](https://gemnasium.com/grosser/ar_after_transaction)
+
 Do something only after the currently open transactions have finished.
 
 Normally everything gets rolled back when a transaction fails, but you cannot roll back sending an email or adding a job to Resque.
@@ -62,6 +66,8 @@ Rails 3+
  - basic support is built in, use it if you can!
  - `after_commit :foo`
  - `after_commit :bar, :on => :create / :update`
+ - [after_commit everywhere](https://dev.to/evilmartians/rails-aftercommit-everywhere--4j9g)
+
 
 [after_commit](https://github.com/pat/after_commit)<br/>
  - pro: threadsafe<br/>
@@ -78,9 +84,10 @@ Authors
  - [Benedikt Deicke](http://blog.synatic.net)
  - [Tyler Rick](https://github.com/TylerRick)
  - [Michael Wu](https://github.com/michaelmwu)
+ - [C.W.](https://github.com/compwron)
+ - [Ben Weintraub](https://github.com/benweint)
 
 [Michael Grosser](http://grosser.it)<br/>
 michael@grosser.it<br/>
 License: MIT<br/>
-[![Build Status](https://travis-ci.org/grosser/ar_after_transaction.png)](https://travis-ci.org/grosser/ar_after_transaction)
 

data/lib/ar_after_transaction.rb

@@ -12,9 +12,9 @@ module ARAfterTransaction
       end
     end
 
-    def transaction_with_after(*args)
+    def transaction_with_after(**args)
       clean = true
-      transaction_without_after(*args) do
+      transaction_without_after(**args) do
         begin
           yield
         rescue ActiveRecord::Rollback
@@ -52,6 +52,8 @@ module ARAfterTransaction
     private
 
     def transactions_open?
+      pool = connection_pool
+      return false unless pool && pool.active_connection?
       connection.open_transactions > normally_open_transactions
     end
 

data/lib/ar_after_transaction/version.rb

@@ -1,3 +1,3 @@
 module ARAfterTransaction
-  VERSION = Version = '0.4.0'
+  VERSION = Version = '0.6.1'
 end

metadata

@@ -1,30 +1,117 @@
 --- !ruby/object:Gem::Specification
 name: ar_after_transaction
 version: !ruby/object:Gem::Version
-  version: 0.4.0
-  prerelease: 
+  version: 0.6.1
 platform: ruby
 authors:
 - Michael Grosser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-15 00:00:00.000000000 Z
+date: 2020-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.2.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.2.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
+- !ruby/object:Gem::Dependency
+  name: wwtd
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bump
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -33,52 +120,30 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .travis.yml
-- Appraisals
-- Gemfile
-- Gemfile.lock
-- Rakefile
 - Readme.md
-- ar_after_transaction.gemspec
-- gemfiles/rails2.gemfile
-- gemfiles/rails2.gemfile.lock
-- gemfiles/rails3.gemfile
-- gemfiles/rails3.gemfile.lock
 - lib/ar_after_transaction.rb
 - lib/ar_after_transaction/version.rb
-- spec/after_initialize_spec.rb
-- spec/ar_after_transaction_spec.rb
-- spec/setup_database.rb
-- spec/spec_helper.rb
 homepage: http://github.com/grosser/ar_after_transaction
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
-      segments:
-      - 0
-      hash: 2099536990730070045
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2099536990730070045
 requirements: []
-rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 3.1.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Execute irreversible actions only when transactions are not rolled back
 test_files: []

data/.travis.yml

@@ -1,4 +0,0 @@
-rvm:
-  - ree
-  - 1.9.2
-  - 1.9.3

data/Appraisals

@@ -1,8 +0,0 @@
-appraise "rails2" do
-  gem "activerecord", "~>2.3.14"
-end
-
-appraise "rails3" do
-  gem "activerecord", "~>3.2.7"
-  gem 'railties'
-end

data/Gemfile

@@ -1,9 +0,0 @@
-source "https://rubygems.org"
-
-gemspec
-
-gem 'appraisal'
-gem 'bump'
-gem 'rake'
-gem 'rspec', '~>2'
-gem 'sqlite3'

data/Gemfile.lock

@@ -1,51 +0,0 @@
-PATH
-  remote: .
-  specs:
-    ar_after_transaction (0.4.0)
-      activerecord
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activemodel (3.2.13)
-      activesupport (= 3.2.13)
-      builder (~> 3.0.0)
-    activerecord (3.2.13)
-      activemodel (= 3.2.13)
-      activesupport (= 3.2.13)
-      arel (~> 3.0.2)
-      tzinfo (~> 0.3.29)
-    activesupport (3.2.13)
-      i18n (= 0.6.1)
-      multi_json (~> 1.0)
-    appraisal (0.5.1)
-      bundler
-      rake
-    arel (3.0.2)
-    builder (3.0.4)
-    bump (0.3.5)
-    diff-lcs (1.1.3)
-    i18n (0.6.1)
-    multi_json (1.7.7)
-    rake (10.0.2)
-    rspec (2.12.0)
-      rspec-core (~> 2.12.0)
-      rspec-expectations (~> 2.12.0)
-      rspec-mocks (~> 2.12.0)
-    rspec-core (2.12.0)
-    rspec-expectations (2.12.0)
-      diff-lcs (~> 1.1.3)
-    rspec-mocks (2.12.0)
-    sqlite3 (1.3.6)
-    tzinfo (0.3.37)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  appraisal
-  ar_after_transaction!
-  bump
-  rake
-  rspec (~> 2)
-  sqlite3

data/Rakefile

@@ -1,13 +0,0 @@
-require "bundler/setup"
-require "bundler/gem_tasks"
-require "appraisal"
-require "bump/tasks"
-
-
-task :spec do
-  sh "rspec spec"
-end
-
-task :default do
-  sh "bundle exec rake appraisal:install && bundle exec rake appraisal spec"
-end

data/ar_after_transaction.gemspec

@@ -1,12 +0,0 @@
-$LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
-require 'ar_after_transaction/version'
-
-Gem::Specification.new "ar_after_transaction", ARAfterTransaction::VERSION do |s|
-  s.summary = "Execute irreversible actions only when transactions are not rolled back"
-  s.authors = ["Michael Grosser"]
-  s.email = "michael@grosser.it"
-  s.homepage = "http://github.com/grosser/ar_after_transaction"
-  s.files = `git ls-files`.split("\n")
-  s.add_runtime_dependency "activerecord"
-  s.license = "MIT"
-end

data/gemfiles/rails2.gemfile

@@ -1,12 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal"
-gem "bump"
-gem "rake"
-gem "rspec", "~>2"
-gem "sqlite3"
-gem "activerecord", "~>2.3.14"
-
-gemspec :path=>"../"

data/gemfiles/rails2.gemfile.lock

@@ -1,39 +0,0 @@
-PATH
-  remote: /Users/mgrosser/code/tools/ar_after_transaction
-  specs:
-    ar_after_transaction (0.3.0)
-      activerecord
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activerecord (2.3.14)
-      activesupport (= 2.3.14)
-    activesupport (2.3.14)
-    appraisal (0.4.1)
-      bundler
-      rake
-    bump (0.3.5)
-    diff-lcs (1.1.3)
-    rake (0.9.2.2)
-    rspec (2.11.0)
-      rspec-core (~> 2.11.0)
-      rspec-expectations (~> 2.11.0)
-      rspec-mocks (~> 2.11.0)
-    rspec-core (2.11.1)
-    rspec-expectations (2.11.3)
-      diff-lcs (~> 1.1.3)
-    rspec-mocks (2.11.3)
-    sqlite3 (1.3.6)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activerecord (~> 2.3.14)
-  appraisal
-  ar_after_transaction!
-  bump
-  rake
-  rspec (~> 2)
-  sqlite3

data/gemfiles/rails3.gemfile

@@ -1,13 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "appraisal"
-gem "bump"
-gem "rake"
-gem "rspec", "~>2"
-gem "sqlite3"
-gem "activerecord", "~>3.2.7"
-gem "railties"
-
-gemspec :path=>"../"

data/gemfiles/rails3.gemfile.lock

@@ -1,89 +0,0 @@
-PATH
-  remote: /Users/mgrosser/code/tools/ar_after_transaction
-  specs:
-    ar_after_transaction (0.3.0)
-      activerecord
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    actionpack (3.2.8)
-      activemodel (= 3.2.8)
-      activesupport (= 3.2.8)
-      builder (~> 3.0.0)
-      erubis (~> 2.7.0)
-      journey (~> 1.0.4)
-      rack (~> 1.4.0)
-      rack-cache (~> 1.2)
-      rack-test (~> 0.6.1)
-      sprockets (~> 2.1.3)
-    activemodel (3.2.8)
-      activesupport (= 3.2.8)
-      builder (~> 3.0.0)
-    activerecord (3.2.8)
-      activemodel (= 3.2.8)
-      activesupport (= 3.2.8)
-      arel (~> 3.0.2)
-      tzinfo (~> 0.3.29)
-    activesupport (3.2.8)
-      i18n (~> 0.6)
-      multi_json (~> 1.0)
-    appraisal (0.4.1)
-      bundler
-      rake
-    arel (3.0.2)
-    builder (3.0.4)
-    bump (0.3.5)
-    diff-lcs (1.1.3)
-    erubis (2.7.0)
-    hike (1.2.3)
-    i18n (0.6.1)
-    journey (1.0.4)
-    json (1.8.0)
-    multi_json (1.3.6)
-    rack (1.4.5)
-    rack-cache (1.2)
-      rack (>= 0.4)
-    rack-ssl (1.3.3)
-      rack
-    rack-test (0.6.2)
-      rack (>= 1.0)
-    railties (3.2.8)
-      actionpack (= 3.2.8)
-      activesupport (= 3.2.8)
-      rack-ssl (~> 1.3.2)
-      rake (>= 0.8.7)
-      rdoc (~> 3.4)
-      thor (>= 0.14.6, < 2.0)
-    rake (0.9.2.2)
-    rdoc (3.12.2)
-      json (~> 1.4)
-    rspec (2.11.0)
-      rspec-core (~> 2.11.0)
-      rspec-expectations (~> 2.11.0)
-      rspec-mocks (~> 2.11.0)
-    rspec-core (2.11.1)
-    rspec-expectations (2.11.3)
-      diff-lcs (~> 1.1.3)
-    rspec-mocks (2.11.3)
-    sprockets (2.1.3)
-      hike (~> 1.2)
-      rack (~> 1.0)
-      tilt (~> 1.1, != 1.3.0)
-    sqlite3 (1.3.6)
-    thor (0.18.1)
-    tilt (1.4.1)
-    tzinfo (0.3.33)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activerecord (~> 3.2.7)
-  appraisal
-  ar_after_transaction!
-  bump
-  railties
-  rake
-  rspec (~> 2)
-  sqlite3

data/spec/after_initialize_spec.rb

@@ -1,96 +0,0 @@
-require 'active_record'
-require File.expand_path '../setup_database', __FILE__
-
-if ActiveRecord::VERSION::MAJOR > 2
-  require 'action_controller/railtie'
-
-  Rack::Session::Cookie
-
-  module Passthrough
-    def self.extended( base )
-      base.class_eval do
-        class << self
-          alias_method :transaction_without_passthrough, :transaction
-          alias_method :transaction, :transaction_with_passthrough
-        end
-      end
-    end
-
-    def transaction_with_passthrough(*args, &block)
-      transaction_without_passthrough(*args, &block)
-    end
-  end
-
-  class Railtie < ::Rails::Railtie
-    config.after_initialize do
-      ActiveRecord::Base.send(:extend, Passthrough)
-    end
-  end
-
-  module ARAfterTransaction
-    class Application < ::Rails::Application
-      config.active_support.deprecation = :log
-
-      config.after_initialize do
-        require 'ar_after_transaction'
-      end
-    end
-  end
-
-  Rack::Session::Cookie.send(:define_method, :warn){|_|} # seilence secret warning
-  ARAfterTransaction::Application.initialize! # initialize app
-
-  class AnExpectedError < Exception
-  end
-
-  class User
-    cattr_accessor :test_callbacks, :test_stack
-    self.test_stack = []
-    self.test_callbacks = []
-
-    after_create :do_it
-    def do_it
-      self.class.test_callbacks.map{|callback| send(callback)}.last
-    end
-
-    def do_after
-      after_transaction do
-        ActiveRecord::Base.transaction do
-          # nested transaction should not cause infinitive recursion
-        end
-        self.class.test_stack << :after
-      end
-    end
-
-    def do_normal
-      self.class.test_stack << :normal
-    end
-
-    def oops
-      raise AnExpectedError
-    end
-
-    def raise_rollback
-      raise ActiveRecord::Rollback
-    end
-  end
-
-  describe ARAfterTransaction do
-    before do
-      User.normally_open_transactions = nil
-      User.send(:transactions_open?).should == false
-      User.test_stack.clear
-      User.test_callbacks.clear
-    end
-
-    it "has a VERSION" do
-      ARAfterTransaction::VERSION.should =~ /^\d+\.\d+\.\d+$/
-    end
-
-    it "executes after a transaction" do
-      User.test_callbacks = [:do_after, :do_normal]
-      User.create!
-      User.test_stack.should == [:normal, :after]
-    end
-  end
-end

data/spec/ar_after_transaction_spec.rb

@@ -1,148 +0,0 @@
-require "spec_helper"
-
-class AnExpectedError < Exception
-end
-
-class User
-  cattr_accessor :test_callbacks, :test_stack
-  self.test_stack = []
-  self.test_callbacks = []
-
-  after_create :do_it
-  def do_it
-    self.class.test_callbacks.map{|callback| send(callback)}.last
-  end
-
-  def do_after
-    after_transaction do
-      ActiveRecord::Base.transaction do
-        # nested transaction should not cause infinitive recursion
-      end
-      self.class.test_stack << :after
-    end
-  end
-
-  def do_normal
-    self.class.test_stack << :normal
-  end
-
-  def oops
-    raise AnExpectedError
-  end
-
-  def raise_rollback
-    raise ActiveRecord::Rollback
-  end
-end
-
-describe ARAfterTransaction do
-  before do
-    User.normally_open_transactions = nil
-    User.send(:transactions_open?).should == false
-    User.test_stack.clear
-    User.test_callbacks.clear
-  end
-
-  it "has a VERSION" do
-    ARAfterTransaction::VERSION.should =~ /^\d+\.\d+\.\d+$/
-  end
-
-  it "executes after a transaction" do
-    User.test_callbacks = [:do_after, :do_normal]
-    User.create!
-    User.test_stack.should == [:normal, :after]
-  end
-
-  it "does not execute when transaction was rolled back" do
-    User.test_callbacks = [:do_after, :do_normal, :oops]
-    lambda{
-      User.create!
-    }.should raise_error(AnExpectedError)
-    User.test_stack.should == [:normal]
-  end
-
-  it "does not execute when transaction gets rolled back by ActiveRecord::Rollback raised in an after_create callback" do
-    User.test_callbacks = [:do_after, :do_normal, :raise_rollback]
-    user = User.create!
-    User.test_stack.should == [:normal]
-  end
-
-  it "does not execute when transaction gets rolled back by ActiveRecord::Rollback outside of the model" do
-    User.test_callbacks = [:do_after, :do_normal]
-    user = nil
-    ActiveRecord::Base.transaction do
-      user = User.create!
-      raise ActiveRecord::Rollback
-    end
-    User.test_stack.should == [:normal]
-  end
-
-  it "clears transaction callbacks when transaction fails" do
-    User.test_callbacks = [:do_after, :do_normal, :oops]
-    lambda{
-      User.create!
-    }.should raise_error(AnExpectedError)
-    User.test_callbacks = [:do_normal]
-    User.create!
-    User.test_stack.should == [:normal, :normal]
-  end
-
-  it "executes when no transaction is open" do
-    user = User.new
-    user.do_after
-    user.do_normal
-    User.test_stack.should == [:after, :normal]
-  end
-
-  it "executes when open transactions are normal" do
-    User.normally_open_transactions = 1
-    User.test_callbacks = [:do_after, :do_normal]
-    User.create!
-    User.test_stack.should == [:after, :normal]
-  end
-
-  it "does not execute the same callback twice when successful" do
-    User.test_callbacks = [:do_after, :do_normal]
-    User.create!
-    User.create!
-    User.test_stack.should == [:normal, :after, :normal, :after]
-  end
-
-  it "does not execute the same callback twice when failed" do
-    User.test_callbacks = [:do_after, :do_normal, :oops]
-    lambda{
-      User.create!
-    }.should raise_error(AnExpectedError)
-    lambda{
-      User.create!
-    }.should raise_error(AnExpectedError)
-    User.test_stack.should == [:normal, :normal]
-  end
-
-  it "does not crash with additional options" do
-    User.transaction(:requires_new => true){}
-  end
-
-  describe :normally_open_transactions do
-    it "uses 0 by default" do
-      User.normally_open_transactions.should == 0
-    end
-
-    it "can set normally open transactions" do
-      User.normally_open_transactions = 5
-      User.normally_open_transactions.should == 5
-    end
-
-    it "sets them globally" do
-      User.normally_open_transactions = 5
-      ActiveRecord::Base.normally_open_transactions.should == 5
-    end
-  end
-end
-
-describe "A normal ActiveRecord subclass" do
-  it "does not get polluted" do
-    User.const_defined?(:VERSION).should be_false
-    User.const_defined?(:Version).should be_false
-  end
-end

data/spec/setup_database.rb

@@ -1,19 +0,0 @@
-ActiveRecord::Base.establish_connection(
-  :adapter  => 'sqlite3',
-  :database => ':memory:'
-)
-
-ActiveRecord::Migration.verbose = false
-ActiveRecord::Schema.define(:version => 1) do
-  create_table :users do |t|
-    t.string :name
-    t.timestamps
-  end
-end
-
-# for detailed debugging:
-#require 'logger'
-#ActiveRecord::Base.logger = Logger.new(STDOUT)
-
-class User < ActiveRecord::Base
-end

data/spec/spec_helper.rb

@@ -1,2 +0,0 @@
-require 'ar_after_transaction'
-require File.expand_path '../setup_database', __FILE__