ar-resque-counter-cache 3.0.1 → 3.0.2

data/lib/ar-resque-counter-cache/active_record.rb

@@ -73,7 +73,7 @@ module ArResqueCounterCache
         # however, we need the `:counter_cache` option to be present so that
         # `ActiveRecord::Base.reset_counters` works correctly (as of
         # activerecord 3.2.9).
-        options[:counter_cache] = true
+        options[:counter_cache] = true if options[:async_counter_cache]
         reflection
       end
 

data/lib/ar-resque-counter-cache/version.rb

@@ -1,3 +1,3 @@
 module ArResqueCounterCache
-  VERSION = '3.0.1'
+  VERSION = '3.0.2'
 end

data/spec/ar_resque_counter_cache/active_record_spec.rb

@@ -44,5 +44,22 @@ describe ArResqueCounterCache::ActiveRecord do
       user.reload
       user.posts_count.should eq(10)
     end
+
+    it "should allow normal counter caches" do
+      user.dogs.create(:name => "Ruff")
+      user.reload
+      user.dogs_count.should eq(1)
+    end
+
+    it "should allow non-counter caches" do
+      user2 = User.create(:name => "Sam")
+      cat = user.cats.create(:name => "Missy")
+      # Transfership of ownership would trigger counter cache methods... it
+      # should do nothing here.
+      cat.user = user2
+      cat.save!
+      user.cats.size.should eq(0)
+      user2.cats.size.should eq(1)
+    end
   end
 end

data/spec/models.rb

@@ -7,6 +7,7 @@ class CreateModelsForTest < ActiveRecord::Migration
       t.string     :name
       t.integer    :posts_count, :default => 0
       t.integer    :comments_count, :default => 0
+      t.integer    :dogs_count, :default => 0
     end
     create_table :posts do |t|
       t.string     :body
@@ -18,17 +19,29 @@ class CreateModelsForTest < ActiveRecord::Migration
       t.belongs_to :user
       t.belongs_to :post
     end
+    create_table :dogs do |t|
+      t.string     :name
+      t.belongs_to :user
+    end
+    create_table :cats do |t|
+      t.string     :name
+      t.belongs_to :user
+    end
   end
   def self.down
     drop_table(:users)
     drop_table(:posts)
     drop_table(:comments)
+    drop_table(:dogs)
+    drop_table(:cats)
   end
 end
 
 class User < ActiveRecord::Base
   has_many :comments
   has_many :posts
+  has_many :dogs
+  has_many :cats
 end
 
 class Post < ActiveRecord::Base
@@ -40,3 +53,13 @@ class Comment < ActiveRecord::Base
   belongs_to :user, :async_counter_cache => true
   belongs_to :post, :async_counter_cache => "count_of_comments"
 end
+
+# Old school counter cache.
+class Dog < ActiveRecord::Base
+  belongs_to :user, :counter_cache => true
+end
+
+# No counter cache at all.
+class Cat < ActiveRecord::Base
+  belongs_to :user
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ar-resque-counter-cache
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-26 00:00:00.000000000 Z
+date: 2012-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord