ar-octopus 0.8.5 → 0.10.2

data/spec/migrations/3_create_users_on_both_shards.rb

@@ -1,4 +1,4 @@
-class CreateUsersOnBothShards < ActiveRecord::Migration
+class CreateUsersOnBothShards < BaseOctopusMigrationClass
   using(:brazil, :canada)
 
   def self.up

data/spec/migrations/4_create_users_on_shards_of_a_group.rb

@@ -1,4 +1,4 @@
-class CreateUsersOnShardsOfAGroup < ActiveRecord::Migration
+class CreateUsersOnShardsOfAGroup < BaseOctopusMigrationClass
   using_group(:country_shards)
 
   def self.up

data/spec/migrations/5_create_users_on_multiples_groups.rb

@@ -1,4 +1,4 @@
-class CreateUsersOnMultiplesGroups < ActiveRecord::Migration
+class CreateUsersOnMultiplesGroups < BaseOctopusMigrationClass
   using_group('country_shards', 'history_shards')
 
   def self.up

data/spec/migrations/6_raise_exception_with_invalid_shard_name.rb

@@ -1,4 +1,4 @@
-class RaiseExceptionWithInvalidShardName < ActiveRecord::Migration
+class RaiseExceptionWithInvalidShardName < BaseOctopusMigrationClass
   using(:amazing_shard)
 
   def self.up

data/spec/migrations/7_raise_exception_with_invalid_multiple_shard_names.rb

@@ -1,4 +1,4 @@
-class RaiseExceptionWithInvalidMultipleShardNames < ActiveRecord::Migration
+class RaiseExceptionWithInvalidMultipleShardNames < BaseOctopusMigrationClass
   using(:brazil, :invalid_shard)
 
   def self.up

data/spec/migrations/8_raise_exception_with_invalid_group_name.rb

@@ -1,4 +1,4 @@
-class RaiseExceptionWithInvalidGroupName < ActiveRecord::Migration
+class RaiseExceptionWithInvalidGroupName < BaseOctopusMigrationClass
   using_group(:invalid_group)
 
   def self.up

data/spec/migrations/9_raise_exception_with_multiple_invalid_group_names.rb

@@ -1,4 +1,4 @@
-class RaiseExceptionWithMultipleInvalidGroupNames < ActiveRecord::Migration
+class RaiseExceptionWithMultipleInvalidGroupNames < BaseOctopusMigrationClass
   using_group(:country_shards, :invalid_group)
 
   def self.up

data/spec/octopus/association_shard_tracking_spec.rb

@@ -73,6 +73,7 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
       expect(@brazil_role.permissions).to eq([@permission_brazil])
 
       expect(@brazil_role.permissions.first).to eq(@permission_brazil)
+      expect(@brazil_role.permissions.first!).to eq(@permission_brazil)
       expect(@brazil_role.permissions.last).to eq(@permission_brazil)
     end
 
@@ -81,6 +82,7 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
       expect(@permission_brazil.roles).to eq([@brazil_role])
 
       expect(@permission_brazil.roles.first).to eq(@brazil_role)
+      expect(@permission_brazil.roles.first!).to eq(@brazil_role)
       expect(@permission_brazil.roles.last).to eq(@brazil_role)
     end
 
@@ -94,7 +96,7 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
       expect(@permission_brazil.roles).to eq([new_brazil_role])
     end
 
-    it 'should works for build method' do
+    it 'should work for build method' do
       new_brazil_role = Role.using(:brazil).create!(:name => 'Brazil Role')
       c = new_brazil_role.permissions.create(:name => 'new Permission')
       c.save
@@ -103,7 +105,7 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
       expect(new_brazil_role.permissions).to eq([c])
     end
 
-    describe 'it should works when using' do
+    describe 'it should work when using' do
       before(:each) do
         @permission_brazil_2 = Permission.using(:brazil).create!(:name => 'Brazil Item 2')
         @role = Role.using(:brazil).create!(:name => 'testes')
@@ -194,11 +196,97 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
         expect(@permission_brazil_2.roles.first).to be_nil
       end
 
+      it 'where' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1')).to eq([role])
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.where('1=1')).to be_empty
+      end
+
+      it 'map' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.map(&:id)).to eq([role.id])
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.map(&:id)).to be_empty
+      end
+
+      it 'where + map' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1').map(&:id)).to eq([role.id])
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.where('1=1').map(&:id)).to be_empty
+      end
+
+      # each_with_index is not listed in active_record/relation/delegation.rb
+      it 'where + each_with_index + map (enum method chain)' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1').each_with_index.map { |r, i| [r.id, i]}).to eq([[role.id, 0]])
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.where('1=1').each_with_index.map { |r, i| [r.id, i]}).to be_empty
+      end
+
+      # sum & index_by is specialized in active_support/core_ext/enumerable.rb
+      it 'where + sum' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1').sum(&:id)).to eq(role.id)
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.where('1=1').sum(&:id)).to eq(0)
+      end
+
+      it 'where + index_by' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1').index_by(&:id)).to eq(role.id => role)
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.where('1=1').index_by(&:id)).to be_empty
+      end
+
+      it 'where + find' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1').find([role.id])).to eq([role])
+        @permission_brazil_2.roles.destroy_all
+        expect { @permission_brazil_2.roles.where('1=1').find([role.id]) }.to raise_error ActiveRecord::RecordNotFound
+      end
+
+      it 'where + find with block' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1').find { |r| r.id == role.id }).to eq(role)
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.where('1=1').find { |r| r.id == role.id }).to be_nil
+      end
+
+      it 'where + select' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1').select(:name).first.name).to eq(role.name)
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.where('1=1').select(:name)).to be_empty
+      end
+
+      it 'where + select with block' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1').select { |r| r.id == role.id }).to eq([role])
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.where('1=1').select { |r| r.id == role.id }).to be_empty
+      end
+
+      it 'where + any?' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1').any?).to be true
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.where('1=1').any?).to be false
+      end
+
+      it 'where + any? with block' do
+        role = @permission_brazil_2.roles.create(:name => 'Builded Role')
+        expect(@permission_brazil_2.roles.where('1=1').any? { |r| r.id == role.id }).to be true
+        @permission_brazil_2.roles.destroy_all
+        expect(@permission_brazil_2.roles.where('1=1').any? { |r| r.id == role.id }).to be false
+      end
+
       it 'exists?' do
         role = @permission_brazil_2.roles.create(:name => 'Builded Role')
-        expect(@permission_brazil_2.roles.exists?(role)).to be true
+        expect(@permission_brazil_2.roles.exists?(role.id)).to be true
         @permission_brazil_2.roles.destroy_all
-        expect(@permission_brazil_2.roles.exists?(role)).to be false
+        expect(@permission_brazil_2.roles.exists?(role.id)).to be false
       end
 
       it 'clear' do
@@ -248,7 +336,7 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
       expect(@project.programmers).to eq([new_brazil_programmer])
     end
 
-    it 'should works for create method' do
+    it 'should work for create method' do
       new_brazil_programmer = Programmer.using(:brazil).create!(:name => 'Joao')
       c = new_brazil_programmer.projects.create(:name => 'new Project')
       c.save
@@ -257,7 +345,7 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
       expect(new_brazil_programmer.projects).to eq([c])
     end
 
-    describe 'it should works when using' do
+    describe 'it should work when using' do
       before(:each) do
         @new_brazil_programmer = Programmer.using(:brazil).create!(:name => 'Jose')
         @project = Project.using(:brazil).create!(:name => 'VB Application :-(')
@@ -348,11 +436,95 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
         expect(@new_brazil_programmer.projects.first).to be_nil
       end
 
+      it 'where' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1')).to eq([role])
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.where('1=1')).to be_empty
+      end
+
+      it 'map' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.map(&:id)).to eq([role.id])
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.map(&:id)).to be_empty
+      end
+
+      it 'where + map' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1').map(&:id)).to eq([role.id])
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.where('1=1').map(&:id)).to be_empty
+      end
+
+      it 'where + each_with_index + map (enum method chain)' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1').each_with_index.map { |r, i| [r.id, i] }).to eq([[role.id, 0]])
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.where('1=1').each_with_index.map { |r, i| [r.id, i] }).to be_empty
+      end
+
+      it 'where + sum' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1').sum(&:id)).to eq(role.id)
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.where('1=1').sum(&:id)).to eq(0)
+      end
+
+      it 'where + index_by' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1').index_by(&:id)).to eq(role.id => role)
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.where('1=1').index_by(&:id)).to be_empty
+      end
+
+      it 'where + find' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1').find(role.id)).to eq(role)
+        @new_brazil_programmer.projects.destroy_all
+        expect { @new_brazil_programmer.projects.where('1=1').find(role.id) }.to raise_error ActiveRecord::RecordNotFound
+      end
+
+      it 'where + find with block' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1').find { |r| r.id == role.id }).to eq(role)
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.where('1=1').find { |r| r.id == role.id }).to be_nil
+      end
+
+      it 'where + select' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1').select(:name).first.name).to eq(role.name)
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.where('1=1').select(:name)).to be_empty
+      end
+
+      it 'where + select with block' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1').select { |r| r.id == role.id }).to eq([role])
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.where('1=1').select { |r| r.id == role.id }).to be_empty
+      end
+
+      it 'where + any?' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1').any?).to be true
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.where('1=1').any?).to be false
+      end
+
+      it 'where + any? with block' do
+        role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
+        expect(@new_brazil_programmer.projects.where('1=1').any? { |r| r.id == role.id }).to be true
+        @new_brazil_programmer.projects.destroy_all
+        expect(@new_brazil_programmer.projects.where('1=1').any? { |r| r.id == role.id }).to be false
+      end
+
       it 'exists?' do
         role = @new_brazil_programmer.projects.create(:name => 'New VB App :-/')
-        expect(@new_brazil_programmer.projects.exists?(role)).to be true
+        expect(@new_brazil_programmer.projects.exists?(role.id)).to be true
         @new_brazil_programmer.projects.destroy_all
-        expect(@new_brazil_programmer.projects.exists?(role)).to be false
+        expect(@new_brazil_programmer.projects.exists?(role.id)).to be false
       end
 
       it 'clear' do
@@ -399,7 +571,13 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
     it 'should raise error if you try to add a record from a different shard' do
       expect do
         @brazil_client.items << Item.using(:canada).create!(:name => 'New User')
-      end.to raise_error('Association Error: Records are from different shards')
+      end.to raise_error(Octopus::AssociationShardTracking::MismatchedShards)
+    end
+
+    it 'should make difference if the shard is a symbol or a string for raising Octopus::AssociationShardTracking::MismatchedShards' do
+      expect do
+        @brazil_client.items << Item.using('brazil').create!(:name => 'New Brazil Item')
+      end.not_to raise_error
     end
 
     it 'should update the attribute for the item' do
@@ -412,7 +590,7 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
       expect(@item_brazil.client).to eq(new_brazil_client)
     end
 
-    it 'should works for build method' do
+    it 'should work for build method' do
       item2 = Item.using(:brazil).create!(:name => 'Brazil Item')
       c = item2.create_client(:name => 'new Client')
       c.save
@@ -440,7 +618,7 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
       end
     end
 
-    describe 'it should works when using' do
+    describe 'it should work when using' do
       before(:each) do
         @item_brazil_2 = Item.using(:brazil).create!(:name => 'Brazil Item 2')
         expect(@brazil_client.items.to_set).to eq([@item_brazil].to_set)
@@ -537,10 +715,82 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
         expect(@brazil_client.items.first).to be_nil
       end
 
+      it 'where' do
+        expect(@brazil_client.items.where('1=1')).to eq([@item_brazil])
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.where('1=1')).to be_empty
+      end
+
+      it 'map' do
+        expect(@brazil_client.items.map(&:id)).to eq([@item_brazil.id])
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.map(&:id)).to be_empty
+      end
+
+      it 'where + map' do
+        expect(@brazil_client.items.where('1=1').map(&:id)).to eq([@item_brazil.id])
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.where('1=1').map(&:id)).to be_empty
+      end
+
+      it 'where + each_with_index + map (enum method chain)' do
+        expect(@brazil_client.items.where('1=1').each_with_index.map { |r, i| [r.id, i]}).to eq([[@item_brazil.id, 0]])
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.where('1=1').each_with_index.map { |r, i| [r.id, i]}).to be_empty
+      end
+
+      it 'where + sum' do
+        expect(@brazil_client.items.where('1=1').sum(&:id)).to eq(@item_brazil.id)
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.where('1=1').sum(&:id)).to eq(0)
+      end
+
+      it 'where + index_by' do
+        expect(@brazil_client.items.where('1=1').index_by(&:id)).to eq(@item_brazil.id => @item_brazil)
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.where('1=1').index_by(&:id)).to be_empty
+      end
+
+      it 'where + find' do
+        expect(@brazil_client.items.where('1=1').find(@item_brazil.id)).to eq(@item_brazil)
+        @brazil_client.items.destroy_all
+        expect { @brazil_client.items.where('1=1').find(@item_brazil.id) }.to raise_error ActiveRecord::RecordNotFound
+      end
+
+      it 'where + find with block' do
+        expect(@brazil_client.items.where('1=1').find { |i| i.id == @item_brazil.id }).to eq(@item_brazil)
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.where('1=1').find { |i| i.id == @item_brazil.id }).to be_nil
+      end
+
+      it 'where + select' do
+        expect(@brazil_client.items.where('1=1').select(:name).first.name).to eq(@item_brazil.name)
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.where('1=1').select(:name)).to be_empty
+      end
+
+      it 'where + select with block' do
+        expect(@brazil_client.items.where('1=1').select { |i| i.id == @item_brazil.id }).to eq([@item_brazil])
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.where('1=1').select { |i| i.id == @item_brazil.id }).to be_empty
+      end
+
+      it 'where + any?' do
+        expect(@brazil_client.items.where('1=1').any?).to be true
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.where('1=1').any?).to be false
+      end
+
+      it 'where + any? with block' do
+        expect(@brazil_client.items.where('1=1').any? { |i| i.id == @item_brazil.id }).to be true
+        @brazil_client.items.destroy_all
+        expect(@brazil_client.items.where('1=1').any? { |i| i.id == @item_brazil.id }).to be false
+      end
+
       it 'exists?' do
-        expect(@brazil_client.items.exists?(@item_brazil)).to be true
+        expect(@brazil_client.items.exists?(@item_brazil.id)).to be true
         @brazil_client.items.destroy_all
-        expect(@brazil_client.items.exists?(@item_brazil)).to be false
+        expect(@brazil_client.items.exists?(@item_brazil.id)).to be false
       end
 
       it 'uniq' do
@@ -584,7 +834,7 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
       expect(@comment_brazil.commentable).to eq(new_brazil_client)
     end
 
-    describe 'it should works when using' do
+    describe 'it should work when using' do
       before(:each) do
         @comment_brazil_2 = Comment.using(:brazil).create!(:name => 'Brazil Comment 2')
         expect(@brazil_client.comments.to_set).to eq([@comment_brazil].to_set)
@@ -630,6 +880,12 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
         expect(@brazil_client.comments.count).to eq(2)
       end
 
+      it 'group + count' do
+        expect(@brazil_client.comments.group(:id).count.length).to eq(1)
+        _cmt = @brazil_client.comments.create(:name => 'Builded Comment')
+        expect(@brazil_client.comments.group(:id).count.length).to eq(2)
+      end
+
       it 'size' do
         expect(@brazil_client.comments.size).to eq(1)
         _cmt = @brazil_client.comments.create(:name => 'Builded Comment')
@@ -681,10 +937,82 @@ describe Octopus::AssociationShardTracking, :shards => [:brazil, :master, :canad
         expect(@brazil_client.comments.first).to be_nil
       end
 
+      it 'where' do
+        expect(@brazil_client.comments.where('1=1')).to eq([@comment_brazil])
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.where('1=1')).to be_empty
+      end
+
+      it 'map' do
+        expect(@brazil_client.comments.map(&:id)).to eq([@comment_brazil.id])
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.map(&:id)).to be_empty
+      end
+
+      it 'where + map' do
+        expect(@brazil_client.comments.where('1=1').map(&:id)).to eq([@comment_brazil.id])
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.where('1=1').map(&:id)).to be_empty
+      end
+
+      it 'where + each_with_index + map (enum method chain)' do
+        expect(@brazil_client.comments.where('1=1').each_with_index.map { |r, i| [r.id, i]}).to eq([[@comment_brazil.id, 0]])
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.where('1=1').each_with_index.map { |r, i| [r.id, i]}).to be_empty
+      end
+
+      it 'where + sum' do
+        expect(@brazil_client.comments.where('1=1').sum(&:id)).to eq(@comment_brazil.id)
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.where('1=1').sum(&:id)).to eq(0)
+      end
+
+      it 'where + index_by' do
+        expect(@brazil_client.comments.where('1=1').index_by(&:id)).to eq(@comment_brazil.id => @comment_brazil)
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.where('1=1').index_by(&:id)).to be_empty
+      end
+
+      it 'where + find' do
+        expect(@brazil_client.comments.where('1=1').find(@comment_brazil.id)).to eq(@comment_brazil)
+        @brazil_client.comments.destroy_all
+        expect { @brazil_client.comments.where('1=1').find(@comment_brazil.id) }.to raise_error ActiveRecord::RecordNotFound
+      end
+
+      it 'where + find with block' do
+        expect(@brazil_client.comments.where('1=1').find { |c| c.id == @comment_brazil.id }).to eq(@comment_brazil)
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.where('1=1').find { |c| c.id == @comment_brazil.id }).to be_nil
+      end
+
+      it 'where + select' do
+        expect(@brazil_client.comments.where('1=1').select(:name).first.name).to eq(@comment_brazil.name)
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.where('1=1').select(:name)).to be_empty
+      end
+
+      it 'where + select with block' do
+        expect(@brazil_client.comments.where('1=1').select { |c| c.id == @comment_brazil.id }).to eq([@comment_brazil])
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.where('1=1').select { |c| c.id == @comment_brazil.id }).to be_empty
+      end
+
+      it 'where + any?' do
+        expect(@brazil_client.comments.where('1=1').any?).to be true
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.where('1=1').any?).to be false
+      end
+
+      it 'where + any? with block' do
+        expect(@brazil_client.comments.where('1=1').any? { |c| c.id == @comment_brazil.id }).to be true
+        @brazil_client.comments.destroy_all
+        expect(@brazil_client.comments.where('1=1').any? { |c| c.id == @comment_brazil.id }).to be false
+      end
+
       it 'exists?' do
-        expect(@brazil_client.comments.exists?(@comment_brazil)).to be true
+        expect(@brazil_client.comments.exists?(@comment_brazil.id)).to be true
         @brazil_client.comments.destroy_all
-        expect(@brazil_client.comments.exists?(@comment_brazil)).to be false
+        expect(@brazil_client.comments.exists?(@comment_brazil.id)).to be false
       end
 
       it 'uniq' do

data/spec/octopus/load_balancing/round_robin_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Octopus::LoadBalancing::RoundRobin do
+  it "raises an error when no shards are given" do
+    expect do
+      Octopus::LoadBalancing::RoundRobin.new([])
+    end.to raise_error Octopus::Exception
+  end
+
+  it "does not raise an error if slaves given" do
+    expect do
+      Octopus::LoadBalancing::RoundRobin.new([:stub])
+    end.to_not raise_error Octopus::Exception
+  end
+end

data/spec/octopus/log_subscriber_spec.rb

@@ -9,7 +9,7 @@ describe Octopus::LogSubscriber, :shards => [:canada] do
   end
 
   after :each do
-    ActiveRecord::Base.logger = nil
+    ActiveRecord::Base.logger = Logger.new(File.open('database.log', 'a'))
   end
 
   it 'should add to the default logger the shard name the query was sent to' do

data/spec/octopus/migration_spec.rb

@@ -1,5 +1,14 @@
 require 'spec_helper'
 
+def get_all_versions
+  if Octopus.atleast_rails52?
+    migrations_root = File.expand_path(File.join(File.dirname(__FILE__), '..', 'migrations'))
+    ActiveRecord::MigrationContext.new(migrations_root).get_all_versions
+  else
+    ActiveRecord::Migrator.get_all_versions
+  end
+end
+
 describe Octopus::Migration do
   it 'should run just in the master shard' do
     OctopusHelper.migrating_to_version 1 do
@@ -30,6 +39,32 @@ describe Octopus::Migration do
     end
   end
 
+  it "should rollback correctly migrations" do
+    migrations_root = File.expand_path(File.join(File.dirname(__FILE__), '..', 'migrations'))
+    if Octopus.atleast_rails52?
+      OctopusHelper.migrate_to_version(:up, migrations_root, 4)
+    else
+      ActiveRecord::Migrator.run(:up, migrations_root, 4)
+    end
+
+    expect(User.using(:canada).find_by_name('Group')).not_to be_nil
+    expect(User.using(:brazil).find_by_name('Group')).not_to be_nil
+    expect(User.using(:russia).find_by_name('Group')).not_to be_nil
+
+
+    Octopus.using(:canada) do
+      if Octopus.atleast_rails52?
+        OctopusHelper.migrate_to_version(:down, migrations_root, 4)
+      else
+        ActiveRecord::Migrator.rollback(migrations_root, 4)
+      end
+    end
+
+    expect(User.using(:canada).find_by_name('Group')).to be_nil
+    expect(User.using(:brazil).find_by_name('Group')).to be_nil
+    expect(User.using(:russia).find_by_name('Group')).to be_nil
+  end
+
   it 'should run once per shard' do
     OctopusHelper.migrating_to_version 5 do
       expect(User.using(:canada).where(:name => 'MultipleGroup').size).to eq(1)
@@ -80,9 +115,9 @@ describe Octopus::Migration do
     class SchemaMigration < ActiveRecord::Base; end
 
     OctopusHelper.migrating_to_version 14 do
-      expect(Octopus.using(:canada) { ActiveRecord::Migrator.get_all_versions }).to include(14)
-      expect(Octopus.using(:brazil) { ActiveRecord::Migrator.get_all_versions }).to include(14)
-      expect(Octopus.using(:russia) { ActiveRecord::Migrator.get_all_versions }).to include(14)
+      expect(Octopus.using(:canada) { get_all_versions }).to include(14)
+      expect(Octopus.using(:brazil) { get_all_versions }).to include(14)
+      expect(Octopus.using(:russia) { get_all_versions }).to include(14)
     end
   end
 
@@ -93,9 +128,9 @@ describe Octopus::Migration do
     Octopus.using(:canada) { SchemaMigration.create(:version => 14) }
 
     OctopusHelper.migrating_to_version 14 do
-      expect(Octopus.using(:canada) { ActiveRecord::Migrator.get_all_versions }).to include(14)
-      expect(Octopus.using(:brazil) { ActiveRecord::Migrator.get_all_versions }).to include(14)
-      expect(Octopus.using(:russia) { ActiveRecord::Migrator.get_all_versions }).to include(14)
+      expect(Octopus.using(:canada) { get_all_versions }).to include(14)
+      expect(Octopus.using(:brazil) { get_all_versions }).to include(14)
+      expect(Octopus.using(:russia) { get_all_versions }).to include(14)
     end
   end
 
@@ -103,13 +138,12 @@ describe Octopus::Migration do
     it 'should run migrations on all shards in the default_migration_group' do
       OctopusHelper.using_environment :octopus_with_default_migration_group do
         OctopusHelper.migrating_to_version 15 do
-          expect(Octopus.using(:master) { ActiveRecord::Migrator.get_all_versions }).not_to include(15)
-          expect(Octopus.using(:canada) { ActiveRecord::Migrator.get_all_versions }).to include(15)
-          expect(Octopus.using(:brazil) { ActiveRecord::Migrator.get_all_versions }).to include(15)
-          expect(Octopus.using(:russia) { ActiveRecord::Migrator.get_all_versions }).to include(15)
+          expect(Octopus.using(:master) { get_all_versions }).not_to include(15)
+          expect(Octopus.using(:canada) { get_all_versions }).to include(15)
+          expect(Octopus.using(:brazil) { get_all_versions }).to include(15)
+          expect(Octopus.using(:russia) { get_all_versions }).to include(15)
         end
       end
     end
   end
-
 end