ar-octopus 0.8.2 → 0.8.3

data/spec/octopus/sharded_replicated_slave_grouped_spec.rb

@@ -1,54 +1,54 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "when the database is both sharded and replicated" do
+describe 'when the database is both sharded and replicated' do
 
-  it "should pick the shard based on current_shard when you have a sharded model" do
+  it 'should pick the shard based on current_shard when you have a sharded model' do
 
     OctopusHelper.using_environment :sharded_replicated_slave_grouped do
       Octopus.using(:russia) do
-        Cat.create!(:name => "Thiago1")
-        Cat.create!(:name => "Thiago2")
+        Cat.create!(:name => 'Thiago1')
+        Cat.create!(:name => 'Thiago2')
       end
 
       # We must stub here to make it effective (not in the `before(:each)` block)
-      Octopus.stub(:env).and_return("sharded_replicated_slave_grouped")
+      allow(Octopus).to receive(:env).and_return('sharded_replicated_slave_grouped')
 
-      Cat.using(:russia).count.should == 2
+      expect(Cat.using(:russia).count).to eq(2)
       # It distributes queries between two slaves in the slave group
-      Cat.using(shard: :russia, slave_group: :slaves1).count.should == 0
-      Cat.using(shard: :russia, slave_group: :slaves1).count.should == 2
-      Cat.using(shard: :russia, slave_group: :slaves1).count.should == 0
+      expect(Cat.using(:shard => :russia, :slave_group => :slaves1).count).to eq(0)
+      expect(Cat.using(:shard => :russia, :slave_group => :slaves1).count).to eq(2)
+      expect(Cat.using(:shard => :russia, :slave_group => :slaves1).count).to eq(0)
       # It distributes queries between two slaves in the slave group
-      Cat.using(shard: :russia, slave_group: :slaves2).count.should == 2
-      Cat.using(shard: :russia, slave_group: :slaves2).count.should == 0
-      Cat.using(shard: :russia, slave_group: :slaves2).count.should == 2
-
-      Cat.using(:europe).count.should == 0
-      Cat.using(shard: :europe, slave_group: :slaves1)
-        .count.should == 0
-      Cat.using(shard: :europe, slave_group: :slaves2)
-        .count.should == 2
+      expect(Cat.using(:shard => :russia, :slave_group => :slaves2).count).to eq(2)
+      expect(Cat.using(:shard => :russia, :slave_group => :slaves2).count).to eq(0)
+      expect(Cat.using(:shard => :russia, :slave_group => :slaves2).count).to eq(2)
+
+      expect(Cat.using(:europe).count).to eq(0)
+      expect(Cat.using(:shard => :europe, :slave_group => :slaves1)
+        .count).to eq(0)
+      expect(Cat.using(:shard => :europe, :slave_group => :slaves2)
+        .count).to eq(2)
     end
   end
 
-  it "should make queries to master when slave groups are configured for the shard but not selected" do
+  it 'should make queries to master when slave groups are configured for the shard but not selected' do
     OctopusHelper.using_environment :sharded_replicated_slave_grouped do
       Octopus.using(:europe) do
         # All the queries go to :master(`octopus_shard_1`)
 
-        Cat.create!(:name => "Thiago1")
-        Cat.create!(:name => "Thiago2")
+        Cat.create!(:name => 'Thiago1')
+        Cat.create!(:name => 'Thiago2')
 
         # In `database.yml` and `shards.yml`, we have configured 1 master and 6 slaves for `sharded_replicated_slave_grouped`
         # So we can ensure Octopus is not distributing queries between them
         # by asserting 1 + 6 = 7 queries go to :master(`octopus_shard_1`)
-        Cat.count.should == 2
-        Cat.count.should == 2
-        Cat.count.should == 2
-        Cat.count.should == 2
-        Cat.count.should == 2
-        Cat.count.should == 2
-        Cat.count.should == 2
+        expect(Cat.count).to eq(2)
+        expect(Cat.count).to eq(2)
+        expect(Cat.count).to eq(2)
+        expect(Cat.count).to eq(2)
+        expect(Cat.count).to eq(2)
+        expect(Cat.count).to eq(2)
+        expect(Cat.count).to eq(2)
       end
     end
   end

data/spec/octopus/sharded_spec.rb

@@ -1,13 +1,13 @@
-require "spec_helper"
+require 'spec_helper'
 
-describe "when the database is not entire sharded" do
+describe 'when the database is not entire sharded' do
   before(:each) do
-    Octopus.stub(:env).and_return("not_entire_sharded")
-    OctopusHelper.clean_connection_proxy()
+    allow(Octopus).to receive(:env).and_return('not_entire_sharded')
+    OctopusHelper.clean_connection_proxy
   end
 
-  it "should not send all queries to the specified slave" do
-    pending()
+  it 'should not send all queries to the specified slave' do
+    skip
     # User.create!(:name => "Thiago")
     #
     # using_environment :not_entire_sharded do
@@ -19,15 +19,15 @@ describe "when the database is not entire sharded" do
     # User.count.should == 2
   end
 
-  it "should pick the shard based on current_shard when you have a sharded model" do
-    Cat.create!(:name => "Thiago")
+  it 'should pick the shard based on current_shard when you have a sharded model' do
+    Cat.create!(:name => 'Thiago')
 
     OctopusHelper.using_environment :not_entire_sharded do
       Octopus.using(:russia) do
-        Cat.create!(:name => "Thiago")
+        Cat.create!(:name => 'Thiago')
       end
     end
 
-    Cat.count.should == 1
+    expect(Cat.count).to eq(1)
   end
 end

data/spec/spec_helper.rb

@@ -1,16 +1,16 @@
-require "rubygems"
-require "pry"
-require "bundler/setup"
-require "octopus"
+require 'rubygems'
+require 'pry'
+require 'bundler/setup'
+require 'octopus'
 
 Octopus.instance_variable_set(:@directory, File.dirname(__FILE__))
 
 # Requires supporting files with custom matchers and macros, etc,
 # in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 RSpec.configure do |config|
-  config.before(:each) do
+  config.before(:each) do |example|
     OctopusHelper.clean_all_shards(example.metadata[:shards])
   end
 end

data/spec/support/active_record/connection_adapters/modify_config_adapter.rb

@@ -4,14 +4,12 @@ module ActiveRecord
       ConnectionAdapters::ModifyConfigAdapter.new(config)
     end
   end
-  
+
   module ConnectionAdapters
     class ModifyConfigAdapter < AbstractAdapter
-      
       def initialize(config)
         config.replace(config.symbolize_keys)
       end
-      
     end
   end
 end

data/spec/support/database_connection.rb

@@ -1,4 +1,4 @@
-require "logger"
+require 'logger'
 
-ActiveRecord::Base.establish_connection(:adapter => "mysql2", :database => "octopus_shard_1", :username => "root", :password => "")
+ActiveRecord::Base.establish_connection(:adapter => 'mysql2', :database => 'octopus_shard_1', :username => 'root', :password => '')
 ActiveRecord::Base.logger = Logger.new(File.open('database.log', 'a'))

data/spec/support/database_models.rb

@@ -1,36 +1,36 @@
 # Rails 3.1 needs to do some introspection around the base class, which requires
 # the model be a descendent of ActiveRecord::Base.
-class BlankModel < ActiveRecord::Base; end;
+class BlankModel < ActiveRecord::Base; end
 
-#The user class is just sharded, not replicated
+# The user class is just sharded, not replicated
 class User < ActiveRecord::Base
-  scope :thiago, lambda { where(:name => 'Thiago') }
+  scope :thiago, -> { where(:name => 'Thiago') }
 
   def awesome_queries
     Octopus.using(:canada) do
-      User.create(:name => "teste")
+      User.create(:name => 'teste')
     end
   end
 end
 
-#The client class isn't replicated
+# The client class isn't replicated
 class Client < ActiveRecord::Base
   has_many :items
   has_many :comments, :as => :commentable
 end
 
-#This class is replicated
+# This class is replicated
 class Cat < ActiveRecord::Base
-  replicated_model()
-  #sharded_model()
+  replicated_model
+  # sharded_model()
 end
 
-#This class sets its own connection
+# This class sets its own connection
 class CustomConnection < ActiveRecord::Base
-  octopus_establish_connection(:adapter => "mysql2", :database => "octopus_shard_2", :username => "root", :password => "")
+  octopus_establish_connection(:adapter => 'mysql2', :database => 'octopus_shard_2', :username => 'root', :password => '')
 end
 
-#This items belongs to a client
+# This items belongs to a client
 class Item < ActiveRecord::Base
   belongs_to :client
   has_many :parts
@@ -77,22 +77,21 @@ class Comment < ActiveRecord::Base
   belongs_to :commentable, :polymorphic => true
 end
 
-
 class Bacon < ActiveRecord::Base
   self.table_name = 'yummy'
 end
 
 class Cheese < ActiveRecord::Base
-  self.table_name = 'yummy' 
+  self.table_name = 'yummy'
 end
 
 class Ham < ActiveRecord::Base
   self.table_name = 'yummy'
 end
 
-#This class sets its own connection
+# This class sets its own connection
 class Advert < ActiveRecord::Base
-  establish_connection(:adapter => "postgresql", :database => "octopus_shard_1", :username => ENV["POSTGRES_USER"] || "postgres", :password => "")
+  establish_connection(:adapter => 'postgresql', :database => 'octopus_shard_1', :username => ENV['POSTGRES_USER'] || 'postgres', :password => '')
 end
 
 class MmorpgPlayer < ActiveRecord::Base
@@ -102,9 +101,9 @@ end
 
 class Weapon < ActiveRecord::Base
   belongs_to :mmorpg_player, :inverse_of => :weapons
-  validates  :hand, :uniqueness => { :scope => :mmorpg_player_id }
+  validates :hand, :uniqueness => { :scope => :mmorpg_player_id }
   validates_presence_of :mmorpg_player
-  has_many   :skills
+  has_many :skills
 end
 
 class Skill < ActiveRecord::Base

data/spec/support/octopus_helper.rb

@@ -5,30 +5,30 @@ module OctopusHelper
     end
 
     shards.each do |shard_symbol|
-      ['schema_migrations', 'users', 'clients', 'cats', 'items', 'keyboards', 'computers', 'permissions_roles', 'roles', 'permissions', 'assignments', 'projects', 'programmers', "yummy", 'adverts'].each do |tables|
+      %w(schema_migrations users clients cats items keyboards computers permissions_roles roles permissions assignments projects programmers yummy adverts).each do |tables|
         BlankModel.using(shard_symbol).connection.execute("DELETE FROM #{tables}")
       end
 
       if shard_symbol == 'alone_shard'
-        ['mmorpg_players', 'weapons', 'skills'].each do |table|
+        %w(mmorpg_players weapons skills).each do |table|
           BlankModel.using(shard_symbol).connection.execute("DELETE FROM #{table}")
         end
       end
     end
   end
 
-  def self.clean_connection_proxy()
-    Thread.current["octopus.current_model"] = nil
-    Thread.current["octopus.current_shard"] = nil
-    Thread.current["octopus.current_group"] = nil
-    Thread.current["octopus.current_slave_group"] = nil
-    Thread.current["octopus.block"] = nil
-    Thread.current["octopus.last_current_shard"] = nil
+  def self.clean_connection_proxy
+    Thread.current['octopus.current_model'] = nil
+    Thread.current['octopus.current_shard'] = nil
+    Thread.current['octopus.current_group'] = nil
+    Thread.current['octopus.current_slave_group'] = nil
+    Thread.current['octopus.block'] = nil
+    Thread.current['octopus.last_current_shard'] = nil
 
-    ActiveRecord::Base.send(:class_variable_set, '@@connection_proxy', nil)
+    ActiveRecord::Base.class_variable_set(:@@connection_proxy, nil)
   end
 
-  def self.migrating_to_version(version, &block)
+  def self.migrating_to_version(version, &_block)
     migrations_root = File.expand_path(File.join(File.dirname(__FILE__), '..', 'migrations'))
 
     begin
@@ -39,18 +39,16 @@ module OctopusHelper
     end
   end
 
-  def self.using_environment(environment, &block)
-    begin
-      set_octopus_env(environment.to_s)
-      clean_connection_proxy()
-      yield
-    ensure
-      set_octopus_env('octopus')
-      clean_connection_proxy()
-    end
+  def self.using_environment(environment, &_block)
+    self.octopus_env = environment.to_s
+    clean_connection_proxy
+    yield
+  ensure
+    self.octopus_env = 'octopus'
+    clean_connection_proxy
   end
 
-  def self.set_octopus_env(env)
+  def self.octopus_env=(env)
     Octopus.instance_variable_set(:@config, nil)
     Octopus.stub(:env).and_return(env)
   end

data/spec/support/query_count.rb

@@ -1,6 +1,5 @@
 module ActiveRecord
   class QueryCounter
-
     attr_accessor :query_count
 
     def initialize
@@ -11,9 +10,8 @@ module ActiveRecord
       lambda(&method(:callback))
     end
 
-    def callback(name, start, finish, message_id, values)
+    def callback(_name, _start, _finish, _message_id, values)
       @query_count += 1 unless %w(CACHE SCHEMA).include?(values[:name])
     end
-
   end
 end

data/spec/support/shared_contexts.rb

@@ -1,4 +1,4 @@
-shared_context "with query cache enabled" do
+shared_context 'with query cache enabled' do
   let!(:counter) { ActiveRecord::QueryCounter.new }
 
   before(:each) do
@@ -6,12 +6,12 @@ shared_context "with query cache enabled" do
     counter.query_count = 0
   end
 
-  after(:each) do 
+  after(:each) do
     ActiveRecord::Base.connection.disable_query_cache!
   end
 
   around(:each) do |example|
-    active_support_subscribed(counter.to_proc, 'sql.active_record') do 
+    active_support_subscribed(counter.to_proc, 'sql.active_record') do
       example.run
     end
   end

data/spec/tasks/octopus.rake_spec.rb

@@ -1,31 +1,31 @@
-require "spec_helper"
-require "rake"
+require 'spec_helper'
+require 'rake'
 
-describe "octopus.rake" do
+describe 'octopus.rake' do
   before do
-    load File.expand_path("../../../lib/tasks/octopus.rake", __FILE__)
+    load File.expand_path('../../../lib/tasks/octopus.rake', __FILE__)
     Rake::Task.define_task(:environment)
   end
 
-  describe "octopus:copy_schema_versions" do
+  describe 'octopus:copy_schema_versions' do
     class SchemaMigration < ActiveRecord::Base; end
 
     before do
-      Rake::Task["octopus:copy_schema_versions"].reenable
+      Rake::Task['octopus:copy_schema_versions'].reenable
 
-      path = File.expand_path("../../migrations", __FILE__)
+      path = File.expand_path('../../migrations', __FILE__)
       ActiveRecord::Migrator.migrations_paths = [path]
     end
 
-    it "assumes each shard migrated to the current master version" do
+    it 'assumes each shard migrated to the current master version' do
       SchemaMigration.create(:version => 1)
       SchemaMigration.create(:version => 2)
       SchemaMigration.create(:version => 3)
 
-      Rake::Task["octopus:copy_schema_versions"].invoke
+      Rake::Task['octopus:copy_schema_versions'].invoke
 
       ActiveRecord::Base.connection.shard_names.each do |shard_name|
-        Octopus.using(shard_name) { ActiveRecord::Migrator.get_all_versions }.should == [1, 2, 3]
+        expect(Octopus.using(shard_name) { ActiveRecord::Migrator.get_all_versions }).to eq([1, 2, 3])
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ar-octopus
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Thiago Pradi
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-03 00:00:00.000000000 Z
+date: 2014-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -41,77 +41,77 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 3.2.0
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.8.7
+        version: 0.3.8
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.8.7
+        version: 0.3.8
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: mysql2
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ! '>'
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '0.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ! '>'
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '0.3'
 - !ruby/object:Gem::Dependency
-  name: mysql2
+  name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>'
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: 0.11.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>'
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: 0.11.0
 - !ruby/object:Gem::Dependency
-  name: pg
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.8.7
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.11.0
+        version: 0.8.7
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.3.4
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.3.4
+        version: '3'
 - !ruby/object:Gem::Dependency
-  name: pry-debugger
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
@@ -125,19 +125,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.3.8
+        version: 1.3.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.3.8
+        version: 1.3.4
+- !ruby/object:Gem::Dependency
+  name: pry-debugger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: This gem allows you to use sharded databases with ActiveRecord. This
   also provides a interface for replication and for running migrations with multiples
   shards.
@@ -151,6 +165,8 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .rubocop.yml
+- .rubocop_todo.yml
 - .ruby-version
 - .travis.yml
 - Appraisals
@@ -161,6 +177,7 @@ files:
 - ar-octopus.gemspec
 - gemfiles/rails32.gemfile
 - gemfiles/rails4.gemfile
+- gemfiles/rails41.gemfile
 - init.rb
 - lib/ar-octopus.rb
 - lib/octopus.rb
@@ -327,7 +344,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.10
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Easy Database Sharding for ActiveRecord