aq_banking 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fb755fc3ecf19519221f888fbbff0eb89105db84
-  data.tar.gz: c914bed545653e9feae6e2e565e0dc74ce8e813f
+  metadata.gz: 70d0bb8ab7a557647a25a06b7a73765cab0270ad
+  data.tar.gz: 378949a71c9fe792ce46a6211f263abc5d97b1b9
 SHA512:
-  metadata.gz: a3b465c9fa966876670fefd120a3e74d3aacf08b1fdd7bb54c3c67e960429d650725376687dcac66f362b37216a53ffc9a485754eb7be6f3303961f5dc59fc22
-  data.tar.gz: c458b092d76bd9805f6b80edb7a5f4f75d0eeaf7dac10a8cbb7f1cc4efaad77e65e24ce153965a31f073de79bce778455e3b7fe8fc3a5b974b0913c64287e66c
+  metadata.gz: c70c690ba8abaaf78102c6f8d60f7007d8d02ac0fa7adb3b84f76bd2b0445850b9fa50cbfb5e665ef3ef2f1067740a5329edbf16be9f4d7a65fde00491bd474c
+  data.tar.gz: 39ece253a7a92c3aaca0800e28a738204ac745e0a1df9fea4ad894b14b7cd54e433505251e7b61a044f791be9dd612f2ceeadf60f0e4d745c7384ff642aaf485

data/README.md

@@ -34,8 +34,10 @@ $ aq_banking request --bank=diba BLZ ACCCOUNT_NUMBER LOGIN_ID PASSWORD --from=20
 }
 ```
 
-It still requires the aq_banking command line tools to be present.
-To avoid errors with versions etc, I recommend using the docker image:
+It still requires the aq_banking command line tools (aqhbci-tool4, aqbanking-cli) to be present.
+To my experience, these tools are very unstable and full of bugs.
+This tool is developed using a specific version which ships with the docker image.
+To avoid errors with different versions, I recommend using the docker image:
 
     docker run -it --rm rweng/aq_banking --help    
     docker run -it --rm rweng/aq_banking request --bank=diba BLZ ACCCOUNT_NUMBER LOGIN_ID PASSWORD --from=2016-04-18

data/lib/aq_banking/commander.rb

@@ -56,8 +56,8 @@ module AqBanking
         # ensure that no old password is in cache
         remove_user bank_code: bank_code, user_id: user_id
 
-        add_account(server_url: server_url, hbci_version: hbci_version,
-                    bank_code: bank_code, user_id: user_id, user_name: user_name)
+        add_user(server_url: server_url, hbci_version: hbci_version,
+                 bank_code: bank_code, user_id: user_id, user_name: user_name)
 
         call_getsysid pin_file: pin_file_path, user_id: user_id, bank_code: bank_code
 
@@ -77,7 +77,7 @@ module AqBanking
     # @param [String] bank_code
     # @param [String] user_id
     # @return [Boolean]
-    def account_exists?(bank_code:, user_id:)
+    def user_exists?(bank_code:, user_id:)
       result = run "aqhbci-tool4 listusers"
       result.stdout.include?("Bank: de/#{bank_code} User Id: #{user_id}")
     end
@@ -90,10 +90,21 @@ module AqBanking
     def remove_user(bank_code:, user_id:)
       logger.debug 'removing user %p' % {bank_code: bank_code, user_id: user_id}
 
-      run "aqhbci-tool4 deluser -u %p -b %p" % [user_id, bank_code]
+      # we must do this due to frickin aqhbci: the option --with-acccounts removes one account and if there are more
+      # an error is raised. on the other hand, aqhbci-tool4 listaccounts only shows bank_code and account number, but not
+      # user id. Refactorings to improve this are very welcome
+      count = 0
+      max_trials = 10
+      loop do
+        count = count + 1
+        result = run "aqhbci-tool4 deluser --with-accounts -u %p -b %p" % [user_id, bank_code]
+        break if result.stderr.include? 'ERROR: No matching users' or result.stdout.match /User %d+ deleted\./
+
+        raise 'could not delete user' if count >= max_trials
+      end
     end
 
-    def add_account(server_url:, hbci_version:, bank_code:, user_id:, user_name: '')
+    def add_user(server_url:, hbci_version:, bank_code:, user_id:, user_name: '')
       logger.debug 'adding account %p' % {server_url: server_url, hbci_version: hbci_version, bank_code: bank_code, user_id: user_id, user_name: user_name}
 
       cmd = ""

data/lib/aq_banking/version.rb

@@ -1,3 +1,3 @@
 module AqBanking
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: aq_banking
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Robin Wenglewski