aq_banking 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7fdafa67936f926c7f71dd8c7ef8f301d4743024
-  data.tar.gz: c045f57adc27935b6a12d0ce21d5c9a16daa7fab
+  metadata.gz: 14c18dc02ea5892da664c7359a56b972906d8d36
+  data.tar.gz: 7b797ae4ff23ace3ea98bf9fa0a1be6efba507a2
 SHA512:
-  metadata.gz: ea6ec63c81dafc9c37d9da372c63d956abbf73504b611adc264f00ab31152d995f65c64e31c411cc1721bee65d7f03790e55a4cf441e50d4095912110800d74c
-  data.tar.gz: 3630b9bcddf7ddfce9fc05e597fcfaf335355afd60745dce0495e826dfbd9fc6a7c7e79a3156f45c8457b78d0f03d7f1087ef6098be4f6fd66246e80f7e70238
+  metadata.gz: a8b0fddd90846924229c2c05208f81ff8e44cd416ed0e3d4e4a9ce6a97fc8a666dbb1e8744ee8607ec02323715ddb2ac72f47f4d65b27bce0d2a2dc86fef6d6d
+  data.tar.gz: 1e6a5b8786683f29c035c079de0bb56deb0fc0b1c0311e997c81b5dc9938fac891d6e74caf58c95044c121086b99f178c233305a80688cc94e39840bfff10515

data/README.md

@@ -1,5 +1,3 @@
-# AqBanking
-
 [![Travis Status](https://travis-ci.org/rweng/aq_banking.svg)](https://travis-ci.org/rweng/aq_banking)
 [![codecov.io](http://codecov.io/github/rweng/aq_banking/coverage.svg?branch=master)](http://codecov.io/github/rweng/aq_banking?branch=master)
 
@@ -41,13 +39,13 @@ To avoid errors with versions etc, I recommend using the docker image:
     docker run -it --rm rweng/aq_banking --help    
     docker run -it --rm rweng/aq_banking request --bank=diba BLZ ACCCOUNT_NUMBER LOGIN_ID PASSWORD --from=2016-04-18
 
-## Installation
+# Installation
 
-### CLI
+## CLI
 
     gem install aq_banking
 
-### Ruby
+## Ruby
 
 Add this line to your application's Gemfile:
 
@@ -59,30 +57,26 @@ And then execute:
 
     $ bundle
 
-## Usage
+# Usage
 
     aq_banking --help
     aq_banking request BLZ ACCCOUNT USER_ID PASSWORD --bank=diba
 
-## Development
-
-    # log into container
-    docker-compose run dev
-    
+# Development
     # run tests
     rspec
-    
-### Release
-
-    # publish gem
-    rake release
-    
-    # publish docker container
-    docker-compose build --no-cache release
-    docker push rweng/aq_banking
-    
-
-## Contributing
+
+    # log into container for integration testing
+    docker-compose run gem
+    aq_banking help
+
+## Release
+
+    # publish gem, build and push docker container
+    rake release && docker-compose build --no-cache gem && docker push rweng/aq_banking
+
+
+# Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/rweng/aq_banking.
 

data/docker-compose.yml

@@ -1,26 +1,18 @@
 version: '2'
 
 services:
-  release:
+  gem:
     build: .
     image: rweng/aq_banking
-
-  dev:
-    image: rweng/aq_banking
-    depends_on:
-      - release
     volumes:
       - .:/gem
-    volumes_from:
-      - cache
+      - cache:/usr/local/bundle/cache
     working_dir: /gem
     entrypoint: []
     command: "/bin/bash -c 'bundle install --binstubs bin; /bin/bash'"
     environment:
       PATH: "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:./bin"
 
+volumes:
   cache:
-    image: busybox
-    volumes:
-      - /usr/local/bundle/cache
 

data/lib/aq_banking/cli.rb

@@ -2,6 +2,11 @@ require 'thor'
 
 module AqBanking
   class Cli < Thor
+    def initialize *args
+      super
+      AqBanking.logger.level = Logger::DEBUG if options[:verbose]
+    end
+
     class_option :dry, :type => :boolean, default: false, aliases: '-d'
     class_option :verbose, :type => :boolean, default: false, aliases: '-v'
 
@@ -24,6 +29,7 @@ module AqBanking
       request_options[:from] = options[:from] if options[:from]
       request_options[:to] = options[:to] if options[:to]
 
+
       response = commander.send_request!(request_options)
       account = parser.parse_account_list(response).first
 
@@ -63,4 +69,4 @@ module AqBanking
       BANKS[options[:bank].to_sym] || raise(ArgumentError.new("bank \"#{options[:bank]}\" not found"))
     end
   end
-end
+end

data/lib/aq_banking/commander.rb

@@ -48,14 +48,19 @@ module AqBanking
       raise ArgumentError.new("unknown hbci_version: \"#{hbci_version}\"") unless HBCI_VERSIONS.include? hbci_version
       raise ArgumentError.new("server url must be present") unless server_url.present?
 
+      logger.debug 'calling Commander#with_pin with args %p %p %p' % [bank_code, user_id, password]
       with_pin bank_code, user_id, password do |pin_file_path|
+        logger.debug 'pinfile: %p' % [pin_file_path]
         unless account_exists? bank_code: bank_code, user_id: user_id
+          logger.debug 'account (%p) does not exist, adding it' % {bank_code: bank_code, user_id: user_id}
           add_account(server_url: server_url, hbci_version: hbci_version,
                       bank_code: bank_code, user_id: user_id, user_name: user_name)
 
+          logger.debug 'calling getsysid with %p' % {pin_file: pin_file_path, user_id: user_id, bank_code: bank_code}
           call_getsysid pin_file: pin_file_path, user_id: user_id, bank_code: bank_code
         end
 
+        logger.debug 'sending request %p' % [bank_code, account_number, pin_file_path, from: from, to: to]
         send_request(bank_code, account_number, pin_file_path, from: from, to: to)
       end
     end
@@ -97,15 +102,15 @@ module AqBanking
     # @return [AqBanking::Commander::Result]
     # @raise [Timeout::Error]
     def run(cmd, timeout: DEFAULT_TIMEOUT)
-      logger.info "run: #{cmd}"
+      logger.debug 'running cmd: %p' % cmd
+
       result = nil
 
       Timeout::timeout(timeout) do
         result = Result.new( *Open3.capture3(cmd) )
       end
 
-      logger.debug result.to_s
-
+      logger.debug "result: #{result.to_s}"
       result
     end
 

data/lib/aq_banking/version.rb

@@ -1,3 +1,3 @@
 module AqBanking
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aq_banking
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Robin Wenglewski
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-04-23 00:00:00.000000000 Z
+date: 2016-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor