aq1018-sqlserver-2000-2008-adpater 0.0.2

data/test/cases/migration_test_sqlserver.rb

@@ -0,0 +1,57 @@
+require 'cases/sqlserver_helper'
+require 'models/person'
+
+class MigrationTestSqlserver < ActiveRecord::TestCase
+  
+  context 'For transactions' do
+    
+    setup do
+      @connection = ActiveRecord::Base.connection
+      @trans_test_table1 = 'sqlserver_trans_table1'
+      @trans_test_table2 = 'sqlserver_trans_table2'
+      @trans_tables = [@trans_test_table1,@trans_test_table2]
+    end
+    
+    teardown do
+      @trans_tables.each do |table_name|
+        ActiveRecord::Migration.drop_table(table_name) if @connection.tables.include?(table_name)
+      end
+    end
+    
+    should 'not create a tables if error in migrations' do
+      begin
+        ActiveRecord::Migrator.up(SQLSERVER_MIGRATIONS_ROOT+'/transaction_table')
+      rescue Exception => e
+        assert_match %r|this and all later migrations canceled|, e.message
+      end
+      assert_does_not_contain @trans_test_table1, @connection.tables
+      assert_does_not_contain @trans_test_table2, @connection.tables
+    end
+    
+  end
+  
+  
+end
+
+
+class MigrationTest < ActiveRecord::TestCase
+  
+  COERCED_TESTS = [:test_add_column_not_null_without_default]
+  
+  include SqlserverCoercedTest
+  
+  
+  def test_coerced_test_add_column_not_null_without_default
+    Person.connection.create_table :testings do |t| 
+      t.column :foo, :string
+      t.column :bar, :string, :null => false
+    end
+    assert_raises(ActiveRecord::StatementInvalid) do
+      Person.connection.execute "INSERT INTO [testings] ([foo], [bar]) VALUES ('hello', NULL)"
+    end
+  ensure
+    Person.connection.drop_table :testings rescue nil
+  end
+  
+  
+end

data/test/cases/offset_and_limit_test_sqlserver.rb

@@ -0,0 +1,89 @@
+require 'cases/sqlserver_helper'
+require 'models/book'
+
+class OffsetAndLimitTestSqlserver < ActiveRecord::TestCase
+  
+  class Account < ActiveRecord::Base; end
+  
+  def setup
+    @connection = ActiveRecord::Base.connection
+  end
+  
+  context 'When selecting with limit' do
+
+    setup do
+      @select_sql = 'SELECT * FROM schema'
+    end
+
+    should 'alter SQL to limit number of records returned' do
+      options = { :limit => 10 }
+      assert_equal('SELECT TOP 10 * FROM schema', @connection.add_limit_offset!(@select_sql, options))
+    end
+
+    should 'only allow integers for limit' do
+      options = { :limit => 'ten' }
+      assert_raise(ArgumentError) {@connection.add_limit_offset!(@select_sql, options) }
+    end
+
+    should 'convert strings which look like integers to integers' do
+      options = { :limit => '42' }
+      assert_nothing_raised(ArgumentError) {@connection.add_limit_offset!(@select_sql, options)}
+    end
+
+    should 'not allow sql injection via limit' do
+      options = { :limit => '1 * FROM schema; DELETE * FROM table; SELECT TOP 10 *'}
+      assert_raise(ArgumentError) { @connection.add_limit_offset!(@select_sql, options) }
+    end
+
+  end
+  
+  context 'When selecting with limit and offset' do
+
+    setup do
+      @select_sql = 'SELECT * FROM books'
+      @subquery_select_sql = 'SELECT *, (SELECT TOP 1 id FROM books) AS book_id FROM books'
+      @books = (1..10).map {|i| Book.create!}
+    end
+    
+    teardown do
+      @books.each {|b| b.destroy}
+    end
+
+    should 'have limit if offset is passed' do
+      options = { :offset => 1 }
+      assert_raise(ArgumentError) { @connection.add_limit_offset!(@select_sql, options) }
+    end
+
+    should 'only allow integers for offset' do
+      options = { :limit => 10, :offset => 'five' }
+      assert_raise(ArgumentError) { @connection.add_limit_offset!(@select_sql, options)}
+    end
+
+    should 'convert strings which look like integers to integers' do
+      options = { :limit => 10, :offset => '5' }
+      assert_nothing_raised(ArgumentError) {@connection.add_limit_offset!(@select_sql, options)}
+    end
+
+    should 'alter SQL to limit number of records returned offset by specified amount' do
+      options = { :limit => 3, :offset => 5 }
+      expected_sql = %&SELECT * FROM (SELECT TOP 3 * FROM (SELECT TOP 8 * FROM books) AS tmp1) AS tmp2&
+      assert_equal(expected_sql, @connection.add_limit_offset!(@select_sql, options))
+    end
+
+    # Not really sure what an offset sql injection might look like
+    should 'not allow sql injection via offset' do
+      options = { :limit => 10, :offset => '1 * FROM schema; DELETE * FROM table; SELECT TOP 10 *'}
+      assert_raise(ArgumentError) { @connection.add_limit_offset!(@select_sql, options) }
+    end
+
+    should 'not create invalid SQL with subquery SELECTs with TOP' do
+      options = { :limit => 5, :offset => 1 }
+      expected_sql = "SELECT * FROM (SELECT TOP 5 * FROM (SELECT TOP 6 *, (SELECT TOP 1 id FROM books) AS book_id FROM books) AS tmp1) AS tmp2"
+      assert_equal expected_sql, @connection.add_limit_offset!(@subquery_select_sql,options)
+    end
+    
+  end
+  
+  
+end
+

data/test/cases/pessimistic_locking_test_sqlserver.rb

@@ -0,0 +1,100 @@
+require 'cases/sqlserver_helper'
+require 'models/person'
+require 'models/reader'
+
+class PessimisticLockingTestSqlserver < ActiveRecord::TestCase
+  
+  self.use_transactional_fixtures = false
+  fixtures :people, :readers
+  
+  def setup
+    Person.columns; Reader.columns # Avoid introspection queries during tests.
+  end
+  
+  context 'For simple finds with default lock option' do
+
+    should 'lock with simple find' do
+      assert_nothing_raised do
+        Person.transaction do
+          Person.find 1, :lock => true
+        end
+      end
+    end
+
+    should 'lock with scoped find' do
+      assert_nothing_raised do
+        Person.transaction do
+          Person.with_scope(:find => { :lock => true }) do
+            Person.find 1
+          end
+        end
+      end
+    end
+
+    should 'lock with eager find' do
+      assert_nothing_raised do
+        Person.transaction do
+          Person.find 1, :include => :readers, :lock => true
+        end
+      end
+    end
+
+    should 'reload with lock when #lock! called' do
+      assert_nothing_raised do
+        Person.transaction do
+          person = Person.find 1
+          old, person.first_name = person.first_name, 'fooman'
+          person.lock!
+          assert_equal old, person.first_name
+        end
+      end
+    end
+
+  end
+  
+  context 'For dueling concurrent connections' do
+    
+    use_concurrent_connections
+
+    should 'no locks does not wait' do
+      first, second = duel { Person.find 1 }
+      assert first.end > second.end
+    end
+    
+    should 'that second lock waits' do
+      assert [0.2, 1, 5].any? { |zzz|
+        first, second = duel(zzz) { Person.find 1, :lock => true }
+        second.end > first.end
+      }
+    end
+    
+  end
+  
+    
+  protected
+  
+  def duel(zzz = 5)
+    t0, t1, t2, t3 = nil, nil, nil, nil
+    a = Thread.new do
+      t0 = Time.now
+      Person.transaction do
+        yield
+        sleep zzz       # block thread 2 for zzz seconds
+      end
+      t1 = Time.now
+    end
+    b = Thread.new do
+      sleep zzz / 2.0   # ensure thread 1 tx starts first
+      t2 = Time.now
+      Person.transaction { yield }
+      t3 = Time.now
+    end
+    a.join
+    b.join
+    assert t1 > t0 + zzz
+    assert t2 > t0
+    assert t3 > t2
+    [t0.to_f..t1.to_f, t2.to_f..t3.to_f]
+  end
+  
+end

data/test/cases/query_cache_test_sqlserver.rb

@@ -0,0 +1,24 @@
+require 'cases/sqlserver_helper'
+require 'models/task'
+
+class QueryCacheTestSqlserver < ActiveRecord::TestCase
+end
+
+class QueryCacheTest < ActiveRecord::TestCase
+  
+  COERCED_TESTS = [:test_cache_does_not_wrap_string_results_in_arrays]
+  
+  include SqlserverCoercedTest
+  
+  fixtures :tasks
+  
+
+  def test_coerced_test_cache_does_not_wrap_string_results_in_arrays
+    Task.cache do
+      assert_instance_of Fixnum, Task.connection.select_value("SELECT count(*) AS count_all FROM tasks")
+    end
+  end
+  
+end
+
+

data/test/cases/schema_dumper_test_sqlserver.rb

@@ -0,0 +1,61 @@
+require 'cases/sqlserver_helper'
+
+class SchemaDumperTestSqlserver < ActiveRecord::TestCase
+  
+  setup :find_all_tables
+  
+  context 'For primary keys' do
+
+    should 'honor nonstandards' do
+      table_dump('movies') do |output|
+        match = output.match(%r{create_table "movies"(.*)do})
+        assert_not_nil(match, "nonstandardpk table not found")
+        assert_match %r(:primary_key => "movieid"), match[1], "non-standard primary key not preserved"
+      end
+    end
+    
+  end
+  
+  context 'For integers' do
+    
+    should 'include limit constraint that match logic for smallint and bigint in #extract_limit' do
+      table_dump('integer_limits') do |output|
+        assert_match %r{c_int_1.*:limit => 2}, output
+        assert_match %r{c_int_2.*:limit => 2}, output
+        assert_match %r{c_int_3.*}, output
+        assert_match %r{c_int_4.*}, output
+        assert_no_match %r{c_int_3.*:limit}, output
+        assert_no_match %r{c_int_4.*:limit}, output
+        assert_match %r{c_int_5.*:limit => 8}, output
+        assert_match %r{c_int_6.*:limit => 8}, output
+        assert_match %r{c_int_7.*:limit => 8}, output
+        assert_match %r{c_int_8.*:limit => 8}, output
+      end
+    end
+    
+  end
+  
+  
+  
+  private
+  
+  def find_all_tables
+    @all_tables ||= ActiveRecord::Base.connection.tables
+  end
+  
+  def standard_dump(ignore_tables = [])
+    stream = StringIO.new
+    ActiveRecord::SchemaDumper.ignore_tables = [*ignore_tables]
+    ActiveRecord::SchemaDumper.dump(ActiveRecord::Base.connection, stream)
+    stream.string
+  end
+  
+  def table_dump(*table_names)
+    stream = StringIO.new
+    ActiveRecord::SchemaDumper.ignore_tables = @all_tables-table_names
+    ActiveRecord::SchemaDumper.dump(ActiveRecord::Base.connection, stream)
+    yield stream.string
+    stream.string
+  end
+  
+end

data/test/cases/specific_schema_test_sqlserver.rb

@@ -0,0 +1,25 @@
+require 'cases/sqlserver_helper'
+
+class StringDefault < ActiveRecord::Base; end;
+
+class SpecificSchemaTestSqlserver < ActiveRecord::TestCase
+  
+  should 'default strings before save' do
+    default = StringDefault.new
+    assert_equal nil, default.string_with_null_default
+    assert_equal 'null', default.string_with_pretend_null_one
+    assert_equal '(null)', default.string_with_pretend_null_two
+    assert_equal 'NULL', default.string_with_pretend_null_three
+    assert_equal '(NULL)', default.string_with_pretend_null_four
+  end
+
+  should 'default strings after save' do
+    default = StringDefault.create
+    assert_equal nil, default.string_with_null_default
+    assert_equal 'null', default.string_with_pretend_null_one
+    assert_equal '(null)', default.string_with_pretend_null_two
+    assert_equal 'NULL', default.string_with_pretend_null_three
+    assert_equal '(NULL)', default.string_with_pretend_null_four
+  end
+  
+end

data/test/cases/sqlserver_helper.rb

@@ -0,0 +1,100 @@
+require 'rubygems'
+require 'shoulda'
+require 'mocha'
+require 'cases/helper'
+require 'models/topic'
+
+SQLSERVER_TEST_ROOT       = File.expand_path(File.join(File.dirname(__FILE__),'..'))
+SQLSERVER_ASSETS_ROOT     = SQLSERVER_TEST_ROOT + "/assets"
+SQLSERVER_FIXTURES_ROOT   = SQLSERVER_TEST_ROOT + "/fixtures"
+SQLSERVER_MIGRATIONS_ROOT = SQLSERVER_TEST_ROOT + "/migrations"
+SQLSERVER_SCHEMA_ROOT     = SQLSERVER_TEST_ROOT + "/schema"
+ACTIVERECORD_TEST_ROOT    = File.expand_path(SQLSERVER_TEST_ROOT + "/../../../../vendor/rails/activerecord/test/")
+
+ActiveRecord::Migration.verbose = false
+
+# Defining our classes in one place as well as soem core tests that need coercing date/time types.
+
+class TableWithRealColumn < ActiveRecord::Base; end
+class FkTestHasFk < ActiveRecord::Base ; end
+class FkTestHasPk < ActiveRecord::Base ; end
+class NumericData < ActiveRecord::Base ; self.table_name = 'numeric_data' ; end
+class CustomersView < ActiveRecord::Base ; self.table_name = 'customers_view' ; end
+class StringDefaultsView < ActiveRecord::Base ; self.table_name = 'string_defaults_view' ; end
+class SqlServerUnicode < ActiveRecord::Base ; end
+class SqlServerString < ActiveRecord::Base ; end
+
+class SqlServerChronic < ActiveRecord::Base
+  coerce_sqlserver_date :date
+  coerce_sqlserver_time :time
+  default_timezone = :utc
+end
+
+class Topic < ActiveRecord::Base
+  coerce_sqlserver_date :last_read
+  coerce_sqlserver_time :bonus_time
+end
+class Person < ActiveRecord::Base
+  coerce_sqlserver_date :favorite_day
+end
+
+# A module that we can include in classes where we want to override an active record test.
+
+module SqlserverCoercedTest
+  def self.included(base)
+    base.extend ClassMethods
+  end
+  module ClassMethods
+    def coerced_tests
+      self.const_get(:COERCED_TESTS) rescue nil
+    end
+    def method_added(method)
+      undef_method(method) if coerced_tests && coerced_tests.include?(method)
+    end
+  end
+end
+
+# Change the text database type to support ActiveRecord's tests for = on text columns which 
+# is not supported in SQL Server text columns, so use varchar(8000) instead.
+
+if ActiveRecord::Base.connection.sqlserver_2000?
+  ActiveRecord::ConnectionAdapters::SQLServerAdapter.native_text_database_type = 'varchar(8000)'
+end
+
+# Our changes/additions to ActiveRecord test helpers specific for SQL Server.
+
+ActiveRecord::Base.connection.class.class_eval do
+  IGNORED_SQL << /SELECT SCOPE_IDENTITY/ << /INFORMATION_SCHEMA.TABLES/ << /INFORMATION_SCHEMA.COLUMNS/
+end
+
+ActiveRecord::ConnectionAdapters::SQLServerAdapter.class_eval do
+  def raw_select_with_query_record(sql, name = nil)
+    $queries_executed ||= []
+    $queries_executed << sql unless IGNORED_SQL.any? { |r| sql =~ r }
+    raw_select_without_query_record(sql,name)
+  end
+  alias_method_chain :raw_select, :query_record
+end
+
+module ActiveRecord 
+  class TestCase < ActiveSupport::TestCase
+    class << self
+      def sqlserver_2000? ; ActiveRecord::Base.connection.sqlserver_2000? ; end
+      def sqlserver_2005? ; ActiveRecord::Base.connection.sqlserver_2005? ; end
+    end
+    def assert_sql(*patterns_to_match)
+      $queries_executed = []
+      yield
+    ensure
+      failed_patterns = []
+      patterns_to_match.each do |pattern|
+        failed_patterns << pattern unless $queries_executed.any?{ |sql| pattern === sql }
+      end
+      assert failed_patterns.empty?, "Query pattern(s) #{failed_patterns.map(&:inspect).join(', ')} not found in:\n#{$queries_executed.inspect}"
+    end
+    def sqlserver_2000? ; self.class.sqlserver_2000? ; end
+    def sqlserver_2005? ; self.class.sqlserver_2005? ; end
+  end
+end
+
+