aptible-cli 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4caf3814e0cffe6799a62625c5d9fb9f79dbd016
-  data.tar.gz: dbe1d0e306d35ce276c4ac0d323d0e1ea706aba4
+  metadata.gz: c42a7a8ab65f7e7818b73f0e84c2b6bca1346eab
+  data.tar.gz: bc17a8345a7e44528ee857e6ec15b79d42226066
 SHA512:
-  metadata.gz: 1149e64d3194970dd488a36519eb07d1783d9ef860b587bd04f844de452afb848980ee4340e2e6a2cef0a10afa148812e48fdce7d9f18c296d072e52da5d45f0
-  data.tar.gz: 7aed71d453418b1d887d214974a6e60903338154c866d1a5ec90e59ab185f0ad02d0e06bc929046bc1290234572c3785c60fa5ac50c91498f9c6513f628a0127
+  metadata.gz: 4490c9a5f1d3fcd9eac19f718e5e1e5b51972952df98287597418f4f1c78d22487cffe06d801a34677e893c55c7c2a4ce626b0309add81475abb740e804024e7
+  data.tar.gz: 50e312a8537bd4ad49c16bca5ae40c4f4c703138877593f38923a8b8901d959e937c26080bce1cb1d6efd6b9f72afacfae2ca3e2b9372ba29e4266434ff57873

data/lib/aptible/cli/helpers/token.rb

@@ -20,17 +20,20 @@ module Aptible
           )
 
           FileUtils.mkdir_p(File.dirname(token_file))
-          File.open(token_file, 'w') do |file|
+
+          File.open(token_file, 'w', 0o600) do |file|
             file.puts hash.to_json
           end
-        rescue
-          raise Thor::Error, <<-ERR.gsub(/\s+/, ' ').strip
-            Could not write token to #{token_file}, please check filesystem
-            permissions
-          ERR
+        rescue StandardError => e
+          m = "Could not write token to #{token_file}: #{e}. " \
+              'Check filesystem permissions.'
+          raise Thor::Error, m
         end
 
         def current_token_hash
+          # NOTE: older versions of the CLI did not properly create the
+          # token_file with mode 600, which is why we update it when reading.
+          File.chmod(0o600, token_file)
           JSON.parse(File.read(token_file))
         rescue
           {}

data/lib/aptible/cli/version.rb

@@ -1,5 +1,5 @@
 module Aptible
   module CLI
-    VERSION = '0.11.0'.freeze
+    VERSION = '0.11.1'.freeze
   end
 end

data/spec/aptible/cli/helpers/token_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe Aptible::CLI::Helpers::Token do
+  around do |example|
+    Dir.mktmpdir { |home| ClimateControl.modify(HOME: home) { example.run } }
+  end
+
+  subject { Class.new.send(:include, described_class).new }
+
+  describe '#save_token / #fetch_token' do
+    it 'reads back a token it saved' do
+      subject.save_token('foo')
+      expect(subject.fetch_token).to eq('foo')
+    end
+  end
+
+  context 'permissions' do
+    before { skip 'Windows' if Gem.win_platform? }
+
+    describe '#save_token' do
+      it 'creates the token_file with mode 600' do
+        subject.save_token('foo')
+        expect(format('%o', File.stat(subject.token_file).mode))
+          .to eq('100600')
+      end
+    end
+
+    describe '#current_token_hash' do
+      it 'updates the token_file to mode 600' do
+        subject.save_token('foo')
+        File.chmod(0o644, subject.token_file)
+        expect(format('%o', File.stat(subject.token_file).mode))
+          .to eq('100644')
+
+        subject.current_token_hash
+        expect(format('%o', File.stat(subject.token_file).mode))
+          .to eq('100600')
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aptible-cli
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Frank Macreery
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-28 00:00:00.000000000 Z
+date: 2017-07-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aptible-resource
@@ -255,6 +255,7 @@ files:
 - spec/aptible/cli/helpers/operation_spec.rb
 - spec/aptible/cli/helpers/options_handle_strategy_spec.rb
 - spec/aptible/cli/helpers/ssh_spec.rb
+- spec/aptible/cli/helpers/token_spec.rb
 - spec/aptible/cli/helpers/tunnel_spec.rb
 - spec/aptible/cli/subcommands/apps_spec.rb
 - spec/aptible/cli/subcommands/backup_spec.rb
@@ -316,6 +317,7 @@ test_files:
 - spec/aptible/cli/helpers/operation_spec.rb
 - spec/aptible/cli/helpers/options_handle_strategy_spec.rb
 - spec/aptible/cli/helpers/ssh_spec.rb
+- spec/aptible/cli/helpers/token_spec.rb
 - spec/aptible/cli/helpers/tunnel_spec.rb
 - spec/aptible/cli/subcommands/apps_spec.rb
 - spec/aptible/cli/subcommands/backup_spec.rb