apralib 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 59af58d7a0d079dec4dca4c1532b86e2663ac9e1
-  data.tar.gz: d6d076636dbf8ecff1f567fdb7a9415e5ae4fb80
+SHA256:
+  metadata.gz: 3b3256db49c369085a45a47586f7d225d6914a951f55baddb18b19d5385bf928
+  data.tar.gz: 9270c0ba4a7d6a228397f1d5439704808042e26f9dca5ce55c37686ce03f16b2
 SHA512:
-  metadata.gz: ddac87c831ebb1de2e417075b17c3d43f253af1bbbce7a609418a192311ed3cd562fec65b4319920ff88131d51c01cfaab656f74546fc063529b34d3e017bad2
-  data.tar.gz: f01b555e830993def27fcf61ea97e3add099707b84517777bb17d2047e8d0ed5aa1bed9bb38d5a72a74193bd42b7e0fe9a93c7fc6f6d4cd098800091bd7c3f98
+  metadata.gz: b05c78f9fed17951c19d6bffa5ad660a8f6f9ef693c87888e5c6767a1a47779b0a9ec87fd0ee2acb032441149ca553075e0356993ed8dd9ed418a864f718f084
+  data.tar.gz: b0c1081c67f7d9446b04f209fb5b0914470e7a36f7688f6e9d1d0e98e7f01bef640cd2c4299864d18599b8b49b716b9bca52ea389a4566c15f93f68d4d2e97b2

data/.rubocop.yml

@@ -0,0 +1,3 @@
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*.rb

data/.travis.yml

@@ -1,8 +1,8 @@
 language: ruby
 rvm:
-- 2.1.3
-- 1.9.3
-env:
-  global:
-  - secure: XQ58eL4HELhYo0x1RgzyLkAF+XCBzTZLe3NIs4qsc4wIbeIUWVxb6chm/8ikbQn8ndk06EsJrZV/HC08EebUtgb1WTGeaEhyJGdyTVThO2dbLc+wKdrrGcmxiZEd1N6pg0G+4l8QsvMCTWJts6ZhrvVtmle6izGPfF467hLWIjM=
-  - secure: FY5lZvsTluLglsk0j4c4rPXj0BqN80PVUzCLwFtBzhZJ/Dic8c6IGGDy91RQPoR11bcsqQgUhEOeTh0LEjmuGijZ1WIm0/0PynLZe2rxM76OA/ph5KKmYIgi5OLEkWJ8mQRLSeOqpw2BeaqW35MfhX6uItcJbEztiSgVkx01Y4g=
+- 2.7.2
+- 2.4.0
+deploy:
+  provider: rubygems
+  edge: true
+

data/README.md

@@ -1,5 +1,10 @@
 # Apralib
 
+
+[![Build Status](https://travis-ci.org/nessche/apralib.svg?branch=master)](https://travis-ci.org/nessche/apralib)
+[![Gem Version](https://badge.fury.io/rb/apralib.svg)](http://badge.fury.io/rb/apralib)
+
+
 A Ruby library to submit documents to the Apra Service run by [Maatalousyrittäjien eläkelaitos](http://www.mela.fi)
 
 ## Installation

data/apralib.gemspec

@@ -17,10 +17,12 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
+  spec.required_ruby_version = '>= 2.4.0'
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', '~> 3.1.0'
+  spec.add_development_dependency 'bundler', '~> 2.1'
+  spec.add_development_dependency 'rake', '< 11.0'
+  spec.add_development_dependency 'rspec', '~> 3.10.0'
   spec.add_development_dependency 'yard'
-  spec.add_dependency 'savon', '~> 2.3.0'
+  spec.add_dependency 'savon', '~> 2.12.0'
+
 end

data/lib/apralib/apra_service.rb

@@ -6,10 +6,12 @@ module ApraService
 
   class Client
 
-    def initialize(username, password)
+    def initialize(username, password, proxy = nil)
+
       @client = Savon.client(wsdl: 'https://palvelu.mela.fi/Apurahailmoitukset/ws/apurahanSyottoWS?wsdl',
                              wsse_auth: [username, password],
-                             endpoint: 'https://palvelu.mela.fi/Apurahailmoitukset/ws/apurahanSyottoWS')
+                             endpoint: 'https://palvelu.mela.fi/Apurahailmoitukset/ws/apurahanSyottoWS',
+                             proxy: proxy)
     end
 
     def send_notifications(notifications)
@@ -17,11 +19,15 @@ module ApraService
       raise ArgumentError, 'notifications object must be either a Notification object or an array of Notification objects' unless
           (notifications.is_a? Notification or (notifications.is_a? Array and notifications.detect {|n| !n.is_a? Notification}.nil?))
       notifications = [notifications] unless notifications.is_a? Array
-      message = {}
-      message[:arg0] = notifications.map {|notification| notification.to_hash}
-      response = @client.call(:lisaa_apurahat, :message => message)
-      raise RuntimeError, 'An error occurred while submitting the notification' unless response.success?
-      Response.from_hash(response.body)
+      if notifications.count > 0
+        message = {}
+        message[:arg0] = notifications.map {|notification| notification.to_hash}
+        response = @client.call(:lisaa_apurahat, :message => message)
+        raise RuntimeError, 'An error occurred while submitting the notification' unless response.success?
+        Response.from_hash(response.body)
+      else
+        Response.new
+      end
     end
 
 

data/lib/apralib/grantee.rb

@@ -2,8 +2,8 @@ module ApraService
 
   class Grantee
 
-    SSN_REGEX = /(\d{6})([-+A])(\d{3})([0-9ABCDEFHJKLMNPRSTUVWXY])/
-    CHECK_DIGITS = %w(0 1 2 3 4 5 6 7 8 9 A B C D E F H J K L M N P R S T U V X Y)
+    SSN_REGEX = /(\d{6})([-+A])(\d{3})([0-9ABCDEFHJKLMNPRSTUVWXY])/.freeze
+    CHECK_DIGITS = %w[0 1 2 3 4 5 6 7 8 9 A B C D E F H J K L M N P R S T U V W X Y].freeze
 
     attr_accessor :first_names, :last_name, :ssn, :address, :zip
 
@@ -26,16 +26,20 @@ module ApraService
       grantee.address = hash[:apurahansaajanosoite]
       grantee.zip = hash[:apurahansaajanpostinumero]
       grantee.first_names = [hash[:etunimi1]]
-      grantee.first_name << hash[:etunimi2] if hash[:etunimi2]
-      grantee.first_name << hash[:etunimi3] if hash[:etunimi3]
+      grantee.first_names << hash[:etunimi2] if hash[:etunimi2]
+      grantee.first_names << hash[:etunimi3] if hash[:etunimi3]
       grantee.ssn = hash[:henkilotunnus]
       grantee.last_name = hash[:sukunimi]
       grantee
     end
 
     def ssn=(ssn)
-      Grantee.verify_ssn!(ssn)
-      self.instance_variable_set('@ssn', ssn)
+      if ssn
+        Grantee.verify_ssn!(ssn.upcase)
+        self.instance_variable_set('@ssn', ssn.upcase)
+      else
+        self.instance_variable_set('@ssn', nil)
+      end
     end
 
     def self.verify_ssn!(ssn)

data/lib/apralib/response.rb

@@ -4,6 +4,10 @@ module ApraService
 
     attr_accessor :failed_notifications
 
+    def initialize
+      @failed_notifications = []
+    end
+
 
     def self.from_hash(hash)
       puts hash.inspect
@@ -13,8 +17,6 @@ module ApraService
       if failures
         failures = [failures] unless failures.is_a? Array
         response.failed_notifications = failures.map {|notification| NotificationResponse.from_hash(notification) }
-      else
-        response.failed_notifications = []
       end
       response
     end

data/lib/apralib/version.rb

@@ -1,3 +1,3 @@
 module Apralib
-  VERSION = "0.0.1"
+  VERSION = '0.1.0'.freeze
 end

data/spec/lib/apra_service_spec.rb

@@ -1,5 +1,6 @@
 # encoding: utf-8
 require 'apralib'
+require 'securerandom'
 
 module ApraService
 
@@ -9,10 +10,11 @@ module ApraService
     def get_client
       credentials = {}
       credentials_file = File.join(File.dirname(__FILE__), 'apra_credentials.yml')
-      credentials = YAML.load(File.read(credentials_file)) if File.exists?(credentials_file)
+      credentials = YAML.load(File.read(credentials_file)) if File.exist?(credentials_file)
       user = credentials['user'] || ENV['APRA_USER']
       password = credentials['password'] || ENV['APRA_PASSWORD']
-      Client.new(user, password)
+      proxy = credentials['proxy'] || ENV['PROXY_URL']
+      Client.new(user, password, proxy)
     end
 
 
@@ -20,11 +22,15 @@ module ApraService
 
       it 'should create a valid object' do
 
-        service = Client.new('user','password')
+        service = Client.new('user', 'password')
         expect(service).not_to be_nil
 
       end
 
+    end
+
+    describe 'send_notifications' do
+
       it 'should send the notification to the server' do
 
         service = get_client
@@ -71,7 +77,12 @@ module ApraService
         expect(notification_response.notification.reference).to eq(notification.reference)
       end
 
-
+      it 'should return an empty response when an empty array is passed' do
+        service = get_client
+        response = service.send_notifications([])
+        expect(response).not_to be_nil
+        expect(response.failed_notifications.count).to eq(0)
+      end
 
 
     end

data/spec/lib/grantee_spec.rb

@@ -22,6 +22,28 @@ module ApraService
 
     end
 
+    describe 'ssn=' do
+
+      it 'should convert the code to uppercase' do
+
+        grantee = Grantee.new
+        grantee.ssn = '111111-111c'
+        expect(grantee.ssn).to eq('111111-111C')
+
+      end
+
+      it 'should set the value to nil when passed a nil value' do
+
+        grantee = Grantee.new
+        grantee.ssn = '111111-111C'
+        grantee.ssn = nil
+        expect(grantee.ssn).to be_nil
+
+      end
+
+
+    end
+
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: apralib
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Marco Sandrini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-02 00:00:00.000000000 Z
+date: 2020-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '11.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '11.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.10.0
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 2.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 2.12.0
 description: A Ruby client for the Apra Service
 email:
 - nessche@gmail.com
@@ -88,6 +88,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -116,15 +117,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: A Ruby library to submit documents to the Apra Service run by Maatalousyrittäjien
@@ -133,4 +133,3 @@ test_files:
 - spec/lib/apra_service_spec.rb
 - spec/lib/grantee_spec.rb
 - spec/spec_helper.rb
-has_rdoc: