apralib 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59af58d7a0d079dec4dca4c1532b86e2663ac9e1
-  data.tar.gz: d6d076636dbf8ecff1f567fdb7a9415e5ae4fb80
+  metadata.gz: 224a37c92a5d6d226dc47de0b91306afea784f2b
+  data.tar.gz: d51148502133e9c5dd52597c85ef56482076f85f
 SHA512:
-  metadata.gz: ddac87c831ebb1de2e417075b17c3d43f253af1bbbce7a609418a192311ed3cd562fec65b4319920ff88131d51c01cfaab656f74546fc063529b34d3e017bad2
-  data.tar.gz: f01b555e830993def27fcf61ea97e3add099707b84517777bb17d2047e8d0ed5aa1bed9bb38d5a72a74193bd42b7e0fe9a93c7fc6f6d4cd098800091bd7c3f98
+  metadata.gz: 9fbad13674a88ea3fe41e72b247a2d92cf5647b3714220fdffa81d36d9977865f3dabbf7cfcc78d8fc55932e690812d360fb226ec6535b7a56240758cc1639d0
+  data.tar.gz: 873b94bd5cc2a74753a97f84ae5f8d51dbc48f1bca7aed0ce83e5c806e4efe71d182ceaf223e392574e697e92f5ccc54e6f9b6ffb1710547c2e5287069743202

data/README.md

@@ -1,5 +1,10 @@
 # Apralib
 
+
+[![Build Status](https://travis-ci.org/nessche/apralib.svg?branch=master)](https://travis-ci.org/nessche/apralib)
+[![Gem Version](https://badge.fury.io/rb/apralib.svg)](http://badge.fury.io/rb/apralib)
+
+
 A Ruby library to submit documents to the Apra Service run by [Maatalousyrittäjien eläkelaitos](http://www.mela.fi)
 
 ## Installation

data/lib/apralib/apra_service.rb

@@ -17,11 +17,15 @@ module ApraService
       raise ArgumentError, 'notifications object must be either a Notification object or an array of Notification objects' unless
           (notifications.is_a? Notification or (notifications.is_a? Array and notifications.detect {|n| !n.is_a? Notification}.nil?))
       notifications = [notifications] unless notifications.is_a? Array
-      message = {}
-      message[:arg0] = notifications.map {|notification| notification.to_hash}
-      response = @client.call(:lisaa_apurahat, :message => message)
-      raise RuntimeError, 'An error occurred while submitting the notification' unless response.success?
-      Response.from_hash(response.body)
+      if notifications.count > 0
+        message = {}
+        message[:arg0] = notifications.map {|notification| notification.to_hash}
+        response = @client.call(:lisaa_apurahat, :message => message)
+        raise RuntimeError, 'An error occurred while submitting the notification' unless response.success?
+        Response.from_hash(response.body)
+      else
+        Response.new
+      end
     end
 
 

data/lib/apralib/response.rb

@@ -4,6 +4,10 @@ module ApraService
 
     attr_accessor :failed_notifications
 
+    def initialize
+      @failed_notifications = []
+    end
+
 
     def self.from_hash(hash)
       puts hash.inspect
@@ -13,8 +17,6 @@ module ApraService
       if failures
         failures = [failures] unless failures.is_a? Array
         response.failed_notifications = failures.map {|notification| NotificationResponse.from_hash(notification) }
-      else
-        response.failed_notifications = []
       end
       response
     end

data/lib/apralib/version.rb

@@ -1,3 +1,3 @@
 module Apralib
-  VERSION = "0.0.1"
+  VERSION = '0.0.2'
 end

data/spec/lib/apra_service_spec.rb

@@ -25,6 +25,10 @@ module ApraService
 
       end
 
+    end
+
+    describe 'send_notifications' do
+
       it 'should send the notification to the server' do
 
         service = get_client
@@ -71,7 +75,12 @@ module ApraService
         expect(notification_response.notification.reference).to eq(notification.reference)
       end
 
-
+      it 'should return an empty response when an empty array is passed' do
+        service = get_client
+        response = service.send_notifications([])
+        expect(response).not_to be_nil
+        expect(response.failed_notifications.count).to eq(0)
+      end
 
 
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: apralib
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Marco Sandrini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-02 00:00:00.000000000 Z
+date: 2014-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler