appydave-tools 0.76.3 → 0.76.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d2b65bd11cb0b4e0a0c9b1718a9ebb262ad6c998167bfdc8f533ddca754ee850
-  data.tar.gz: e45a7a56eb7f77249911ea874037c002829cfcca1f8f5cfd8553b60d12e88898
+  metadata.gz: 0531bc72c6c4aeac9830f72f552a4d683775d7efc61ee483069d882cdbbbf5af
+  data.tar.gz: 1c8e032ddc4e8dfc4c196452465abea40958107d2d68c5e4063c1ec2c36a3a9d
 SHA512:
-  metadata.gz: feb57bd1aca715ae2b6b3a587e762e024457b4d14f1172069d1afd19e953c6c432567d9c76c819543f740acb757c53bb36fa7bc839e4e7c8706f13435e94bfb0
-  data.tar.gz: eba77632d7dad881243726e122d8da5546040910b2851c36a9b751d7310da9ca3d1a4279571baa31b908bb1ff398436253bed4f7e52907adeeb6e4cfe1b1f69a
+  metadata.gz: 1787f781bdf758fae98c3388cce0437aca330a3161937f5c214651885c80e05598682e64afc3adea1e2ffd3b2f70d09287a9acca12c8fada89077b7d48791a39
+  data.tar.gz: 6cadabed0aa0f0be9d993b4dbda2c304c9a34f717fcc7b86b8cc059777e7cb0a57a494ddc2c3e5432fd4d4d85990330a6d401aa75c89bb7b0be5f5207c68d12b

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+## [0.76.4](https://github.com/appydave/appydave-tools/compare/v0.76.3...v0.76.4) (2026-03-19)
+
+
+### Bug Fixes
+
+* add subprocess test for -f json flag to cli_spec ([de6a28a](https://github.com/appydave/appydave-tools/commit/de6a28a39790d29f5141fbf313fa5e44782b90a6))
+* restore youtube_automation_config require accidentally removed in previous commit ([e4180db](https://github.com/appydave/appydave-tools/commit/e4180db9ad90040ec4faf2811fad713a20e6be8e))
+
+## [0.76.3](https://github.com/appydave/appydave-tools/compare/v0.76.2...v0.76.3) (2026-03-19)
+
+
+### Bug Fixes
+
+* add field isolation assertions to update_spec non-updated fields ([da678f6](https://github.com/appydave/appydave-tools/commit/da678f68f5ff0384020639069b459d98e0558968))
+
 ## [0.76.2](https://github.com/appydave/appydave-tools/compare/v0.76.1...v0.76.2) (2026-03-19)
 
 

data/README.md

@@ -43,7 +43,6 @@ ad_config -c
 This creates empty configuration files at `~/.config/appydave/`:
 - `settings.json` - Paths and preferences
 - `channels.json` - YouTube channel definitions
-- `youtube-automation.json` - Automation workflows
 
 **2. Option A: Copy example files**
 
@@ -276,38 +275,6 @@ prompt_tools completion -f prompt_template.md -k topic=Ruby,style=tutorial -c
 
 ---
 
-### ⚡ YouTube Automation *(Internal/Experimental)*
-
-**The problem:** Video content creation workflows involve multiple steps: research → scripting → production.
-
-**The solution:** Run predefined prompt sequences against OpenAI API to automate research and content generation steps.
-
-```bash
-# Run automation sequence (requires configuration)
-youtube_automation -s 01-1
-
-# With debug output
-youtube_automation -s 01-1 -d
-```
-
-**What it does:**
-- Loads sequence configuration from `~/.config/appydave/youtube_automation.json`
-- Reads prompt templates from Dropbox (`_common/raw_prompts/`)
-- Executes OpenAI API calls for each sequence step
-- Saves responses to output files
-
-**Configuration required:**
-- Sequence definitions in `youtube_automation.json`
-- Prompt template files in configured Dropbox path
-- `OPENAI_ACCESS_TOKEN` environment variable
-
-**Current status:** ⚠️ **Internal tool** - Hardcoded Dropbox paths, uses deprecated Completion API, not documented for external use.
-
-**Relationship to other tools:** This is separate from **Move Images** tool (which organizes downloaded images into video project asset folders).
-
-**Use cases:** Automated content research, script outline generation, multi-step prompt workflows.
-
----
 
 ### ⚙️ Configuration Manager
 
@@ -338,7 +305,6 @@ ad_config -p
 |------|---------|-------------------------|
 | `settings.json` | Paths and preferences (video-projects-root, download folders, etc.) | ✅ Yes (after removing personal paths) |
 | `channels.json` | YouTube channel definitions (code, name, youtube_handle, locations) | ✅ Yes (share structure, customize paths locally) |
-| `youtube_automation.json` | Automation workflow configurations | ✅ Yes (if no sensitive data) |
 | `.env` | **Secrets and API keys** | ❌ **NEVER** (gitignored) |
 
 **Key Settings:**

data/bin/dam

@@ -515,63 +515,6 @@ class VatCLI
     brands.key?(brand_key) || brands.shortcut?(brand_key)
   end
 
-  # Add local sync status to matched projects data
-  # Mutates the matched_projects hash to add :local_status key
-  # @param matched_projects [Hash] Map of project_id => S3 data
-  # @param brand_key [String] Brand key (e.g., 'appydave', 'ss')
-  # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-  def add_local_sync_status!(matched_projects, brand_key)
-    matched_projects.each do |project_id, data|
-      project_path = Appydave::Tools::Dam::Config.project_path(brand_key, project_id)
-      s3_staging_path = File.join(project_path, 's3-staging')
-
-      if !Dir.exist?(project_path)
-        data[:local_status] = :no_project # Project directory doesn't exist
-      elsif !Dir.exist?(s3_staging_path)
-        data[:local_status] = :no_files # Project exists but no downloads yet
-      else
-        # Count local files in s3-staging
-        local_files = Dir.glob(File.join(s3_staging_path, '**', '*'))
-                         .select { |f| File.file?(f) }
-                         .reject { |f| File.basename(f).include?('Zone.Identifier') } # Exclude Windows metadata
-
-        s3_file_count = data[:file_count]
-        local_file_count = local_files.size
-
-        data[:local_status] = if local_file_count.zero?
-                                :no_files
-                              elsif local_file_count == s3_file_count
-                                :synced # Fully synced
-                              else
-                                :partial # Some files downloaded
-                              end
-
-        data[:local_file_count] = local_file_count
-      end
-    end
-  end
-  # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-
-  # Format local sync status for display
-  # @param status [Symbol] :synced, :no_files, :partial, :no_project
-  # @param local_count [Integer, nil] Number of local files
-  # @param s3_count [Integer] Number of S3 files
-  # @return [String] Formatted status string
-  def format_local_status(status, local_count, s3_count)
-    case status
-    when :synced
-      '✓ Synced'
-    when :no_files
-      '⚠ None'
-    when :partial
-      "⚠ #{local_count}/#{s3_count}"
-    when :no_project
-      '✗ Missing'
-    else
-      'Unknown'
-    end
-  end
-
   def parse_share_args(args)
     # Extract --expires flag
     expires = '7d' # default
@@ -693,14 +636,14 @@ class VatCLI
 
       # Format columns
       file_col = filename.ljust(40)
-      size_col = format_bytes(size).rjust(10)
+      size_col = Appydave::Tools::Dam::FileHelper.format_size(size).rjust(10)
       date_col = last_modified ? last_modified.strftime('%Y-%m-%d %H:%M') : 'N/A'.ljust(16)
 
       puts "#{file_col} #{size_col}     #{date_col}"
     end
 
     puts '-' * 72
-    puts "Total: #{files.size} #{files.size == 1 ? 'file' : 'files'}, #{format_bytes(total_bytes)}"
+    puts "Total: #{files.size} #{files.size == 1 ? 'file' : 'files'}, #{Appydave::Tools::Dam::FileHelper.format_size(total_bytes)}"
 
     # Quick actions section
     puts ''
@@ -1478,7 +1421,7 @@ class VatCLI
     File.write(manifest_path, JSON.pretty_generate(manifest))
 
     # Add local sync status to matched projects
-    add_local_sync_status!(matched_projects, brand_key)
+    Appydave::Tools::Dam::LocalSyncStatus.enrich!(matched_projects, brand_key)
 
     # Display table
     display_s3_scan_table(matched_projects, orphaned_projects, bucket, prefix, region)
@@ -1507,8 +1450,8 @@ class VatCLI
     # Display matched projects first (sorted alphabetically)
     matched_projects.sort.each do |project_id, data|
       files = data[:file_count].to_s.rjust(5)
-      size = format_bytes(data[:total_bytes]).rjust(10)
-      local_status = format_local_status(data[:local_status], data[:local_file_count], data[:file_count])
+      size = Appydave::Tools::Dam::FileHelper.format_size(data[:total_bytes]).rjust(10)
+      local_status = Appydave::Tools::Dam::LocalSyncStatus.format(data[:local_status], data[:local_file_count], data[:file_count])
       modified = data[:last_modified] ? Time.parse(data[:last_modified]).strftime('%Y-%m-%d %H:%M') : 'N/A'
 
       puts format('%-36s %5s %10s  %-9s  %s', project_id, files, size, local_status, modified)
@@ -1520,7 +1463,7 @@ class VatCLI
     puts '-' * 92
     orphaned_projects.sort.each do |project_id, data|
       files = data[:file_count].to_s.rjust(5)
-      size = format_bytes(data[:total_bytes]).rjust(10)
+      size = Appydave::Tools::Dam::FileHelper.format_size(data[:total_bytes]).rjust(10)
       local_status = 'N/A'
       modified = data[:last_modified] ? Time.parse(data[:last_modified]).strftime('%Y-%m-%d %H:%M') : 'N/A'
 
@@ -1582,19 +1525,6 @@ class VatCLI
     puts "Total brands scanned: #{successful.size}/#{results.size}"
   end
   # rubocop:enable Metrics/MethodLength
-
-  # Format bytes in human-readable format
-  # rubocop:disable Style/FormatStringToken
-  def format_bytes(bytes)
-    return '0 B' if bytes.zero?
-
-    units = %w[B KB MB GB TB]
-    exp = (Math.log(bytes) / Math.log(1024)).to_i
-    exp = [exp, units.length - 1].min
-
-    format('%.1f %s', bytes.to_f / (1024**exp), units[exp])
-  end
-  # rubocop:enable Style/FormatStringToken
 end
 
 # Run CLI

data/docs/planning/AGENTS.md

@@ -14,6 +14,18 @@
 
 ---
 
+## ⚠️ Pre-Commit Check (Mandatory Every Commit)
+
+Before running `kfix`, always run:
+```bash
+git status
+```
+Confirm ONLY the files you intentionally changed are staged. If unexpected files appear, run `git diff` to investigate before proceeding.
+
+**Why:** micro-cleanup (2026-03-19) accidentally staged a pre-existing uncommitted change in `lib/appydave/tools.rb` when running `kfix`.
+
+---
+
 ## Build & Run Commands
 
 ```bash
@@ -33,7 +45,7 @@ kfeat "add feature description"             # Minor version bump
 kfix "fix bug description"                  # Patch version bump
 ```
 
-**Baseline (2026-03-19):** 748 examples, 0 failures, 84.88% line coverage (7680/9048)
+**Baseline (2026-03-19):** 831 examples, 0 failures, ~85.92% line coverage
 
 ---
 
@@ -82,9 +94,9 @@ docs/
 
 Every work unit must satisfy ALL of the following before marking `[x]`:
 
-- [ ] `bundle exec rspec` — 748+ examples, 0 failures
+- [ ] `bundle exec rspec` — 831+ examples, 0 failures
 - [ ] `bundle exec rubocop --format clang` — 0 offenses
-- [ ] Line coverage stays ≥ 84.88%
+- [ ] Line coverage stays ≥ 85.92%
 - [ ] Any new functionality has ≥ 1 spec covering it
 - [ ] All new `.rb` files start with `# frozen_string_literal: true`
 - [ ] No hardcoded brand transformation strings (always use BrandResolver)
@@ -209,9 +221,9 @@ Appydave::Tools::Configuration::Config.configure
 
 ## Quality Gates
 
-- **Tests:** `bundle exec rspec` — 748 examples, 0 failures (do not ship if any fail)
+- **Tests:** `bundle exec rspec` — 831 examples, 0 failures (do not ship if any fail)
 - **Lint:** `bundle exec rubocop --format clang` — 0 offenses (CI will reject)
-- **Coverage:** ≥ 84.88% line coverage
+- **Coverage:** ≥ 85.92% line coverage
 - **frozen_string_literal:** Required on every new `.rb` file
 - **Commit format:** `kfeat`/`kfix` only — triggers semantic versioning + CI wait
 

data/docs/planning/BACKLOG.md

@@ -1,35 +1,20 @@
 # Project Backlog — AppyDave Tools
 
-**Last updated**: 2026-03-19 (bugfix-and-security assessment + 4 new items from quality audit)
-**Total**: 27 | Pending: 17 | Done: 10 | Deferred: 0 | Rejected: 0
+**Last updated**: 2026-03-19 (micro-cleanup campaign complete)
+**Total**: 33 | Pending: 7 | In Progress: 1 | Done: 25 | Deferred: 0 | Rejected: 0
 
 ---
 
 ## Pending
 
-### High Priority
-- [ ] B024 — Tests: add configure_ssl_options unit tests to s3_operations_spec + share_operations_spec (protects B017 security fix) | Priority: high
-- [ ] B015 — BUG-2: FileCollector uses FileUtils.cd without ensure (process dir not restored on exception) | Priority: high
-- [x] B006 — BUG-1: Jump CLI get/remove key lookup | Completed: verified fixed 2026-03-19, regression spec added
-
 ### Medium Priority
-- [ ] B022 — Tests: expand cli_spec.rb with functional tests (-i, -e, -f, -o flags, exit codes) | Priority: medium
-- [ ] B026 — Tests: add determine_range edge cases (b00, b9, a40) to sync_from_ssd_spec + manifest_generator_spec | Priority: medium
-- [ ] B027 — Tests: strengthen gpt_context no-args spec to verify file collection actually stops | Priority: medium
-- [ ] B023 — Tests: add file_collector_spec coverage for JSON format, aider format, error paths | Priority: medium
-- [ ] B018 — Tests: add specs for Jump Commands::Remove, Commands::Add, Commands::Update | Priority: medium
-- [ ] B019 — Fix: remove debug puts @working_directory from gpt_context/file_collector.rb | Priority: medium
 - [ ] B001 — FR-1: GPT Context token counting | Priority: medium
 - [ ] B012 — Arch: add integration tests for brand resolution end-to-end | Priority: medium
-
-- [ ] B025 — Fix: stale comment in sync_from_ssd.rb line 173 (says 60-69, should say b50-b99) | Priority: low
-
-### Low Priority
 - [ ] B007 — Performance: parallel git/S3 status checks for dam list | Priority: low
 - [ ] B008 — Performance: cache git/S3 status with 5-min TTL | Priority: low
 - [ ] B009 — UX: progress indicators for dam operations > 5s | Priority: low
 - [ ] B010 — UX: auto-adjust dam table column widths to terminal width | Priority: low
-- [ ] B011 — Arch: extract VatCLI business logic from bin/dam (1,600-line God class) | Priority: low
+- [~] B011 — Arch: extract VatCLI business logic from bin/dam (1,600-line God class) | Campaign: extract-vat-cli
 - [ ] B020 — Arch: split S3Operations (1,030 lines, mixed I/O + logic) | Priority: low
 
 ---
@@ -45,6 +30,22 @@
 - [x] B016 — BUG-3: ManifestGenerator + SyncFromSsd incompatible SSD range strings | Completed: bugfix-and-security (2026-03-19)
 - [x] B017 — Security: ssl_verify_peer disabled unconditionally in S3Operations + ShareOperations + S3Scanner | Completed: bugfix-and-security (2026-03-19)
 - [x] B021 — Fix: gpt_context no-args guard had dead format.nil? condition | Completed: bugfix-and-security (2026-03-19)
+- [x] B024 — Tests: configure_ssl_options unit tests (protects B017 fix) | Completed: test-coverage-gaps (2026-03-19)
+- [x] B022 — Tests: functional cli_spec tests for -i -e -f -o flags | Completed: test-coverage-gaps (2026-03-19)
+- [x] B026 — Tests: determine_range edge cases (b00, b9, a40) | Completed: test-coverage-gaps (2026-03-19)
+- [x] B027 — Tests: gpt_context no-args spec verifies collection stops | Completed: test-coverage-gaps (2026-03-19)
+- [x] B025 — Fix: stale comment sync_from_ssd.rb:173 | Completed: test-coverage-gaps (2026-03-19)
+- [x] B018 — Tests: Jump Commands::Remove, Add, Update specs | Completed: test-coverage-gaps (2026-03-19)
+- [x] B015 — BUG-2: FileCollector FileUtils.cd without ensure | Completed: already fixed in commit 13d5f87; closed without campaign 2026-03-19
+- [x] B019 — Fix: remove debug puts @working_directory from file_collector.rb | Completed: already removed prior to test-coverage-gaps campaign; closed without campaign 2026-03-19
+- [x] B006 — BUG-1: Jump CLI get/remove key lookup | Completed: verified fixed 2026-03-19, regression spec added
+- [x] B023 — Tests: file_collector_spec json/aider/error path coverage | Completed: final-test-gaps (2026-03-19)
+- [x] B028 — Tests: cli_spec file body content assertions in -i/-e tests | Completed: final-test-gaps (2026-03-19)
+- [x] B029 — Tests: add_spec validate all returned location data fields | Completed: final-test-gaps (2026-03-19)
+- [x] B030 — Tests: update_spec verify non-updated fields unchanged | Completed: final-test-gaps (2026-03-19)
+- [x] B031 — Tests: add_spec `type` field assertion | Completed: already in commit 8eec40c; closed micro-cleanup (2026-03-19)
+- [x] B032 — Tests: cli_spec `-f json` subprocess test | Completed: micro-cleanup (2026-03-19), v0.76.4
+- [x] B033 — Fix: file_collector.rb return `''` when working_directory missing | Completed: already in commit 13d5f87; closed micro-cleanup (2026-03-19)
 
 ---
 
@@ -64,40 +65,6 @@
 
 ---
 
-### B002 — FR-2: GPT Context AI-Friendly Help System
-
-**Spec:** `docs/specs/fr-002-gpt-context-help-system.md`
-
-**User Story**: As an AI agent using GPT Context via skills, I want structured, comprehensive help output so I can understand all options and use the tool correctly.
-
-**Notes:** Full spec exists. High priority — enables AI skill integration.
-
----
-
-### B006 — BUG-1: Jump CLI get/remove Key Lookup Bug
-
-**Priority:** High — but verify live first
-
-**⚠️ Three-lens audit (2026-03-19) found:** Static analysis of `Jump::Config#find`, `Config#remove`, and `Search#get` shows correct dual-key guards. Bug may be environmental (stale config file format) or already fixed in a prior commit. **Run `bin/jump.rb get <key>` live before writing any code.**
-
-**Steps to Reproduce:**
-```bash
-bin/jump.rb search awb-team   # ✅ finds entry
-bin/jump.rb get awb-team      # ❌ "Location not found"  ← confirm this still fails
-bin/jump.rb remove test-minimal --force  # ❌ "No locations found."
-```
-
-**If bug confirmed:** Failure site is in `Jump::Config#find` (`loc.key == key`) or the memoization of `@locations` — NOT in `name_manager/`. The `Commands::Remove#run` → `config.find(key)` → `locations.find { |loc| loc.key == key }` path is the call chain to trace.
-
-**Acceptance Criteria:**
-- [ ] Confirm bug still exists live (if not, write regression spec and close)
-- [ ] `get <key>` finds entry when `search <key>` finds it
-- [ ] `remove <key>` finds entry when `search <key>` finds it
-- [ ] Regression tests for key lookup consistency
-- [ ] Root cause documented in commit message
-
----
-
 ### B007 — Performance: Parallel git/S3 Status Checks
 
 **Context:** `dam list appydave` with 13 projects takes ~26s (sequential git+S3 check per project).
@@ -146,47 +113,6 @@ bin/jump.rb remove test-minimal --force  # ❌ "No locations found."
 
 ---
 
-### B015 — BUG-2: FileCollector FileUtils.cd Without ensure
-
-**Context:** `lib/appydave/tools/gpt_context/file_collector.rb` line 20 calls `FileUtils.cd(@working_directory)`. If an exception fires inside `build`, the process working directory is never restored to `Dir.home`. Affects any subsequent operation in the same process.
-**Fix:** Wrap in block form: `FileUtils.cd(@working_directory) { ... }` — Ruby handles restore automatically. Or add `ensure FileUtils.cd(Dir.home)`.
-**Blocker for:** FR-2 — fix this before adding more code paths to `file_collector.rb`.
-**Source:** Code quality audit 2026-03-19, MAJOR issue #2.
-
----
-
-### B016 — BUG-3: ManifestGenerator vs SyncFromSsd Incompatible Range Strings
-
-**Context:** `ManifestGenerator.determine_range('b65')` returns `"b50-b99"`. `SyncFromSsd.determine_range('b65')` returns `"60-69"`. Both are used to construct SSD archive folder paths. Projects archived via SSD sync won't be found by the manifest generator, and vice versa. A `find_ssd_project_path` fallback scan may paper over this in practice.
-**Fix:** Standardise both methods on one format. Decide which format matches actual SSD folder structure on disk, then update the other method to match.
-**Source:** Code quality audit 2026-03-19, MAJOR issue #1.
-
----
-
-### B017 — Security: ssl_verify_peer Disabled in S3Operations + ShareOperations
-
-**Context:** `lib/appydave/tools/dam/s3_operations.rb` lines 110-113 and `share_operations.rb` lines 97-100 set `ssl_verify_peer: false` unconditionally. Comment claims "safe for AWS S3" — this is incorrect. Disabling peer verification removes MITM protection on all S3 operations including AWS credential transmission.
-**Fix:** Remove the `ssl_verify_peer: false` override entirely. AWS SDK handles SSL correctly by default. If there was a historical reason (corporate proxy, dev cert issue), document it and scope to `ENV['AWS_SKIP_SSL'] == 'true'` only.
-**Source:** Code quality audit 2026-03-19, MAJOR issue #3.
-
----
-
-### B018 — Tests: Jump Commands Layer Has No Dedicated Specs
-
-**Context:** `Commands::Remove`, `Commands::Add`, `Commands::Update` have zero unit specs. The CLI spec only tests auto-regenerate side effects. `--force` guard, error codes, suggestion-on-not-found logic, and key nil-handling in these commands are entirely untested.
-**Fix:** Add `spec/appydave/tools/jump/commands/remove_spec.rb`, `add_spec.rb`, `update_spec.rb`. Use `JumpTestLocations` factory + `with jump filesystem` context.
-**Source:** Test quality audit 2026-03-19, RISK-1.
-
----
-
-### B019 — Fix: Remove Debug puts From file_collector.rb
-
-**Context:** `lib/appydave/tools/gpt_context/file_collector.rb` line 15: `puts @working_directory`. Prints working directory on every `gpt_context` invocation. Pollutes captured output. Must be removed before FR-2 adds help system output.
-**Fix:** Delete line 15.
-**Source:** Code quality audit 2026-03-19, MINOR issue #4.
-
----
-
 ### B020 — Arch: Split S3Operations (1,030 lines)
 
 **Context:** `S3Operations` handles upload, download, status, cleanup, archive to SSD, MD5 comparison, content type detection, file formatting, and time formatting — all in one class with direct `puts` throughout. No result objects returned from upload/download/cleanup (void methods with side effects).