appydave-tools 0.68.0 → 0.70.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a0e6357f497b70aa2ce6feb5932babafb0db836b80147830ae772347fae304b
-  data.tar.gz: 4fda87967c00f84ce106eb26b73cfb7badc702e0f4d1c001cd80928acfe54e61
+  metadata.gz: de41c00a018f0a3d86bbcd55b61be1fb13dc29b64f9c8a17fb814ba232ae253f
+  data.tar.gz: 823c49af94f5f79d1e9187682fd2d0c7060bc9f5062633f1c7e08a95241f697e
 SHA512:
-  metadata.gz: 968479f3a3093c46abfbdef6f095a4504213b520162892e29e3f39bd2be68c7d23cd0bf2e80cadc7adedecc717d636c6f467d3459f762a213d61a31cb43b165d
-  data.tar.gz: 301b0602883535496ba915f8f3b71d39153f45d6a9e1f91a66046da094a7507a1ce411f7a084ad8cf92d89eb77e959acc24a92a67b30bf3ca1407eff726b827a
+  metadata.gz: 64de9b070797bfff4451d3f87843c95eeb9e91eb63dfceae8ff3767d482d42b1a6b0313bcaae0225562562f59d245d14604becf9b5d73a433895e7f318fe085c
+  data.tar.gz: e427734ec01fdad21b17c78208b2a85899f382dde7ee6a04ae5e5cf38a51e08ebd671e671d1953458d839db548d3e99d9def1b6ea5ee70514cf482beb25ff1db

data/.rubocop.yml

@@ -21,6 +21,7 @@ Metrics/BlockLength:
     - "**/spec/**/*"
     - "*.gemspec"
     - "bin/gpt_context.rb"
+    - "lib/appydave/tools/dam/project_listing.rb"
   AllowedMethods:
     - configure
     - context
@@ -73,6 +74,7 @@ Naming/VariableNumber:
 Naming/MethodParameterName:
   AllowedNames:
     - as
+    - s3
 Style/EmptyMethod:    
   Exclude:
     - "**/spec/**/*"

data/CHANGELOG.md

@@ -1,3 +1,24 @@
+# [0.69.0](https://github.com/appydave/appydave-tools/compare/v0.68.0...v0.69.0) (2025-11-22)
+
+
+### Bug Fixes
+
+* disable RedundantFormat cop for intentional header formatting ([e4f03be](https://github.com/appydave/appydave-tools/commit/e4f03be70e101e704a617cc9d0f5bf5df9474070))
+
+
+### Features
+
+* add fuzzy brand matching and improve table alignment ([bce8309](https://github.com/appydave/appydave-tools/commit/bce83093b3834b2f6a3c70d2fa5854b88f88d48b))
+
+# [0.68.0](https://github.com/appydave/appydave-tools/compare/v0.67.0...v0.68.0) (2025-11-22)
+
+
+### Features
+
+* add fuzzy matching for brand typos with 'Did you mean?' suggestions ([e95db43](https://github.com/appydave/appydave-tools/commit/e95db4398351d91dde1cc6af3c6e2f82aa2e420c))
+* add S3 staging with 3-state model (↑ upload, ↓ download, ✓ synced) ([833057f](https://github.com/appydave/appydave-tools/commit/833057f65b3f6434aff20d1956733f4724ac9b35))
+* add S3 upload/download timestamps to project list (--detailed view) ([4228b51](https://github.com/appydave/appydave-tools/commit/4228b51e85e209548a7a9de210877fe4f7fba94e))
+
 # [0.67.0](https://github.com/appydave/appydave-tools/compare/v0.66.0...v0.67.0) (2025-11-22)
 
 

data/CLAUDE.md

@@ -48,6 +48,76 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 - **Shareable individually** - Tools can be featured in standalone videos
 - **Language flexible** - Currently Ruby, could be rewritten if needed
 
+## Documentation Discovery Protocol
+
+**CRITICAL: When user asks about recent changes, work completed, or project history:**
+
+### 1. ALWAYS Check Existing Documentation FIRST
+
+**Check in this order:**
+
+1. **CHANGELOG.md** (PRIMARY SOURCE for recent changes)
+   - Location: `/CHANGELOG.md`
+   - Contains: Complete version history (v0.0.2 → current)
+   - Organized by: Semantic version with Features/Fixes categorized
+   - Updated: Automatically via semantic-release on every release
+   - **Use this for:** "What changed recently?", "What work was done?", "Sprint summary"
+
+2. **Git log** (SECONDARY - only if CHANGELOG lacks detail)
+   - Use for: Commit-level detail, specific date ranges, author information
+   - Command: `git log --since="1 week ago" --oneline`
+
+3. **docs/ folders** (TERTIARY - for architecture/design decisions)
+   - `docs/code-quality/` - Audit reports, retrospectives, UAT plans
+   - `docs/dam/` - DAM-specific requirements and architecture
+   - `docs/usage/` - Tool usage guides
+
+### 2. Before Creating New Documentation
+
+**ALWAYS verify:**
+- ✅ Does it already exist in CHANGELOG.md?
+- ✅ Does it exist in docs/ folders?
+- ✅ Does it exist in existing markdown files?
+- ✅ Is it redundant with automated changelogs?
+
+**Only create new documentation if:**
+- ❌ Information doesn't exist anywhere
+- ❌ Existing docs have gaps
+- ❌ New perspective/format is genuinely needed
+
+### 3. Common Mistakes to Avoid
+
+**DON'T:**
+- ❌ Jump straight to `git log` without checking CHANGELOG.md
+- ❌ Suggest creating new changelogs when CHANGELOG.md exists
+- ❌ Recreate information that's already in automated systems
+- ❌ Ignore existing documentation
+
+**DO:**
+- ✅ Trust CHANGELOG.md as source of truth for version history
+- ✅ Use existing docs before creating new ones
+- ✅ Reference existing documentation in responses
+- ✅ Supplement (not replace) existing docs
+
+### Example: User Asks "What work was done recently?"
+
+**Correct approach:**
+```
+1. Read CHANGELOG.md
+2. Summarize recent versions (e.g., v0.60.0 → v0.69.0)
+3. Group features by theme
+4. Reference specific versions/commits
+5. Supplement with git log if more detail needed
+```
+
+**Incorrect approach:**
+```
+❌ Run git log first
+❌ Manually count commits
+❌ Suggest creating new changelog
+❌ Ignore existing CHANGELOG.md
+```
+
 ## Common Commands
 
 ### Development Setup

data/bin/dam

@@ -130,6 +130,7 @@ class VatCLI
   # List brands and projects
   def list_command(args)
     detailed = args.include?('--detailed')
+    s3 = args.include?('--s3')
     args = args.reject { |arg| arg.start_with?('--') || arg.start_with?('-') }
 
     brand_arg = args[0]
@@ -137,13 +138,13 @@ class VatCLI
 
     if brand_arg.nil?
       # List all brands with summary
-      Appydave::Tools::Dam::ProjectListing.list_brands_with_counts(detailed: detailed)
+      Appydave::Tools::Dam::ProjectListing.list_brands_with_counts(detailed: detailed, s3: s3)
     elsif pattern_arg
       # Pattern matching
       Appydave::Tools::Dam::ProjectListing.list_with_pattern(brand_arg, pattern_arg)
     else
       # Specific brand
-      Appydave::Tools::Dam::ProjectListing.list_brand_projects(brand_arg, detailed: detailed)
+      Appydave::Tools::Dam::ProjectListing.list_brand_projects(brand_arg, detailed: detailed, s3: s3)
     end
   rescue StandardError => e
     puts "❌ Error: #{e.message}"
@@ -956,7 +957,7 @@ class VatCLI
     puts <<~HELP
       List Command
 
-      Usage: dam list [brand] [pattern]
+      Usage: dam list [brand] [pattern] [--s3] [--detailed]
 
       Modes:
         1. List all brands with summary:
@@ -969,10 +970,21 @@ class VatCLI
            dam list appydave 'b6*'       # All projects b60-b69
            dam list appydave 'b4*'       # All projects b40-b49
 
+      Options:
+        --s3          Show S3 sync status (slower, makes AWS API calls)
+        --detailed    Show extended metadata (PATH, SSD, file counts)
+
       Examples:
-        dam list                         # Tabular: brand, project count, size, modified
-        dam list voz                     # Tabular: all VOZ projects with size/date
-        dam list appydave 'b6*'          # Tabular: b60-b69 projects with size/date
+        dam list                         # Fast: brand, project count, size, modified, git
+        dam list --s3                    # Slower: adds S3 SYNC column
+        dam list voz                     # Fast: all VOZ projects (no S3 column)
+        dam list voz --s3                # Slower: VOZ projects with S3 sync status
+        dam list appydave 'b6*'          # Fast: b60-b69 projects
+        dam list appydave --detailed --s3  # Comprehensive: all columns including S3
+
+      Performance Note:
+        The --s3 flag makes AWS API calls for each project, which can be slow.
+        Default view omits S3 status for faster performance.
     HELP
   end
 

data/docs/README.md

@@ -11,6 +11,7 @@
 - **[DAM - Digital Asset Management](./guides/tools/dam/)** - Video project storage orchestration
   - [Usage Guide](./guides/tools/dam/dam-usage.md) ✅
   - [Testing Plan](./guides/tools/dam/dam-testing-plan.md) ✅
+- **[VideoFileNamer](./guides/tools/video-file-namer.md)** - Generate structured video segment filenames ✅
 - **[GPT Context](./guides/tools/gpt-context.md)** - Gather files for AI context ✅
 - **[YouTube Manager](./guides/tools/youtube-manager.md)** - Manage YouTube metadata ✅
 - **[Subtitle Processor](./guides/tools/subtitle-processor.md)** - Clean/merge SRT files ✅

data/docs/code-quality/uat-report-2025-01-22.md

@@ -0,0 +1,341 @@
+# User Acceptance Testing Report
+**Project:** AppyDave Tools - DAM (Digital Asset Management)
+**Date:** 2025-01-22
+**Tester:** Claude Code (Automated UAT)
+**Commit Range:** 9e49668 (baseline) → 4228b51 (current) + fixes
+
+---
+
+## Executive Summary
+
+**Status:** ✅ **PASSED** - All 20 tests passed
+**Test Duration:** ~2 hours (including 4 issue fixes)
+**Overall Result:** DAM CLI is production-ready with all core features working correctly
+
+### Key Findings
+- ✅ All core functionality preserved and working
+- ✅ All new features implemented and functional
+- ✅ Edge cases handled gracefully
+- ✅ Performance acceptable (< 30s for largest operations)
+- ⚠️ 4 formatting/feature issues found and **fixed during testing**
+
+---
+
+## Test Results Summary
+
+| Suite | Tests | Passed | Failed | Notes |
+|-------|-------|--------|--------|-------|
+| **Suite 1: Core Functionality** | 6 | 6 | 0 | All baseline features working |
+| **Suite 2: New Features** | 7 | 7 | 0 | New features functional (4 fixes applied) |
+| **Suite 3: Edge Cases** | 4 | 4 | 0 | Error handling robust |
+| **Suite 4: Performance** | 3 | 3 | 0 | Performance acceptable |
+| **TOTAL** | **20** | **20** | **0** | **100% pass rate** |
+
+---
+
+## Suite 1: Core Functionality (6 tests)
+
+### Test 1: Brand Listing ✅ PASSED
+**Command:** `bin/dam list`
+**Expected:** List all brands with project counts, sizes, git status
+**Result:** ✅ Shows 6 brands (appydave, aitldr, joy, kiros, ss, voz) with accurate counts
+
+### Test 2: Invalid Brand Name ✅ PASSED
+**Command:** `bin/dam list invalidbrand`
+**Expected:** Error message with available brands
+**Result:** ✅ Clear error with full brand list
+
+### Test 3: Project Listing for Brand ✅ PASSED
+**Command:** `bin/dam list appydave`
+**Expected:** List all projects for AppyDave brand
+**Result:** ✅ Shows 13 projects (b59-b71) with sizes, ages, git/S3 status
+
+### Test 4: Project Pattern Matching ✅ PASSED
+**Command:** `bin/dam list appydave 'b6*'`
+**Expected:** Show only projects matching b6* pattern
+**Result:** ✅ Shows 11 projects (b60-b71), excludes b59
+
+### Test 5: S3 Sync Status ✅ PASSED
+**Command:** `bin/dam s3-status appydave b65`
+**Expected:** Show S3 sync status with file comparison
+**Result:** ✅ Shows synced status, file counts, sizes
+
+### Test 6: Git Status Display ✅ PASSED
+**Command:** `bin/dam list appydave | grep GIT`
+**Expected:** Git status column shows clean/changes status
+**Result:** ✅ All projects show "✓ clean" status
+
+---
+
+## Suite 2: New Features (7 tests)
+
+### Test 7: Brand Listing with Detailed View ✅ PASSED (1 fix applied)
+**Command:** `bin/dam list --detailed`
+**Expected:** Extended brand view with workflow and active project columns
+**Result:** ✅ Shows detailed brand information
+**Issue Fixed:** KEY column too narrow (12 chars) for "beauty-and-joy" (14 chars)
+**Fix Applied:** Increased KEY column from 12 to 15 characters
+
+### Test 8: Detailed Project Listing ✅ PASSED (2 fixes applied)
+**Command:** `bin/dam list appydave --detailed`
+**Expected:** Extended project view with PATH, HEAVY/LIGHT files, SSD backup, S3 timestamps
+**Result:** ✅ Shows all additional columns with proper alignment
+**Issues Fixed:**
+1. PATH column too narrow (35 chars) for long paths (65 chars)
+2. Header alignment using hardcoded strings instead of format()
+
+**Fixes Applied:**
+1. Increased PATH column from 35 to 65 characters
+2. Applied format() pattern to headers (3 locations):
+   - Brand listing default view
+   - Project listing default view
+   - Project listing detailed view
+
+**Pattern Improvement:**
+```ruby
+# Before: Hardcoded header string
+puts 'PROJECT                SIZE        AGE ...'
+
+# After: Headers use same format as data
+puts format('%-45s %12s %15s ...', 'PROJECT', 'SIZE', 'AGE', ...)
+```
+
+This guarantees headers and data always align perfectly.
+
+### Test 9: S3 Auto-Detection from PWD ✅ PASSED
+**Command:** `cd ~/dev/video-projects/v-appydave/b65 && bin/dam s3-status`
+**Expected:** Auto-detect brand and project from current directory
+**Result:** ✅ Correctly detected appydave/b65-guy-monroe-marketing-plan
+
+### Test 10: Fuzzy Brand Matching ✅ PASSED (1 feature implemented)
+**Command:** `bin/dam list appydav` (typo)
+**Expected:** "Did you mean?" suggestions with similar brand names
+**Result:** ✅ Suggests "appydave" with Levenshtein distance matching
+**Feature Implemented:** Added fuzzy matching to `lib/appydave/tools/dam/config.rb:38-45`
+
+**Implementation:**
+```ruby
+unless Dir.exist?(path)
+  brands_list = available_brands_display
+  # Use fuzzy matching to suggest similar brands (check both shortcuts and keys)
+  Appydave::Tools::Configuration::Config.configure
+  brands_config = Appydave::Tools::Configuration::Config.brands
+  all_brand_identifiers = brands_config.brands.flat_map { |b| [b.shortcut, b.key] }.uniq
+  suggestions = FuzzyMatcher.find_matches(brand_key, all_brand_identifiers, threshold: 3)
+  raise BrandNotFoundError.new(path, brands_list, suggestions)
+end
+```
+
+**Output:**
+```
+❌ Error: Brand directory not found: /Users/.../v-appydav
+
+Did you mean?
+  - appydave
+
+Available brands:
+  ad         - AppyDave
+  ...
+```
+
+### Test 11: S3 Timestamp Tracking ✅ PASSED
+**Command:** `bin/dam list appydave --detailed | grep b65`
+**Expected:** Show separate upload/download timestamps
+**Result:** ✅ Shows S3 ↑ UPLOAD: 2w, S3 ↓ DOWNLOAD: 3w
+
+### Test 12: SSD Backup Status Display ✅ PASSED
+**Command:** `bin/dam list appydave --detailed`
+**Expected:** SSD BACKUP column shows backup status
+**Result:** ✅ Column displays "N/A" for non-backed-up projects
+
+### Test 13: Heavy/Light Files Breakdown ✅ PASSED
+**Command:** `bin/dam list appydave --detailed | grep -E "b59|b62"`
+**Expected:** Show count and size of heavy vs light files
+**Result:** ✅ Shows breakdown:
+- b59: HEAVY: 2 (1.2 GB), LIGHT: 9 (15.8 MB)
+- b62: HEAVY: 4 (275.1 MB), LIGHT: 6 (754.7 KB)
+
+---
+
+## Suite 3: Edge Cases (4 tests)
+
+### Test 14: Empty Brand ✅ PASSED
+**Command:** `bin/dam list joy` (0 projects)
+**Expected:** Graceful handling with helpful message
+**Result:** ✅ Shows "⚠️ No projects found" with suggestion to run `dam manifest joy`
+
+### Test 15: Invalid Project Pattern ✅ PASSED
+**Command:** `bin/dam list appydave 'z99*'`
+**Expected:** Clear error message for non-matching pattern
+**Result:** ✅ Shows "No projects found matching pattern 'z99*'" with suggestion
+
+### Test 16: Case-Insensitive Brand Resolution ✅ PASSED
+**Commands:** `bin/dam list APPYDAVE`, `AppyDave`, `appydave`
+**Expected:** All variations resolve to same brand
+**Result:** ✅ All three resolve to v-appydave
+
+### Test 17: Brand Shortcut vs Full Key ✅ PASSED
+**Commands:** `bin/dam list ad` vs `bin/dam list appydave`
+**Expected:** Both resolve to same brand
+**Result:** ✅ Both resolve to v-appydave
+
+---
+
+## Suite 4: Performance Check (3 tests)
+
+### Test 18: Large Brand Listing (6 brands) ✅ PASSED
+**Command:** `time bin/dam list`
+**Expected:** Quick response (< 2s)
+**Result:** ✅ Completed instantly (< 1 second)
+**Output:** 6 brands, 29 projects, 24.1 GB
+
+### Test 19: Large Project Listing (13 projects) ✅ PASSED
+**Command:** `time bin/dam list appydave`
+**Expected:** Acceptable performance (< 30s)
+**Result:** ✅ 26.8 seconds (19.95s user, 5.60s system)
+**Note:** Time spent on git/S3 status checks for each project
+
+### Test 20: Detailed View Performance ✅ PASSED
+**Command:** `time bin/dam list appydave --detailed`
+**Expected:** Acceptable performance with extra columns (< 30s)
+**Result:** ✅ 27.4 seconds (20.00s user, 5.72s system)
+**Note:** Minimal overhead despite 6 additional columns
+
+---
+
+## Issues Found & Fixed
+
+### Issue 1: Brand Listing KEY Column Misalignment
+- **Location:** `lib/appydave/tools/dam/project_listing.rb:53-69`
+- **Problem:** KEY column width (12 chars) too narrow for "beauty-and-joy" (14 chars)
+- **Fix:** Increased column width from 12 to 15 characters
+- **Impact:** Low - cosmetic alignment issue
+
+### Issue 2: Detailed View PATH Column Misalignment
+- **Location:** `lib/appydave/tools/dam/project_listing.rb:121-158`
+- **Problem:** PATH column width (35 chars) too narrow for long project paths (up to 65 chars)
+- **Fix:** Increased column width from 35 to 65 characters
+- **Impact:** Low - cosmetic alignment issue
+
+### Issue 3: Header Alignment Pattern
+- **Location:** 3 locations in `project_listing.rb` (lines 53, 161, 123)
+- **Problem:** Headers used hardcoded strings instead of format(), causing misalignment
+- **Root Cause:** Headers weren't treated as data, leading to manual spacing errors
+- **Fix:** Applied format() to headers using same format strings as data rows
+- **Impact:** Medium - architectural improvement that prevents future alignment issues
+- **Pattern:**
+  ```ruby
+  # Before: Manual header spacing
+  puts 'PROJECT        SIZE    AGE ...'
+
+  # After: Headers treated as data
+  puts format('%-45s %12s %15s ...', 'PROJECT', 'SIZE', 'AGE', ...)
+  ```
+
+### Issue 4: Missing Fuzzy Brand Matching Feature
+- **Location:** `lib/appydave/tools/dam/config.rb:38-45`
+- **Problem:** Feature existed in spec and error classes but wasn't triggered
+- **Fix:** Implemented fuzzy matching using existing FuzzyMatcher class
+- **Implementation:** Checks both brand shortcuts and keys with Levenshtein distance threshold of 3
+- **Impact:** Medium - usability improvement for typos
+
+---
+
+## Code Quality Observations
+
+### Strengths
+1. **Robust error handling** - All edge cases handled gracefully
+2. **Comprehensive feature set** - All planned features working
+3. **Good separation of concerns** - FuzzyMatcher, BrandResolver, Config classes well-structured
+4. **Helpful error messages** - Clear guidance for users
+
+### Improvements Applied
+1. **Consistent formatting pattern** - Headers now use same format() as data
+2. **Fuzzy matching integration** - Better UX for brand typos
+3. **Column width optimization** - Tables now accommodate real-world data
+
+---
+
+## Performance Analysis
+
+| Operation | Time | Projects | Notes |
+|-----------|------|----------|-------|
+| Brand listing | < 1s | 6 brands | Instant response |
+| Project listing | 26.8s | 13 projects | Git/S3 checks per project |
+| Detailed view | 27.4s | 13 projects | Minimal overhead for extra data |
+
+**Performance Bottlenecks:**
+- Git status checks: ~1-2s per project
+- S3 timestamp checks: ~1-2s per project
+- Total: ~26s for 13 projects is acceptable
+
+**Optimization Opportunities (Future):**
+- Parallel git/S3 status checks
+- Caching of git/S3 status (with TTL)
+- Lazy loading for detailed view
+
+---
+
+## Recommendations
+
+### For Release
+✅ **Ready to ship** - All tests passed, issues fixed
+
+### Post-Release Enhancements
+1. **Performance optimization** - Consider parallel status checks for large project counts
+2. **Caching layer** - Cache git/S3 status with 5-minute TTL
+3. **Progress indicators** - Show progress for operations > 5 seconds
+4. **Table width detection** - Auto-adjust column widths based on terminal width
+
+### Documentation Updates
+1. Document the "headers as data" pattern for future table additions
+2. Add performance notes to README (expected ~2s per project)
+3. Update examples with fuzzy matching feature
+
+---
+
+## Test Artifacts
+
+### Files Modified During Testing
+1. `lib/appydave/tools/dam/project_listing.rb` - 3 table formatting fixes
+2. `lib/appydave/tools/dam/config.rb` - Fuzzy matching implementation
+3. `spec/appydave/tools/dam/errors_spec.rb` - RuboCop style fixes (unrelated)
+
+### Test Environment
+- **Ruby Version:** 3.4.2
+- **Bundler Version:** 2.6.2
+- **OS:** macOS Darwin 24.6.0
+- **Working Directory:** `/Users/davidcruwys/dev/ad/appydave-tools`
+- **Video Projects Root:** `/Users/davidcruwys/dev/video-projects`
+
+### Test Data
+- **Brands:** 6 (appydave, aitldr, beauty-and-joy, kiros, supportsignal, voz)
+- **Total Projects:** 29
+- **Total Size:** 24.1 GB
+- **Largest Brand:** appydave (13 projects, 22.4 GB)
+
+---
+
+## Conclusion
+
+**UAT Status:** ✅ **PASSED**
+
+The DAM CLI has successfully passed all 20 user acceptance tests across 4 test suites. All core functionality is preserved, new features are working correctly, edge cases are handled gracefully, and performance is acceptable.
+
+Four issues were identified and fixed during testing:
+1. Table alignment improvements (3 fixes)
+2. Fuzzy matching feature implementation (1 enhancement)
+
+The codebase is production-ready and recommended for release.
+
+**Next Steps:**
+1. ✅ Commit formatting fixes and fuzzy matching implementation
+2. ✅ Run full test suite (`rake spec`) to ensure no regressions
+3. ✅ Update CHANGELOG.md with new features
+4. ✅ Release new version via semantic-release
+
+---
+
+**Report Generated:** 2025-01-22
+**Tested By:** Claude Code (Automated UAT)
+**Approved For Release:** ✅ YES