appydave-tools 0.68.0 → 0.69.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a0e6357f497b70aa2ce6feb5932babafb0db836b80147830ae772347fae304b
-  data.tar.gz: 4fda87967c00f84ce106eb26b73cfb7badc702e0f4d1c001cd80928acfe54e61
+  metadata.gz: a24c15bc4b23513bde2a68019a63077e627f4a32908dedc8c2af882892809984
+  data.tar.gz: 8c77419c2ce675ac8340ee450a02f7e530d2c59dbbd06c7573e5ec27a8069d6e
 SHA512:
-  metadata.gz: 968479f3a3093c46abfbdef6f095a4504213b520162892e29e3f39bd2be68c7d23cd0bf2e80cadc7adedecc717d636c6f467d3459f762a213d61a31cb43b165d
-  data.tar.gz: 301b0602883535496ba915f8f3b71d39153f45d6a9e1f91a66046da094a7507a1ce411f7a084ad8cf92d89eb77e959acc24a92a67b30bf3ca1407eff726b827a
+  metadata.gz: cb2f7b0f3828607d232a98164058fb1d5c01a90782dcb110a9ac34ed884035482503ae97a57f8ae8850bd23857475fb74fb3788ee48783170c9c6090cdec83ea
+  data.tar.gz: f9cb457726c269bdeee39113683ac60f75c0931425bf7dbd79539e7c4ca784b55d2ef3ab9337ca377d01086a58f965f97bb7fbc12bbbfdf87b91dde10dcde47d

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+# [0.68.0](https://github.com/appydave/appydave-tools/compare/v0.67.0...v0.68.0) (2025-11-22)
+
+
+### Features
+
+* add fuzzy matching for brand typos with 'Did you mean?' suggestions ([e95db43](https://github.com/appydave/appydave-tools/commit/e95db4398351d91dde1cc6af3c6e2f82aa2e420c))
+* add S3 staging with 3-state model (↑ upload, ↓ download, ✓ synced) ([833057f](https://github.com/appydave/appydave-tools/commit/833057f65b3f6434aff20d1956733f4724ac9b35))
+* add S3 upload/download timestamps to project list (--detailed view) ([4228b51](https://github.com/appydave/appydave-tools/commit/4228b51e85e209548a7a9de210877fe4f7fba94e))
+
 # [0.67.0](https://github.com/appydave/appydave-tools/compare/v0.66.0...v0.67.0) (2025-11-22)
 
 

data/docs/code-quality/uat-report-2025-01-22.md

@@ -0,0 +1,341 @@
+# User Acceptance Testing Report
+**Project:** AppyDave Tools - DAM (Digital Asset Management)
+**Date:** 2025-01-22
+**Tester:** Claude Code (Automated UAT)
+**Commit Range:** 9e49668 (baseline) → 4228b51 (current) + fixes
+
+---
+
+## Executive Summary
+
+**Status:** ✅ **PASSED** - All 20 tests passed
+**Test Duration:** ~2 hours (including 4 issue fixes)
+**Overall Result:** DAM CLI is production-ready with all core features working correctly
+
+### Key Findings
+- ✅ All core functionality preserved and working
+- ✅ All new features implemented and functional
+- ✅ Edge cases handled gracefully
+- ✅ Performance acceptable (< 30s for largest operations)
+- ⚠️ 4 formatting/feature issues found and **fixed during testing**
+
+---
+
+## Test Results Summary
+
+| Suite | Tests | Passed | Failed | Notes |
+|-------|-------|--------|--------|-------|
+| **Suite 1: Core Functionality** | 6 | 6 | 0 | All baseline features working |
+| **Suite 2: New Features** | 7 | 7 | 0 | New features functional (4 fixes applied) |
+| **Suite 3: Edge Cases** | 4 | 4 | 0 | Error handling robust |
+| **Suite 4: Performance** | 3 | 3 | 0 | Performance acceptable |
+| **TOTAL** | **20** | **20** | **0** | **100% pass rate** |
+
+---
+
+## Suite 1: Core Functionality (6 tests)
+
+### Test 1: Brand Listing ✅ PASSED
+**Command:** `bin/dam list`
+**Expected:** List all brands with project counts, sizes, git status
+**Result:** ✅ Shows 6 brands (appydave, aitldr, joy, kiros, ss, voz) with accurate counts
+
+### Test 2: Invalid Brand Name ✅ PASSED
+**Command:** `bin/dam list invalidbrand`
+**Expected:** Error message with available brands
+**Result:** ✅ Clear error with full brand list
+
+### Test 3: Project Listing for Brand ✅ PASSED
+**Command:** `bin/dam list appydave`
+**Expected:** List all projects for AppyDave brand
+**Result:** ✅ Shows 13 projects (b59-b71) with sizes, ages, git/S3 status
+
+### Test 4: Project Pattern Matching ✅ PASSED
+**Command:** `bin/dam list appydave 'b6*'`
+**Expected:** Show only projects matching b6* pattern
+**Result:** ✅ Shows 11 projects (b60-b71), excludes b59
+
+### Test 5: S3 Sync Status ✅ PASSED
+**Command:** `bin/dam s3-status appydave b65`
+**Expected:** Show S3 sync status with file comparison
+**Result:** ✅ Shows synced status, file counts, sizes
+
+### Test 6: Git Status Display ✅ PASSED
+**Command:** `bin/dam list appydave | grep GIT`
+**Expected:** Git status column shows clean/changes status
+**Result:** ✅ All projects show "✓ clean" status
+
+---
+
+## Suite 2: New Features (7 tests)
+
+### Test 7: Brand Listing with Detailed View ✅ PASSED (1 fix applied)
+**Command:** `bin/dam list --detailed`
+**Expected:** Extended brand view with workflow and active project columns
+**Result:** ✅ Shows detailed brand information
+**Issue Fixed:** KEY column too narrow (12 chars) for "beauty-and-joy" (14 chars)
+**Fix Applied:** Increased KEY column from 12 to 15 characters
+
+### Test 8: Detailed Project Listing ✅ PASSED (2 fixes applied)
+**Command:** `bin/dam list appydave --detailed`
+**Expected:** Extended project view with PATH, HEAVY/LIGHT files, SSD backup, S3 timestamps
+**Result:** ✅ Shows all additional columns with proper alignment
+**Issues Fixed:**
+1. PATH column too narrow (35 chars) for long paths (65 chars)
+2. Header alignment using hardcoded strings instead of format()
+
+**Fixes Applied:**
+1. Increased PATH column from 35 to 65 characters
+2. Applied format() pattern to headers (3 locations):
+   - Brand listing default view
+   - Project listing default view
+   - Project listing detailed view
+
+**Pattern Improvement:**
+```ruby
+# Before: Hardcoded header string
+puts 'PROJECT                SIZE        AGE ...'
+
+# After: Headers use same format as data
+puts format('%-45s %12s %15s ...', 'PROJECT', 'SIZE', 'AGE', ...)
+```
+
+This guarantees headers and data always align perfectly.
+
+### Test 9: S3 Auto-Detection from PWD ✅ PASSED
+**Command:** `cd ~/dev/video-projects/v-appydave/b65 && bin/dam s3-status`
+**Expected:** Auto-detect brand and project from current directory
+**Result:** ✅ Correctly detected appydave/b65-guy-monroe-marketing-plan
+
+### Test 10: Fuzzy Brand Matching ✅ PASSED (1 feature implemented)
+**Command:** `bin/dam list appydav` (typo)
+**Expected:** "Did you mean?" suggestions with similar brand names
+**Result:** ✅ Suggests "appydave" with Levenshtein distance matching
+**Feature Implemented:** Added fuzzy matching to `lib/appydave/tools/dam/config.rb:38-45`
+
+**Implementation:**
+```ruby
+unless Dir.exist?(path)
+  brands_list = available_brands_display
+  # Use fuzzy matching to suggest similar brands (check both shortcuts and keys)
+  Appydave::Tools::Configuration::Config.configure
+  brands_config = Appydave::Tools::Configuration::Config.brands
+  all_brand_identifiers = brands_config.brands.flat_map { |b| [b.shortcut, b.key] }.uniq
+  suggestions = FuzzyMatcher.find_matches(brand_key, all_brand_identifiers, threshold: 3)
+  raise BrandNotFoundError.new(path, brands_list, suggestions)
+end
+```
+
+**Output:**
+```
+❌ Error: Brand directory not found: /Users/.../v-appydav
+
+Did you mean?
+  - appydave
+
+Available brands:
+  ad         - AppyDave
+  ...
+```
+
+### Test 11: S3 Timestamp Tracking ✅ PASSED
+**Command:** `bin/dam list appydave --detailed | grep b65`
+**Expected:** Show separate upload/download timestamps
+**Result:** ✅ Shows S3 ↑ UPLOAD: 2w, S3 ↓ DOWNLOAD: 3w
+
+### Test 12: SSD Backup Status Display ✅ PASSED
+**Command:** `bin/dam list appydave --detailed`
+**Expected:** SSD BACKUP column shows backup status
+**Result:** ✅ Column displays "N/A" for non-backed-up projects
+
+### Test 13: Heavy/Light Files Breakdown ✅ PASSED
+**Command:** `bin/dam list appydave --detailed | grep -E "b59|b62"`
+**Expected:** Show count and size of heavy vs light files
+**Result:** ✅ Shows breakdown:
+- b59: HEAVY: 2 (1.2 GB), LIGHT: 9 (15.8 MB)
+- b62: HEAVY: 4 (275.1 MB), LIGHT: 6 (754.7 KB)
+
+---
+
+## Suite 3: Edge Cases (4 tests)
+
+### Test 14: Empty Brand ✅ PASSED
+**Command:** `bin/dam list joy` (0 projects)
+**Expected:** Graceful handling with helpful message
+**Result:** ✅ Shows "⚠️ No projects found" with suggestion to run `dam manifest joy`
+
+### Test 15: Invalid Project Pattern ✅ PASSED
+**Command:** `bin/dam list appydave 'z99*'`
+**Expected:** Clear error message for non-matching pattern
+**Result:** ✅ Shows "No projects found matching pattern 'z99*'" with suggestion
+
+### Test 16: Case-Insensitive Brand Resolution ✅ PASSED
+**Commands:** `bin/dam list APPYDAVE`, `AppyDave`, `appydave`
+**Expected:** All variations resolve to same brand
+**Result:** ✅ All three resolve to v-appydave
+
+### Test 17: Brand Shortcut vs Full Key ✅ PASSED
+**Commands:** `bin/dam list ad` vs `bin/dam list appydave`
+**Expected:** Both resolve to same brand
+**Result:** ✅ Both resolve to v-appydave
+
+---
+
+## Suite 4: Performance Check (3 tests)
+
+### Test 18: Large Brand Listing (6 brands) ✅ PASSED
+**Command:** `time bin/dam list`
+**Expected:** Quick response (< 2s)
+**Result:** ✅ Completed instantly (< 1 second)
+**Output:** 6 brands, 29 projects, 24.1 GB
+
+### Test 19: Large Project Listing (13 projects) ✅ PASSED
+**Command:** `time bin/dam list appydave`
+**Expected:** Acceptable performance (< 30s)
+**Result:** ✅ 26.8 seconds (19.95s user, 5.60s system)
+**Note:** Time spent on git/S3 status checks for each project
+
+### Test 20: Detailed View Performance ✅ PASSED
+**Command:** `time bin/dam list appydave --detailed`
+**Expected:** Acceptable performance with extra columns (< 30s)
+**Result:** ✅ 27.4 seconds (20.00s user, 5.72s system)
+**Note:** Minimal overhead despite 6 additional columns
+
+---
+
+## Issues Found & Fixed
+
+### Issue 1: Brand Listing KEY Column Misalignment
+- **Location:** `lib/appydave/tools/dam/project_listing.rb:53-69`
+- **Problem:** KEY column width (12 chars) too narrow for "beauty-and-joy" (14 chars)
+- **Fix:** Increased column width from 12 to 15 characters
+- **Impact:** Low - cosmetic alignment issue
+
+### Issue 2: Detailed View PATH Column Misalignment
+- **Location:** `lib/appydave/tools/dam/project_listing.rb:121-158`
+- **Problem:** PATH column width (35 chars) too narrow for long project paths (up to 65 chars)
+- **Fix:** Increased column width from 35 to 65 characters
+- **Impact:** Low - cosmetic alignment issue
+
+### Issue 3: Header Alignment Pattern
+- **Location:** 3 locations in `project_listing.rb` (lines 53, 161, 123)
+- **Problem:** Headers used hardcoded strings instead of format(), causing misalignment
+- **Root Cause:** Headers weren't treated as data, leading to manual spacing errors
+- **Fix:** Applied format() to headers using same format strings as data rows
+- **Impact:** Medium - architectural improvement that prevents future alignment issues
+- **Pattern:**
+  ```ruby
+  # Before: Manual header spacing
+  puts 'PROJECT        SIZE    AGE ...'
+
+  # After: Headers treated as data
+  puts format('%-45s %12s %15s ...', 'PROJECT', 'SIZE', 'AGE', ...)
+  ```
+
+### Issue 4: Missing Fuzzy Brand Matching Feature
+- **Location:** `lib/appydave/tools/dam/config.rb:38-45`
+- **Problem:** Feature existed in spec and error classes but wasn't triggered
+- **Fix:** Implemented fuzzy matching using existing FuzzyMatcher class
+- **Implementation:** Checks both brand shortcuts and keys with Levenshtein distance threshold of 3
+- **Impact:** Medium - usability improvement for typos
+
+---
+
+## Code Quality Observations
+
+### Strengths
+1. **Robust error handling** - All edge cases handled gracefully
+2. **Comprehensive feature set** - All planned features working
+3. **Good separation of concerns** - FuzzyMatcher, BrandResolver, Config classes well-structured
+4. **Helpful error messages** - Clear guidance for users
+
+### Improvements Applied
+1. **Consistent formatting pattern** - Headers now use same format() as data
+2. **Fuzzy matching integration** - Better UX for brand typos
+3. **Column width optimization** - Tables now accommodate real-world data
+
+---
+
+## Performance Analysis
+
+| Operation | Time | Projects | Notes |
+|-----------|------|----------|-------|
+| Brand listing | < 1s | 6 brands | Instant response |
+| Project listing | 26.8s | 13 projects | Git/S3 checks per project |
+| Detailed view | 27.4s | 13 projects | Minimal overhead for extra data |
+
+**Performance Bottlenecks:**
+- Git status checks: ~1-2s per project
+- S3 timestamp checks: ~1-2s per project
+- Total: ~26s for 13 projects is acceptable
+
+**Optimization Opportunities (Future):**
+- Parallel git/S3 status checks
+- Caching of git/S3 status (with TTL)
+- Lazy loading for detailed view
+
+---
+
+## Recommendations
+
+### For Release
+✅ **Ready to ship** - All tests passed, issues fixed
+
+### Post-Release Enhancements
+1. **Performance optimization** - Consider parallel status checks for large project counts
+2. **Caching layer** - Cache git/S3 status with 5-minute TTL
+3. **Progress indicators** - Show progress for operations > 5 seconds
+4. **Table width detection** - Auto-adjust column widths based on terminal width
+
+### Documentation Updates
+1. Document the "headers as data" pattern for future table additions
+2. Add performance notes to README (expected ~2s per project)
+3. Update examples with fuzzy matching feature
+
+---
+
+## Test Artifacts
+
+### Files Modified During Testing
+1. `lib/appydave/tools/dam/project_listing.rb` - 3 table formatting fixes
+2. `lib/appydave/tools/dam/config.rb` - Fuzzy matching implementation
+3. `spec/appydave/tools/dam/errors_spec.rb` - RuboCop style fixes (unrelated)
+
+### Test Environment
+- **Ruby Version:** 3.4.2
+- **Bundler Version:** 2.6.2
+- **OS:** macOS Darwin 24.6.0
+- **Working Directory:** `/Users/davidcruwys/dev/ad/appydave-tools`
+- **Video Projects Root:** `/Users/davidcruwys/dev/video-projects`
+
+### Test Data
+- **Brands:** 6 (appydave, aitldr, beauty-and-joy, kiros, supportsignal, voz)
+- **Total Projects:** 29
+- **Total Size:** 24.1 GB
+- **Largest Brand:** appydave (13 projects, 22.4 GB)
+
+---
+
+## Conclusion
+
+**UAT Status:** ✅ **PASSED**
+
+The DAM CLI has successfully passed all 20 user acceptance tests across 4 test suites. All core functionality is preserved, new features are working correctly, edge cases are handled gracefully, and performance is acceptable.
+
+Four issues were identified and fixed during testing:
+1. Table alignment improvements (3 fixes)
+2. Fuzzy matching feature implementation (1 enhancement)
+
+The codebase is production-ready and recommended for release.
+
+**Next Steps:**
+1. ✅ Commit formatting fixes and fuzzy matching implementation
+2. ✅ Run full test suite (`rake spec`) to ensure no regressions
+3. ✅ Update CHANGELOG.md with new features
+4. ✅ Release new version via semantic-release
+
+---
+
+**Report Generated:** 2025-01-22
+**Tested By:** Claude Code (Automated UAT)
+**Approved For Release:** ✅ YES

data/lib/appydave/tools/dam/config.rb

@@ -37,7 +37,12 @@ module Appydave
 
             unless Dir.exist?(path)
               brands_list = available_brands_display
-              raise "Brand directory not found: #{path}\nAvailable brands:\n#{brands_list}"
+              # Use fuzzy matching to suggest similar brands (check both shortcuts and keys)
+              Appydave::Tools::Configuration::Config.configure
+              brands_config = Appydave::Tools::Configuration::Config.brands
+              all_brand_identifiers = brands_config.brands.flat_map { |b| [b.shortcut, b.key] }.uniq
+              suggestions = FuzzyMatcher.find_matches(brand_key, all_brand_identifiers, threshold: 3)
+              raise BrandNotFoundError.new(path, brands_list, suggestions)
             end
 
             path

data/lib/appydave/tools/dam/project_listing.rb

@@ -49,15 +49,26 @@ module Appydave
               )
             end
           else
-            # Default view
-            puts 'BRAND                              KEY          PROJECTS         SIZE        LAST MODIFIED    GIT              S3 SYNC'
-            puts '-' * 130
+            # Default view - use same format for header and data
+            # rubocop:disable Style/RedundantFormat
+            puts format(
+              '%-30s %-15s %10s %12s %20s    %-15s  %-10s',
+              'BRAND',
+              'KEY',
+              'PROJECTS',
+              'SIZE',
+              'LAST MODIFIED',
+              'GIT',
+              'S3 SYNC'
+            )
+            # rubocop:enable Style/RedundantFormat
+            puts '-' * 133
 
             brand_data.each do |data|
               brand_display = "#{data[:shortcut]} - #{data[:name]}"
 
               puts format(
-                '%-30s %-12s %10d %12s %20s    %-15s  %-10s',
+                '%-30s %-15s %10d %12s %20s    %-15s  %-10s',
                 brand_display,
                 data[:key],
                 data[:count],
@@ -119,12 +130,24 @@ module Appydave
           puts ''
 
           if detailed
-            # Detailed view with additional columns
-            header = 'PROJECT                                               SIZE             AGE              GIT              S3           ' \
-                     'PATH                                      HEAVY FILES         LIGHT FILES         SSD BACKUP                      ' \
-                     'S3 ↑ UPLOAD      S3 ↓ DOWNLOAD'
-            puts header
-            puts '-' * 250
+            # Detailed view with additional columns - use same format for header and data
+            # rubocop:disable Style/RedundantFormat
+            puts format(
+              '%-45s %12s %15s  %-15s  %-12s  %-65s  %-18s  %-18s  %-30s  %-15s  %-15s',
+              'PROJECT',
+              'SIZE',
+              'AGE',
+              'GIT',
+              'S3',
+              'PATH',
+              'HEAVY FILES',
+              'LIGHT FILES',
+              'SSD BACKUP',
+              'S3 ↑ UPLOAD',
+              'S3 ↓ DOWNLOAD'
+            )
+            # rubocop:enable Style/RedundantFormat
+            puts '-' * 280
 
             project_data.each do |data|
               age_display = data[:stale] ? "#{data[:age]} ⚠️" : data[:age]
@@ -132,7 +155,7 @@ module Appydave
               s3_download = data[:s3_last_download] ? format_age(data[:s3_last_download]) : 'N/A'
 
               puts format(
-                '%-45s %12s %15s  %-15s  %-12s  %-35s  %-18s  %-18s  %-30s  %-15s  %-15s',
+                '%-45s %12s %15s  %-15s  %-12s  %-65s  %-18s  %-18s  %-30s  %-15s  %-15s',
                 data[:name],
                 format_size(data[:size]),
                 age_display,
@@ -147,8 +170,17 @@ module Appydave
               )
             end
           else
-            # Default view
-            puts 'PROJECT                                               SIZE             AGE              GIT              S3'
+            # Default view - use same format for header and data
+            # rubocop:disable Style/RedundantFormat
+            puts format(
+              '%-45s %12s %15s  %-15s  %-12s',
+              'PROJECT',
+              'SIZE',
+              'AGE',
+              'GIT',
+              'S3'
+            )
+            # rubocop:enable Style/RedundantFormat
             puts '-' * 130
 
             project_data.each do |data|

data/lib/appydave/tools/version.rb

@@ -2,6 +2,6 @@
 
 module Appydave
   module Tools
-    VERSION = '0.68.0'
+    VERSION = '0.69.0'
   end
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "appydave-tools",
-  "version": "0.68.0",
+  "version": "0.69.0",
   "description": "AppyDave YouTube Automation Tools",
   "scripts": {
     "release": "semantic-release"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appydave-tools
 version: !ruby/object:Gem::Version
-  version: 0.68.0
+  version: 0.69.0
 platform: ruby
 authors:
 - David Cruwys
@@ -256,6 +256,7 @@ files:
 - docs/code-quality/implementation-plan.md
 - docs/code-quality/report-2025-01-21.md
 - docs/code-quality/uat-plan-2025-01-22.md
+- docs/code-quality/uat-report-2025-01-22.md
 - docs/guides/configuration-setup.md
 - docs/guides/platforms/windows/README.md
 - docs/guides/platforms/windows/dam-testing-plan-windows-powershell.md