appydave-tools 0.36.0 → 0.38.0

data/lib/appydave/tools/dam/repo_status.rb

@@ -107,49 +107,32 @@ module Appydave
         end
 
         def current_branch
-          `git -C "#{brand_path}" rev-parse --abbrev-ref HEAD 2>/dev/null`.strip
-        rescue StandardError
-          'unknown'
+          GitHelper.current_branch(brand_path)
         end
 
         def remote_url
-          result = `git -C "#{brand_path}" remote get-url origin 2>/dev/null`.strip
-          result.empty? ? nil : result
-        rescue StandardError
-          nil
+          GitHelper.remote_url(brand_path)
         end
 
         def modified_files_count
-          `git -C "#{brand_path}" status --porcelain 2>/dev/null | grep -E "^.M|^M" | wc -l`.strip.to_i
-        rescue StandardError
-          0
+          GitHelper.modified_files_count(brand_path)
         end
 
         def untracked_files_count
-          `git -C "#{brand_path}" status --porcelain 2>/dev/null | grep -E "^\\?\\?" | wc -l`.strip.to_i
-        rescue StandardError
-          0
+          GitHelper.untracked_files_count(brand_path)
         end
 
         def commits_ahead
-          `git -C "#{brand_path}" rev-list --count @{upstream}..HEAD 2>/dev/null`.strip.to_i
-        rescue StandardError
-          0
+          GitHelper.commits_ahead(brand_path)
         end
 
         def commits_behind
-          `git -C "#{brand_path}" rev-list --count HEAD..@{upstream} 2>/dev/null`.strip.to_i
-        rescue StandardError
-          0
+          GitHelper.commits_behind(brand_path)
         end
 
         # Check if repo has uncommitted changes (matches old script: git diff-index --quiet HEAD --)
         def uncommitted_changes?
-          # git diff-index returns 0 if clean, 1 if there are changes
-          system("git -C \"#{brand_path}\" diff-index --quiet HEAD -- 2>/dev/null")
-          !$CHILD_STATUS.success?
-        rescue StandardError
-          false
+          GitHelper.uncommitted_changes?(brand_path)
         end
 
         # Show file list using git status --short (matches old script)

data/lib/appydave/tools/dam/s3_operations.rb

@@ -768,11 +768,7 @@ module Appydave
 
         # Calculate total size of a directory
         def calculate_directory_size(dir_path)
-          total = 0
-          Dir.glob(File.join(dir_path, '**', '*'), File::FNM_DOTMATCH).each do |file|
-            total += File.size(file) if File.file?(file)
-          end
-          total
+          FileHelper.calculate_directory_size(dir_path)
         end
       end
     end

data/lib/appydave/tools/dam/status.rb

@@ -241,40 +241,27 @@ module Appydave
         end
 
         def current_branch
-          `git -C "#{brand_path}" rev-parse --abbrev-ref HEAD 2>/dev/null`.strip
-        rescue StandardError
-          'unknown'
+          GitHelper.current_branch(brand_path)
         end
 
         def remote_url
-          result = `git -C "#{brand_path}" remote get-url origin 2>/dev/null`.strip
-          result.empty? ? nil : result
-        rescue StandardError
-          nil
+          GitHelper.remote_url(brand_path)
         end
 
         def modified_files_count
-          `git -C "#{brand_path}" status --porcelain 2>/dev/null | grep -E "^.M|^M" | wc -l`.strip.to_i
-        rescue StandardError
-          0
+          GitHelper.modified_files_count(brand_path)
         end
 
         def untracked_files_count
-          `git -C "#{brand_path}" status --porcelain 2>/dev/null | grep -E "^\\?\\?" | wc -l`.strip.to_i
-        rescue StandardError
-          0
+          GitHelper.untracked_files_count(brand_path)
         end
 
         def commits_ahead
-          `git -C "#{brand_path}" rev-list --count @{upstream}..HEAD 2>/dev/null`.strip.to_i
-        rescue StandardError
-          0
+          GitHelper.commits_ahead(brand_path)
         end
 
         def commits_behind
-          `git -C "#{brand_path}" rev-list --count HEAD..@{upstream} 2>/dev/null`.strip.to_i
-        rescue StandardError
-          0
+          GitHelper.commits_behind(brand_path)
         end
       end
     end

data/lib/appydave/tools/dam/sync_from_ssd.rb

@@ -268,13 +268,7 @@ module Appydave
 
         # Format bytes into human-readable format
         def format_bytes(bytes)
-          if bytes < 1024
-            "#{bytes}B"
-          elsif bytes < 1024 * 1024
-            "#{(bytes / 1024.0).round(1)}KB"
-          else
-            "#{(bytes / 1024.0 / 1024.0).round(1)}MB"
-          end
+          FileHelper.format_size(bytes)
         end
       end
     end

data/lib/appydave/tools/version.rb

@@ -2,6 +2,6 @@
 
 module Appydave
   module Tools
-    VERSION = '0.36.0'
+    VERSION = '0.38.0'
   end
 end

data/lib/appydave/tools.rb

@@ -52,6 +52,9 @@ require 'appydave/tools/prompt_tools/prompt_completion'
 require 'appydave/tools/subtitle_processor/clean'
 require 'appydave/tools/subtitle_processor/join'
 
+require 'appydave/tools/dam/errors'
+require 'appydave/tools/dam/file_helper'
+require 'appydave/tools/dam/git_helper'
 require 'appydave/tools/dam/config'
 require 'appydave/tools/dam/project_resolver'
 require 'appydave/tools/dam/config_loader'

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "appydave-tools",
-  "version": "0.36.0",
+  "version": "0.38.0",
   "description": "AppyDave YouTube Automation Tools",
   "scripts": {
     "release": "semantic-release"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appydave-tools
 version: !ruby/object:Gem::Version
-  version: 0.36.0
+  version: 0.38.0
 platform: ruby
 authors:
 - David Cruwys
@@ -228,6 +228,8 @@ files:
 - bin/youtube_automation.rb
 - bin/youtube_manager.rb
 - docs/README.md
+- docs/ai-instructions/code-quality-retrospective.md
+- docs/ai-instructions/defensive-logging-audit.md
 - docs/architecture/cli/cli-pattern-comparison.md
 - docs/architecture/cli/cli-patterns.md
 - docs/architecture/configuration/configuration-systems.md
@@ -248,6 +250,9 @@ files:
 - docs/archive/test-coverage-quick-wins.md
 - docs/archive/tool-discovery.md
 - docs/archive/tool-documentation-analysis.md
+- docs/code-quality/README.md
+- docs/code-quality/implementation-plan.md
+- docs/code-quality/report-2025-01-21.md
 - docs/guides/configuration-setup.md
 - docs/guides/platforms/windows/README.md
 - docs/guides/platforms/windows/dam-testing-plan-windows-powershell.md
@@ -294,6 +299,9 @@ files:
 - lib/appydave/tools/configuration/openai.rb
 - lib/appydave/tools/dam/config.rb
 - lib/appydave/tools/dam/config_loader.rb
+- lib/appydave/tools/dam/errors.rb
+- lib/appydave/tools/dam/file_helper.rb
+- lib/appydave/tools/dam/git_helper.rb
 - lib/appydave/tools/dam/manifest_generator.rb
 - lib/appydave/tools/dam/project_listing.rb
 - lib/appydave/tools/dam/project_resolver.rb