appydave-tools 0.35.0 → 0.37.0

data/lib/appydave/tools/configuration/config.rb

@@ -25,7 +25,13 @@ module Appydave
 
           def register(key, klass)
             @configurations ||= {}
-            @configurations[key] = klass.new
+            # Only create new instance if not already registered (prevents multiple reloads)
+            @configurations[key] ||= klass.new
+          end
+
+          # Reset all configurations (primarily for testing)
+          def reset
+            @configurations = nil
           end
 
           def method_missing(method_name, *_args)

data/lib/appydave/tools/configuration/models/brands_config.rb

@@ -10,10 +10,27 @@ module Appydave
           def get_brand(brand_key)
             brand_key_str = brand_key.to_s
 
+            log.info "Looking up brand: '#{brand_key_str}'" if debug_mode?
+
+            # Validate data structure
+            unless data.is_a?(Hash)
+              log.error "Config data is not a Hash: #{data.class}"
+              raise "Invalid brands config: data is #{data.class}, expected Hash"
+            end
+
+            unless data['brands'].is_a?(Hash)
+              log.error "Config data['brands'] is #{data['brands'].class}, expected Hash"
+              log.error "Available keys in data: #{data.keys.inspect}"
+              raise "Invalid brands config: 'brands' key is #{data['brands'].class}, expected Hash"
+            end
+
+            log.info "Available brands: #{data['brands'].keys.inspect}" if debug_mode?
+
             # Try direct key lookup first (case-insensitive)
             brand_entry = data['brands'].find { |key, _info| key.downcase == brand_key_str.downcase }
             if brand_entry
               actual_key = brand_entry[0]
+              log.info "Found brand by key: '#{actual_key}'" if debug_mode?
               return BrandInfo.new(actual_key, brand_entry[1])
             end
 
@@ -21,10 +38,12 @@ module Appydave
             brand_entry = data['brands'].find { |_key, info| info['shortcut']&.downcase == brand_key_str.downcase }
             if brand_entry
               actual_key = brand_entry[0]
+              log.info "Found brand by shortcut: '#{actual_key}'" if debug_mode?
               return BrandInfo.new(actual_key, brand_entry[1])
             end
 
             # Return default if not found (use normalized lowercase key)
+            log.warn "Brand not found: '#{brand_key_str}', returning default" if debug_mode?
             BrandInfo.new(brand_key_str.downcase, default_brand_info)
           end
 

data/lib/appydave/tools/configuration/models/config_base.rb

@@ -30,11 +30,31 @@ module Appydave
           end
 
           def load
-            return JSON.parse(File.read(config_path)) if File.exist?(config_path)
+            if debug_mode?
+              log.info "Loading config: #{config_name}"
+              log.info "Config path: #{config_path}"
+              log.info "File exists: #{File.exist?(config_path)}"
+            end
+
+            unless File.exist?(config_path)
+              log.warn "Config file not found: #{config_path}" if debug_mode?
+              return default_data
+            end
 
+            content = File.read(config_path)
+            log.info "Config file size: #{content.bytesize} bytes" if debug_mode?
+
+            data = JSON.parse(content)
+            log.info "Config loaded successfully: #{config_name}" if debug_mode?
+            log.json data if debug_mode?
+            data
+          rescue JSON::ParserError => e
+            log.error "JSON parse error in #{config_path}: #{e.message}"
+            log.error "File content preview: #{content[0..200]}" if content
             default_data
-          rescue JSON::ParserError
-            # log.exception e
+          rescue StandardError => e
+            log.error "Error loading #{config_path}: #{e.message}"
+            log.error e.backtrace.first(3).join("\n") if debug_mode?
             default_data
           end
 
@@ -55,6 +75,10 @@ module Appydave
 
           private
 
+          def debug_mode?
+            ENV['DAM_DEBUG'] == 'true' || ENV['DEBUG'] == 'true'
+          end
+
           def default_data
             {}
           end

data/lib/appydave/tools/dam/project_resolver.rb

@@ -109,22 +109,24 @@ module Appydave
           end
 
           # Detect brand and project from current directory
-          # @return [Array<String, String>] [brand, project] or [nil, nil]
+          # @return [Array<String, String>] [brand_key, project] or [nil, nil]
           def detect_from_pwd
             current = Dir.pwd
 
             # Check if we're inside a v-* directory
             if current =~ %r{/(v-[^/]+)/([^/]+)/?}
-              brand = ::Regexp.last_match(1)
-              project = ::Regexp.last_match(2)
-              return [brand, project] if project_exists?(brand, project)
+              brand_with_prefix = ::Regexp.last_match(1)
+              project = ::Regexp.last_match(2) # Capture BEFORE .sub() which resets Regexp.last_match
+              # Strip 'v-' prefix to get brand key (e.g., 'v-supportsignal' → 'supportsignal')
+              brand_key = brand_with_prefix.sub(/^v-/, '')
+              return [brand_key, project] if project_exists?(brand_key, project)
             end
 
             [nil, nil]
           end
 
           # Check if project exists in brand directory
-          # @param brand [String] Brand name (v-appydave format)
+          # @param brand [String] Brand key (e.g., 'appydave', 'supportsignal')
           # @param project [String] Project name
           # @return [Boolean] true if project directory exists
           def project_exists?(brand, project)

data/lib/appydave/tools/version.rb

@@ -2,6 +2,6 @@
 
 module Appydave
   module Tools
-    VERSION = '0.35.0'
+    VERSION = '0.37.0'
   end
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "appydave-tools",
-  "version": "0.35.0",
+  "version": "0.37.0",
   "description": "AppyDave YouTube Automation Tools",
   "scripts": {
     "release": "semantic-release"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appydave-tools
 version: !ruby/object:Gem::Version
-  version: 0.35.0
+  version: 0.37.0
 platform: ruby
 authors:
 - David Cruwys
@@ -228,6 +228,8 @@ files:
 - bin/youtube_automation.rb
 - bin/youtube_manager.rb
 - docs/README.md
+- docs/ai-instructions/code-quality-retrospective.md
+- docs/ai-instructions/defensive-logging-audit.md
 - docs/architecture/cli/cli-pattern-comparison.md
 - docs/architecture/cli/cli-patterns.md
 - docs/architecture/configuration/configuration-systems.md