appydave-tools 0.33.0 → 0.34.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7dae60a45e72f5c3a8b551750c4728a037ee8584b436989dd700daa78f3ee8a1
-  data.tar.gz: 7b26dbf29f2d47524832504a2ef5fd2a021efd9a458a61477a19dccd22a56fb0
+  metadata.gz: '0822e53f40e94e9d3c113babd747f20676c51706e0fcb8c7d4f73ab30dba1264'
+  data.tar.gz: fe3f9dc1576f199f0194e298e60330f56542ed235a65808c6edaacc6079a822e
 SHA512:
-  metadata.gz: 36090c84bffcf2e1e0dc581b8af16d3adc2e2a89eaf2a0c47a264479006d7365b8099ee1998ec6b15e360797108bb42632b09edeadef84479f2c1d8734f401d8
-  data.tar.gz: 84e6011c4bc9ad9d4ec692b147d82542df34413a4faccd7056964bf6c5b2ae394328368db6a4b7a9f7c12f10503fd3a56f30476212f06733a6fbe70dc9f359ea
+  metadata.gz: 5ec28829f3743f5fae51f54d7a387c2c2e22a79674d94c7e9af8230f0c4f0e32bbb4cfeb7e668077a68c19cad310397d81144fb78d915641636894fef8af4e24
+  data.tar.gz: cad3a37461ad7158b6e44711dd3e8b3e2b34ddc70ae95b038c9e4794c072fd7326f8a9d7ee0c19e1c0ffbc6ec2f66e2a26cd3589f8cd01a0ac7f991c60824aa3

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# [0.33.0](https://github.com/appydave/appydave-tools/compare/v0.32.5...v0.33.0) (2025-11-21)
+
+
+### Features
+
+* add orphaned S3 folder detection in s3-scan command - separates matched projects from orphaned folders with file count and size info for easier cleanup identification ([3aa03aa](https://github.com/appydave/appydave-tools/commit/3aa03aab5e57ca55015d226b39fcb4f3203d4ca4))
+
 ## [0.32.5](https://github.com/appydave/appydave-tools/compare/v0.32.4...v0.32.5) (2025-11-21)
 
 

data/bin/dam

@@ -1125,7 +1125,7 @@ class VatCLI
     exit 1
   end
 
-  # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+  # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/AbcSize
   def scan_single_brand_s3(brand_arg)
     puts "🔄 Scanning S3 for #{brand_arg}..."
     puts ''
@@ -1133,11 +1133,30 @@ class VatCLI
     brand_key = brand_arg
     scanner = Appydave::Tools::Dam::S3Scanner.new(brand_key)
 
-    # Scan all projects
-    results = scanner.scan_all_projects
+    # Get brand info for S3 path
+    Appydave::Tools::Configuration::Config.configure
+    brand_info = Appydave::Tools::Configuration::Config.brands.get_brand(brand_key)
+    bucket = brand_info.aws.s3_bucket
+    prefix = brand_info.aws.s3_prefix
+    region = brand_info.aws.region
+
+    # Spinner characters for progress
+    spinner_chars = ['⠋', '⠙', '⠹', '⠸', '⠼', '⠴', '⠦', '⠧', '⠇', '⠏']
+    spinner_index = 0
+
+    print "🔍 Scanning s3://#{bucket}/#{prefix}\n"
+    print '    Scanning projects... '
+
+    # Scan all projects with progress callback
+    results = scanner.scan_all_projects(show_progress: false) do |current, total|
+      print "\r    Scanning projects... #{spinner_chars[spinner_index]} (#{current}/#{total})"
+      spinner_index = (spinner_index + 1) % spinner_chars.length
+    end
+
+    print "\r    Scanning projects... ✓ (#{results.size} found)\n"
+    puts ''
 
     if results.empty?
-      puts ''
       puts "⚠️  No projects found in S3 for #{brand_key}"
       puts '   This may indicate:'
       puts '   - No files uploaded to S3 yet'
@@ -1147,12 +1166,10 @@ class VatCLI
     end
 
     # Load existing manifest
-    Appydave::Tools::Configuration::Config.configure
     brand_path = Appydave::Tools::Dam::Config.brand_path(brand_key)
     manifest_path = File.join(brand_path, 'projects.json')
 
     unless File.exist?(manifest_path)
-      puts ''
       puts "❌ Manifest not found: #{manifest_path}"
       puts "   Run: dam manifest #{brand_key}"
       puts "   Then retry: dam s3-scan #{brand_key}"
@@ -1163,8 +1180,8 @@ class VatCLI
 
     # Identify matched and orphaned S3 projects
     local_project_ids = manifest[:projects].map { |p| p[:id] }
-    matched_s3_projects = results.keys.select { |project_id| local_project_ids.include?(project_id) }
-    orphaned_s3_projects = results.keys.reject { |project_id| local_project_ids.include?(project_id) }
+    matched_projects = results.slice(*local_project_ids)
+    orphaned_projects = results.reject { |project_id, _| local_project_ids.include?(project_id) }
 
     # Merge S3 scan data into manifest for matched projects
     updated_count = 0
@@ -1184,37 +1201,68 @@ class VatCLI
     # Write updated manifest
     File.write(manifest_path, JSON.pretty_generate(manifest))
 
+    # Display table
+    display_s3_scan_table(matched_projects, orphaned_projects, bucket, prefix, region)
+
+    # Summary
     total_manifest_projects = manifest[:projects].size
+    missing_count = total_manifest_projects - matched_projects.size
 
     puts ''
-    puts "✅ Updated manifest with S3 data: #{manifest_path}"
-    puts "   Projects in S3: #{results.size}"
-    puts "   Projects in manifest: #{total_manifest_projects}"
-    puts "   Updated #{updated_count} projects in manifest"
+    puts 'ℹ️  Summary:'
+    puts "   • Updated #{updated_count} projects in manifest"
+    puts "   • #{missing_count} local project(s) not yet uploaded to S3" if missing_count.positive?
+    puts "   • Manifest: #{manifest_path}"
+    puts ''
+  end
+  # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/AbcSize
 
-    if orphaned_s3_projects.any?
-      puts ''
-      puts '   ⚠️  Orphaned S3 folders (no local project):'
-      orphaned_s3_projects.each do |project_id|
-        s3_data = results[project_id]
-        size = format_bytes(s3_data[:total_bytes])
-        puts "      - #{project_id} (#{s3_data[:file_count]} files, #{size})"
-      end
-      puts ''
-      puts '   These folders exist in S3 but have no corresponding local project.'
-      puts '   Consider cleaning them up with: dam s3-cleanup'
+  # Display S3 scan results in table format
+  # rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Style/FormatStringToken
+  def display_s3_scan_table(matched_projects, orphaned_projects, bucket, prefix, region)
+    puts '✅ S3 Projects Report'
+    puts ''
+    puts 'PROJECT                    FILES    SIZE        STATUS    LAST MODIFIED'
+    puts '-' * 80
+
+    # Display matched projects first (sorted alphabetically)
+    matched_projects.sort.each do |project_id, data|
+      files = data[:file_count].to_s.rjust(5)
+      size = format_bytes(data[:total_bytes]).rjust(10)
+      status = '✓'
+      modified = data[:last_modified] ? Time.parse(data[:last_modified]).strftime('%Y-%m-%d %H:%M') : 'N/A'
+
+      puts format('%-26s %5s %10s       %s       %s', project_id, files, size, status, modified)
     end
 
-    if matched_s3_projects.size < total_manifest_projects
-      missing_count = total_manifest_projects - matched_s3_projects.size
-      puts ''
-      puts "   ℹ️  #{missing_count} local project(s) not yet uploaded to S3"
+    # Display orphaned projects (sorted alphabetically)
+    return if orphaned_projects.empty?
+
+    puts '-' * 80
+    orphaned_projects.sort.each do |project_id, data|
+      files = data[:file_count].to_s.rjust(5)
+      size = format_bytes(data[:total_bytes]).rjust(10)
+      status = '❌'
+      modified = data[:last_modified] ? Time.parse(data[:last_modified]).strftime('%Y-%m-%d %H:%M') : 'N/A'
+
+      puts format('%-26s %5s %10s       %s       %s', project_id, files, size, status, modified)
     end
+
     puts ''
+    folder_word = orphaned_projects.size > 1 ? 'folders' : 'folder'
+    puts "⚠️  #{orphaned_projects.size} orphaned #{folder_word} found (no local project)"
+
+    orphaned_projects.sort.each do |project_id, _data|
+      # Build AWS Console URL
+      project_prefix = "#{prefix}#{project_id}/"
+      console_url = "https://#{region}.console.aws.amazon.com/s3/buckets/#{bucket}?prefix=#{project_prefix}&region=#{region}"
+      puts "   → #{project_id}"
+      puts "     #{console_url}"
+    end
   end
-  # rubocop:enable Metrics/MethodLength
+  # rubocop:enable Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Style/FormatStringToken
 
-  # rubocop:disable Metrics/MethodLength
+  # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
   def scan_all_brands_s3
     Appydave::Tools::Configuration::Config.configure
     brands_config = Appydave::Tools::Configuration::Config.brands
@@ -1255,7 +1303,7 @@ class VatCLI
     puts ''
     puts "Total brands scanned: #{successful.size}/#{results.size}"
   end
-  # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+  # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
   # Format bytes in human-readable format
   # rubocop:disable Style/FormatStringToken

data/lib/appydave/tools/dam/s3_scanner.rb

@@ -17,12 +17,13 @@ module Appydave
 
         # Scan S3 for a specific project
         # @param project_id [String] Project ID (e.g., "b65-guy-monroe-marketing-plan")
+        # @param show_progress [Boolean] Whether to show progress output (default: true)
         # @return [Hash] S3 file data with :file_count, :total_bytes, :last_modified
-        def scan_project(project_id)
+        def scan_project(project_id, show_progress: true)
           bucket = @brand_info.aws.s3_bucket
           prefix = File.join(@brand_info.aws.s3_prefix, project_id, '')
 
-          puts "  🔍 Scanning #{project_id}..."
+          puts "  🔍 Scanning #{project_id}..." if show_progress
 
           files = list_s3_objects(bucket, prefix)
 
@@ -50,28 +51,23 @@ module Appydave
         end
 
         # Scan all projects in brand's S3 bucket
+        # @param show_progress [Boolean] Whether to show detailed progress (default: true)
         # @return [Hash] Map of project_id => scan result
-        def scan_all_projects
+        def scan_all_projects(show_progress: true, &progress_callback)
           bucket = @brand_info.aws.s3_bucket
           prefix = @brand_info.aws.s3_prefix
 
-          puts "🔍 Scanning all projects in S3: s3://#{bucket}/#{prefix}"
-          puts ''
-
           # List all "directories" (prefixes) under brand prefix
           project_prefixes = list_s3_prefixes(bucket, prefix)
 
-          if project_prefixes.empty?
-            puts '  📭 No projects found in S3'
-            return {}
-          end
-
-          puts "  Found #{project_prefixes.size} projects in S3"
-          puts ''
+          return {} if project_prefixes.empty?
 
           results = {}
-          project_prefixes.each do |project_id|
-            results[project_id] = scan_project(project_id)
+          project_prefixes.each_with_index do |project_id, index|
+            # Call progress callback if provided (for spinner)
+            progress_callback&.call(index + 1, project_prefixes.size)
+
+            results[project_id] = scan_project(project_id, show_progress: show_progress)
           end
 
           results

data/lib/appydave/tools/version.rb

@@ -2,6 +2,6 @@
 
 module Appydave
   module Tools
-    VERSION = '0.33.0'
+    VERSION = '0.34.0'
   end
 end

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "appydave-tools",
-  "version": "0.33.0",
+  "version": "0.34.0",
   "description": "AppyDave YouTube Automation Tools",
   "scripts": {
     "release": "semantic-release"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appydave-tools
 version: !ruby/object:Gem::Version
-  version: 0.33.0
+  version: 0.34.0
 platform: ruby
 authors:
 - David Cruwys