appydave-tools 0.20.0 → 0.21.0

data/docs/dam/dam-testing-plan.md

@@ -1,13 +1,13 @@
 # DAM (Digital Asset Management) - Integration Testing Plan
 
-**Date**: 2025-11-08
+**Date**: 2025-11-10
 **Purpose**: Validate DAM integration into appydave-tools gem
 **Tester**: David Cruwys
 **Status**: Ready for User Acceptance Testing
 
 **Reference**: Original UAT plan at `/Users/davidcruwys/dev/video-projects/video-asset-tools/docs/testing-plan.md`
 
-**Windows Testing**: See [windows-testing-guide.md](./windows-testing-guide.md) for Windows-specific testing scenarios
+**Windows Testing**: See [dam-testing-plan-windows-powershell.md](./dam-testing-plan-windows-powershell.md) for Windows-specific testing scenarios
 
 ---
 
@@ -37,25 +37,17 @@
 - ✅ `dam archive` - Archive to SSD with dry-run and force options
 - ✅ `dam sync-ssd` - Restore light files from SSD (dry-run supported)
 
-**Git Repository Management Scripts - Intentionally Not Migrated**:
+**Commands - Phase 4 Complete** (Status & Git Integration):
+- ✅ `dam status` - Unified status view (local/S3/SSD/git)
+- ✅ `dam repo-status` - Git status for brand repositories (supports `--all`)
+- ✅ `dam repo-sync` - Pull updates for brand repositories (supports `--all`)
+- ✅ `dam repo-push` - Push changes for brand repository (optional project validation)
 
-These are **shell scripts** for managing the multi-repo video-projects git structure, NOT video asset management commands:
-
-- ❌ `status-all.sh` - Runs `git status` on all v-* brand repos (git workflow, not asset management)
-- ❌ `sync-all.sh` - Runs `git pull` on all v-* brand repos (git workflow, not asset management)
-- ❌ `clone-all.sh` - Clones all v-* brand repos if missing (git workflow, not asset management)
-
-**Why not migrated:**
-1. These manage **git repositories**, not **video assets**
-2. They loop through brand folders running git commands
-3. They're workflow automation for the video-projects repo structure
-4. They belong in `/video-projects/v-shared/`, not in the appydave-tools gem
-5. Different use case: repo management vs. video file management
-
-**If you want these migrated:** We could add `dam repo-status`, `dam repo-sync`, `dam repo-clone` commands, but they would:
-- Need Ruby implementations of multi-repo git operations
-- Duplicate functionality that shell scripts handle well
-- Mix concerns (video assets vs. git repos)
+**New Manifest Fields (Phase 4)**:
+- ✅ `git_remote` - Self-healing git remote URL detection in brands.json
+- ✅ `s3: { exists: true/false }` - S3 staging folder tracking in manifest
+- ✅ `type: 'flivideo' | 'storyline-app'` - Project type detection
+- ✅ `hasStorylineJson: true/false` - Storyline project identification
 
 ---
 
@@ -150,10 +142,19 @@ These commands only read data and don't modify files:
 | Command | Type | What It Does |
 |---------|------|--------------|
 | **list** | Read-only | List brands/projects |
+| **status** | Read-only | Show unified status (local/S3/SSD/git) |
+| **repo-status** | Read-only | Check git status for brand repos |
 | **manifest** | Generates JSON | Generate `projects.json` manifest |
 | **s3-status** | Read-only | Check sync status |
 | **help** | Read-only | Show help information |
 
+### Git Commands (Special Behavior)
+
+| Command | Type | What It Does | Safety Features |
+|---------|------|--------------|-----------------|
+| **repo-sync** | Modifies (git pull) | Pull updates for brand repos | Skips if uncommitted changes |
+| **repo-push** | Modifies (git push) | Push changes for brand repo | Warns if uncommitted changes, optional project validation |
+
 ### Force Flag Behavior
 
 Commands requiring `--force` provide extra protection for destructive operations:
@@ -244,14 +245,14 @@ bundle exec rspec spec/appydave/tools/dam/config_loader_spec.rb
 #### Test 2.1: Help System
 ```bash
 # Test: Main help
-bin/dam help
+dam help
 
 # Test: Command-specific help
-bin/dam help list
-bin/dam help s3-up
-bin/dam help s3-down
-bin/dam help brands
-bin/dam help workflows
+dam help list
+dam help s3-up
+dam help s3-down
+dam help brands
+dam help workflows
 ```
 **Expected**:
 - Full help overview
@@ -264,40 +265,22 @@ bin/dam help workflows
 
 ---
 
-#### Test 2.3: List Brands (Mode 1)
-```bash
-# Test: List brands only
-bin/dam list
-```
-**Expected**: `Brands: aitldr, appydave, joy, kiros, ss, voz` (shortcuts)
-
-**Status**: [ ] Pass [ ] Fail
-**Notes**: ___________________________________________
-
----
-
-#### Test 2.4: List Brands with Summary (Mode 2)
+#### Test 2.3: List Brands
 ```bash
-# Test: Brands with project counts
-bin/dam list --summary
-```
-**Expected**:
-```
-aitldr: X projects
-appydave: Y projects
-joy: Z projects
-...
+# Test: List all brands with project counts
+dam list
 ```
+**Expected**: Tabular output showing all brands with project counts, sizes, and paths
 
 **Status**: [ ] Pass [ ] Fail
 **Notes**: ___________________________________________
 
 ---
 
-#### Test 2.5: List Brand Projects (Mode 3)
+#### Test 2.4: List Brand Projects
 ```bash
 # Test: All projects for brand
-bin/dam list appydave
+dam list appydave
 ```
 **Expected**: List of all appydave projects (excludes `archived/`, `.git`, etc.)
 
@@ -306,10 +289,10 @@ bin/dam list appydave
 
 ---
 
-#### Test 2.6: Pattern Matching (Mode 3b)
+#### Test 2.5: Pattern Matching
 ```bash
 # Test: Pattern matching
-bin/dam list appydave 'b6*'
+dam list appydave 'b6*'
 ```
 **Expected**: Only projects starting with `b6` (b60-b69)
 
@@ -318,7 +301,7 @@ bin/dam list appydave 'b6*'
 
 ---
 
-#### Test 2.7: S3 Upload with CLI Args
+#### Test 2.6: S3 Upload with CLI Args
 ```bash
 # Test: Upload with explicit args (dry-run)
 bin/s3_sync_up.rb appydave b65 --dry-run
@@ -330,7 +313,7 @@ bin/s3_sync_up.rb appydave b65 --dry-run
 
 ---
 
-#### Test 2.8: S3 Upload Auto-Detect
+#### Test 2.7: S3 Upload Auto-Detect
 ```bash
 # Test: Upload from project directory
 cd ~/dev/video-projects/v-appydave/b65-*
@@ -343,7 +326,7 @@ bin/s3_sync_up.rb --dry-run
 
 ---
 
-#### Test 2.9: S3 Download with CLI Args ⭐ NEW
+#### Test 2.8: S3 Download with CLI Args ⭐ NEW
 ```bash
 # Test: Download with explicit args (dry-run)
 bin/s3_sync_down.rb appydave b65 --dry-run
@@ -355,7 +338,7 @@ bin/s3_sync_down.rb appydave b65 --dry-run
 
 ---
 
-#### Test 2.10: S3 Download Auto-Detect ⭐ NEW
+#### Test 2.9: S3 Download Auto-Detect ⭐ NEW
 ```bash
 # Test: Download from project directory
 cd ~/dev/video-projects/v-appydave/b65-*
@@ -368,7 +351,7 @@ bin/s3_sync_down.rb --dry-run
 
 ---
 
-#### Test 2.11: S3 Status with CLI Args ⭐ NEW
+#### Test 2.10: S3 Status with CLI Args ⭐ NEW
 ```bash
 # Test: Check status with explicit args
 bin/s3_sync_status.rb appydave b65
@@ -380,7 +363,7 @@ bin/s3_sync_status.rb appydave b65
 
 ---
 
-#### Test 2.12: S3 Status Auto-Detect ⭐ NEW
+#### Test 2.11: S3 Status Auto-Detect ⭐ NEW
 ```bash
 # Test: Check status from project directory
 cd ~/dev/video-projects/v-appydave/b65-*
@@ -393,7 +376,7 @@ bin/s3_sync_status.rb
 
 ---
 
-#### Test 2.13: S3 Cleanup with CLI Args ⭐ NEW
+#### Test 2.12: S3 Cleanup with CLI Args ⭐ NEW
 ```bash
 # Test: Cleanup with explicit args (dry-run)
 bin/s3_sync_cleanup.rb appydave b65 --dry-run
@@ -405,7 +388,7 @@ bin/s3_sync_cleanup.rb appydave b65 --dry-run
 
 ---
 
-#### Test 2.14: S3 Cleanup Auto-Detect ⭐ NEW
+#### Test 2.13: S3 Cleanup Auto-Detect ⭐ NEW
 ```bash
 # Test: Cleanup from project directory
 cd ~/dev/video-projects/v-appydave/b65-*
@@ -418,6 +401,102 @@ bin/s3_sync_cleanup.rb --dry-run
 
 ---
 
+#### Test 2.14: Status - Brand Overview ⭐ PHASE 4
+```bash
+# Test: Show unified status for entire brand
+dam status appydave
+```
+**Expected**: Shows brand git status, manifest summary (total projects, local, S3, SSD counts)
+
+**Status**: [ ] Pass [ ] Fail
+**Notes**: ___________________________________________
+
+---
+
+#### Test 2.15: Status - Specific Project ⭐ PHASE 4
+```bash
+# Test: Show detailed status for specific project
+dam status appydave b65
+```
+**Expected**: Shows storage locations (local, S3 staging, SSD backup) and git status for project
+
+**Status**: [ ] Pass [ ] Fail
+**Notes**: ___________________________________________
+
+---
+
+#### Test 2.16: Repo Status - Single Brand ⭐ PHASE 4
+```bash
+# Test: Show git status for single brand
+dam repo-status appydave
+```
+**Expected**: Shows branch, remote, working directory status, sync status
+
+**Status**: [ ] Pass [ ] Fail
+**Notes**: ___________________________________________
+
+---
+
+#### Test 2.17: Repo Status - All Brands ⭐ PHASE 4
+```bash
+# Test: Show git status for all brands
+dam repo-status --all
+```
+**Expected**: Shows git status for all configured brands (appydave, voz, aitldr, etc.)
+
+**Status**: [ ] Pass [ ] Fail
+**Notes**: ___________________________________________
+
+---
+
+#### Test 2.18: Repo Sync - Single Brand ⭐ PHASE 4
+```bash
+# Test: Pull updates for single brand
+dam repo-sync appydave
+```
+**Expected**: Pulls updates if available, skips if uncommitted changes, shows status
+
+**Status**: [ ] Pass [ ] Fail
+**Notes**: ___________________________________________
+
+---
+
+#### Test 2.19: Repo Sync - All Brands ⭐ PHASE 4
+```bash
+# Test: Pull updates for all brands
+dam repo-sync --all
+```
+**Expected**: Syncs all brands, shows summary, skips brands with uncommitted changes
+
+**Status**: [ ] Pass [ ] Fail
+**Notes**: ___________________________________________
+
+---
+
+#### Test 2.20: Repo Push - Basic ⭐ PHASE 4
+```bash
+# Test: Push changes for brand (no project validation)
+dam repo-push appydave
+```
+**Expected**: Pushes commits, shows push summary
+
+**Status**: [ ] Pass [ ] Fail
+**Notes**: ___________________________________________
+
+---
+
+#### Test 2.21: Repo Push - With Project Validation ⭐ PHASE 4
+```bash
+# Test: Push with project validation
+dam repo-push appydave b65
+```
+**Expected**: Validates project exists in manifest before pushing, shows validation message
+
+**Status**: [ ] Pass [ ] Fail
+**Notes**: ___________________________________________
+
+---
+
 ### Phase 3: Gem Installation Tests (Manual - Installed Gem)
 
 **Prerequisites**: `gem install pkg/appydave-tools-*.gem`
@@ -670,31 +749,18 @@ All video asset management commands have been successfully migrated and are full
 - ✅ `dam archive` - Archive to SSD (dry-run + optional force)
 - ✅ `dam sync-ssd` - Restore light files from SSD (dry-run)
 
+### Phase 4: Status & Git Integration
+- ✅ `dam status` - Unified status view (local/S3/SSD/git)
+- ✅ `dam repo-status` - Git status for brand repositories (`--all` support)
+- ✅ `dam repo-sync` - Pull updates for brand repositories (`--all` support)
+- ✅ `dam repo-push` - Push changes with optional project validation
+
 ### All Commands Support:
 - **CLI args**: `dam <command> <brand> <project>`
 - **Auto-detect**: Works from project directory (where applicable)
 - **Dry-run**: All destructive operations support `--dry-run`
 - **Force flags**: Extra safety for deletions
-
----
-
-## Git Repository Scripts - Separate Concern
-
-The following shell scripts are **intentionally not migrated** as they manage git repositories, not video assets:
-
-### `/video-projects/v-shared/*.sh`
-
-- `status-all.sh` - Runs `git status` on all v-* brand repos
-- `sync-all.sh` - Runs `git pull` on all v-* brand repos
-- `clone-all.sh` - Clones missing v-* brand repos
-
-**Why separate:**
-1. Different domain: Git repository management vs. video asset management
-2. Different tools: Shell + git commands vs. Ruby + AWS/file operations
-3. Different location: Belongs in video-projects workspace, not in distributed gem
-4. Shell scripts work perfectly for this use case
-
-**If migration is desired:** Could add `dam repo-status/sync/clone` but would duplicate working shell functionality and mix concerns.
+- **Git integration**: Unified status + repo management commands
 
 ---
 
@@ -707,8 +773,8 @@ The following shell scripts are **intentionally not migrated** as they manage gi
 - **TOTAL**: **64 / 64 ✅**
 
 ### Phase 2: Integration Tests (Manual - Development)
-- Passed: _____ / 13
-- Failed: _____ / 13
+- Passed: _____ / 23
+- Failed: _____ / 23
 
 ### Phase 3: Gem Installation Tests (Manual - Installed)
 - Passed: _____ / 6
@@ -728,8 +794,8 @@ The following shell scripts are **intentionally not migrated** as they manage gi
 
 ### **GRAND TOTAL**
 - **Unit Tests**: 64 / 64 ✅
-- **Manual Tests**: _____ / 29
-- **Overall**: _____ / 93
+- **Manual Tests**: _____ / 39
+- **Overall**: _____ / 103
 
 ---
 
@@ -832,8 +898,8 @@ The following shell scripts are **intentionally not migrated** as they manage gi
 
 **Then manual development tests** (safest first):
 2. Phase 2.1-2.5: Help and list commands
-3. Phase 2.6-2.7: S3 upload with dry-run
-4. Phase 2.8-2.13: Phase 2 commands (download, status, cleanup) with dry-run
+3. Phase 2.6-2.14: S3 commands (upload, download, status, cleanup) with dry-run
+4. Phase 2.15-2.23: Phase 4 commands (status, repo-status, repo-sync, repo-push) ⭐ NEW
 5. Phase 4: Edge cases and error handling
 
 **Then gem installation tests**: