appsignal 3.6.1-java → 3.6.3-java

data/spec/lib/appsignal/capistrano2_spec.rb

@@ -160,7 +160,7 @@ if DependencyHelper.capistrano2_present?
               run
             end
 
-            it "transmits the overriden revision" do
+            it "transmits the overridden revision" do
               expect(output).to include \
                 "Notifying AppSignal of deploy with: revision: abc123, user: batman",
                 "AppSignal has been notified of this deploy!"
@@ -174,7 +174,7 @@ if DependencyHelper.capistrano2_present?
               run
             end
 
-            it "transmits the overriden deploy user" do
+            it "transmits the overridden deploy user" do
               expect(output).to include \
                 "Notifying AppSignal of deploy with: revision: 503ce0923ed177a3ce000005," \
                   " user: robin",

data/spec/lib/appsignal/capistrano3_spec.rb

@@ -172,7 +172,7 @@ if DependencyHelper.capistrano3_present?
               run
             end
 
-            it "transmits the overriden revision" do
+            it "transmits the overridden revision" do
               expect(output).to include \
                 "Notifying AppSignal of deploy with: revision: abc123, user: batman",
                 "AppSignal has been notified of this deploy!"
@@ -186,7 +186,7 @@ if DependencyHelper.capistrano3_present?
               run
             end
 
-            it "transmits the overriden deploy user" do
+            it "transmits the overridden deploy user" do
               expect(output).to include \
                 "Notifying AppSignal of deploy with: revision: 503ce0923ed177a3ce000005, " \
                   "user: robin",

data/spec/lib/appsignal/cli/diagnose_spec.rb

@@ -466,7 +466,7 @@ describe Appsignal::CLI::Diagnose, :api_stub => true, :send_report => :yes_cli_i
         end
       end
 
-      context "when the extention returns invalid JSON" do
+      context "when the extension returns invalid JSON" do
         before do
           expect(Appsignal::Extension).to receive(:diagnose).and_return("invalid agent\njson")
           run

data/spec/lib/appsignal/config_spec.rb

@@ -6,7 +6,8 @@ describe Appsignal::Config do
       configured_env_keys = (
         config::ENV_STRING_KEYS +
         config::ENV_BOOLEAN_KEYS +
-        config::ENV_ARRAY_KEYS
+        config::ENV_ARRAY_KEYS +
+        config::ENV_FLOAT_KEYS
       ).sort
 
       expect(mapped_env_keys).to eql(configured_env_keys)
@@ -264,7 +265,7 @@ describe Appsignal::Config do
       end
     end
 
-    context "with an overriden config file" do
+    context "with an overridden config file" do
       let(:config) do
         project_fixture_config("production", {}, Appsignal.internal_logger,
           File.join(project_fixture_path, "config", "appsignal.yml"))
@@ -275,7 +276,7 @@ describe Appsignal::Config do
         expect(config.active?).to be_truthy
       end
 
-      context "with an invalid overriden config file" do
+      context "with an invalid overridden config file" do
         let(:config) do
           project_fixture_config("production", {}, Appsignal.internal_logger,
             File.join(project_fixture_path, "config", "missing.yml"))
@@ -300,7 +301,7 @@ describe Appsignal::Config do
           stdout = std_stream
           stderr = std_stream
           log = capture_logs { capture_std_streams(stdout, stderr) { config } }
-          message = "An error occured while loading the AppSignal config file. " \
+          message = "An error occurred while loading the AppSignal config file. " \
             "Skipping file config. " \
             "In future versions AppSignal will not start on a config file " \
             "error. To opt-in to this new behavior set " \
@@ -326,7 +327,7 @@ describe Appsignal::Config do
           ENV["APPSIGNAL_PUSH_API_KEY"] = "something valid"
           ENV["APPSIGNAL_INACTIVE_ON_CONFIG_FILE_ERROR"] = "1"
           log = capture_logs { capture_std_streams(stdout, stderr) { config } }
-          message = "An error occured while loading the AppSignal config file. " \
+          message = "An error occurred while loading the AppSignal config file. " \
             "Not starting AppSignal because APPSIGNAL_INACTIVE_ON_CONFIG_FILE_ERROR is set.\n" \
             "File: #{File.join(config_path, "config", "appsignal.yml").inspect}\n" \
             "KeyError: key not found"
@@ -414,6 +415,7 @@ describe Appsignal::Config do
         :push_api_key => "aaa-bbb-ccc",
         :active => true,
         :bind_address => "0.0.0.0",
+        :cpu_count => 1.5,
         :name => "App name",
         :debug => true,
         :dns_servers => ["8.8.8.8", "8.8.4.4"],
@@ -436,6 +438,7 @@ describe Appsignal::Config do
       ENV["APPSIGNAL_ACTIVE"]                  = "true"
       ENV["APPSIGNAL_APP_NAME"]                = "App name"
       ENV["APPSIGNAL_BIND_ADDRESS"]            = "0.0.0.0"
+      ENV["APPSIGNAL_CPU_COUNT"]               = "1.5"
       ENV["APPSIGNAL_DEBUG"]                   = "true"
       ENV["APPSIGNAL_DNS_SERVERS"]             = "8.8.8.8,8.8.4.4"
       ENV["APPSIGNAL_IGNORE_ACTIONS"]          = "action1,action2"
@@ -631,6 +634,7 @@ describe Appsignal::Config do
     let(:config) { project_fixture_config(:production) }
     before do
       config[:bind_address] = "0.0.0.0"
+      config[:cpu_count] = 1.5
       config[:logging_endpoint] = "http://localhost:123"
       config[:http_proxy] = "http://localhost"
       config[:ignore_actions] = %w[action1 action2]
@@ -654,6 +658,7 @@ describe Appsignal::Config do
         .to end_with("spec/support/fixtures/projects/valid")
       expect(ENV.fetch("_APPSIGNAL_AGENT_PATH", nil)).to end_with("/ext")
       expect(ENV.fetch("_APPSIGNAL_BIND_ADDRESS", nil)).to eq("0.0.0.0")
+      expect(ENV.fetch("_APPSIGNAL_CPU_COUNT", nil)).to eq("1.5")
       expect(ENV.fetch("_APPSIGNAL_DEBUG_LOGGING", nil)).to eq "false"
       expect(ENV.fetch("_APPSIGNAL_LOG", nil)).to eq "stdout"
       expect(ENV.fetch("_APPSIGNAL_LOG_FILE_PATH", nil)).to end_with("/tmp/appsignal.log")

data/spec/lib/appsignal/environment_spec.rb

@@ -90,7 +90,7 @@ describe Appsignal::Environment do
       end
     end
 
-    context "when something unforseen errors" do
+    context "when something unforeseen errors" do
       it "does not re-raise the error and writes it to the log" do
         klass = Class.new do
           def inspect
@@ -127,7 +127,7 @@ describe Appsignal::Environment do
       expect(rake_spec.version.to_s).to_not be_empty
     end
 
-    context "when something unforseen errors" do
+    context "when something unforeseen errors" do
       it "does not re-raise the error and writes it to the log" do
         expect(Bundler).to receive(:rubygems).and_raise(RuntimeError, "bundler error")
 
@@ -148,7 +148,7 @@ describe Appsignal::Environment do
       expect_environment_metadata("ruby_a_test_enabled", "true")
     end
 
-    context "when something unforseen errors" do
+    context "when something unforeseen errors" do
       it "does not re-raise the error and writes it to the log" do
         klass = Class.new do
           def to_s

data/spec/lib/appsignal/event_formatter/mongo_ruby_driver/query_formatter_spec.rb

@@ -21,7 +21,7 @@ describe Appsignal::EventFormatter::MongoRubyDriver::QueryFormatter do
       formatter.format(strategy, command)
     end
 
-    context "when strategy is unkown" do
+    context "when strategy is unknown" do
       let(:strategy) { :bananas }
 
       it "should return an empty hash" do

data/spec/lib/appsignal/hooks/resque_spec.rb

@@ -160,7 +160,7 @@ describe Appsignal::Hooks::ResqueHook do
         end
         after { Object.send(:remove_const, :ActiveJobMock) }
 
-        it "does not set arguments but lets the ActiveJob intergration handle it" do
+        it "does not set arguments but lets the ActiveJob integration handle it" do
           perform_job(
             ResqueTestJob,
             "class" => "ActiveJob::QueueAdapters::ResqueAdapter::JobWrapper",

data/spec/lib/appsignal/hooks_spec.rb

@@ -47,7 +47,7 @@ describe Appsignal::Hooks do
     Appsignal::Hooks.hooks.delete(:mock_present_hook)
   end
 
-  it "should not install if depencies are not present" do
+  it "should not install if dependencies are not present" do
     Appsignal::Hooks::Hook.register(:mock_not_present_hook, MockNotPresentHook)
 
     expect(Appsignal::Hooks.hooks[:mock_not_present_hook]).to be_instance_of(MockNotPresentHook)

data/spec/lib/appsignal/integrations/railtie_spec.rb

@@ -256,10 +256,28 @@ if DependencyHelper.rails_present?
             end
 
             context "when no transaction is active" do
+              class ExampleRailsRequestMock
+                def path
+                  "path"
+                end
+
+                def method
+                  "GET"
+                end
+
+                def filtered_parameters
+                  { :user_id => 123, :password => "[FILTERED]" }
+                end
+              end
+
               class ExampleRailsControllerMock
                 def action_name
                   "index"
                 end
+
+                def request
+                  @request ||= ExampleRailsRequestMock.new
+                end
               end
 
               class ExampleRailsJobMock
@@ -275,7 +293,7 @@ if DependencyHelper.rails_present?
                 clear_current_transaction!
               end
 
-              it "fetches the action from the controller in the context" do
+              it "fetches the action, path and method from the controller in the context" do
                 # The controller key is set by Rails when raised in a controller
                 given_context = { :controller => ExampleRailsControllerMock.new }
                 with_rails_error_reporter do
@@ -285,7 +303,14 @@ if DependencyHelper.rails_present?
                 transaction = last_transaction
                 transaction_hash = transaction.to_h
                 expect(transaction_hash).to include(
-                  "action" => "ExampleRailsControllerMock#index"
+                  "action" => "ExampleRailsControllerMock#index",
+                  "metadata" => hash_including(
+                    "path" => "path",
+                    "method" => "GET"
+                  ),
+                  "sample_data" => hash_including(
+                    "params" => { "user_id" => 123, "password" => "[FILTERED]" }
+                  )
                 )
               end
 

data/spec/lib/appsignal/integrations/sidekiq_spec.rb

@@ -8,7 +8,7 @@ describe Appsignal::Integrations::SidekiqErrorHandler do
   end
   around { |example| keep_transactions { example.run } }
 
-  context "without a current transction" do
+  context "without a current transaction" do
     let(:exception) do
       raise ExampleStandardError, "uh oh"
     rescue => error

data/spec/lib/appsignal/rack/generic_instrumentation_spec.rb

@@ -50,7 +50,7 @@ describe Appsignal::Rack::GenericInstrumentation do
       expect(app).to receive(:call).with(env)
     end
 
-    context "with an exception raised from call()", :error => true do
+    context "with an exception", :error => true do
       let(:error) { ExampleException }
       let(:app) do
         double.tap do |d|
@@ -58,9 +58,8 @@ describe Appsignal::Rack::GenericInstrumentation do
         end
       end
 
-      it "records the exception and completes the transaction" do
+      it "records the exception" do
         expect_any_instance_of(Appsignal::Transaction).to receive(:set_error).with(error)
-        expect(Appsignal::Transaction).to receive(:complete_current!)
       end
     end
 

data/spec/lib/appsignal/rack/rails_instrumentation_spec.rb

@@ -65,8 +65,7 @@ if DependencyHelper.rails_present?
 
     describe "#call_with_appsignal_monitoring" do
       def run
-        _status, _headers, body = middleware.call(env)
-        body.close # Rack will always call close() on the body
+        middleware.call(env)
       end
 
       it "calls the wrapped app" do
@@ -127,8 +126,7 @@ if DependencyHelper.rails_present?
           end
         end
 
-        it "records the exception and completes the transaction" do
-          expect(Appsignal::Transaction).to receive(:complete_current!)
+        it "records the exception" do
           expect { run }.to raise_error(error)
 
           transaction_hash = last_transaction.to_h

data/spec/lib/appsignal/rack/sinatra_instrumentation_spec.rb

@@ -3,9 +3,7 @@ if DependencyHelper.sinatra_present?
 
   module SinatraRequestHelpers
     def make_request(env)
-      _status, _headers, body = middleware.call(env)
-      # Close the body so that the transaction gets completed
-      body&.close
+      middleware.call(env)
     end
 
     def make_request_with_error(env, error)

data/spec/lib/appsignal/rack/streaming_listener_spec.rb

@@ -90,11 +90,10 @@ describe Appsignal::Rack::StreamingListener do
     context "with an exception in the instrumentation call" do
       let(:error) { ExampleException }
 
-      it "should add the exception to the transaction and complete the transaction" do
+      it "should add the exception to the transaction" do
         allow(app).to receive(:call).and_raise(error)
 
         expect(transaction).to receive(:set_error).with(error)
-        expect(Appsignal::Transaction).to receive(:complete_current!).and_call_original
 
         expect do
           listener.call_with_appsignal_monitoring(env)
@@ -102,19 +101,64 @@ describe Appsignal::Rack::StreamingListener do
       end
     end
 
-    it "should wrap the response body in a wrapper" do
+    it "should wrap the body in a wrapper" do
+      expect(Appsignal::StreamWrapper).to receive(:new)
+        .with("body", transaction)
+        .and_return(wrapper)
+
       body = listener.call_with_appsignal_monitoring(env)[2]
 
-      expect(body).to be_kind_of(Appsignal::Rack::BodyWrapper)
+      expect(body).to be_a(Appsignal::StreamWrapper)
     end
   end
 end
 
 describe Appsignal::StreamWrapper do
-  it ".new returns an EnumerableWrapper" do
-    fake_body = double(:each => nil)
-    fake_txn = double
-    stream_wrapper = Appsignal::StreamWrapper.new(fake_body, fake_txn)
-    expect(stream_wrapper).to be_kind_of(Appsignal::Rack::EnumerableBodyWrapper)
+  let(:stream)      { double }
+  let(:transaction) do
+    Appsignal::Transaction.create(SecureRandom.uuid, Appsignal::Transaction::HTTP_REQUEST, {})
+  end
+  let(:wrapper) { Appsignal::StreamWrapper.new(stream, transaction) }
+
+  describe "#each" do
+    it "calls the original stream" do
+      expect(stream).to receive(:each)
+
+      wrapper.each
+    end
+
+    context "when #each raises an error" do
+      let(:error) { ExampleException }
+
+      it "records the exception" do
+        allow(stream).to receive(:each).and_raise(error)
+
+        expect(transaction).to receive(:set_error).with(error)
+
+        expect { wrapper.send(:each) }.to raise_error(error)
+      end
+    end
+  end
+
+  describe "#close" do
+    it "closes the original stream and completes the transaction" do
+      expect(stream).to receive(:close)
+      expect(Appsignal::Transaction).to receive(:complete_current!)
+
+      wrapper.close
+    end
+
+    context "when #close raises an error" do
+      let(:error) { ExampleException }
+
+      it "records the exception and completes the transaction" do
+        allow(stream).to receive(:close).and_raise(error)
+
+        expect(transaction).to receive(:set_error).with(error)
+        expect(transaction).to receive(:complete)
+
+        expect { wrapper.send(:close) }.to raise_error(error)
+      end
+    end
   end
 end

data/spec/lib/appsignal/transaction_spec.rb

@@ -303,7 +303,7 @@ describe Appsignal::Transaction do
         context "with overridden options" do
           let(:options) { { :params_method => :filtered_params } }
 
-          it "sets the overriden :params_method" do
+          it "sets the overridden :params_method" do
             expect(subject[:params_method]).to eq :filtered_params
           end
         end
@@ -751,7 +751,7 @@ describe Appsignal::Transaction do
         e
       end
 
-      it "should also respond to add_exception for backwords compatibility" do
+      it "should also respond to add_exception for backwards compatibility" do
         expect(transaction).to respond_to(:add_exception)
       end
 

data/spec/lib/appsignal_spec.rb

@@ -258,7 +258,7 @@ describe Appsignal do
     end
 
     describe ".listen_for_error" do
-      it "does not record anyhing" do
+      it "does not record anything" do
         error = RuntimeError.new("specific error")
         expect do
           Appsignal.listen_for_error do

data/spec/lib/puma/appsignal_spec.rb

@@ -204,7 +204,7 @@ RSpec.describe "Puma plugin" do
       }
     end
 
-    it "collects puma stats as guage metrics with the (summed) worker metrics" do
+    it "collects puma stats as gauge metrics with the (summed) worker metrics" do
       run_plugin(stats_data, appsignal_plugin) do
         expect(logs).to_not include([:error, kind_of(String)])
         expect_gauge(:workers, 2, "type" => "count")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 3.6.1
+  version: 3.6.3
 platform: java
 authors:
 - Robert Beekman
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-05 00:00:00.000000000 Z
+date: 2024-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -282,7 +282,6 @@ files:
 - lib/appsignal/probes/helpers.rb
 - lib/appsignal/probes/mri.rb
 - lib/appsignal/probes/sidekiq.rb
-- lib/appsignal/rack/body_wrapper.rb
 - lib/appsignal/rack/generic_instrumentation.rb
 - lib/appsignal/rack/rails_instrumentation.rb
 - lib/appsignal/rack/sinatra_instrumentation.rb
@@ -381,7 +380,6 @@ files:
 - spec/lib/appsignal/probes/gvl_spec.rb
 - spec/lib/appsignal/probes/mri_spec.rb
 - spec/lib/appsignal/probes/sidekiq_spec.rb
-- spec/lib/appsignal/rack/body_wrapper_spec.rb
 - spec/lib/appsignal/rack/generic_instrumentation_spec.rb
 - spec/lib/appsignal/rack/rails_instrumentation_spec.rb
 - spec/lib/appsignal/rack/sinatra_instrumentation_spec.rb
@@ -467,7 +465,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.15
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Logs performance and exception data from your app to appsignal.com

data/lib/appsignal/rack/body_wrapper.rb

@@ -1,161 +0,0 @@
-# frozen_string_literal: true
-
-module Appsignal
-  # @api private
-  module Rack
-    class BodyWrapper
-      def self.wrap(original_body, appsignal_transaction)
-        # The logic of how Rack treats a response body differs based on which methods
-        # the body responds to. This means that to support the Rack 3.x spec in full
-        # we need to return a wrapper which matches the API of the wrapped body as closely
-        # as possible. Pick the wrapper from the most specific to the least specific.
-        # See https://github.com/rack/rack/blob/main/SPEC.rdoc#the-body-
-        #
-        # What is important is that our Body wrapper responds to the same methods Rack
-        # (or a webserver) would be checking and calling, and passes through that functionality
-        # to the original body. This can be done using delegation via i.e. SimpleDelegate
-        # but we also need "close" to get called correctly so that the Appsignal transaction
-        # gets completed - which will not happen, for example, when #to_ary gets called
-        # just on the delegated Rack body.
-        #
-        # This comment https://github.com/rails/rails/pull/49627#issuecomment-1769802573
-        # is of particular interest to understand why this has to be somewhat complicated.
-        if original_body.respond_to?(:to_path)
-          PathableBodyWrapper.new(original_body, appsignal_transaction)
-        elsif original_body.respond_to?(:to_ary)
-          ArrayableBodyWrapper.new(original_body, appsignal_transaction)
-        elsif !original_body.respond_to?(:each) && original_body.respond_to?(:call)
-          # This body only supports #call, so we must be running a Rack 3 application
-          # It is possible that a body exposes both `each` and `call` in the hopes of
-          # being backwards-compatible with both Rack 3.x and Rack 2.x, however
-          # this is not going to work since the SPEC says that if both are available,
-          # `each` should be used and `call` should be ignored.
-          # So for that case we can drop by to our default EnumerableBodyWrapper
-          CallableBodyWrapper.new(original_body, appsignal_transaction)
-        else
-          EnumerableBodyWrapper.new(original_body, appsignal_transaction)
-        end
-      end
-
-      def initialize(body, appsignal_transaction)
-        @body_already_closed = false
-        @body = body
-        @transaction = appsignal_transaction
-      end
-
-      # This must be present in all Rack bodies and will be called by the serving adapter
-      def close
-        # The @body_already_closed check is needed so that if `to_ary`
-        # of the body has already closed itself (as prescribed) we do not
-        # attempt to close it twice
-        if !@body_already_closed && @body.respond_to?(:close)
-          Appsignal.instrument("response_body_close.rack") { @body.close }
-        end
-        @body_already_closed = true
-      rescue Exception => error # rubocop:disable Lint/RescueException
-        @transaction.set_error(error)
-        raise error
-      ensure
-        complete_transaction!
-      end
-
-      def complete_transaction!
-        # We need to call the Transaction class method and not
-        # @transaction.complete because the transaction is still
-        # thread-local and it needs to remove itself from the
-        # thread variables correctly, which does not happen on
-        # Transaction#complete.
-        #
-        # In the future it would be a good idea to ensure
-        # that the current transaction is the same as @transaction,
-        # or allow @transaction to complete itself and remove
-        # itself from Thread.current
-        Appsignal::Transaction.complete_current!
-      end
-    end
-
-    # The standard Rack body wrapper which exposes "each" for iterating
-    # over the response body. This is supported across all 3 major Rack
-    # versions.
-    #
-    # @api private
-    class EnumerableBodyWrapper < BodyWrapper
-      def each(&blk)
-        # This is a workaround for the Rails bug when there was a bit too much
-        # eagerness in implementing to_ary, see:
-        # https://github.com/rails/rails/pull/44953
-        # https://github.com/rails/rails/pull/47092
-        # https://github.com/rails/rails/pull/49627
-        # https://github.com/rails/rails/issues/49588
-        # While the Rack SPEC does not mandate `each` to be callable
-        # in a blockless way it is still a good idea to have it in place.
-        return enum_for(:each) unless block_given?
-
-        Appsignal.instrument("process_response_body.rack", "Process Rack response body (#each)") do
-          @body.each(&blk)
-        end
-      rescue Exception => error # rubocop:disable Lint/RescueException
-        @transaction.set_error(error)
-        raise error
-      end
-    end
-
-    # The callable response bodies are a new Rack 3.x feature, and would not work
-    # with older Rack versions. They must not respond to `each` because
-    # "If it responds to each, you must call each and not call". This is why
-    # it inherits from BodyWrapper directly and not from EnumerableBodyWrapper
-    #
-    # @api private
-    class CallableBodyWrapper < BodyWrapper
-      def call(stream)
-        # `stream` will be closed by the app we are calling, no need for us
-        # to close it ourselves
-        Appsignal.instrument("process_response_body.rack", "Process Rack response body (#call)") do
-          @body.call(stream)
-        end
-      rescue Exception => error # rubocop:disable Lint/RescueException
-        @transaction.set_error(error)
-        raise error
-      end
-    end
-
-    # "to_ary" takes precedence over "each" and allows the response body
-    # to be read eagerly. If the body supports that method, it takes precedence
-    # over "each":
-    # "Middleware may call to_ary directly on the Body and return a new Body in its place"
-    # One could "fold" both the to_ary API and the each() API into one Body object, but
-    # to_ary must also call "close" after it executes - and in the Rails implementation
-    # this pecularity was not handled properly.
-    #
-    # @api private
-    class ArrayableBodyWrapper < EnumerableBodyWrapper
-      def to_ary
-        @body_already_closed = true
-        Appsignal.instrument(
-          "process_response_body.rack",
-          "Process Rack response body (#to_ary)"
-        ) do
-          @body.to_ary
-        end
-      rescue Exception => error # rubocop:disable Lint/RescueException
-        @transaction.set_error(error)
-        raise error
-      ensure
-        # We do not call "close" on ourselves as the only action
-        # we need to complete is completing the transaction.
-        complete_transaction!
-      end
-    end
-
-    # Having "to_path" on a body allows Rack to serve out a static file, or to
-    # pass that file to the downstream webserver for sending using X-Sendfile
-    class PathableBodyWrapper < EnumerableBodyWrapper
-      def to_path
-        Appsignal.instrument("response_body_to_path.rack") { @body.to_path }
-      rescue Exception => error # rubocop:disable Lint/RescueException
-        @transaction.set_error(error)
-        raise error
-      end
-    end
-  end
-end